)]}'
{"puppet/manifests/overcloud_controller_pacemaker.pp":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c585ea2c3e7d4b05b572d2128a5713af8d6c26b8","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"  if $pacemaker_master {"},{"line_number":1940,"context_line":""},{"line_number":1941,"context_line":"    class {\u0027::keystone::roles::admin\u0027 :"},{"line_number":1942,"context_line":"      require \u003d\u003e Pacemaker::Resource::Service[$::apache::params::service_name],"},{"line_number":1943,"context_line":"    } -\u003e"},{"line_number":1944,"context_line":"    class {\u0027::keystone::endpoint\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba0121b8_ca3425e0","side":"PARENT","line":1941,"updated":"2016-03-28 21:02:52.000000000","message":"Unfortunately it looks like this does need to move up too:\n\nError: Could not find resource \u0027Class[Keystone::Roles::Admin]\u0027 for relationship on \u0027Class[Heat::Keystone::Domain]\u0027 on node overcloud-controller-0.localdomain\n\nI don\u0027t know if there was any particular reason this has to happen at the end though. :-/","commit_id":"c6249a1af273886fa326563dbc696af8fb561caa"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b65c1cfb5938846bc0663fd5c64db56db48bb431","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"  if $pacemaker_master {"},{"line_number":1940,"context_line":""},{"line_number":1941,"context_line":"    class {\u0027::keystone::roles::admin\u0027 :"},{"line_number":1942,"context_line":"      require \u003d\u003e Pacemaker::Resource::Service[$::apache::params::service_name],"},{"line_number":1943,"context_line":"    } -\u003e"},{"line_number":1944,"context_line":"    class {\u0027::keystone::endpoint\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba0121b8_995285dc","side":"PARENT","line":1941,"in_reply_to":"ba0121b8_ca3425e0","updated":"2016-03-28 23:56:38.000000000","message":"you can\u0027t just move this up because of the require on the Pacemaker resource. that will fail because that resource is not defined for steps 1-3.\n\ni\u0027m just going to try it without the require, and see if it works.","commit_id":"c6249a1af273886fa326563dbc696af8fb561caa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0ea5cc6dacff34e8c142f3d3fd8c0bcd2f3dee95","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"  hiera_include(\u0027controller_classes\u0027)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"  if $pacemaker_master {"},{"line_number":1173,"context_line":"    include ::keystone::roles::admin"},{"line_number":1174,"context_line":"    include ::keystone::endpoint"},{"line_number":1175,"context_line":"    include ::heat::keystone::domain"},{"line_number":1176,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_bb9e3d54","line":1173,"updated":"2016-03-29 14:32:43.000000000","message":"I am not reallt opposed but neither too happy about moving admin role and endpoint creation in a step where pcmk doesn\u0027t know about keystone yet; it might pass \n\nI think the issue with the heat unwanted restart will be fixed by I95e21e10471cd7575f28c095c48150325f1414b3 or at leat I would slow this down to see if that fixes it","commit_id":"1e6e15a548647b25f753c68a79e4fd63f7973a76"}]}