)]}'
{"environments/neutron-midonet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"510a449b27b4fb9bdc7a0692b735540f291ff863","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  EnableCassandraOnController: true"},{"line_number":9,"context_line":"  NeutronCorePlugin: \u0027midonet.neutron.plugin_v1.MidonetPluginV2\u0027 # Overriding default core_plugin in Neutron. Don\u0027t touch it"},{"line_number":10,"context_line":"  NeutronEnableIsolatedMetadata: true  # MidoNet 1.9 needs this one to work. Don\u0027t change it"},{"line_number":11,"context_line":"  OS::TripleO::Services::NeutronL3Agent: OS::Heat::None"},{"line_number":12,"context_line":"  NeutronEnableOVSAgent: false"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  # Other available options for MidoNet Services"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"dab17558_2c099c31","line":11,"updated":"2016-05-17 21:21:50.000000000","message":"shouldn\u0027t this be under the resource_registry and not parameter_defaults?","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"affac404b1e8e2eb1aadb87191a5428d4693d0f8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  EnableCassandraOnController: true"},{"line_number":9,"context_line":"  NeutronCorePlugin: \u0027midonet.neutron.plugin_v1.MidonetPluginV2\u0027 # Overriding default core_plugin in Neutron. Don\u0027t touch it"},{"line_number":10,"context_line":"  NeutronEnableIsolatedMetadata: true  # MidoNet 1.9 needs this one to work. Don\u0027t change it"},{"line_number":11,"context_line":"  OS::TripleO::Services::NeutronL3Agent: OS::Heat::None"},{"line_number":12,"context_line":"  NeutronEnableOVSAgent: false"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  # Other available options for MidoNet Services"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bab6814e_973403df","line":11,"in_reply_to":"dab17558_2c099c31","updated":"2016-05-18 07:09:12.000000000","message":"+1 good point/nice catch... we add the Service values/definitions under \"resource_registry\" in the resource registry :/ https://review.openstack.org/#/c/303562/29/overcloud-resource-registry-puppet.yaml\n\n    resource_registry:\n        OS::TripleO::Services::NeutronDhcpAgent: puppet/services/neutron-dhcp.yaml\n\n    parameter_defaults:\n        ...","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"}],"environments/neutron-opencontrail.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"510a449b27b4fb9bdc7a0692b735540f291ff863","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  NeutronCorePlugin: neutron_plugin_contrail.plugins.opencontrail.contrail_plugin.NeutronPluginContrailCoreV2"},{"line_number":9,"context_line":"  NeutronServicePlugins: neutron_plugin_contrail.plugins.opencontrail.loadbalancer.plugin.LoadBalancerPlugin"},{"line_number":10,"context_line":"  OS::TripleO::Services::NeutronDhcpAgent: OS::Heat::None"},{"line_number":11,"context_line":"  OS::TripleO::Services::NeutronL3Agent: OS::Heat::None"},{"line_number":12,"context_line":"  NeutronEnableMetadataAgent: false"},{"line_number":13,"context_line":"  NeutronEnableOVSAgent: false"},{"line_number":14,"context_line":"  NeutronEnableTunnelling: false"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"dab17558_8c040818","line":11,"updated":"2016-05-17 21:21:50.000000000","message":"ditto","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"}],"environments/neutron-plumgrid.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"510a449b27b4fb9bdc7a0692b735540f291ff863","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # PLUMgrid doesn\u0027t require dhcp, l3, ovs and metadata agents"},{"line_number":26,"context_line":"  OS::TripleO::Services::NeutronDhcpAgent: OS::Heat::None"},{"line_number":27,"context_line":"  OS::TripleO::Services::NeutronL3Agent: OS::Heat::None"},{"line_number":28,"context_line":"  NeutronEnableMetadataAgent: false"},{"line_number":29,"context_line":"  NeutronEnableOVSAgent: false"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"dab17558_af03be0b","line":27,"updated":"2016-05-17 21:21:50.000000000","message":"ditto","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"}],"overcloud.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"019a60ed5509aaf86b8db1b4c1d65dd6b0f76c35","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    description: |"},{"line_number":243,"context_line":"        Comma-separated list of extensions enabled for the Neutron agents."},{"line_number":244,"context_line":"    type: comma_delimited_list"},{"line_number":245,"context_line":"  NeutronAllowL3AgentFailover:"},{"line_number":246,"context_line":"    default: \u0027False\u0027"},{"line_number":247,"context_line":"    description: Allow automatic l3-agent failover"},{"line_number":248,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_ebcd67b8","line":245,"updated":"2016-04-13 09:37:27.000000000","message":"this?","commit_id":"2951f9b1708e439326d9e961e1c8e6f86f234b3a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"019a60ed5509aaf86b8db1b4c1d65dd6b0f76c35","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    default: \u0027False\u0027"},{"line_number":247,"context_line":"    description: Allow automatic l3-agent failover"},{"line_number":248,"context_line":"    type: string"},{"line_number":249,"context_line":"  NeutronL3HA:"},{"line_number":250,"context_line":"    default: \u0027False\u0027"},{"line_number":251,"context_line":"    description: Whether to enable l3-agent HA"},{"line_number":252,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_abd36f5e","line":249,"updated":"2016-04-13 09:37:27.000000000","message":"wana get rid of this too?","commit_id":"2951f9b1708e439326d9e961e1c8e6f86f234b3a"}],"puppet/controller.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"186805a91568bea948d017284b09c15b9d404515","unresolved":false,"context_lines":[{"line_number":956,"context_line":"            params:"},{"line_number":957,"context_line":"              MECHANISMS: {get_param: NeutronMechanismDrivers}"},{"line_number":958,"context_line":"        neutron_allow_l3agent_failover: {get_param: NeutronAllowL3AgentFailover}"},{"line_number":959,"context_line":"        neutron_l3_ha: {get_param: NeutronL3HA}"},{"line_number":960,"context_line":"        neutron_network_vlan_ranges:"},{"line_number":961,"context_line":"          str_replace:"},{"line_number":962,"context_line":"            template: RANGES"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_0b59c3fe","line":959,"updated":"2016-04-13 09:38:07.000000000","message":"and here","commit_id":"2951f9b1708e439326d9e961e1c8e6f86f234b3a"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"f9906a936f28877c476862ae7ea8a2fa1a8c2e7f","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    description: Knob to enable/disable OVS Agent"},{"line_number":333,"context_line":"    type: boolean"},{"line_number":334,"context_line":"    default: true"},{"line_number":335,"context_line":"  NeutronAgentMode:"},{"line_number":336,"context_line":"    default: \u0027dvr_snat\u0027"},{"line_number":337,"context_line":"    description: Agent mode for the neutron-l3-agent on the controller hosts"},{"line_number":338,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"dab17558_0e64d5b6","line":335,"updated":"2016-05-16 18:30:34.000000000","message":"This is actually a property of the L3 agent -or should be. It currently doesn\u0027t do anything afaict and that is a good thing because the default should be \u0027legacy\u0027 unless DVR is enabled. Can we move it with the L3 agent, change it\u0027s default to the proper value and mark it with a TODO. Alternatively, mark it with a TODO to simply remove and re-add when we get to adding proper DVR support?","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"0a525d7343075390149b7bc17f98259426781ba5","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    description: Knob to enable/disable OVS Agent"},{"line_number":333,"context_line":"    type: boolean"},{"line_number":334,"context_line":"    default: true"},{"line_number":335,"context_line":"  NeutronAgentMode:"},{"line_number":336,"context_line":"    default: \u0027dvr_snat\u0027"},{"line_number":337,"context_line":"    description: Agent mode for the neutron-l3-agent on the controller hosts"},{"line_number":338,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bab6814e_a2ca954d","line":335,"in_reply_to":"dab17558_0e64d5b6","updated":"2016-05-18 12:17:58.000000000","message":"Brent: I think a cleanup patch will follow which removes all of the many unused Neutron parameters.","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"}],"puppet/manifests/overcloud_controller_pacemaker.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"20e7938229cfb4da464b599f667e4ac32b775acb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tag \u003d\u003d \u0027ceilometer-service\u0027 or"},{"line_number":26,"context_line":"  tag \u003d\u003d \u0027gnocchi-service\u0027 or"},{"line_number":27,"context_line":"  tag \u003d\u003d \u0027heat-service\u0027 or"},{"line_number":28,"context_line":"  tag \u003d\u003d \u0027neutron-service\u0027 or"},{"line_number":29,"context_line":"  tag \u003d\u003d \u0027nova-service\u0027 or"},{"line_number":30,"context_line":"  tag \u003d\u003d \u0027sahara-service\u0027"},{"line_number":31,"context_line":"|\u003e {"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"dab17558_8ffe71ac","line":28,"updated":"2016-05-13 08:51:47.000000000","message":"remove this too?","commit_id":"360d30790d69bdba600781f0edc2f0a01fb55919"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d0a50d01a8124fc12ca525b8b71be00bf81f7913","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tag \u003d\u003d \u0027ceilometer-service\u0027 or"},{"line_number":26,"context_line":"  tag \u003d\u003d \u0027gnocchi-service\u0027 or"},{"line_number":27,"context_line":"  tag \u003d\u003d \u0027heat-service\u0027 or"},{"line_number":28,"context_line":"  tag \u003d\u003d \u0027neutron-service\u0027 or"},{"line_number":29,"context_line":"  tag \u003d\u003d \u0027nova-service\u0027 or"},{"line_number":30,"context_line":"  tag \u003d\u003d \u0027sahara-service\u0027"},{"line_number":31,"context_line":"|\u003e {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"dab17558_a33869ef","line":28,"updated":"2016-05-16 07:56:29.000000000","message":"can we remove this?","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"}],"puppet/services/pacemaker/neutron-l3.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"20e7938229cfb4da464b599f667e4ac32b775acb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      config_settings:"},{"line_number":29,"context_line":"        map_merge:"},{"line_number":30,"context_line":"          - get_attr: [NeutronL3Base, role_data, config_settings]"},{"line_number":31,"context_line":"          - tripleo::profile::pacemaker::neutron::enable_l3: True"},{"line_number":32,"context_line":"      step_config: |"},{"line_number":33,"context_line":"        include ::tripleo::profile::pacemaker::neutron::l3"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"dab17558_4f35a9d9","line":31,"updated":"2016-05-13 08:51:47.000000000","message":"looks like this landed already puppet-tripleo side so we can revisit after this lands...  we are passing the manage_service/enabled from here and not having to include those params on the puppet-tripleo class like at  https://review.openstack.org/#/c/313649/ https://review.openstack.org/#/c/313650/","commit_id":"360d30790d69bdba600781f0edc2f0a01fb55919"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"20d72648b890df6454c0113e1f9404194daac0e8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        map_merge:"},{"line_number":30,"context_line":"          - get_attr: [NeutronL3Base, role_data, config_settings]"},{"line_number":31,"context_line":"          - tripleo::profile::pacemaker::neutron::enable_l3: True"},{"line_number":32,"context_line":"          - ::neutron::agents::l3::manage_service: false"},{"line_number":33,"context_line":"          - ::neutron::agents::l3::enabled: false"},{"line_number":34,"context_line":"      step_config: |"},{"line_number":35,"context_line":"        include ::tripleo::profile::pacemaker::neutron::l3"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dab17558_12010a6b","line":32,"updated":"2016-05-13 09:21:06.000000000","message":"I think l32 and l33 go without the leading \u0027-\u0027","commit_id":"70277eca838ba9bbfbcf41f477e5151399d375b2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b1ca6c26c801ac4ba3d29d0ec49cdd2f501c4cc9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        map_merge:"},{"line_number":30,"context_line":"          - get_attr: [NeutronL3Base, role_data, config_settings]"},{"line_number":31,"context_line":"          - tripleo::profile::pacemaker::neutron::enable_l3: True"},{"line_number":32,"context_line":"          - ::neutron::agents::l3::manage_service: false"},{"line_number":33,"context_line":"          - ::neutron::agents::l3::enabled: false"},{"line_number":34,"context_line":"      step_config: |"},{"line_number":35,"context_line":"        include ::tripleo::profile::pacemaker::neutron::l3"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dab17558_f211e6b0","line":32,"in_reply_to":"dab17558_12010a6b","updated":"2016-05-13 09:21:30.000000000","message":"yeah and also the ::","commit_id":"70277eca838ba9bbfbcf41f477e5151399d375b2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d0a50d01a8124fc12ca525b8b71be00bf81f7913","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      config_settings:"},{"line_number":29,"context_line":"        map_merge:"},{"line_number":30,"context_line":"          - get_attr: [NeutronL3Base, role_data, config_settings]"},{"line_number":31,"context_line":"          - tripleo::profile::pacemaker::neutron::enable_l3: True"},{"line_number":32,"context_line":"      step_config: |"},{"line_number":33,"context_line":"        include ::tripleo::profile::pacemaker::neutron::l3"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"dab17558_83460579","line":31,"updated":"2016-05-16 07:56:29.000000000","message":"Hi Dan, just checking that you meant to remove the passing of manage_service and enabled (see v28) - they will be removed puppet-tripleo side by https://review.openstack.org/#/c/313649/3/manifests/profile/base/neutron/l3.pp","commit_id":"fd8bb7ee96f7eecbfd06c4716305d7bac7125081"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"69d218f1b089606137baf1b63501ba6bedf9acae","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      config_settings:"},{"line_number":29,"context_line":"        map_merge:"},{"line_number":30,"context_line":"          - get_attr: [NeutronL3Base, role_data, config_settings]"},{"line_number":31,"context_line":"          - tripleo::profile::pacemaker::neutron::enable_l3: True"},{"line_number":32,"context_line":"      step_config: |"},{"line_number":33,"context_line":"        include ::tripleo::profile::pacemaker::neutron::l3"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"bab6814e_9ebcf76d","line":31,"updated":"2016-05-18 17:05:30.000000000","message":"sorry came late on it but I think we needed to pass neutron::agents::l3::enabled: false and neutron::agents::l3::manage_service: false here; I\u0027ll post an update","commit_id":"59e2f29fd1a43bee6a6d59d655c6ba579597f67e"}]}