)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"ffab0c34f1e8aa634e907c08ad1c10802b04d28b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds support for conditionally enabling DVR by deploying the"},{"line_number":10,"context_line":"L3 and metadata agents on the compute node and setting the proper"},{"line_number":11,"context_line":"configuration values throughout."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I24099795e76ecd520c990ba49d3511288dec7a12"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bacf61ea_61b5477d","line":12,"updated":"2016-08-02 18:10:07.000000000","message":"If you do another revision, you could reference the blueprint here.","commit_id":"4e7bf1c3708b96f236719a7c272a833e12aeb1ff"}],"environments/neutron-ovs-dvr.yaml":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"05e96eafd2fcbca1a239853eade1f2215699689d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"parameter_defaults:"},{"line_number":9,"context_line":"  NovaComputeExtraConfig:"},{"line_number":10,"context_line":"    neutron::agents::l3::debug: true"},{"line_number":11,"context_line":"    neutron::agents::l3::agent_mode: \u0027dvr\u0027"},{"line_number":12,"context_line":"    neutron::agents::ml2::ovs::l2_population: true"},{"line_number":13,"context_line":"    neutron::agents::ml2::ovs::enable_distributed_routing: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_e93f72d4","line":10,"updated":"2016-06-21 19:06:44.000000000","message":"debug logging? :)","commit_id":"b5febe0882155d874e384ce37f6809fc64f45262"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"783b9172b107d053166f106a0845c40e82d92558","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  ControllerExtraConfig:"},{"line_number":16,"context_line":"    neutron::server::router_distributed: true"},{"line_number":17,"context_line":"    neutron::plugins::ml2::mechanism_drivers: \u0027openvswitch,l2population\u0027"},{"line_number":18,"context_line":"    neutron::agents::ml2::ovs::l2_population: true"},{"line_number":19,"context_line":"    neutron::agents::ml2::ovs::enable_distributed_routing: true"},{"line_number":20,"context_line":"    neutron::agents::l3::agent_mode: \u0027dvr_snat\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_d710c45b","line":17,"updated":"2016-06-23 19:58:24.000000000","message":"Did we confirm that if you put \u0027openvswitch,sriov\u0027 for example, this env file won\u0027t override your previous choice? I guess we need to see that the SRIOV spec in-progress can play nice with this patch.","commit_id":"f348c6e704b9e41bb03044b67475c70ff4343962"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d3367d05c2e99dc093d553eb0844ad5be8c01625","unresolved":false,"context_lines":[{"line_number":12,"context_line":"parameter_defaults:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  # DVR requires that the L2 population feature is enabled"},{"line_number":15,"context_line":"  NeutronMechanismDrivers: \u0027openvswitch,l2population\u0027"},{"line_number":16,"context_line":"  NeutronEnableL2Pop: \u0027True\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  # Setting NeutronEnableDVR enables distributed routing support in the"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_120e7c8b","line":15,"updated":"2016-07-07 16:52:45.000000000","message":"it should be an array, see:\nhttps://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ml2.pp#L45-L51","commit_id":"0752e948bf40a600773c28f6974a89a9c5a552df"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"278f2c7f3d84a914bc7199b0678a4f13523c4f7d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  # \"Compute\" and \"Controller\" nodes run their L3 agents in different"},{"line_number":23,"context_line":"  # modes."},{"line_number":24,"context_line":"  NovaComputeExtraConfig:"},{"line_number":25,"context_line":"    neutron::agents::l3::agent_mode: \u0027dvr\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  ControllerExtraConfig:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_05d6784e","line":24,"updated":"2016-07-12 14:08:59.000000000","message":"One comment on the use of ComputeExtraConfig here. These parameters were really meant for the end user to be able to add custom Hiera I think and we should refrain from using the mechanism internally.\n\nI\u0027m wondering if perhaps instead of this we should instead have a new L3 service that extends the \u0027base\u0027 or \u0027pacemaker\u0027 services to add this extra Hiera setting. Similar to what we are doing in puppet/services/pacemaker/neutron-l3.yaml. So you would copy that and make a new version for puppet/services/neutron-l3-dvr.yaml and puppet/services/pacemaker/neutron-l3-dvr.yaml. Then in this environment we would swap in the new L3 agents for compute and controller. NOTE: in doing this you will likely need to depend-on I2496372ca6e6ba9f52e9a8bb6e8dc731c125af13 which adds the required resource_registry entry for OS::TripleO::Services::ComputeNeutronOvsAgent.","commit_id":"1dd3539ba0530feaf2d2a4ef1336b77ee84a5053"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"13f922d66962179db236034c01afb6acbbb9e438","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  # \"Compute\" and \"Controller\" nodes run their L3 agents in different"},{"line_number":23,"context_line":"  # modes."},{"line_number":24,"context_line":"  NovaComputeExtraConfig:"},{"line_number":25,"context_line":"    neutron::agents::l3::agent_mode: \u0027dvr\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  ControllerExtraConfig:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_d351cc63","line":24,"in_reply_to":"1aa78d24_05d6784e","updated":"2016-07-12 17:34:12.000000000","message":"Yeah, that\u0027s a good point, and it means this will break if used in any environment where the ExtraConfig parameters are used in an operator environment.","commit_id":"1dd3539ba0530feaf2d2a4ef1336b77ee84a5053"}],"overcloud-resource-registry-puppet.yaml":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"84ab5ceb3e25e2b31e7e35a185546b72f3ff21f3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  OS::TripleO::Services::Snmp: puppet/services/snmp.yaml"},{"line_number":175,"context_line":"  OS::TripleO::Services::Timezone: puppet/services/time/timezone.yaml"},{"line_number":176,"context_line":"  OS::TripleO::Services::ComputeL3Agent: OS::Heat::None"},{"line_number":177,"context_line":"  OS::TripleO::Services::ComputeMetadataAgent: OS::Heat::None"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"parameter_defaults:"},{"line_number":180,"context_line":"  EnablePackageInstall: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1aa78d24_6a001767","line":177,"updated":"2016-07-11 18:55:13.000000000","message":"Trying to align this patch with what I\u0027m doing here as well:\n\nI2496372ca6e6ba9f52e9a8bb6e8dc731c125af13\n\nCould we name these settings ComputeNeutronL3Agent and ComputeNeutronMetadataAgent instead?","commit_id":"c034ba100326715e26fb6aa7cdc6960447ae1b43"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"f1cafd21f4fabfefe6f3251e3ac788d886e7e571","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  OS::TripleO::Services::Snmp: puppet/services/snmp.yaml"},{"line_number":175,"context_line":"  OS::TripleO::Services::Timezone: puppet/services/time/timezone.yaml"},{"line_number":176,"context_line":"  OS::TripleO::Services::ComputeL3Agent: OS::Heat::None"},{"line_number":177,"context_line":"  OS::TripleO::Services::ComputeMetadataAgent: OS::Heat::None"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"parameter_defaults:"},{"line_number":180,"context_line":"  EnablePackageInstall: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1aa78d24_3095de32","line":177,"in_reply_to":"1aa78d24_6a001767","updated":"2016-07-11 19:53:10.000000000","message":"Yup, sounds good to me! Smoke testing the changes now","commit_id":"c034ba100326715e26fb6aa7cdc6960447ae1b43"}],"puppet/services/neutron-l3-compute-dvr.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"203d9c9574bee412ed43f0ed01620103da62f51f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    type: json"},{"line_number":13,"context_line":"  Debug:"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    default: \u0027\u0027"},{"line_number":16,"context_line":"  NeutronExternalNetworkBridge:"},{"line_number":17,"context_line":"    description: Name of bridge used for external network traffic."},{"line_number":18,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_67bfcafb","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":15},"updated":"2016-07-25 15:55:58.000000000","message":"This parameter is unused?","commit_id":"f3432d8c39773bb47bb5283123bd1452da8027e8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bacb4f028213cad570caebc3d72b57ecf13e4b34","unresolved":false,"context_lines":[{"line_number":34,"context_line":"          - neutron::agents::l3::external_network_bridge: {get_param: NeutronExternalNetworkBridge}"},{"line_number":35,"context_line":"            neutron::agents::l3::agent_mode : \u0027dvr\u0027"},{"line_number":36,"context_line":"      step_config: |"},{"line_number":37,"context_line":"        include tripleo::profile::base::neutron::l3"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bacf61ea_f9b9f87a","line":37,"updated":"2016-08-02 15:26:32.000000000","message":"So we\u0027re duplicating regular neutron l3 service here, and just trick some parameters? Sounds like we could do better and just re-use the same service, and change the parameters depending on the environment we\u0027re running.","commit_id":"bc68592c70daaa5702c8d37f9087faec811f3b85"}],"puppet/services/neutron-l3.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"203d9c9574bee412ed43f0ed01620103da62f51f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    type: json"},{"line_number":12,"context_line":"  Debug:"},{"line_number":13,"context_line":"    type: string"},{"line_number":14,"context_line":"    default: \u0027\u0027"},{"line_number":15,"context_line":"  NeutronExternalNetworkBridge:"},{"line_number":16,"context_line":"    description: Name of bridge used for external network traffic."},{"line_number":17,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_a75ee2e6","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":15},"updated":"2016-07-25 15:55:58.000000000","message":"Aha, copy/paste error, this is also unused so we can fix this one in another patch :)","commit_id":"f3432d8c39773bb47bb5283123bd1452da8027e8"}]}