)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ebd7efb72e6e7b0dd1e613231b70aba3d25f3699","unresolved":false,"context_lines":[{"line_number":15,"context_line":"keeps confusing users)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"We will leave the environment/puppet-pacemaker.yaml around"},{"line_number":18,"context_line":"until Pike."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I0f61016df6a9f07971c5eab51cc9674a1458c66f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a30ddce_6298201d","line":18,"updated":"2017-03-10 16:24:26.000000000","message":"This now needs to be kept until Queens.","commit_id":"f231d959a9ff5ef5d7f716a4755774385ab1ded2"}],"ci/environments/multinode-3nodes.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"212d593699dc15a9b98b1da683bf0fc71979298f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - OS::TripleO::Services::OsloMessagingRpc"},{"line_number":74,"context_line":"    - OS::TripleO::Services::OsloMessagingNotify"},{"line_number":75,"context_line":"    - OS::TripleO::Services::HAproxy"},{"line_number":76,"context_line":"    - OS::TripleO::Services::Keepalived"},{"line_number":77,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":78,"context_line":"    - OS::TripleO::Services::Memcached"},{"line_number":79,"context_line":"    - OS::TripleO::Services::Pacemaker"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"bfb3d3c7_ec15639d","side":"PARENT","line":76,"updated":"2019-05-24 10:21:59.000000000","message":"i think it might be useful to keep this here to make sure the heat resource is actually disabled in the default config\n\nsame applies to the other files where we have this line","commit_id":"d90434187315e96d3ebc184866dcd91954c0471d"}],"ci/environments/scenario001-multinode-containers.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"00eeb0d831d78801db04038a065cab9262e188c5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":37,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":38,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":39,"context_line":"    - OS::TripleO::Services::Docker"},{"line_number":40,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":41,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":42,"context_line":"    - OS::TripleO::Services::LoginDefs"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_cbb98e15","line":39,"range":{"start_line":39,"start_character":29,"end_line":39,"end_character":35},"updated":"2020-03-17 15:55:39.000000000","message":"Missing podman","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b6ca3f3984f8eaea594f13a755d0ea2c86a29c0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":37,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":38,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":39,"context_line":"    - OS::TripleO::Services::Docker"},{"line_number":40,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":41,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":42,"context_line":"    - OS::TripleO::Services::LoginDefs"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_b2212250","line":39,"range":{"start_line":39,"start_character":29,"end_line":39,"end_character":35},"in_reply_to":"1fa4df85_cbb98e15","updated":"2020-03-17 17:27:38.000000000","message":"Done","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"}],"ci/environments/scenario007-multinode-containers.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"00eeb0d831d78801db04038a065cab9262e188c5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":34,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":35,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":36,"context_line":"    - OS::TripleO::Services::Docker"},{"line_number":37,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":38,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":39,"context_line":"    - OS::TripleO::Services::GlanceApi"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_ab1a1214","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":35},"updated":"2020-03-17 15:55:39.000000000","message":"missing podman","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b6ca3f3984f8eaea594f13a755d0ea2c86a29c0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":34,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":35,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":36,"context_line":"    - OS::TripleO::Services::Docker"},{"line_number":37,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":38,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":39,"context_line":"    - OS::TripleO::Services::GlanceApi"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_12e036fa","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":35},"in_reply_to":"1fa4df85_ab1a1214","updated":"2020-03-17 17:27:38.000000000","message":"Done","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"}],"ci/environments/scenario010-multinode-containers.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"00eeb0d831d78801db04038a065cab9262e188c5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":33,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":34,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":35,"context_line":"    - OS::TripleO::Services::Docker"},{"line_number":36,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":37,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":38,"context_line":"    - OS::TripleO::Services::GlanceApi"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_6bd2da36","line":35,"range":{"start_line":35,"start_character":29,"end_line":35,"end_character":35},"updated":"2020-03-17 15:55:39.000000000","message":"missing podman","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b6ca3f3984f8eaea594f13a755d0ea2c86a29c0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":33,"context_line":"    - OS::TripleO::Services::Clustercheck"},{"line_number":34,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":35,"context_line":"    - OS::TripleO::Services::Docker"},{"line_number":36,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":37,"context_line":"    - OS::TripleO::Services::Keystone"},{"line_number":38,"context_line":"    - OS::TripleO::Services::GlanceApi"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_d2e13efe","line":35,"range":{"start_line":35,"start_character":29,"end_line":35,"end_character":35},"in_reply_to":"1fa4df85_6bd2da36","updated":"2020-03-17 17:27:38.000000000","message":"Done","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"}],"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"930690bb3928eb0e50784fbf57fd4306390edb45","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                            - {get_param: [DefaultPasswords, mysql_root_password]}"},{"line_number":361,"context_line":"                  command:"},{"line_number":362,"context_line":"                    - \u0027mysql\u0027"},{"line_number":363,"context_line":"                    - \u0027-u${ROOT_PASSWORD}\u0027"},{"line_number":364,"context_line":"                    - \u0027-e\u0027"},{"line_number":365,"context_line":"                    - \u0027\\\"CREATE USER IF NOT EXISTS \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${CLUSTERCHECK_PASSWORD}\u0027\u0027; GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\\\"\u0027"},{"line_number":366,"context_line":"            - name: Remove non-HA mysql container"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"df33271e_beb4b936","line":363,"updated":"2020-03-26 22:31:57.000000000","message":"\"-u\" is for user, not password.\nHowever, you should exec into the container as root, because then you automatically inherit the right .my.cnf and you don\u0027t need to pass any or -uroot or -p${ROOT_PASSWORD}, so you don\u0027t need to define ROOT_PASSWORD env var.","commit_id":"cf403bc85b38121f237861b479ec10290d51beec"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"060396326004ffa4945b911676c7d12fdc98542d","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                            - {get_param: [DefaultPasswords, mysql_root_password]}"},{"line_number":361,"context_line":"                  command:"},{"line_number":362,"context_line":"                    - \u0027mysql\u0027"},{"line_number":363,"context_line":"                    - \u0027-u${ROOT_PASSWORD}\u0027"},{"line_number":364,"context_line":"                    - \u0027-e\u0027"},{"line_number":365,"context_line":"                    - \u0027\\\"CREATE USER IF NOT EXISTS \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${CLUSTERCHECK_PASSWORD}\u0027\u0027; GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\\\"\u0027"},{"line_number":366,"context_line":"            - name: Remove non-HA mysql container"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"df33271e_5723cb05","line":363,"in_reply_to":"df33271e_beb4b936","updated":"2020-03-27 11:53:07.000000000","message":"Done","commit_id":"cf403bc85b38121f237861b479ec10290d51beec"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"930690bb3928eb0e50784fbf57fd4306390edb45","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                    - \u0027mysql\u0027"},{"line_number":363,"context_line":"                    - \u0027-u${ROOT_PASSWORD}\u0027"},{"line_number":364,"context_line":"                    - \u0027-e\u0027"},{"line_number":365,"context_line":"                    - \u0027\\\"CREATE USER IF NOT EXISTS \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${CLUSTERCHECK_PASSWORD}\u0027\u0027; GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\\\"\u0027"},{"line_number":366,"context_line":"            - name: Remove non-HA mysql container"},{"line_number":367,"context_line":"              include_role:"},{"line_number":368,"context_line":"                name: tripleo_container_rm"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"df33271e_fe876160","line":365,"updated":"2020-03-26 22:31:57.000000000","message":"Not sure we need the backslash before the quote?","commit_id":"cf403bc85b38121f237861b479ec10290d51beec"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"15417a68ac782f49c86475992e8488bab7631873","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                    - \u0027mysql\u0027"},{"line_number":363,"context_line":"                    - \u0027-u${ROOT_PASSWORD}\u0027"},{"line_number":364,"context_line":"                    - \u0027-e\u0027"},{"line_number":365,"context_line":"                    - \u0027\\\"CREATE USER IF NOT EXISTS \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${CLUSTERCHECK_PASSWORD}\u0027\u0027; GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\\\"\u0027"},{"line_number":366,"context_line":"            - name: Remove non-HA mysql container"},{"line_number":367,"context_line":"              include_role:"},{"line_number":368,"context_line":"                name: tripleo_container_rm"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"df33271e_de4b7d56","line":365,"updated":"2020-03-26 22:23:17.000000000","message":"note sure about the quotes here... we\u0027ll see","commit_id":"cf403bc85b38121f237861b479ec10290d51beec"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"060396326004ffa4945b911676c7d12fdc98542d","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                    - \u0027mysql\u0027"},{"line_number":363,"context_line":"                    - \u0027-u${ROOT_PASSWORD}\u0027"},{"line_number":364,"context_line":"                    - \u0027-e\u0027"},{"line_number":365,"context_line":"                    - \u0027\\\"CREATE USER IF NOT EXISTS \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 IDENTIFIED BY \u0027\u0027${CLUSTERCHECK_PASSWORD}\u0027\u0027; GRANT PROCESS ON *.* TO \u0027\u0027clustercheck\u0027\u0027@\u0027\u0027localhost\u0027\u0027 WITH GRANT OPTION;\\\"\u0027"},{"line_number":366,"context_line":"            - name: Remove non-HA mysql container"},{"line_number":367,"context_line":"              include_role:"},{"line_number":368,"context_line":"                name: tripleo_container_rm"}],"source_content_type":"text/x-yaml","patch_set":65,"id":"df33271e_77288fe1","line":365,"in_reply_to":"df33271e_fe876160","updated":"2020-03-27 11:53:07.000000000","message":"Done","commit_id":"cf403bc85b38121f237861b479ec10290d51beec"}],"environments/nonha-arch.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51342ef25c6d9a8f249b48fd85bfef7c5cb8995c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  OS::TripleO::Services::HAproxy: ../puppet/services/haproxy.yaml"},{"line_number":7,"context_line":"  OS::TripleO::Services::Redis: ../puppet/services/database/redis.yaml"},{"line_number":8,"context_line":"  OS::TripleO::Services::MySQL: ../puppet/services/database/mysql.yaml"},{"line_number":9,"context_line":"  OS::TripleO::Services::Keepalived: ../puppet/services/keepalived.yaml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_3f73ec16","line":9,"updated":"2017-01-11 08:55:58.000000000","message":"do you also want  OS::TripleO::Services::Pacemaker: OS::Heat::None \nhere (as per comment at https://review.openstack.org/#/c/359060/8/overcloud-resource-registry-puppet.j2.yaml )","commit_id":"3725a9988173df65d723315ae3e52e879f4f128f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b2faa911d173ace1ed128116bf260ff65342278e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  OS::TripleO::Services::HAproxy: ../puppet/services/haproxy.yaml"},{"line_number":7,"context_line":"  OS::TripleO::Services::Redis: ../puppet/services/database/redis.yaml"},{"line_number":8,"context_line":"  OS::TripleO::Services::MySQL: ../puppet/services/database/mysql.yaml"},{"line_number":9,"context_line":"  OS::TripleO::Services::Keepalived: ../puppet/services/keepalived.yaml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_dd992970","line":9,"in_reply_to":"ba5201f7_3f73ec16","updated":"2017-01-16 00:41:56.000000000","message":"Ack, yes good catch","commit_id":"3725a9988173df65d723315ae3e52e879f4f128f"}],"environments/puppet-pacemaker.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51342ef25c6d9a8f249b48fd85bfef7c5cb8995c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# the pacemaker deployment is now the default. This file will be"},{"line_number":3,"context_line":"# removed with the release of pike."},{"line_number":4,"context_line":"# Use environments/nonha-arch.yaml to get the non-HA deployment"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# An environment which enables configuration of an"},{"line_number":7,"context_line":"# Overcloud controller with Pacemaker."},{"line_number":8,"context_line":"resource_registry:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_df5e6044","line":5,"updated":"2017-01-11 08:55:58.000000000","message":"good that we have the note here but it *is* a little reduntant in the sense that if you aren\u0027t using it because you deploy for _reason_ the non-ha current default you\u0027ll miss it.\n\nI guess this should only really apply to ci/dev setups so shouldn\u0027t really be a big problem #justsayin...\n\nmaybe we need to make sure we make adequate noise in the docs and releasenotes for next cut of tripleo-heat-templates","commit_id":"3725a9988173df65d723315ae3e52e879f4f128f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b2faa911d173ace1ed128116bf260ff65342278e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# the pacemaker deployment is now the default. This file will be"},{"line_number":3,"context_line":"# removed with the release of pike."},{"line_number":4,"context_line":"# Use environments/nonha-arch.yaml to get the non-HA deployment"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# An environment which enables configuration of an"},{"line_number":7,"context_line":"# Overcloud controller with Pacemaker."},{"line_number":8,"context_line":"resource_registry:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_1da491a4","line":5,"in_reply_to":"ba5201f7_df5e6044","updated":"2017-01-16 00:41:56.000000000","message":"Yes we definitelly will need to add a release note with the mechanism Emilien introduced","commit_id":"3725a9988173df65d723315ae3e52e879f4f128f"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"672fdec112c82df4abf3c9d2cae3cdab5175bd3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# DO NOT RELY ON THIS FILE ANY LONGER"},{"line_number":2,"context_line":"# the pacemaker deployment is now the default. This file will be"},{"line_number":3,"context_line":"# removed with the release of pike."},{"line_number":4,"context_line":"# Use environments/nonha-arch.yaml to get the non-HA deployment"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# An environment which enables configuration of an"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a30ddce_4fe5ca06","line":3,"range":{"start_line":3,"start_character":30,"end_line":3,"end_character":34},"updated":"2017-03-13 16:30:32.000000000","message":"This statement might be technically true (we\u0027ll release pike and then remove the file), but I think it\u0027s confusing to word it this way.  I also suspect it was actually meant to say something else too since this was also how it read when the file was going to be removed in pike.","commit_id":"b104c3210ecb0c7a9167c546cdc1f39da4f15289"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1d458a8fe54f29708372da08ce23c885111a4f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# DO NOT RELY ON THIS FILE ANY LONGER"},{"line_number":2,"context_line":"# the pacemaker deployment is now the default. This file will be"},{"line_number":3,"context_line":"# removed with the release of queens."},{"line_number":4,"context_line":"# Use environments/nonha-arch.yaml to get the non-HA deployment"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f201791_0d5d8079","line":1,"updated":"2017-06-23 10:04:03.000000000","message":"maybe add \u0027DEPRECATED\u0027 if you get another pass but no problem","commit_id":"74673878e9b4ba139b2e45268f61d3482756a3f4"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"a6dcf6f3c95d209c38443022802388136855e3c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# DO NOT RELY ON THIS FILE ANY LONGER"},{"line_number":2,"context_line":"# the pacemaker deployment is now the default. This file will be"},{"line_number":3,"context_line":"# removed with the release of queens."},{"line_number":4,"context_line":"# Use environments/nonha-arch.yaml to get the non-HA deployment"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f201791_805a774c","line":1,"in_reply_to":"5f201791_0d5d8079","updated":"2017-06-23 10:32:38.000000000","message":"Sure thing.","commit_id":"74673878e9b4ba139b2e45268f61d3482756a3f4"}],"environments/services/zaqar.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"00eeb0d831d78801db04038a065cab9262e188c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::Zaqar: ../../deployment/zaqar/zaqar-container-puppet.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Redis : ../../deployment/database/redis-pacemaker-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_eb200a4c","line":3,"range":{"start_line":3,"start_character":82,"end_line":3,"end_character":83},"updated":"2020-03-17 15:55:39.000000000","message":"This is used by the undercloud only i think?","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b6ca3f3984f8eaea594f13a755d0ea2c86a29c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::Zaqar: ../../deployment/zaqar/zaqar-container-puppet.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Redis : ../../deployment/database/redis-pacemaker-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_12b916e8","line":3,"range":{"start_line":3,"start_character":82,"end_line":3,"end_character":83},"in_reply_to":"1fa4df85_eb200a4c","updated":"2020-03-17 17:27:38.000000000","message":"Done","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51342ef25c6d9a8f249b48fd85bfef7c5cb8995c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginMidonet: puppet/services/neutron-midonet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: puppet/services/neutron-ovs-agent.yaml"},{"line_number":163,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: puppet/services/neutron-ovs-agent.yaml"},{"line_number":164,"context_line":"  OS::TripleO::Services::Pacemaker: puppet/services/pacemaker.yaml"},{"line_number":165,"context_line":"  OS::TripleO::Services::NeutronSriovAgent: OS::Heat::None"},{"line_number":166,"context_line":"  OS::TripleO::Services::RabbitMQ: puppet/services/pacemaker/rabbitmq.yaml"},{"line_number":167,"context_line":"  OS::TripleO::Services::HAproxy: puppet/services/pacemaker/haproxy.yaml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_7f7c94eb","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":66},"updated":"2017-01-11 08:55:58.000000000","message":"might want to also add this to the nonha-arch? I mean if I say \u0027-e nonha-arch\u0027 I may be surprised to find pacemaker running? (even though it won\u0027t be managing anything)","commit_id":"3725a9988173df65d723315ae3e52e879f4f128f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b2faa911d173ace1ed128116bf260ff65342278e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginMidonet: puppet/services/neutron-midonet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: puppet/services/neutron-ovs-agent.yaml"},{"line_number":163,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: puppet/services/neutron-ovs-agent.yaml"},{"line_number":164,"context_line":"  OS::TripleO::Services::Pacemaker: puppet/services/pacemaker.yaml"},{"line_number":165,"context_line":"  OS::TripleO::Services::NeutronSriovAgent: OS::Heat::None"},{"line_number":166,"context_line":"  OS::TripleO::Services::RabbitMQ: puppet/services/pacemaker/rabbitmq.yaml"},{"line_number":167,"context_line":"  OS::TripleO::Services::HAproxy: puppet/services/pacemaker/haproxy.yaml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_3d9f8d51","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":66},"in_reply_to":"ba5201f7_7f7c94eb","updated":"2017-01-16 00:41:56.000000000","message":"Ack, done","commit_id":"3725a9988173df65d723315ae3e52e879f4f128f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"574afd8be9cb93368e7bfb7e369ce872a16533cb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  OS::TripleO::NodeExtraConfig: puppet/extraconfig/pre_deploy/default.yaml"},{"line_number":66,"context_line":"  OS::TripleO::NodeExtraConfigPost: extraconfig/post_deploy/default.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  OS::TripleO::ControllerConfig: puppet/controller-config-pacemaker.yaml"},{"line_number":69,"context_line":"  OS::TripleO::Tasks::ControllerPrePuppet: extraconfig/tasks/pre_puppet_pacemaker.yaml"},{"line_number":70,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppet: extraconfig/tasks/post_puppet_pacemaker.yaml"},{"line_number":71,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppetRestart: extraconfig/tasks/post_puppet_pacemaker_restart.yaml"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a3c09a3_68402335","line":68,"updated":"2017-01-17 11:55:15.000000000","message":"this was removed with I1e010099263a325d06483f498c70582b008c31e2","commit_id":"eb1c5426d4d1910f18974ba56058187d5b880898"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"00eeb0d831d78801db04038a065cab9262e188c5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  OS::TripleO::Services::NeutronCorePluginNuage: deployment/neutron/neutron-plugin-nuage.yaml"},{"line_number":152,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Nuage: deployment/neutron/neutron-plugin-ml2-nuage.yaml"},{"line_number":153,"context_line":"  OS::TripleO::Services::NeutronCorePluginNSX: deployment/neutron/neutron-plugin-nsx-container-puppet.yaml"},{"line_number":154,"context_line":"  OS::TripleO::Services::OVNDBs: deployment/ovn/ovn-dbs-container-puppet.yaml"},{"line_number":155,"context_line":"  OS::TripleO::Services::OVNController: deployment/ovn/ovn-controller-container-puppet.yaml"},{"line_number":156,"context_line":"  OS::TripleO::Services::OvsDpdkNetcontrold: OS::Heat::None"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_ab01b2b1","line":154,"range":{"start_line":154,"start_character":0,"end_line":154,"end_character":77},"updated":"2020-03-17 15:55:39.000000000","message":"Missing pacemaker here","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b6ca3f3984f8eaea594f13a755d0ea2c86a29c0","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  OS::TripleO::Services::NeutronCorePluginNuage: deployment/neutron/neutron-plugin-nuage.yaml"},{"line_number":152,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Nuage: deployment/neutron/neutron-plugin-ml2-nuage.yaml"},{"line_number":153,"context_line":"  OS::TripleO::Services::NeutronCorePluginNSX: deployment/neutron/neutron-plugin-nsx-container-puppet.yaml"},{"line_number":154,"context_line":"  OS::TripleO::Services::OVNDBs: deployment/ovn/ovn-dbs-container-puppet.yaml"},{"line_number":155,"context_line":"  OS::TripleO::Services::OVNController: deployment/ovn/ovn-controller-container-puppet.yaml"},{"line_number":156,"context_line":"  OS::TripleO::Services::OvsDpdkNetcontrold: OS::Heat::None"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_92d506e8","line":154,"range":{"start_line":154,"start_character":0,"end_line":154,"end_character":77},"in_reply_to":"1fa4df85_ab01b2b1","updated":"2020-03-17 17:27:38.000000000","message":"Done","commit_id":"b9ff564b2e669c654ee3607ec7d6e5a00062298b"}],"overcloud-resource-registry-puppet.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"faae831c302033df971afeff5e6dd195ae031c85","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  OS::TripleO::Tasks::PackageUpdate: extraconfig/tasks/yum_update.yaml"},{"line_number":27,"context_line":"  OS::TripleO::Tasks::ControllerPrePuppet: extraconfig/tasks/pre_puppet_pacemaker.yaml"},{"line_number":28,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppet: extraconfig/tasks/post_puppet_pacemaker.yaml"},{"line_number":29,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppetRestart: extraconfig/tasks/post_puppet_pacemaker_restart.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  OS::TripleO::Server: OS::Nova::Server"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_d86878bd","line":29,"updated":"2016-08-26 16:54:11.000000000","message":"I wonder if we need to create new hooks, so that operators can still insert something here..","commit_id":"1b615855108f45b06c4b127aedc9f43cb0135bc8"}],"releasenotes/notes/pacemaker-by-default-c5d28ee8dc897c62.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e2cdf6ac86d0834d59ffef65cf28e564d1456278","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The environments/puppet-pacemaker.yaml file is now deprecated and the HA"},{"line_number":4,"context_line":"    deployment is now the default. In order to get the non-HA deployment use"},{"line_number":5,"context_line":"    environments/nonha-arch.yaml explicitly."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5f201791_f7c0f82c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"updated":"2017-06-22 11:16:14.000000000","message":"does this have an upgrade impact as well?","commit_id":"5fae3153be7161fc943a293b1e502810e5d7aa36"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"53de784d92819512891326e149d9468cd7d96e3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The environments/puppet-pacemaker.yaml file is now deprecated and the HA"},{"line_number":4,"context_line":"    deployment is now the default. In order to get the non-HA deployment use"},{"line_number":5,"context_line":"    environments/nonha-arch.yaml explicitly."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5f201791_d2a18aab","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"in_reply_to":"5f201791_d284ea60","updated":"2017-06-22 11:51:39.000000000","message":"Thanks! Could you please specify the required steps to the corresponding release notes\u0027 upgrade section?","commit_id":"5fae3153be7161fc943a293b1e502810e5d7aa36"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ce504a3a0ad9864a6b1161ae7bf1c15d567ecd5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The environments/puppet-pacemaker.yaml file is now deprecated and the HA"},{"line_number":4,"context_line":"    deployment is now the default. In order to get the non-HA deployment use"},{"line_number":5,"context_line":"    environments/nonha-arch.yaml explicitly."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5f201791_3268be1f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"in_reply_to":"5f201791_d2a18aab","updated":"2017-06-22 11:59:00.000000000","message":"Sure thing, thanks for the feedback.","commit_id":"5fae3153be7161fc943a293b1e502810e5d7aa36"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"e861aee7bb16b58af17f007b1b93d5c3c179b022","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The environments/puppet-pacemaker.yaml file is now deprecated and the HA"},{"line_number":4,"context_line":"    deployment is now the default. In order to get the non-HA deployment use"},{"line_number":5,"context_line":"    environments/nonha-arch.yaml explicitly."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5f201791_d284ea60","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"in_reply_to":"5f201791_f7c0f82c","updated":"2017-06-22 11:42:31.000000000","message":"Hi,\n\nI mean the way the upgrade command currently uses pacemaker is:\n\n  openstack overcloud deploy \\\n  --templates /home/stack/tht-master/ \\\n  -e /home/stack/tht-master/overcloud-resource-registry-puppet.yaml \\\n  -e /home/stack/tht-master/environments/puppet-pacemaker.yaml \\\n  -e /home/stack/tht-master/environments/major-upgrade-composable-steps.yaml \\\n  -e upgrade_repos.yaml\n\n\nAfter this lands and all CI jobs are working fine. If you want to launch an upgrade to master you should execute the same command, just removing:\n  -e /home/stack/tht-master/environments/puppet-pacemaker.yaml \\\n\nAs the resource registry is updated to have the content of the pacemaker template.\n\nBTW, downstream is already working in this way.","commit_id":"5fae3153be7161fc943a293b1e502810e5d7aa36"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1d458a8fe54f29708372da08ce23c885111a4f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    -e /home/stack/tht-master/environments/puppet-pacemaker.yaml"},{"line_number":11,"context_line":"    when running an Overcloud upgrade if using pacemaker."},{"line_number":12,"context_line":"    This is because the data in that template will be part of the default"},{"line_number":13,"context_line":"    resource registry content."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f201791_4d649822","line":13,"updated":"2017-06-23 10:04:03.000000000","message":"thankfully it also makes no difference if they do decide to continue using it. one day we will remove the file and they will break but until then...","commit_id":"74673878e9b4ba139b2e45268f61d3482756a3f4"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"a6dcf6f3c95d209c38443022802388136855e3c7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    -e /home/stack/tht-master/environments/puppet-pacemaker.yaml"},{"line_number":11,"context_line":"    when running an Overcloud upgrade if using pacemaker."},{"line_number":12,"context_line":"    This is because the data in that template will be part of the default"},{"line_number":13,"context_line":"    resource registry content."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f201791_20504332","line":13,"in_reply_to":"5f201791_4d649822","updated":"2017-06-23 10:32:38.000000000","message":"Done","commit_id":"74673878e9b4ba139b2e45268f61d3482756a3f4"}],"roles/Standalone.yaml":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"6ecb08a6efa826b1ac30b02b7557d7eef3fc1158","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    - OS::TripleO::Services::DesignateMDNS"},{"line_number":75,"context_line":"    - OS::TripleO::Services::DesignateProducer"},{"line_number":76,"context_line":"    - OS::TripleO::Services::DesignateSink"},{"line_number":77,"context_line":"    - OS::TripleO::Services::DesignateWorkerRegistry"},{"line_number":78,"context_line":"    - OS::TripleO::Services::Etcd"},{"line_number":79,"context_line":"    - OS::TripleO::Services::ExternalSwiftProxy"},{"line_number":80,"context_line":"    - OS::TripleO::Services::GlanceApi"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"1fa4df85_b55b3a85","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":52},"updated":"2020-03-18 17:50:40.000000000","message":"this should be DesignateWorker (no Registry)","commit_id":"8e14a2c920eb6d7ece817f130921db49f53df258"}]}