)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"23a1d484ad289b230ff14fad0ee21361e8759a51","unresolved":false,"context_lines":[{"line_number":14,"context_line":"accepts the following options:"},{"line_number":15,"context_line":"* full - for full cleaning with removing the data via ATA secure erase or shred"},{"line_number":16,"context_line":"* metadata - for cleaning only partitioning table."},{"line_number":17,"context_line":"The third option \"none\" is suppored by Puppet but is not advertised here as"},{"line_number":18,"context_line":"disabling disk wiping completely is known to cause bugs."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note that the upstream Ironic default is a bit unfortunate: it enabled both"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_b3f8007e","line":17,"updated":"2016-09-01 13:56:06.000000000","message":"Minor typo - \"suppored\"","commit_id":"de21e7ae8c67f0b5c8b3cc9ab7b9e3b10fa86fb4"}],"puppet/services/ironic-conductor.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e93e694a56e8152aae531d772fe8d2c2fed9e59d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":20,"context_line":"    type: json"},{"line_number":21,"context_line":"  IronicCleaningDiskErase:"},{"line_number":22,"context_line":"    default: \u0027full\u0027"},{"line_number":23,"context_line":"    description: Type of disk cleaning before and between deployments,"},{"line_number":24,"context_line":"                 \"full\" for full cleaning, \"metadata\" to clean only disk"},{"line_number":25,"context_line":"                 metadata (partition table)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_3c915f9a","line":22,"updated":"2016-09-05 12:44:40.000000000","message":"What impact can this have on speed of the deployment? (I guess this is a good default for production, but would it make sense to do e.g. metadata only cleaning in CI?)","commit_id":"e2d5bbc41e3e7ab4952dab55094c88933d4b7143"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b8647f5c2880ed4c9dc223ac489d62134b3a149a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":20,"context_line":"    type: json"},{"line_number":21,"context_line":"  IronicCleaningDiskErase:"},{"line_number":22,"context_line":"    default: \u0027full\u0027"},{"line_number":23,"context_line":"    description: Type of disk cleaning before and between deployments,"},{"line_number":24,"context_line":"                 \"full\" for full cleaning, \"metadata\" to clean only disk"},{"line_number":25,"context_line":"                 metadata (partition table)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_fc261715","line":22,"in_reply_to":"9a89bdaa_3c915f9a","updated":"2016-09-05 12:54:21.000000000","message":"\u003e What impact can this have on speed of the deployment\n\nNot deployment itself, but 1. time it takes to make a node \"available\", 2. time it takes to tear down an instance. This process can take a lot. Note, however, that this default matches the upstream one.\n\n\u003e would it make sense to do e.g. metadata only cleaning in CI\n\nOf course, as soon as we actually have this properly covered by CI ;)","commit_id":"e2d5bbc41e3e7ab4952dab55094c88933d4b7143"}]}