)]}'
{"extraconfig/tasks/major_upgrade_pacemaker.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8622565569fc382b2489ce2f2f0654e6aa495cef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2014-10-16"},{"line_number":2,"context_line":"description: \u0027Upgrade for Pacemaker deployments\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_15e43f0b","side":"PARENT","line":1,"updated":"2016-09-15 11:02:17.000000000","message":"set this to 2016-10-14","commit_id":"89f9a3f2e0274169f305a503f642867ef14244e1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8622565569fc382b2489ce2f2f0654e6aa495cef","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      servers: {get_param: controller_servers}"},{"line_number":58,"context_line":"      config: {get_resource: CephMonUpgradeConfig}"},{"line_number":59,"context_line":"      input_values: {get_param: input_values}"},{"line_number":60,"context_line":"      batch_create:"},{"line_number":61,"context_line":"        max_batch_size: 1"},{"line_number":62,"context_line":"      rolling_update:"},{"line_number":63,"context_line":"        max_batch_size: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_f5fa73bc","side":"PARENT","line":60,"updated":"2016-09-15 11:02:17.000000000","message":"these are valid for SoftwareDeploymentGroup too and needed here to perform the deployment on one node at a time\n\nwe just need to update the template version as they were added in liberty","commit_id":"89f9a3f2e0274169f305a503f642867ef14244e1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9f319229f4620754ae1bfa17368a237444112b05","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      servers: {get_param: controller_servers}"},{"line_number":58,"context_line":"      config: {get_resource: CephMonUpgradeConfig}"},{"line_number":59,"context_line":"      input_values: {get_param: input_values}"},{"line_number":60,"context_line":"      batch_create:"},{"line_number":61,"context_line":"        max_batch_size: 1"},{"line_number":62,"context_line":"      rolling_update:"},{"line_number":63,"context_line":"        max_batch_size: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_79b80ee6","side":"PARENT","line":60,"in_reply_to":"7a8ec9b2_f5fa73bc","updated":"2016-09-15 15:39:03.000000000","message":"yeah I added a note on the bug when i went looking, i wondered there if it was the template version. https://bugs.launchpad.net/tripleo/+bug/1623506","commit_id":"89f9a3f2e0274169f305a503f642867ef14244e1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4af5991ec7fa0b591fd0a995b20a7eb443d885c2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    properties:"},{"line_number":57,"context_line":"      servers: {get_param: controller_servers}"},{"line_number":58,"context_line":"      config: {get_resource: CephMonUpgradeConfig}"},{"line_number":59,"context_line":"      input_values: {get_param: input_values}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  ControllerPacemakerUpgradeConfig_Step1:"},{"line_number":62,"context_line":"    type: OS::Heat::SoftwareConfig"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_84d74322","line":59,"updated":"2016-09-15 10:03:02.000000000","message":"hey matbu, am trying to understand a little more about what is going on here, will update the bug too, but we should get gfidente to have a look here as well since he added them at https://review.openstack.org/#/c/357130/13/extraconfig/tasks/major_upgrade_pacemaker.yaml","commit_id":"3d4d555463278ac94e48690115a014d1d27cefd7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"91aae9f99ba9e2d828da79917d8b41dacd1bbd6a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      config: {get_resource: CephMonUpgradeConfig}"},{"line_number":59,"context_line":"      input_values: {get_param: input_values}"},{"line_number":60,"context_line":"   update_policy:"},{"line_number":61,"context_line":"     batch_create:"},{"line_number":62,"context_line":"        max_batch_size: 1"},{"line_number":63,"context_line":"      rolling_update:"},{"line_number":64,"context_line":"        max_batch_size: 1"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a8ec9b2_86a540a3","line":61,"updated":"2016-09-16 13:12:46.000000000","message":"It probably doesn\u0027t matter syntax-wise, but visually the indentation is off by one space on both of these lines (you need an extra one).","commit_id":"8aba3d6f54a0c2a412117144c14c8d5812c50213"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cedafd0a9a8cad384e7c32cee99804c77dca8824","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      config: {get_resource: CephMonUpgradeConfig}"},{"line_number":59,"context_line":"      input_values: {get_param: input_values}"},{"line_number":60,"context_line":"   update_policy:"},{"line_number":61,"context_line":"     batch_create:"},{"line_number":62,"context_line":"        max_batch_size: 1"},{"line_number":63,"context_line":"      rolling_update:"},{"line_number":64,"context_line":"        max_batch_size: 1"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a8ec9b2_8679c0ca","line":61,"in_reply_to":"7a8ec9b2_86a540a3","updated":"2016-09-16 13:14:49.000000000","message":"right thanks!","commit_id":"8aba3d6f54a0c2a412117144c14c8d5812c50213"}]}