)]}'
{"puppet/services/opendaylight-api.yaml":[{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"29083d9748ec4914fbfa83cf5c3d6e109cbf4174","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  OpenDaylightProviderMappings:"},{"line_number":48,"context_line":"    description: Mappings between logical networks and physical interfaces."},{"line_number":49,"context_line":"                 Required for VLAN deployments.  For example physnet1 -\u003e eth1."},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \"datacentre:br-ex\""},{"line_number":52,"context_line":"  EndpointMap:"},{"line_number":53,"context_line":"    default: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a98d1f4_dba81ade","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":16},"updated":"2016-09-30 17:04:02.000000000","message":"One thing to note here is this is a string instead of a comma delimited list.  This parameter is identical to neutron bridge mappings, but with using a string here we dont have to bother with str_replace.  The puppet module accepts this value as a string instead of array:\nhttps://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ovs/opendaylight.pp#L26\n\nI can update this to be an array and the heat templates to be a list later.  If it is preferred to do it now and list it is a dependency of this patch I can also do that.","commit_id":"a300f72f4dcd1670ecb1806f3358aaff7438b46e"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c965ba11914beb6db4d2ae6de587644b328c060e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  OpenDaylightProviderMappings:"},{"line_number":48,"context_line":"    description: Mappings between logical networks and physical interfaces."},{"line_number":49,"context_line":"                 Required for VLAN deployments.  For example physnet1 -\u003e eth1."},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \"datacentre:br-ex\""},{"line_number":52,"context_line":"  EndpointMap:"},{"line_number":53,"context_line":"    default: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_b3d8631f","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":16},"in_reply_to":"3a98d1f4_dba81ade","updated":"2016-10-04 17:35:11.000000000","message":"Consistency would be a good thing - if for no other reason that it would allow us to get some more consistency within the puppet modules. \n\nOn an unrelated note, I\u0027m curious as to why you have this property in both the API and OVS services files. If you are configuring OVS on this host, isn\u0027t it possible that you are going to have to configure the other ODL-OVS bits (e.g. username, etc.)? Something seems a bit off...","commit_id":"a300f72f4dcd1670ecb1806f3358aaff7438b46e"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"85a278b98fb491a9ee3355a966a41dbc49a82430","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  OpenDaylightProviderMappings:"},{"line_number":48,"context_line":"    description: Mappings between logical networks and physical interfaces."},{"line_number":49,"context_line":"                 Required for VLAN deployments.  For example physnet1 -\u003e eth1."},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \"datacentre:br-ex\""},{"line_number":52,"context_line":"  EndpointMap:"},{"line_number":53,"context_line":"    default: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_e89db10a","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":16},"in_reply_to":"3a98d1f4_dba81ade","updated":"2016-10-10 17:52:55.000000000","message":"I would prefer to make this a comma-delimited list, because that gives us limited input checking pre-deployment (fail fast in case of user error). I\u0027m neutral on whether we need a dependent patch to do that, or if it can be a follow-up patch.","commit_id":"a300f72f4dcd1670ecb1806f3358aaff7438b46e"}]}