)]}'
{"puppet/services/nova-libvirt.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a202f39b7c8395b76f2f6dd36eee7a6517d39a3e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                dport:"},{"line_number":56,"context_line":"                  - 16509"},{"line_number":57,"context_line":"                  - 16514"},{"line_number":58,"context_line":"                  - \u002749152:49261\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      step_config: |"},{"line_number":61,"context_line":"        include tripleo::profile::base::nova::libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_06c17f80","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":32},"updated":"2016-10-31 16:12:01.000000000","message":"Where did this range come from? The defaults from /etc/libvirt/qemu.conf seem to be 49152 to 49215. We also don\u0027t seem to be adjusting it via nova::migration::qemu so I just want to make sure we have the right range. Also given that this is in the ephermal range, do we need to ensure that the ports are properly reserved?","commit_id":"b454a184f410b4f9f9b483fb65294d84bbe125ae"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"251e92599f59315a014369a74f8fe3794c5e5877","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                dport:"},{"line_number":56,"context_line":"                  - 16509"},{"line_number":57,"context_line":"                  - 16514"},{"line_number":58,"context_line":"                  - \u002749152:49261\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      step_config: |"},{"line_number":61,"context_line":"        include tripleo::profile::base::nova::libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_71baecc1","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":32},"in_reply_to":"ba5da102_06c17f80","updated":"2016-10-31 22:03:11.000000000","message":"https://github.com/libvirt/libvirt/blob/bff2f781ab9d687b57c62e79aedf02a2cee2b77c/src/libxl/libxl_conf.h#L49-L50  I think the upper bounds was typoed in documentation somewhere","commit_id":"b454a184f410b4f9f9b483fb65294d84bbe125ae"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10d910496773d110e1643a0c472bf2904727ffb9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                dport:"},{"line_number":56,"context_line":"                  - 16509"},{"line_number":57,"context_line":"                  - 16514"},{"line_number":58,"context_line":"                  - \u002749152:49261\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      step_config: |"},{"line_number":61,"context_line":"        include tripleo::profile::base::nova::libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_514b2887","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":32},"in_reply_to":"ba5da102_71baecc1","updated":"2016-10-31 22:21:59.000000000","message":"Also according to the firewall docs it should be a - not a :. so 49152-49215","commit_id":"b454a184f410b4f9f9b483fb65294d84bbe125ae"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"132cd9340dc7ce6e80f724754b68c8dc39768b48","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                dport:"},{"line_number":56,"context_line":"                  - 16509"},{"line_number":57,"context_line":"                  - 16514"},{"line_number":58,"context_line":"                  - \u002749152:49215\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      step_config: |"},{"line_number":61,"context_line":"        include tripleo::profile::base::nova::libvirt"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_f4918a53","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":27},"updated":"2016-10-31 22:55:23.000000000","message":"i think this needs to be a -, but i\u0027m not sure","commit_id":"8d2333aceb7eaf9b8a76ee1ea17fc4e79154cabf"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ba9fab30f6b42c692c00feb94c90bcf65f974e7d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                dport:"},{"line_number":56,"context_line":"                  - 16509"},{"line_number":57,"context_line":"                  - 16514"},{"line_number":58,"context_line":"                  - \u002749152-49215\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      step_config: |"},{"line_number":61,"context_line":"        include tripleo::profile::base::nova::libvirt"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_7da2ab4c","line":58,"updated":"2016-11-01 14:40:01.000000000","message":"fwiw I think either the colon or the dash would\u0027ve worked, but IIUC the provider converts the former to the latter so this is better :)\n\nAlso fwiw, the docs referenced in the commit message are a little inconsistent (text and example don\u0027t match) AFAICT, the real authority is the values indicated in /etc/libvirt/qemu.conf.","commit_id":"a22dbb812ccf9e7c508f3aa15aaccfd622a8b819"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f9930a89863414a6116ebda91d69c471b0b639ef","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                dport:"},{"line_number":56,"context_line":"                  - 16509"},{"line_number":57,"context_line":"                  - 16514"},{"line_number":58,"context_line":"                  - \u002749152-49215\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      step_config: |"},{"line_number":61,"context_line":"        include tripleo::profile::base::nova::libvirt"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_9223e9a6","line":58,"in_reply_to":"ba5da102_7da2ab4c","updated":"2016-11-01 14:54:18.000000000","message":"The example in the docs is wrong but if you read the text before the example it has this port range (which matches libvirt code). I\u0027ve asked around how to fix the example in the docs but haven\u0027t heard anything yet.","commit_id":"a22dbb812ccf9e7c508f3aa15aaccfd622a8b819"}]}