)]}'
{"extraconfig/tasks/pacemaker_resource_restart.sh":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"a5c008aafbb7c330b45ee22347a58b2bb60a7c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a629dbe_92ca7b4e","line":32,"updated":"2016-11-07 16:45:43.000000000","message":"If this is not working for you, it could be because it seems like it\u0027s not executing the restart.sh at all nowadays. Looking at the history i think we lost the ControllerPostPuppet part here (i see it in \u0027-\u0027 lines but nothing putting it back in \u0027+\u0027 lines):\n\nhttps://github.com/openstack/tripleo-heat-templates/commit/54a0286106e716250231dbd80e467dbe85a160a5#diff-087ee1733f8822f77863d94858a6399eL103\n\nPerhaps we can just call this PrePuppet and PostPuppet (remove the \"Controller\" part of the name), and execute it on all nodes. We just have to always make sure that we only perform the operations on nodes where they should be performed. Looking at the script, it already checks for Pacemaker and Haproxy presence separately, so i think it could be working fine, once the PrePuppet/PostPuppet is re-added.","commit_id":"01f36ce76c1b03ed5132f98958c56d7d8a949130"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"59a3b9df8178a10e1fcc4afa4ecdd8ec064d933e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RESTART_FOLDER\u003d\"/var/lib/tripleo/pacemaker-restarts\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ -d \"$RESTART_FOLDER\" \u0026\u0026 -n $(pcmk_running) \u0026\u0026 -n $(is_bootstrap_node) ]]; then"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    TIMEOUT\u003d600"},{"line_number":13,"context_line":"    PCS_STATUS_OUTPUT\u003d\"$(pcs status)\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_05099edd","line":10,"updated":"2016-11-08 13:17:48.000000000","message":"I\u0027m not sure if this is necessary, but i guess it doesn\u0027t hurt either :) (All nodes that pass the pcmk_running and is_bootstrap_node checks together, should be also always passing the check for existence of this directory i think.)","commit_id":"3e0c8dd82710279ad226c745191a3a89c3129660"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"428cde16285b6376a799a54ff953e1013bf1f594","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RESTART_FOLDER\u003d\"/var/lib/tripleo/pacemaker-restarts\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ -d \"$RESTART_FOLDER\" \u0026\u0026 -n $(pcmk_running) \u0026\u0026 -n $(is_bootstrap_node) ]]; then"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    TIMEOUT\u003d600"},{"line_number":13,"context_line":"    PCS_STATUS_OUTPUT\u003d\"$(pcs status)\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_f38f1021","line":10,"in_reply_to":"9a629dbe_05099edd","updated":"2016-11-08 13:59:53.000000000","message":"ack, just let me run some tests and if its not needed Ill remove that check.","commit_id":"3e0c8dd82710279ad226c745191a3a89c3129660"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"59a3b9df8178a10e1fcc4afa4ecdd8ec064d933e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    for service in $SERVICES_TO_RESTART; do"},{"line_number":24,"context_line":"        echo \"Restarting $service...\""},{"line_number":25,"context_line":"        pcs resource restart --wait\u003d$TIMEOUT $service"},{"line_number":26,"context_line":"        rm -f /var/lib/tripleo/pacemaker-restarts/$service"},{"line_number":27,"context_line":"    done"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_05627ead","line":26,"updated":"2016-11-08 13:17:48.000000000","message":"here\u0027s $RESTART_FOLDER too","commit_id":"3e0c8dd82710279ad226c745191a3a89c3129660"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"428cde16285b6376a799a54ff953e1013bf1f594","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    for service in $SERVICES_TO_RESTART; do"},{"line_number":24,"context_line":"        echo \"Restarting $service...\""},{"line_number":25,"context_line":"        pcs resource restart --wait\u003d$TIMEOUT $service"},{"line_number":26,"context_line":"        rm -f /var/lib/tripleo/pacemaker-restarts/$service"},{"line_number":27,"context_line":"    done"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_1393a450","line":26,"in_reply_to":"9a629dbe_05627ead","updated":"2016-11-08 13:59:53.000000000","message":"Done","commit_id":"3e0c8dd82710279ad226c745191a3a89c3129660"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"59a3b9df8178a10e1fcc4afa4ecdd8ec064d933e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  OS::TripleO::Tasks::ControllerPrePuppet: OS::Heat::None"},{"line_number":61,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppet: OS::Heat::None"},{"line_number":62,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppetRestart: OS::Heat::None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  # \"AllNodes\" Extra cluster config, runs on all nodes prior to the post_deploy"},{"line_number":65,"context_line":"  # phase, e.g when puppet is applied, but after the pre_deploy phase.  Useful when"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a629dbe_65425a40","line":62,"updated":"2016-11-08 13:17:48.000000000","message":"I think we could safely remove the last line here, the ControllerPostPuppetRestart concept is internal to the particular ControllerPostPuppet resource we\u0027re using. \n\nWhatever is setting ControllerPostPuppet to the implementation we\u0027re using for HA, will also need to set ControllerPostPuppetRestart, but it does not need to be in the top-level resource registry.","commit_id":"3e0c8dd82710279ad226c745191a3a89c3129660"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"428cde16285b6376a799a54ff953e1013bf1f594","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  OS::TripleO::Tasks::ControllerPrePuppet: OS::Heat::None"},{"line_number":61,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppet: OS::Heat::None"},{"line_number":62,"context_line":"  OS::TripleO::Tasks::ControllerPostPuppetRestart: OS::Heat::None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  # \"AllNodes\" Extra cluster config, runs on all nodes prior to the post_deploy"},{"line_number":65,"context_line":"  # phase, e.g when puppet is applied, but after the pre_deploy phase.  Useful when"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a629dbe_08937350","line":62,"in_reply_to":"9a629dbe_65425a40","updated":"2016-11-08 13:59:53.000000000","message":"Done","commit_id":"3e0c8dd82710279ad226c745191a3a89c3129660"}]}