)]}'
{"extraconfig/tasks/major_upgrade_controller_pacemaker_2.sh":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"618aca7074b42dc687e04be0cdf8bfa42aac5593","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# on mysql package versionning, but this can be overriden manually"},{"line_number":45,"context_line":"# to support specific upgrade scenario"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"if [[ -n $(is_bootstrap_node) ]]; then"},{"line_number":48,"context_line":"    if [ $DO_MYSQL_UPGRADE -eq 1 ]; then"},{"line_number":49,"context_line":"        mysqldump $backup_flags \u003e \"$MYSQL_BACKUP_DIR/openstack_database.sql\""},{"line_number":50,"context_line":"        cp -rdp /etc/my.cnf* \"$MYSQL_BACKUP_DIR\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_d38adebe","line":47,"updated":"2016-11-09 10:58:55.000000000","message":"Then we call mysql_need_update here, see my comment in the template file.\n\nThat would set DO_MYSQL_UPGRADE without checking disk (which has been done in step one)","commit_id":"fc8f57f4b4de6096fc65c02e7305e7827a63a92e"}],"extraconfig/tasks/major_upgrade_pacemaker.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"618aca7074b42dc687e04be0cdf8bfa42aac5593","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      group: script"},{"line_number":113,"context_line":"      config:"},{"line_number":114,"context_line":"        list_join:"},{"line_number":115,"context_line":"        - \u0027\u0027"},{"line_number":116,"context_line":"        - - get_file: pacemaker_common_functions.sh"},{"line_number":117,"context_line":"          - get_file: major_upgrade_pacemaker_migrations.sh"},{"line_number":118,"context_line":"          - get_file: major_upgrade_controller_pacemaker_2.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a629dbe_d303be40","line":115,"updated":"2016-11-09 10:58:55.000000000","message":"You need to include major_upgrade_check.sh here as it holds the necessary function (check_disk_for_mysql_dump) that set the DO_MYSQL_UPGRADE variable.\n\nThis is unfortunate as the check is doing a full dump and that could take some time.   I think we should split the check_disk_for_mysql_dump into two functions:\n\n   mysql_need_update(){}\n\n   check_disk_for_mysql_dump(){}\n\nThen in check_disk_for_mysql_dump we call mysql_need_update which set the variable.  But it enables us to call mysql_need_update in step 2 without having to check for disk space again.","commit_id":"fc8f57f4b4de6096fc65c02e7305e7827a63a92e"}]}