)]}'
{"environments/major-upgrade-composable-steps.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::PostDeploySteps: ../puppet/major_upgrade_steps.yaml"},{"line_number":3,"context_line":"parameter_defaults:"},{"line_number":4,"context_line":"  UpgradeLevelNovaCompute: newton"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_212743b7","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":33},"updated":"2017-01-27 17:54:59.000000000","message":"would be good if this and https://review.openstack.org/419886 were consistent","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ecdc74f67db299b1a66ede8d66c9002dd6afc0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::PostDeploySteps: ../puppet/major_upgrade_steps.yaml"},{"line_number":3,"context_line":"parameter_defaults:"},{"line_number":4,"context_line":"  UpgradeLevelNovaCompute: newton"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_7f39bea3","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":33},"in_reply_to":"3a461143_212743b7","updated":"2017-01-30 08:26:27.000000000","message":"i thought we were going to try and use \u0027auto\u0027 for this cycle unless testing told us otherwise.","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"10b4778ebc12e5ea3d571d4bc11e0dbe6af5d326","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::PostDeploySteps: ../puppet/major_upgrade_steps.yaml"},{"line_number":3,"context_line":"parameter_defaults:"},{"line_number":4,"context_line":"  UpgradeLevelNovaCompute: newton"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_1fcce1b9","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":33},"updated":"2017-02-01 08:30:02.000000000","message":"sanity check... is \u0027auto\u0027 not working?","commit_id":"65c5754e7928a742c08eff600327faba846db074"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b466c1bcb8536455dccd80fc591c031e78dbd97","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::PostDeploySteps: ../puppet/major_upgrade_steps.yaml"},{"line_number":3,"context_line":"parameter_defaults:"},{"line_number":4,"context_line":"  UpgradeLevelNovaCompute: newton"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_55aef285","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":33},"updated":"2017-02-06 09:10:24.000000000","message":"do we want to make this auto - either way lets be  consistent with https://review.openstack.org/#/c/405241/26/puppet/services/nova-conductor.yaml","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"b8a8c0613afd68d8aac8f2d586a9ac0723df9c00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::PostDeploySteps: ../puppet/major_upgrade_steps.yaml"},{"line_number":3,"context_line":"parameter_defaults:"},{"line_number":4,"context_line":"  UpgradeLevelNovaCompute: newton"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_d8a5b704","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":33},"in_reply_to":"1a430d35_55aef285","updated":"2017-02-06 09:16:57.000000000","message":"ack, i\u0027ll update in a bit","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"}],"puppet/services/nova-api.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"41fa712dc5535985f8a723bea56e7b59f3980e8b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            - \"%{hiera(\u0027mysql_bind_host\u0027)}\""},{"line_number":162,"context_line":"      upgrade_tasks:"},{"line_number":163,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":164,"context_line":"          tags: step2"},{"line_number":165,"context_line":"          shell: \"apachectl -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":166,"context_line":"          register: nova_api_apache"},{"line_number":167,"context_line":"          ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_63bd2c02","line":164,"updated":"2016-12-07 13:41:08.000000000","message":"hey @shardy I think we may need to add another step or perhaps add a step0 and make that the init, with step 1 being the new one. It is for things like \u0027rabbit_newton_ocata_upgrade\u0027 https://github.com/openstack/tripleo-heat-templates/blob/71ed1dba52639fd34fd039c29195537dfff91d3f/extraconfig/tasks/major_upgrade_pacemaker_migrations.sh#L189\n\nand also the checks check_cluster etc that happen at the top of controller_pacemaker_1.sh? wdyt? i could start to add that (looking for something to do here to get involved... will try and catchup with camacho and matbu on a call this week as they both have things in review) and we can catch up next week when you\u0027re back. Sounds like you\u0027ll be having some conversations about the approach this week so would be nice to perhaps schedule a upgrades squad sync call next week? I could arrange that too if you think its a good idea. (We could just use bluejeans and give it to anyone that says they\u0027d like to join i mean on #tripleo)","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bba8ca23448ea2e38c60df73fa906248131a5e94","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            - \"%{hiera(\u0027mysql_bind_host\u0027)}\""},{"line_number":162,"context_line":"      upgrade_tasks:"},{"line_number":163,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":164,"context_line":"          tags: step2"},{"line_number":165,"context_line":"          shell: \"apachectl -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":166,"context_line":"          register: nova_api_apache"},{"line_number":167,"context_line":"          ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_db24eec7","line":164,"in_reply_to":"3a71b18c_63bd2c02","updated":"2016-12-08 14:35:51.000000000","message":"o/ shardy added somethingat https://review.openstack.org/#/c/408631/ that adds a step0 wdyt?","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"d4983ddbd3fed3a792843ccc8d48d21a356c62ce","unresolved":false,"context_lines":[{"line_number":171,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":172,"context_line":"        - name: Stop and disable nova_api_api service (pre-upgrade not under httpd)"},{"line_number":173,"context_line":"          tags: step2"},{"line_number":174,"context_line":"          service: name\u003dopenstack-nova_api-api state\u003dstopped enabled\u003dno"},{"line_number":175,"context_line":"        - name: Start nova_api_api service (running under httpd)"},{"line_number":176,"context_line":"          tags: step6"},{"line_number":177,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5201f7_f04b4a57","line":174,"updated":"2017-01-11 11:46:05.000000000","message":"service name should be openstack-nova-api","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"8ede839e565686ac5875bdaaed39b77bdcc5f0b3","unresolved":false,"context_lines":[{"line_number":173,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":174,"context_line":"        - name: Stop and disable nova_api_api service (pre-upgrade not under httpd)"},{"line_number":175,"context_line":"          tags: step2"},{"line_number":176,"context_line":"          service: name\u003dopenstack-nova_api-api state\u003dstopped enabled\u003dno"},{"line_number":177,"context_line":"        - name: Start nova_api_api service (running under httpd)"},{"line_number":178,"context_line":"          tags: step6"},{"line_number":179,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a57fde8_aee7fb10","line":176,"range":{"start_line":176,"start_character":34,"end_line":176,"end_character":42},"updated":"2017-01-12 18:51:20.000000000","message":"This is wrong and doesn\u0027t work, the name needs fixing","commit_id":"f8079e1287822dd2777e0f10ac12b2aef655de3d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"55bd3b534dd0e793d867d5c52612804f30fd094a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7a3c09a3_f3f6d1f7","updated":"2017-01-17 08:45:45.000000000","message":"this is a pretty cool pattern and gives us a way of dealing with these migrations ++","commit_id":"14b9afc004cee95bd9467e92b7a503ff39177b28"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"55bd3b534dd0e793d867d5c52612804f30fd094a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        - name: update nova api"},{"line_number":174,"context_line":"          tags: step2"},{"line_number":175,"context_line":"          yum: name\u003dopenstack-nova-api state\u003dlatest"},{"line_number":176,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":177,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":178,"context_line":"          tags: step2"},{"line_number":179,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a3c09a3_13fc3db7","line":176,"range":{"start_line":176,"start_character":17,"end_line":176,"end_character":32},"updated":"2017-01-17 08:45:45.000000000","message":"not entirely clear on this bit... why do we update at step2 if we are already running under apache (vs @ step3 via tripleo-packages.","commit_id":"14b9afc004cee95bd9467e92b7a503ff39177b28"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c920f2e10e6615b6ce0bb6437928c9e87eadef7e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        - name: update nova api"},{"line_number":174,"context_line":"          tags: step2"},{"line_number":175,"context_line":"          yum: name\u003dopenstack-nova-api state\u003dlatest"},{"line_number":176,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":177,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":178,"context_line":"          tags: step2"},{"line_number":179,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a3c09a3_cb903146","line":176,"range":{"start_line":176,"start_character":17,"end_line":176,"end_character":32},"in_reply_to":"7a3c09a3_13fc3db7","updated":"2017-01-17 12:22:52.000000000","message":"I think matbu put this here to work around the nova packaging which tries to restart services when you update the package, which fails because we\u0027ve stopped rabbit.\n\nProbably need to do it earlier than step2 in that case though, as we\u0027re probably just lucky re the task list ordering if this works in step 2.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/rabbitmq.yaml#L107\n\nWe\u0027re also missing logic to handle the cell0 DB stuff - since that\u0027s been reverted from puppet I think we have to work around it here or the upgrade from newton won\u0027t work in CI - I\u0027m working on adding that atm.","commit_id":"14b9afc004cee95bd9467e92b7a503ff39177b28"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"85222fa4b7d24e37380a9b1ad53bf573c1ba0f19","unresolved":false,"context_lines":[{"line_number":195,"context_line":"          ignore_errors: true"},{"line_number":196,"context_line":"        - name: Extra migration for or nova tripleo/+bug/1656791"},{"line_number":197,"context_line":"          tags: step2"},{"line_number":198,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":199,"context_line":"        - name: Stop nova_api service (running under httpd)"},{"line_number":200,"context_line":"          tags: step2"},{"line_number":201,"context_line":"          service: name\u003dhttpd state\u003dstopped"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_70c7e195","line":198,"range":{"start_line":198,"start_character":34,"end_line":198,"end_character":56},"updated":"2017-01-18 13:58:19.000000000","message":"This command is hanging for me in local testing (and in CI I suspect as it\u0027s also timing out)","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"1ad470d16ce28dfae4142da446625abc7d909649","unresolved":false,"context_lines":[{"line_number":195,"context_line":"          ignore_errors: true"},{"line_number":196,"context_line":"        - name: Extra migration for or nova tripleo/+bug/1656791"},{"line_number":197,"context_line":"          tags: step2"},{"line_number":198,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":199,"context_line":"        - name: Stop nova_api service (running under httpd)"},{"line_number":200,"context_line":"          tags: step2"},{"line_number":201,"context_line":"          service: name\u003dhttpd state\u003dstopped"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_b04dc9c5","line":198,"range":{"start_line":198,"start_character":34,"end_line":198,"end_character":56},"in_reply_to":"7a3c09a3_70c7e195","updated":"2017-01-18 14:06:22.000000000","message":"I think the problem is this is the wrong step - we either need to do it before the DB/VIPs are disabled in step1, or after they come back up in step 4","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"473ab750dc753ebbdbe0a64950fc224868d496cc","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":207,"context_line":"          tags: step2"},{"line_number":208,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":209,"context_line":"        # FIXME(shardy) we do the cell0 setup here, we may defer this to"},{"line_number":210,"context_line":"        # puppet in future when support is re-added there?"},{"line_number":211,"context_line":"        - name: Create a new database for nova cells"},{"line_number":212,"context_line":"          tags: step5"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_8bb5147f","line":209,"range":{"start_line":209,"start_character":10,"end_line":209,"end_character":15},"updated":"2017-01-18 08:08:22.000000000","message":"is this because we are still waiting for something to land for the related bug (I\u0027ll try and check today at some point)... in any case is unfortunate we have to deal with that as well here. But it is also pretty cool to see how you *can* work around it with ansible here. Ultimately though this goes away right?","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"382f62f13748bef739560b160f6ec1b98e717559","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":207,"context_line":"          tags: step2"},{"line_number":208,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":209,"context_line":"        # FIXME(shardy) we do the cell0 setup here, we may defer this to"},{"line_number":210,"context_line":"        # puppet in future when support is re-added there?"},{"line_number":211,"context_line":"        - name: Create a new database for nova cells"},{"line_number":212,"context_line":"          tags: step5"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_d0118353","line":209,"range":{"start_line":209,"start_character":10,"end_line":209,"end_character":15},"in_reply_to":"7a3c09a3_8bb5147f","updated":"2017-01-18 10:11:30.000000000","message":"I\u0027m not quite sure if it will go away, but all the cellsv2 stuff got reverted from puppet-tripleo, so we\u0027ll have to see what happens when it lands again.\n\nRegardless we\u0027ve got to have some way to set up the cellsv2 DB before doing the API db_sync, so perhaps it makes sense for the upgrade workflow around that to be handled here (since we\u0027re not relying on puppet to do the DB sync for any other services, it\u0027s arguably more consistent to do it here?)\n\nI\u0027ll add Alex for comment as he\u0027s been working on the puppet cells support.","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"34c9d452306788f587cdb0741ebdfe1400da6ee8","unresolved":false,"context_lines":[{"line_number":208,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":209,"context_line":"        # FIXME(shardy) we do the cell0 setup here, we may defer this to"},{"line_number":210,"context_line":"        # puppet in future when support is re-added there?"},{"line_number":211,"context_line":"        - name: Create a new database for nova cells"},{"line_number":212,"context_line":"          tags: step5"},{"line_number":213,"context_line":"          mysql_db:"},{"line_number":214,"context_line":"            name: nova_api_cell0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_de0df8e8","line":211,"updated":"2017-01-18 17:26:22.000000000","message":"This fails when it runs on a different role than controller role with:\n\n    TASK [Create a new database for nova cells] ************************************\n    fatal: [localhost]: FAILED! \u003d\u003e {\"changed\": false, \"failed\": true, \"msg\": \"unable to find /root/.my.cnf. Exception message: (2002, \\\"Can\u0027t connect to local MySQL server through socket \u0027/var/lib/mysql/mysql.sock\u0027 (2)\\\")\"}\n    \tto retry, use: --limit @/var/lib/heat-config/heat-config-ansible/e5891670-37ad-4a2a-8896-cff962c89b8c_playbook.retry","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"428dbb336997b5107dab9d4ab17a510f4112a146","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        - name: Create a new database for nova cells"},{"line_number":212,"context_line":"          tags: step5"},{"line_number":213,"context_line":"          mysql_db:"},{"line_number":214,"context_line":"            name: nova_api_cell0"},{"line_number":215,"context_line":"            state: present"},{"line_number":216,"context_line":"        - name: Grant access to the nova_api DB user"},{"line_number":217,"context_line":"          tags: step5"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_01501531","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":32},"updated":"2017-01-18 12:58:04.000000000","message":"Changed to nova_cell0 -  https://bugs.launchpad.net/nova/+bug/1656673","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"428dbb336997b5107dab9d4ab17a510f4112a146","unresolved":false,"context_lines":[{"line_number":217,"context_line":"          tags: step5"},{"line_number":218,"context_line":"          mysql_user:"},{"line_number":219,"context_line":"            str_replace:"},{"line_number":220,"context_line":"              template: \"name\u003dnova_api password\u003dPASSWORD host\u003d\\\"%\\\" priv\u003d\\\"nova_api.*:ALL/nova_api_cell0.*:ALL,GRANT\\\" state\u003dpresent\""},{"line_number":221,"context_line":"              params:"},{"line_number":222,"context_line":"                PASSWORD: {get_param: NovaPassword}"},{"line_number":223,"context_line":"        - name: Setup cells_v2"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_610f1937","line":220,"range":{"start_line":220,"start_character":14,"end_line":220,"end_character":133},"updated":"2017-01-18 12:58:04.000000000","message":"Also changed to nova db user","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0a785114f7b48def5d2284de429c4390126c261f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"          tags: step5"},{"line_number":225,"context_line":"          command:"},{"line_number":226,"context_line":"            str_replace:"},{"line_number":227,"context_line":"              template:  \"nova-manage cell_v2 simple_cell_setup --transport-url rabbit://USER:PASSWORD@HOST:port/?SSL\""},{"line_number":228,"context_line":"              params:"},{"line_number":229,"context_line":"                USER: {get_param: RabbitUserName}"},{"line_number":230,"context_line":"                PASSWORD: {get_param: RabbitPassword}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_1ce697e8","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":118},"updated":"2017-01-18 22:37:24.000000000","message":"I\u0027ve been informed that this created a cell with no name which will make it hard to properly manage in puppet. We need to sync how this is done here and what puppet will do before proceeding.","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0095f9ba671774cdda28bd3b6504eebf521c5050","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        - name: Sync nova_api DB"},{"line_number":240,"context_line":"          tags: step5"},{"line_number":241,"context_line":"          command: nova-manage api_db sync"},{"line_number":242,"context_line":"        - name: Start nova_api service (running under httpd)"},{"line_number":243,"context_line":"          tags: step6"},{"line_number":244,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_a6d36137","line":242,"updated":"2017-01-20 13:12:12.000000000","message":"We should check for depreciated/new values before restarting the nova-api services.  For instance osapi_compute_workers poses problem : https://bugzilla.redhat.com/show_bug.cgi?id\u003d1412197  (sorry about the osp11 bug, have to check with upstream as well)\n\nMakes more ini_file ?","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"510bdff39867a801d3ebb87086a6de22edd66433","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        - name: Sync nova_api DB"},{"line_number":240,"context_line":"          tags: step5"},{"line_number":241,"context_line":"          command: nova-manage api_db sync"},{"line_number":242,"context_line":"        - name: Start nova_api service (running under httpd)"},{"line_number":243,"context_line":"          tags: step6"},{"line_number":244,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a3905b3_324dea6c","line":242,"in_reply_to":"5a3905b3_a6d36137","updated":"2017-01-20 14:33:02.000000000","message":"Yes this is why I\u0027ve removed step6 from all other services - I\u0027ll rebase this to do the same, then we can let puppet take care of configuring the service and starting it again","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0caf25c244429d71c2cb16f3019fe45dbfa355d7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"          register: nova_api_cell_uuid"},{"line_number":213,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":214,"context_line":"          tags: step5"},{"line_number":215,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":216,"context_line":"        - name: Sync nova_api DB"},{"line_number":217,"context_line":"          tags: step5"},{"line_number":218,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a3905b3_ab3b13d0","line":215,"updated":"2017-01-20 19:46:34.000000000","message":"I think puppet can take over from here","commit_id":"5661d871fdacab0afead675b07c650d654c59245"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0caf25c244429d71c2cb16f3019fe45dbfa355d7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"          command: nova-manage api_db sync"},{"line_number":219,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":220,"context_line":"          tags: step5"},{"line_number":221,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":222,"context_line":"        - name: Start nova_api service (running under httpd)"},{"line_number":223,"context_line":"          tags: step6"},{"line_number":224,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a3905b3_4b78ef8f","line":221,"updated":"2017-01-20 19:46:34.000000000","message":"Puppet should do this once this lands https://review.openstack.org/#/c/421249/","commit_id":"5661d871fdacab0afead675b07c650d654c59245"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f50c81209437f422b34530867024e1c49bc8156e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":208,"context_line":"          tags: step5"},{"line_number":209,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":210,"context_line":"        - name: Sync nova_api DB"},{"line_number":211,"context_line":"          tags: step5"},{"line_number":212,"context_line":"          command: nova-manage api_db sync"},{"line_number":213,"context_line":"        - name: Start nova_api service (running under httpd)"},{"line_number":214,"context_line":"          tags: step6"},{"line_number":215,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_7ec0bd50","line":215,"range":{"start_line":210,"start_character":8,"end_line":215,"end_character":43},"updated":"2017-01-23 17:33:53.000000000","message":"@shardy: we are relying on puppet to start the services now, correct? If so then I should remove these 2 tasks.","commit_id":"0c2e3d77ef5a1d94fb325ab3c239fb1f21f14854"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"8352fe986e31d2c08d55481364edb813b99cd944","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":208,"context_line":"          tags: step5"},{"line_number":209,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":210,"context_line":"        - name: Sync nova_api DB"},{"line_number":211,"context_line":"          tags: step5"},{"line_number":212,"context_line":"          command: nova-manage api_db sync"},{"line_number":213,"context_line":"        - name: Start nova_api service (running under httpd)"},{"line_number":214,"context_line":"          tags: step6"},{"line_number":215,"context_line":"          service: name\u003dhttpd state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_1ac68016","line":215,"range":{"start_line":210,"start_character":8,"end_line":215,"end_character":43},"in_reply_to":"5a3905b3_7ec0bd50","updated":"2017-01-25 11:18:45.000000000","message":"Yes, step6 should be removed from all services now as we expect puppet to start the services - and in this case I think we have to as the nova httpd conf won\u0027t be there until puppet has run (which is one reason I deferred starting things to puppet).","commit_id":"0c2e3d77ef5a1d94fb325ab3c239fb1f21f14854"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        - name: Stop nova_api service (running under httpd)"},{"line_number":177,"context_line":"          tags: step2"},{"line_number":178,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":179,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":180,"context_line":"          tags: step2"},{"line_number":181,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":182,"context_line":"        - name: update nova api"},{"line_number":183,"context_line":"          tags: step2"},{"line_number":184,"context_line":"          yum: name\u003dopenstack-nova-api state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_092c33aa","line":181,"range":{"start_line":179,"start_character":8,"end_line":181,"end_character":56},"updated":"2017-01-27 17:54:59.000000000","message":"(nit) I moved this here but looking at it again I think it would be better to move this to the end of step 2 instead of splitting apache conf tasks","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b94ba48c115283c07396b92fbc31fc8a8fedd5a3","unresolved":false,"context_lines":[{"line_number":188,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":189,"context_line":"        - name: Setup cell_v2 (map cell0)"},{"line_number":190,"context_line":"          tags: step5"},{"line_number":191,"context_line":"          command: nova-manage cell_v2 map_cell0"},{"line_number":192,"context_line":"        - name: Setup cell_v2 (create default cell)"},{"line_number":193,"context_line":"          tags: step5"},{"line_number":194,"context_line":"          # (owalsh) puppet-nova expects the cell name \u0027default\u0027"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_90a45f08","line":191,"updated":"2017-01-31 15:02:38.000000000","message":"So in talking about this change in IRC, it needs to be noted that these commands don\u0027t exist in the newton version of the code. Additionally if we do a yum update in the upgrade, I think we would no longer get the automatic db syncs from puppet when the packages get updated.","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"10b4778ebc12e5ea3d571d4bc11e0dbe6af5d326","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":170,"context_line":"      upgrade_tasks:"},{"line_number":171,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":172,"context_line":"          tags: step0,pre-upgrade"},{"line_number":173,"context_line":"          register: transport_url"},{"line_number":174,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":175,"context_line":"        - name: set nova api transport_url in nova.conf"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_9f6611b9","line":172,"range":{"start_line":172,"start_character":22,"end_line":172,"end_character":33},"updated":"2017-02-01 08:30:02.000000000","message":"new tag? ah i guess it will help distinguish \"step0,validation\" or anything that is just \"step0\" , for example","commit_id":"65c5754e7928a742c08eff600327faba846db074"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"87b62b0e88d197e7ca3e47d621545a3fabde6d8a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":170,"context_line":"      upgrade_tasks:"},{"line_number":171,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":172,"context_line":"          tags: step0,pre-upgrade"},{"line_number":173,"context_line":"          register: transport_url"},{"line_number":174,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":175,"context_line":"        - name: set nova api transport_url in nova.conf"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_f49d770a","line":172,"range":{"start_line":172,"start_character":22,"end_line":172,"end_character":33},"in_reply_to":"3a461143_9f6611b9","updated":"2017-02-01 09:43:24.000000000","message":"Yep exactly.\nI think it\u0027s sane to identify those steps which are some pre-upgrade tasks, and which should run at the very begining (before the cluster is shutting down and before httpd and nova is stopped)","commit_id":"65c5754e7928a742c08eff600327faba846db074"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"10b4778ebc12e5ea3d571d4bc11e0dbe6af5d326","unresolved":false,"context_lines":[{"line_number":168,"context_line":"      metadata_settings:"},{"line_number":169,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":170,"context_line":"      upgrade_tasks:"},{"line_number":171,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":172,"context_line":"          tags: step0,pre-upgrade"},{"line_number":173,"context_line":"          register: transport_url"},{"line_number":174,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":175,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":176,"context_line":"          tags: step0,pre-upgrade"},{"line_number":177,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"},{"line_number":178,"context_line":"        - name: restart nova_api service"},{"line_number":179,"context_line":"          tags: step0,pre-upgrade"},{"line_number":180,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":181,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":182,"context_line":"          tags: step0,pre-upgrade"},{"line_number":183,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_bfd58d1c","line":180,"range":{"start_line":171,"start_character":0,"end_line":180,"end_character":58},"updated":"2017-02-01 08:30:02.000000000","message":"looks like these are the placement API related conf like we have to do for the compute @ https://review.openstack.org/#/c/419886/19/puppet/major_upgrade_steps.j2.yaml - does that mean latest we know we *do* have to do this? (It wasn\u0027t yet clear if we had to carry this config for the computes and to be applied before this file in fact, i.e. before the controller upgrade, or not)","commit_id":"65c5754e7928a742c08eff600327faba846db074"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a72e00f5e1fe123bb7642ab50dd263ce616c6972","unresolved":false,"context_lines":[{"line_number":168,"context_line":"      metadata_settings:"},{"line_number":169,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":170,"context_line":"      upgrade_tasks:"},{"line_number":171,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":172,"context_line":"          tags: step0,pre-upgrade"},{"line_number":173,"context_line":"          register: transport_url"},{"line_number":174,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":175,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":176,"context_line":"          tags: step0,pre-upgrade"},{"line_number":177,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"},{"line_number":178,"context_line":"        - name: restart nova_api service"},{"line_number":179,"context_line":"          tags: step0,pre-upgrade"},{"line_number":180,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":181,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":182,"context_line":"          tags: step0,pre-upgrade"},{"line_number":183,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_01a9d8df","line":180,"range":{"start_line":171,"start_character":0,"end_line":180,"end_character":58},"in_reply_to":"3a461143_bfd58d1c","updated":"2017-02-01 15:21:24.000000000","message":"https://review.openstack.org/#/c/417961/ has merged but there is a gotcha in the upgrade release note https://review.openstack.org/#/c/417961/41/releasenotes/notes/resource_providers_scheduler_db_filters-16b2ed3da00c51dd.yaml@8","commit_id":"65c5754e7928a742c08eff600327faba846db074"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"b390b29a8e07796001f309527c16877dcab456e1","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":201,"context_line":"          tags: step2"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":203,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":204,"context_line":"          tags: step5"},{"line_number":205,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":206,"context_line":"        - name: Setup cell_v2 (map cell0)"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1a430d35_89c4fe92","line":203,"updated":"2017-02-03 13:49:01.000000000","message":"This is to early or too late. The mentioned bug is already addressed in L185, and for the after upgrade step it\u0027s too early, it must happen after the db-syncs.","commit_id":"85c300d455890df5237bf46e3c7ae1878ea30505"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"f8454b523a062b960d5613770077d768cd60910f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"1a430d35_e6f9314f","line":234,"updated":"2017-02-03 13:37:54.000000000","message":"There is still a post-db-sync online_data_migration missing, to make the upgrade complete. The online_data_migration can preferably be run when the system is already up and running again, to minimize downtime, but it could also be run before the service is running (but still after the db-sync), as a intermediate solution.","commit_id":"85c300d455890df5237bf46e3c7ae1878ea30505"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b466c1bcb8536455dccd80fc591c031e78dbd97","unresolved":false,"context_lines":[{"line_number":187,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":188,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":189,"context_line":"          tags: step2"},{"line_number":190,"context_line":"          shell: \"apachectl -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":191,"context_line":"          register: nova_api_apache"},{"line_number":192,"context_line":"          ignore_errors: true"},{"line_number":193,"context_line":"        - name: Stop nova_api service (running under httpd)"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_f55d1e7a","line":190,"range":{"start_line":190,"start_character":18,"end_line":190,"end_character":64},"updated":"2017-02-06 09:10:24.000000000","message":"i just sanity checked this on one of my OSP10 controllers:\n\n[root@overcloud-controller-0 heat-admin]# apachectl -t -D DUMP_VHOSTS\nPassing arguments to httpd using apachectl is no longer supported.\nYou can only start/stop/restart httpd using this script.\nIf you want to pass extra arguments to httpd, edit the\n/etc/sysconfig/httpd config file.\n[root@overcloud-controller-0 heat-admin]# apachectl -t -D DUMP_VHOSTS\nPassing arguments to httpd using apachectl is no longer supported.\nYou can only start/stop/restart httpd using this script.\nIf you want to pass extra arguments to httpd, edit the\n/etc/sysconfig/httpd config file.\n[root@overcloud-controller-0 heat-admin]# \n\n\nare we sure this is doing what we need?","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"372ddccf5691b6c6a022814790b6c243286d66f8","unresolved":false,"context_lines":[{"line_number":187,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":188,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":189,"context_line":"          tags: step2"},{"line_number":190,"context_line":"          shell: \"apachectl -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":191,"context_line":"          register: nova_api_apache"},{"line_number":192,"context_line":"          ignore_errors: true"},{"line_number":193,"context_line":"        - name: Stop nova_api service (running under httpd)"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_98b6cfda","line":190,"range":{"start_line":190,"start_character":18,"end_line":190,"end_character":64},"in_reply_to":"1a430d35_f55d1e7a","updated":"2017-02-06 09:16:21.000000000","message":"I think we should use \u0027httpd -t -D DUMP_VHOSTS\u0027 instead, according to my tests it outputs the correct info.","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"b8a8c0613afd68d8aac8f2d586a9ac0723df9c00","unresolved":false,"context_lines":[{"line_number":187,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":188,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":189,"context_line":"          tags: step2"},{"line_number":190,"context_line":"          shell: \"apachectl -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":191,"context_line":"          register: nova_api_apache"},{"line_number":192,"context_line":"          ignore_errors: true"},{"line_number":193,"context_line":"        - name: Stop nova_api service (running under httpd)"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_785123d8","line":190,"range":{"start_line":190,"start_character":18,"end_line":190,"end_character":64},"in_reply_to":"1a430d35_f55d1e7a","updated":"2017-02-06 09:16:57.000000000","message":"hmm i\u0027ll double check when my env will be ready.","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b466c1bcb8536455dccd80fc591c031e78dbd97","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        - name: update nova api"},{"line_number":197,"context_line":"          tags: step2"},{"line_number":198,"context_line":"          yum: name\u003dopenstack-nova-api state\u003dlatest"},{"line_number":199,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":200,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":201,"context_line":"          tags: step2"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_15dc6ae3","line":199,"range":{"start_line":199,"start_character":17,"end_line":199,"end_character":40},"updated":"2017-02-06 09:10:24.000000000","message":"so if we *are* running under apache (please see the comment above though) then we update nova-api in step2? Why do we need this sorry if I missed the discussion.","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb18d78d908760879de680f3d738ed9f1ca0f24","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    description: Default pool for floating IP addresses"},{"line_number":60,"context_line":"    type: string"},{"line_number":61,"context_line":"  NovaDbSyncTimeout:"},{"line_number":62,"context_line":"    default: 300"},{"line_number":63,"context_line":"    description: Timeout for Nova db sync"},{"line_number":64,"context_line":"    type: number"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1a430d35_f45a7782","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":16},"updated":"2017-02-06 12:26:11.000000000","message":"NB: The default timeout on the undercloud has been increased to 900 in puppet (https://review.openstack.org/428843).\n\nIt\u0027s *probably* ok at 300s for the overcloud upgrade. AFAIK it\u0027s assumed is that overcloud will have faster storage etc... Also upgrade will have fewer migrations to perform.","commit_id":"bea3f18e821f178f64f4a6fba0bfc5ce5a136b91"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb18d78d908760879de680f3d738ed9f1ca0f24","unresolved":false,"context_lines":[{"line_number":190,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":191,"context_line":"          register: nova_api_apache"},{"line_number":192,"context_line":"          ignore_errors: true"},{"line_number":193,"context_line":"        - name: Stop nova_api service (running under httpd)"},{"line_number":194,"context_line":"          tags: step2"},{"line_number":195,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":196,"context_line":"        - name: update nova api"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1a430d35_175b852f","line":193,"range":{"start_line":193,"start_character":10,"end_line":193,"end_character":59},"updated":"2017-02-06 12:26:11.000000000","message":"Shouldn\u0027t this have the when: \"nova_api_apache.rc \u003d\u003d 0\"?","commit_id":"bea3f18e821f178f64f4a6fba0bfc5ce5a136b91"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb18d78d908760879de680f3d738ed9f1ca0f24","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        - name: update nova api"},{"line_number":197,"context_line":"          tags: step2"},{"line_number":198,"context_line":"          yum: name\u003dopenstack-nova-api state\u003dlatest"},{"line_number":199,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":200,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":201,"context_line":"          tags: step2"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1a430d35_774cc970","line":199,"range":{"start_line":199,"start_character":10,"end_line":199,"end_character":41},"updated":"2017-02-06 12:26:11.000000000","message":"Why depend on whether it\u0027s running under apache?","commit_id":"bea3f18e821f178f64f4a6fba0bfc5ce5a136b91"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb18d78d908760879de680f3d738ed9f1ca0f24","unresolved":false,"context_lines":[{"line_number":199,"context_line":"          when: \"nova_api_apache.rc \u003d\u003d 0\""},{"line_number":200,"context_line":"        - name: Stop and disable nova_api service (pre-upgrade not under httpd)"},{"line_number":201,"context_line":"          tags: step2"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":203,"context_line":"        - name: Setup cell_v2 (map cell0)"},{"line_number":204,"context_line":"          tags: step5"},{"line_number":205,"context_line":"          command: nova-manage cell_v2 map_cell0"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1a430d35_f7a51904","line":202,"range":{"start_line":202,"start_character":57,"end_line":202,"end_character":67},"updated":"2017-02-06 12:26:11.000000000","message":"should this be stopped but enabled, now the we are reverting the move to apache/WSGI?","commit_id":"bea3f18e821f178f64f4a6fba0bfc5ce5a136b91"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c3f49bfb5f045fc10110e34ba23db228296621da","unresolved":false,"context_lines":[{"line_number":187,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":188,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":189,"context_line":"          tags: step2"},{"line_number":190,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":191,"context_line":"          register: nova_api_apache"},{"line_number":192,"context_line":"          ignore_errors: true"},{"line_number":193,"context_line":"        - name: Stop nova_api service (running under httpd)"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_50bdeab5","line":190,"range":{"start_line":190,"start_character":18,"end_line":190,"end_character":23},"updated":"2017-02-07 08:58:25.000000000","message":"thanks this now seems to work fine on my osp10 env","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3ed571999ba48058831b4a1f778d0c466b660f5c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"          poll: 10"},{"line_number":218,"context_line":"        - name: Setup cell_v2 (migrate hosts)"},{"line_number":219,"context_line":"          tags: step5"},{"line_number":220,"context_line":"          command: nova-manage cell_v2 map_cell_and_hosts"},{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_3fc5a65a","line":220,"range":{"start_line":220,"start_character":39,"end_line":220,"end_character":57},"updated":"2017-02-06 17:59:22.000000000","message":"Just noticed that we have to pass the cell name here. I\u0027ll push an update.","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c3f49bfb5f045fc10110e34ba23db228296621da","unresolved":false,"context_lines":[{"line_number":217,"context_line":"          poll: 10"},{"line_number":218,"context_line":"        - name: Setup cell_v2 (migrate hosts)"},{"line_number":219,"context_line":"          tags: step5"},{"line_number":220,"context_line":"          command: nova-manage cell_v2 map_cell_and_hosts"},{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_d0f8fac5","line":220,"range":{"start_line":220,"start_character":39,"end_line":220,"end_character":57},"in_reply_to":"1a430d35_3fc5a65a","updated":"2017-02-07 08:58:25.000000000","message":"thanks owalsh. \n\nyou may recall i had issues with my undercloud because of this. My original workaround was no longer working (manual creation of the nova_api_cell0 database). I tried it fresh but it failed again.\n\nSO I think the actual workaround will be to do what you guys are doing here... i.e. still manually create the database do the create_cell bit above for puppet-nova which wants \u0027default\u0027","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"02c62515f0b97c3ef1c04577b7a00d0f374cecf4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"          poll: 10"},{"line_number":218,"context_line":"        - name: Setup cell_v2 (migrate hosts)"},{"line_number":219,"context_line":"          tags: step5"},{"line_number":220,"context_line":"          command: nova-manage cell_v2 map_cell_and_hosts"},{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_c9fa1075","line":220,"range":{"start_line":220,"start_character":39,"end_line":220,"end_character":57},"in_reply_to":"1a430d35_690cbced","updated":"2017-02-07 11:58:11.000000000","message":"Yes, and `sudo nova-status upgrade check` should pass afterward","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4ba8bb3211d309da240beaff4805a8e738723777","unresolved":false,"context_lines":[{"line_number":217,"context_line":"          poll: 10"},{"line_number":218,"context_line":"        - name: Setup cell_v2 (migrate hosts)"},{"line_number":219,"context_line":"          tags: step5"},{"line_number":220,"context_line":"          command: nova-manage cell_v2 map_cell_and_hosts"},{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_6e8f622a","line":220,"range":{"start_line":220,"start_character":39,"end_line":220,"end_character":57},"in_reply_to":"1a430d35_d0f8fac5","updated":"2017-02-07 11:33:09.000000000","message":"Sorry I was mistaken (far too much context switching). Don\u0027t need to pass the call name here. The command only needs to be passed a cell name if the cell doesn\u0027t already exist (it will create it).","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d9e2359f80b66fe9da690c6be502a42c547f7c25","unresolved":false,"context_lines":[{"line_number":217,"context_line":"          poll: 10"},{"line_number":218,"context_line":"        - name: Setup cell_v2 (migrate hosts)"},{"line_number":219,"context_line":"          tags: step5"},{"line_number":220,"context_line":"          command: nova-manage cell_v2 map_cell_and_hosts"},{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_690cbced","line":220,"range":{"start_line":220,"start_character":39,"end_line":220,"end_character":57},"in_reply_to":"1a430d35_d0f8fac5","updated":"2017-02-07 11:52:29.000000000","message":"update, FYI/fwiw the commands I extracted from here got me to a clean undercloud upgrade:\n\nsudo nova-manage cell_v2 map_cell0\nsudo nova-manage cell_v2 create_cell --name\u003d\u0027default\u0027\nsudo nova-manage db sync\nsudo nova-manage cell_v2 map_cell_and_hosts\ncell_uuid\u003d$(sudo nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027)\nsudo nova-manage cell_v2 map_instances --cell_uuid $cell_uuid\nsudo nova-manage api_db sync","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"9ec110fe0006b908c9ef53a03d3cb4b5a00a47d3","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"},{"line_number":224,"context_line":"          register: nova_api_cell_uuid"},{"line_number":225,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":226,"context_line":"          tags: step5"},{"line_number":227,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_94f00693","line":224,"updated":"2017-02-07 20:53:32.000000000","message":"On my environment(3 controllers) this registers 3 items which makes the next task fail:\n\nnova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027\n09e24242-3c59-44c7-a63e-5e9a980cfe6b\n942b906e-9cce-461d-8cf0-3a9b5fb25ba0\n434efad7-72b7-4d61-b230-1a11b4f25f95","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ab8f7b8ce9c0f28a3d3242bd155d4abd7461810b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"},{"line_number":224,"context_line":"          register: nova_api_cell_uuid"},{"line_number":225,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":226,"context_line":"          tags: step5"},{"line_number":227,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_a8d4c61f","line":224,"in_reply_to":"1a430d35_94f00693","updated":"2017-02-07 21:16:08.000000000","message":"https://review.openstack.org/430183 should resolve this","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"6774dab2a1b08e0889aa1bad806a40fe7faf143c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        - name: Setup cell_v2 (get cell uuid)"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          shell: nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027"},{"line_number":224,"context_line":"          register: nova_api_cell_uuid"},{"line_number":225,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":226,"context_line":"          tags: step5"},{"line_number":227,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_4ea8b8db","line":224,"in_reply_to":"1a430d35_a8d4c61f","updated":"2017-02-08 10:04:02.000000000","message":"Will need to update the mysql uri in nova.conf for upgrade though, I\u0027ll push a fix.","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"9ec110fe0006b908c9ef53a03d3cb4b5a00a47d3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"          register: nova_api_cell_uuid"},{"line_number":225,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":226,"context_line":"          tags: step5"},{"line_number":227,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":228,"context_line":"        - name: Sync nova_api DB"},{"line_number":229,"context_line":"          tags: step5"},{"line_number":230,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_74c9da58","line":227,"updated":"2017-02-07 20:53:32.000000000","message":"This failed on my environment with 3 controllers:\n\nTASK [Setup cell_v2 (migrate instances)] ***************************************\nfatal: [localhost]: FAILED! \u003d\u003e {\"changed\": true, \"cmd\": [\"nova-manage\", \"cell_v2\", \"map_instances\", \"--cell_uuid\", \"09e24242-3c59-44c7-a63e-5e9a980cfe6b\", \"942b906e-9cce-461d-8cf0-3a9b5fb25ba0\", \"434efad7-72b7-4d61-b230-1a11b4f25f95\"], \"delta\": \"0:00:04.438980\", \"end\": \"2017-02-07 20:36:20.878633\", \"failed\": true, \"rc\": 1, \"start\": \"2017-02-07 20:36:16.439653\", \"stderr\": \"\", \"stdout\": \"An error has occurred:\\nTraceback (most recent call last):\\n  File \\\"/usr/lib/python2.7/site-packages/nova/cmd/manage.py\\\", line 1587, in main\\n    ret \u003d fn(*fn_args, **fn_kwargs)\\nTypeError: map_instances() got multiple values for keyword argument \u0027cell_uuid\u0027\", \"stdout_lines\": [\"An error has occurred:\", \"Traceback (most recent call last):\", \"  File \\\"/usr/lib/python2.7/site-packages/nova/cmd/manage.py\\\", line 1587, in main\", \"    ret \u003d fn(*fn_args, **fn_kwargs)\", \"TypeError: map_instances() got multiple values for keyword argument \u0027cell_uuid\u0027\"], \"warnings\": []}","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"5659fb0f6fbe1d39bb8a758c0142fd303668717c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"          tags: step5"},{"line_number":219,"context_line":"          # (owalsh) puppet-nova expects the cell name \u0027default\u0027"},{"line_number":220,"context_line":"          # (owalsh) pass the db uri explicitly to avoid https://bugs.launchpad.net/tripleo/+bug/1662344"},{"line_number":221,"context_line":"          command: nova-manage cell_v2 create_cell --name\u003d\u0027default\u0027 --database_connection\u003d$(hiera nova::database_connection)"},{"line_number":222,"context_line":"          register: nova_api_create_cell"},{"line_number":223,"context_line":"          failed_when: nova_api_create_cell.rc not in [0,2]"},{"line_number":224,"context_line":"          changed_when: nova_api_create_cell.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1a430d35_37dc7c45","line":221,"updated":"2017-02-08 21:43:33.000000000","message":"the variable won\u0027t be interpreted by the \"command\" module.\nWe need to use shell module in this case.\nIm pushing a new change.","commit_id":"985c26bec5a02bb2e0ac69e6510058c40f627d27"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a7d022dd680a18b1fd7785fa8be0b808fbd22a9a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":191,"context_line":"          tags: step0,pre-upgrade"},{"line_number":192,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"},{"line_number":193,"context_line":"        - name: restart nova_api service"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":196,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa31d9ce_cde7d63e","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":40},"updated":"2017-02-10 15:06:18.000000000","message":"Can see a reason for this restart, and it will definitely fail if we have already upgraded pkgs (e.g if upgrade fails and we re-run)","commit_id":"d7e9b228b62e260b86fee222b7a97569dd4f9883"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"c939e8f9a88a616bb6eebd18dd0227520de3400a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":191,"context_line":"          tags: step0,pre-upgrade"},{"line_number":192,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"},{"line_number":193,"context_line":"        - name: restart nova_api service"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":196,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa31d9ce_cdf2769a","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":40},"in_reply_to":"fa31d9ce_6d5d0ae9","updated":"2017-02-10 15:16:22.000000000","message":"the reason of restart the nova-api is to take in account the settings of the transport_url above ^\nlets do it in another way, just ignore the failure if happen, but since it\u0027s a pre-upgrade, its should not be re-run twice.","commit_id":"d7e9b228b62e260b86fee222b7a97569dd4f9883"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"366609da2146e1bb40d9839531fe1143e0c6d6f0","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":191,"context_line":"          tags: step0,pre-upgrade"},{"line_number":192,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"},{"line_number":193,"context_line":"        - name: restart nova_api service"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":196,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa31d9ce_6d5d0ae9","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":40},"in_reply_to":"fa31d9ce_cde7d63e","updated":"2017-02-10 15:08:29.000000000","message":"s/Can/Can\u0027t/","commit_id":"d7e9b228b62e260b86fee222b7a97569dd4f9883"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d48659893bdc55c328c93ae02753f2cfa2f8f614","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":187,"context_line":"          tags: step0,pre-upgrade"},{"line_number":188,"context_line":"          register: transport_url"},{"line_number":189,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":190,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":191,"context_line":"          tags: step0,pre-upgrade"},{"line_number":192,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"fa31d9ce_46266369","line":189,"updated":"2017-02-10 16:18:15.000000000","message":"I don\u0027t think this matches the transport url puppet would use. In theory we should be collecting all the rabbitmq ips and create one transport_url that contains all of them.  https://review.openstack.org/#/c/409911/","commit_id":"2889dbfa8d1d694d9920353d92f152288d2d0483"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"76ba47b5858f95efd7c34cdf5c6cea9ec00a1e68","unresolved":false,"context_lines":[{"line_number":225,"context_line":"          changed_when: nova_api_create_cell.rc \u003d\u003d 0"},{"line_number":226,"context_line":"        - name: Setup cell_v2 (sync nova/cell DB)"},{"line_number":227,"context_line":"          tags: step5"},{"line_number":228,"context_line":"          command: nova-manage db sync"},{"line_number":229,"context_line":"          async: {get_param: NovaDbSyncTimeout}"},{"line_number":230,"context_line":"          poll: 10"},{"line_number":231,"context_line":"        - name: Setup cell_v2 (migrate hosts)"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"fa31d9ce_a168e9bb","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":38},"updated":"2017-02-10 16:33:40.000000000","message":"from mcornea via irc, don\u0027t we want to guard these for bootstrap node only?","commit_id":"2889dbfa8d1d694d9920353d92f152288d2d0483"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"165a258d3dcb1434f8761b418c3ba9fea6a31a28","unresolved":false,"context_lines":[{"line_number":189,"context_line":"          register: bootstrap_node"},{"line_number":190,"context_line":"        - name: set is_bootstrap_node fact"},{"line_number":191,"context_line":"          tags: step0"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          register: transport_url"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_2bc1fa2e","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":83},"updated":"2017-02-13 13:07:09.000000000","message":"are we sure this is working OK ? latest run i have \n\nFeb 13 12:59:50 overcloud-controller-0.localdomain os-collect-config[174548]: [2017-02-13 12:59:50,487] (heat-config) [INFO] {\"deploy_stdout\": \"\\nPLAY [localhost] ***************************************************************\\n\\nTASK [setup] *******************************************************************\\nok: [localhost]\\n\\nTASK [Sync keystone DB] ********************************************************\\nchanged: [localhost]\\n\\nTASK [Sync glance_api DB] ******************************************************\\nchanged: [localhost]\\n\\nTASK [Sync heat_engine DB] *****************************************************\\nchanged: [localhost]\\n\\nTASK [Setup cell_v2 (map cell0)] ***********************************************\\nfatal: [localhost]: FAILED! \u003d\u003e {\\\"failed\\\": true, \\\"msg\\\": \\\"The conditional check \u0027is_bootstrap_node\u0027 failed. The error was: error while evaluating conditional (is_bootstrap_node): \u0027is_bootstrap_node\u0027 is undefined\\\"}\\n\\tto retry, use: --limit @/var/lib/heat-config/heat-config-ansible/24ec662d-774d-4a18-b01c-75a4eede2497_playbook.retry\\n\\nPLAY RECAP *********************************************************************\\nlocalhost                  : ok\u003d4    changed\u003d3    unreachable\u003d0    failed\u003d1   \\n\\n\", \"deploy_stderr\": \"\", \"deploy_status_code\": 2}\n\nhttp://paste.openstack.org/raw/598645/","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c429c795a2b4051e6cb374988636dd27ba38643e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"          register: bootstrap_node"},{"line_number":190,"context_line":"        - name: set is_bootstrap_node fact"},{"line_number":191,"context_line":"          tags: step0"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          register: transport_url"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_ee5a904f","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":83},"in_reply_to":"fa31d9ce_2bc1fa2e","updated":"2017-02-13 13:30:41.000000000","message":"update: yeah it appears it works ok for step0 but it fails on the step5 checks see comment below @ https://review.openstack.org/#/c/405241/36/puppet/services/nova-api.yaml@225","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37d48e0d1d3ba59653de8a7be008ea937be9b6d4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          register: transport_url"},{"line_number":196,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":197,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":198,"context_line":"          tags: step0,pre-upgrade"},{"line_number":199,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_4650fc5e","line":196,"updated":"2017-02-12 20:58:02.000000000","message":"This transport url needs to match what the puppet will use.  See my comment from patchset 34. Here\u0027s how we do it in puppet https://review.openstack.org/#/c/409911/","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7028800eb070d9a1eb08e2314ba4b05296fbdd9f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          register: transport_url"},{"line_number":196,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":197,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":198,"context_line":"          tags: step0,pre-upgrade"},{"line_number":199,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_4879d7f5","line":196,"in_reply_to":"fa31d9ce_4650fc5e","updated":"2017-02-13 12:00:30.000000000","message":"I can do this with ansible/jinja2 but it\u0027s fugly: http://paste.openstack.org/show/598638/","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"70f63e7303c97a62f6f43d7977ed0f4218c3b0e8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        - name: restart nova_api service"},{"line_number":201,"context_line":"          tags: step0,pre-upgrade"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":203,"context_line":"          ignore_errors: true"},{"line_number":204,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":205,"context_line":"          tags: step0,pre-upgrade"},{"line_number":206,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_fdab3a87","line":203,"range":{"start_line":203,"start_character":10,"end_line":203,"end_character":23},"updated":"2017-02-13 06:53:16.000000000","message":"cool so i assume this will then make it \"safe\" for re-runs (we were discussing this with owalsh briefly end of last week)","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7028800eb070d9a1eb08e2314ba4b05296fbdd9f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        - name: restart nova_api service"},{"line_number":201,"context_line":"          tags: step0,pre-upgrade"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":203,"context_line":"          ignore_errors: true"},{"line_number":204,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":205,"context_line":"          tags: step0,pre-upgrade"},{"line_number":206,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_c8e94782","line":203,"range":{"start_line":203,"start_character":10,"end_line":203,"end_character":23},"in_reply_to":"fa31d9ce_fdab3a87","updated":"2017-02-13 12:00:30.000000000","message":"I still don\u0027t understand why we restart. AFAIK we just need the updated conf in place for the nova-manage commands.","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6a3b49fafc1597ecd0f0542abc03589b86912ab8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"          tags: step0,pre-upgrade"},{"line_number":206,"context_line":"          when: is_bootstrap_node"},{"line_number":207,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":208,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":209,"context_line":"          tags: step2"},{"line_number":210,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":211,"context_line":"          register: nova_api_apache"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_95b5a7ef","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":70},"updated":"2017-02-13 12:22:13.000000000","message":"So I think we can also remove this one because of https://review.openstack.org/#/c/428807/","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cb35ed3cbe5983bb7b8498b0f6343a2e6fcb53ae","unresolved":false,"context_lines":[{"line_number":222,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":223,"context_line":"        - name: Setup cell_v2 (map cell0)"},{"line_number":224,"context_line":"          tags: step5"},{"line_number":225,"context_line":"          when: is_bootstrap_node"},{"line_number":226,"context_line":"          command: nova-manage cell_v2 map_cell0"},{"line_number":227,"context_line":"        - name: Setup cell_v2 (create default cell)"},{"line_number":228,"context_line":"          tags: step5"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_6b35b2f5","line":225,"range":{"start_line":225,"start_character":16,"end_line":225,"end_character":33},"updated":"2017-02-13 13:15:22.000000000","message":"i *think* we can\u0027t use this here because it was only defined for step0 ?\n\ni.e. it is applied like \n\nansible-playbook -i localhost, --module-path /usr/share/ansible-modules --skip-tags validation,pre-upgrade --tags step5 /var/lib/heat-config/heat-config-ansible/6a20d881\n\nI wonder if that is why i am seeing the errors about is_bootstrap_node here being undefined.. .i.e. it was defined but earlier when step0 was run? the error is like http://paste.openstack.org/raw/598645/","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d84ad7f2da2eda7562f79459f70406947c606e7e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":223,"context_line":"        - name: Setup cell_v2 (map cell0)"},{"line_number":224,"context_line":"          tags: step5"},{"line_number":225,"context_line":"          when: is_bootstrap_node"},{"line_number":226,"context_line":"          command: nova-manage cell_v2 map_cell0"},{"line_number":227,"context_line":"        - name: Setup cell_v2 (create default cell)"},{"line_number":228,"context_line":"          tags: step5"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_8e42f40e","line":225,"range":{"start_line":225,"start_character":16,"end_line":225,"end_character":33},"in_reply_to":"fa31d9ce_6b35b2f5","updated":"2017-02-13 13:24:02.000000000","message":"Yea, that\u0027s what I figured too.","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"70f63e7303c97a62f6f43d7977ed0f4218c3b0e8","unresolved":false,"context_lines":[{"line_number":252,"context_line":"          tags: step5"},{"line_number":253,"context_line":"          when: is_bootstrap_node"},{"line_number":254,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":255,"context_line":"        - name: Sync nova_api DB"},{"line_number":256,"context_line":"          tags: step5"},{"line_number":257,"context_line":"          command: nova-manage api_db sync"},{"line_number":258,"context_line":"        - name: Online data migration for nova"},{"line_number":259,"context_line":"          tags: step5"},{"line_number":260,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_5d78c62b","line":257,"range":{"start_line":255,"start_character":0,"end_line":257,"end_character":42},"updated":"2017-02-13 06:53:16.000000000","message":"this one doesn\u0027t need is_bootstrap_node?","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7028800eb070d9a1eb08e2314ba4b05296fbdd9f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"          tags: step5"},{"line_number":253,"context_line":"          when: is_bootstrap_node"},{"line_number":254,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":255,"context_line":"        - name: Sync nova_api DB"},{"line_number":256,"context_line":"          tags: step5"},{"line_number":257,"context_line":"          command: nova-manage api_db sync"},{"line_number":258,"context_line":"        - name: Online data migration for nova"},{"line_number":259,"context_line":"          tags: step5"},{"line_number":260,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_088b5fc4","line":257,"range":{"start_line":255,"start_character":0,"end_line":257,"end_character":42},"in_reply_to":"fa31d9ce_5d78c62b","updated":"2017-02-13 12:00:30.000000000","message":"oops, missed one","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8735b0958c8b511f540f38d8fe830ebb291b2670","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      #   get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":185,"context_line":"      upgrade_tasks:"},{"line_number":186,"context_line":"        - name: get bootstrap nodeid"},{"line_number":187,"context_line":"          tags: step0,common"},{"line_number":188,"context_line":"          command: hiera bootstrap_nodeid"},{"line_number":189,"context_line":"          register: bootstrap_node"},{"line_number":190,"context_line":"        - name: set is_bootstrap_node fact"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_a9ffb265","line":187,"range":{"start_line":187,"start_character":22,"end_line":187,"end_character":28},"updated":"2017-02-13 13:41:51.000000000","message":"cool so this makes sense as one easy way we can include this on all the steps (will test on next run ... current one is ongoing where i just duplicated this into step5 for testing/confirmation )","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8735b0958c8b511f540f38d8fe830ebb291b2670","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          register: transport_url"},{"line_number":196,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":197,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":198,"context_line":"          tags: step0,pre-upgrade"},{"line_number":199,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_69613a39","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":125},"updated":"2017-02-13 13:41:51.000000000","message":"see comments from Alex on v36 (so isn\u0027t lost) thanks","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"d8d8ebadbb292676b8474210fae6fd374332579e","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":194,"context_line":"          tags: step0,pre-upgrade"},{"line_number":195,"context_line":"          register: transport_url"},{"line_number":196,"context_line":"          shell: echo rabbit://$(hiera rabbitmq::default_user):$(hiera rabbitmq::default_pass)@$(hiera rabbitmq::interface)//"},{"line_number":197,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":198,"context_line":"          tags: step0,pre-upgrade"},{"line_number":199,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_ff479c1a","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":125},"in_reply_to":"fa31d9ce_69613a39","updated":"2017-02-13 14:09:36.000000000","message":"yes, i\u0027ll addressed it in a new pass","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"d8d8ebadbb292676b8474210fae6fd374332579e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        - name: restart nova_api service"},{"line_number":201,"context_line":"          tags: step0,pre-upgrade"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":203,"context_line":"          ignore_errors: true"},{"line_number":204,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":205,"context_line":"          tags: step0,pre-upgrade"},{"line_number":206,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_df21f84e","line":203,"updated":"2017-02-13 14:09:36.000000000","message":"i think we could remove therestart, i\u0027m testing a new change","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8735b0958c8b511f540f38d8fe830ebb291b2670","unresolved":false,"context_lines":[{"line_number":205,"context_line":"          tags: step0,pre-upgrade"},{"line_number":206,"context_line":"          when: is_bootstrap_node"},{"line_number":207,"context_line":"          command: nova-manage db online_data_migrations"},{"line_number":208,"context_line":"        - name: check for nova_api running under apache (post upgrade)"},{"line_number":209,"context_line":"          tags: step2"},{"line_number":210,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q nova_api\""},{"line_number":211,"context_line":"          register: nova_api_apache"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_49ef16b0","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":70},"updated":"2017-02-13 13:41:51.000000000","message":"So I think we can also remove this one because of https://review.openstack.org/#/c/428807/","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8735b0958c8b511f540f38d8fe830ebb291b2670","unresolved":false,"context_lines":[{"line_number":254,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":255,"context_line":"        - name: Sync nova_api DB"},{"line_number":256,"context_line":"          tags: step5"},{"line_number":257,"context_line":"          command: nova-manage api_db sync"},{"line_number":258,"context_line":"        - name: Online data migration for nova"},{"line_number":259,"context_line":"          tags: step5"},{"line_number":260,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_096a7e1a","line":257,"range":{"start_line":257,"start_character":0,"end_line":257,"end_character":42},"updated":"2017-02-13 13:41:51.000000000","message":"(copy pasting from previous version so it isn\u0027t forgotten)\n\nthis one doesn\u0027t need is_bootstrap_node?","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"d8d8ebadbb292676b8474210fae6fd374332579e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":255,"context_line":"        - name: Sync nova_api DB"},{"line_number":256,"context_line":"          tags: step5"},{"line_number":257,"context_line":"          command: nova-manage api_db sync"},{"line_number":258,"context_line":"        - name: Online data migration for nova"},{"line_number":259,"context_line":"          tags: step5"},{"line_number":260,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa31d9ce_9fdea03d","line":257,"range":{"start_line":257,"start_character":0,"end_line":257,"end_character":42},"in_reply_to":"fa31d9ce_096a7e1a","updated":"2017-02-13 14:09:36.000000000","message":"i guess so","commit_id":"0d306be450ed2f1183655ccda64dd539a56659d1"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"085ca61e66b40b5b9b842bbe58a32fa70800f1e3","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbit://{%for host in rmq_node_names.stdout|from_json%}:{{nova_rmq_user.stdout}}:{{nova_rmq_pass.stdout}}@{{host}}{%endfor%}:{{nova_rmq_port}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":219,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":220,"context_line":"          tags: step0,pre-upgrade"},{"line_number":221,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"fa31d9ce_b0dc6ee5","line":218,"range":{"start_line":218,"start_character":142,"end_line":218,"end_character":160},"updated":"2017-02-13 15:46:20.000000000","message":"should the port be within the for loop?","commit_id":"cc78318c8113c51fd253924b6b13d67405c79bc4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c0bc93f57f17c29776e3798d4e3c1739295c877b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbit://{%for host in rmq_node_names.stdout|from_json%}:{{nova_rmq_user.stdout}}:{{nova_rmq_pass.stdout}}@{{host}}{%endfor%}:{{nova_rmq_port}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":219,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":220,"context_line":"          tags: step0,pre-upgrade"},{"line_number":221,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"fa31d9ce_56788a8f","line":218,"range":{"start_line":218,"start_character":142,"end_line":218,"end_character":160},"in_reply_to":"fa31d9ce_6bb76786","updated":"2017-02-13 16:09:47.000000000","message":"Don\u0027t think so, we are passing it through the from_json jinja2 filter","commit_id":"cc78318c8113c51fd253924b6b13d67405c79bc4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8715566fd7903db897a39485602d3554dd937bcc","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbit://{%for host in rmq_node_names.stdout|from_json%}:{{nova_rmq_user.stdout}}:{{nova_rmq_pass.stdout}}@{{host}}{%endfor%}:{{nova_rmq_port}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":219,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":220,"context_line":"          tags: step0,pre-upgrade"},{"line_number":221,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"fa31d9ce_eb91979a","line":218,"range":{"start_line":218,"start_character":142,"end_line":218,"end_character":160},"in_reply_to":"fa31d9ce_b0dc6ee5","updated":"2017-02-13 15:53:28.000000000","message":"AFAICT this will also have a leading : and isn\u0027t joining the hosts using ,","commit_id":"cc78318c8113c51fd253924b6b13d67405c79bc4"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"aae4b5a9e8aeadfebfaf5c178d81478ecafa45cb","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbit://{%for host in rmq_node_names.stdout|from_json%}:{{nova_rmq_user.stdout}}:{{nova_rmq_pass.stdout}}@{{host}}{%endfor%}:{{nova_rmq_port}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":219,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":220,"context_line":"          tags: step0,pre-upgrade"},{"line_number":221,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"fa31d9ce_6bb76786","line":218,"range":{"start_line":218,"start_character":142,"end_line":218,"end_character":160},"in_reply_to":"fa31d9ce_eb91979a","updated":"2017-02-13 16:05:20.000000000","message":"yes it should have the port (fixed in the next patchset)\nFor the ,\nit\u0027s fine because in hiera we have:\n    \"rabbitmq_node_names\": [\n        \"overcloud-controller-0.internalapi.localdomain\",\n        \"overcloud-controller-1.internalapi.localdomain\",\n        \"overcloud-controller-2.internalapi.localdomain\"","commit_id":"cc78318c8113c51fd253924b6b13d67405c79bc4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ad6b9f385e759b45b25c8127ed88e46fbad67e0","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbit://{%for host in rmq_node_names.stdout|from_json%}:{{nova_rmq_user.stdout}}:{{nova_rmq_pass.stdout}}@{{host}}:{{nova_rmq_port}}{%endfor%}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":219,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":220,"context_line":"          tags: step0,pre-upgrade"},{"line_number":221,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"fa31d9ce_76a66e11","line":218,"range":{"start_line":218,"start_character":126,"end_line":218,"end_character":130},"updated":"2017-02-13 16:09:47.000000000","message":"This should be ok except for the case if this is ipv6 addresses they need to be bracketed.  This is one of the things the puppet function does automagically, https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/parser/functions/os_transport_url.rb#L117","commit_id":"df9100b71e57797f3a6304f4c4cb3d3ab9bec044"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"fdde9d29a79687d439c464383bcc03e4c794fd16","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbit://{%for host in rmq_node_names.stdout|from_json%}:{{nova_rmq_user.stdout}}:{{nova_rmq_pass.stdout}}@{{host}}:{{nova_rmq_port}}{%endfor%}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":219,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":220,"context_line":"          tags: step0,pre-upgrade"},{"line_number":221,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"fa31d9ce_f656ded0","line":218,"range":{"start_line":218,"start_character":126,"end_line":218,"end_character":130},"in_reply_to":"fa31d9ce_76a66e11","updated":"2017-02-13 16:12:08.000000000","message":"little nits, im testing localy.\nThanks Alex, we also need to figure out the ipv6 case then","commit_id":"df9100b71e57797f3a6304f4c4cb3d3ab9bec044"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5234d62a4f820d84b1fb718c38109a357d836c74","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_eae07598","line":218,"range":{"start_line":218,"start_character":17,"end_line":218,"end_character":25},"updated":"2017-02-14 18:13:06.000000000","message":"it\u0027s rabbit not rabbitmq. See https://github.com/openstack/puppet-nova/blob/master/spec/acceptance/nova_wsgi_apache_spec.rb#L35","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3a93845fbb43f72ba8d68a6f132fdb4ab89966d4","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_42a24b9a","line":218,"range":{"start_line":218,"start_character":17,"end_line":218,"end_character":25},"updated":"2017-02-14 17:13:32.000000000","message":"so are you guys sure about this? it refuses to start nova-api for me with trace like \nFeb 14 12:04:19 overcloud-controller-1 nova-api: File \"/usr/lib/python2.7/site-packages/nova/rpc.py\", line 234, in create_transport\nFeb 14 12:04:19 overcloud-controller-1 nova-api: aliases\u003dTRANSPORT_ALIASES)\nFeb 14 12:04:19 overcloud-controller-1 nova-api: File \"/usr/lib/python2.7/site-packages/oslo_messaging/transport.py\", line 194, in get_transport\nFeb 14 12:04:19 overcloud-controller-1 nova-api: raise DriverLoadFailure(url.transport, ex)\nFeb 14 12:04:19 overcloud-controller-1 nova-api: oslo_messaging.transport.DriverLoadFailure: Failed to load transport driver \"rabbitmq\": No \u0027oslo.messaging.drivers\u0027 driver found, looking for \u0027rabbitmq\u0027\n\n\nIn nova.conf it is set like: \n\n[root@overcloud-controller-2 heat-admin]# grep transport_url /etc/nova/nova.conf\ntransport_url \u003d rabbitmq://guest:BpJfCcphPwRaAGzVYaRpVyXhk@overcloud-controller-0.internalapi.localdomain:5672,guest:BpJfCcphPwRaAGzVYaRpVyXhk@overcloud-controller-1.internalapi.localdomain:5672,guest:BpJfCcphPwRaAGzVYaRpVyXhk@overcloud-controller-2.internalapi.localdomain:5672?ssl\u003d0\n\n\nI tried adding \"\" didnt help. I tried like this\ntransport_url \u003d rabbit://guest:BpJfCcphPwRaAGzVYaRpVyXhk@overcloud-controller-0.internalapi.localdomain:5672,rabbit://guest:BpJfCcphPwRaAGzVYaRpVyXhk@overcloud-controller-1.internalapi.localdomain:5672,rabbit://guest:BpJfCcphPwRaAGzVYaRpVyXhk@overcloud-controller-2.internalapi.localdomain:5672?ssl\u003d0\n\nand at least nova-api is started but not sure if setting like that is completely wrong/doesn\u0027t make sense? \n\nme eod so will pickup tomorrow.","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7ea6c4d9c839a895ddef647a1ab6039f52f6bc4b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          tags: step0,common"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        - name: get rabbitmq node names"},{"line_number":195,"context_line":"          tags: step0,pre-upgrade"},{"line_number":196,"context_line":"          command: hiera rabbitmq_node_names"},{"line_number":197,"context_line":"          register: rmq_node_names"},{"line_number":198,"context_line":"        - name: get_rabbitmq_user"},{"line_number":199,"context_line":"          tags: step0,pre-upgrade"},{"line_number":200,"context_line":"          command: hiera nova::rabbit_userid"},{"line_number":201,"context_line":"          register: nova_rmq_user"},{"line_number":202,"context_line":"        - name: get rabbitmq password"},{"line_number":203,"context_line":"          tags: step0,pre-upgrade"},{"line_number":204,"context_line":"          command: hiera nova::rabbit_password"},{"line_number":205,"context_line":"          register: nova_rmq_pass"},{"line_number":206,"context_line":"        - name: get rabbitmq port"},{"line_number":207,"context_line":"          tags: step0,pre-upgrade"},{"line_number":208,"context_line":"          command: hiera nova::rabbit_port"},{"line_number":209,"context_line":"          register: nova_rmq_port"},{"line_number":210,"context_line":"        - name: get rabbitmq use ssl"},{"line_number":211,"context_line":"          tags: step0,pre-upgrade"},{"line_number":212,"context_line":"          command: hiera nova::rabbit_use_ssl"},{"line_number":213,"context_line":"          register: nova_rmq_ssl"},{"line_number":214,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step0,pre-upgrade"},{"line_number":223,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_562db5a6","line":220,"range":{"start_line":194,"start_character":0,"end_line":220,"end_character":91},"updated":"2017-02-14 16:15:20.000000000","message":"how about something like:\n\n\n      - name: create puppet manifest\n        copy:\n          dest: /tmp/test.pp\n          content: \u003e\n            $transport_url \u003d os_transport_url({\n              \u0027transport\u0027 \u003d\u003e hiera(\u0027messaging_service_name\u0027, \u0027rabbit\u0027),\n              \u0027hosts\u0027     \u003d\u003e any2array(hiera(\u0027rabbitmq_node_names\u0027, undef)),\n              \u0027port\u0027      \u003d\u003e sprintf(\u0027%s\u0027,hiera(\u0027nova::rabbit_port\u0027, \u00275672\u0027) ),\n              \u0027username\u0027  \u003d\u003e hiera(\u0027nova::rabbit_userid\u0027, \u0027guest\u0027),\n              \u0027password\u0027  \u003d\u003e hiera(\u0027nova::rabbit_password\u0027),\n              \u0027ssl\u0027       \u003d\u003e sprintf(\u0027%s\u0027, bool2num(str2bool(hiera(\u0027nova::rabbit_use_ssl\u0027, \u00270\u0027))))\n            })\n            oslo::messaging::default { \u0027nova_config\u0027:\n              transport_url \u003d\u003e $transport_url\n            }\n      - name: run puppet apply\n        command: puppet apply --detailed-exitcodes /tmp/test.pp\n        register: puppet_apply\n        failed_when: puppet_apply.rc not in [0,2]\n        changed_when: puppet_apply.rc \u003d\u003d 2","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"14352daa675b355cc5238461bc9146044fef1a32","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          tags: step0,common"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        - name: get rabbitmq node names"},{"line_number":195,"context_line":"          tags: step0,pre-upgrade"},{"line_number":196,"context_line":"          command: hiera rabbitmq_node_names"},{"line_number":197,"context_line":"          register: rmq_node_names"},{"line_number":198,"context_line":"        - name: get_rabbitmq_user"},{"line_number":199,"context_line":"          tags: step0,pre-upgrade"},{"line_number":200,"context_line":"          command: hiera nova::rabbit_userid"},{"line_number":201,"context_line":"          register: nova_rmq_user"},{"line_number":202,"context_line":"        - name: get rabbitmq password"},{"line_number":203,"context_line":"          tags: step0,pre-upgrade"},{"line_number":204,"context_line":"          command: hiera nova::rabbit_password"},{"line_number":205,"context_line":"          register: nova_rmq_pass"},{"line_number":206,"context_line":"        - name: get rabbitmq port"},{"line_number":207,"context_line":"          tags: step0,pre-upgrade"},{"line_number":208,"context_line":"          command: hiera nova::rabbit_port"},{"line_number":209,"context_line":"          register: nova_rmq_port"},{"line_number":210,"context_line":"        - name: get rabbitmq use ssl"},{"line_number":211,"context_line":"          tags: step0,pre-upgrade"},{"line_number":212,"context_line":"          command: hiera nova::rabbit_use_ssl"},{"line_number":213,"context_line":"          register: nova_rmq_ssl"},{"line_number":214,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step0,pre-upgrade"},{"line_number":223,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_ec0fb836","line":220,"range":{"start_line":194,"start_character":0,"end_line":220,"end_character":91},"in_reply_to":"fa31d9ce_0c708cdb","updated":"2017-02-14 16:47:01.000000000","message":"actually it\u0027s in the 10.1.0 tag... can we assume we\u0027re upgrading from the latest Newton point release?","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"385b940e1631bb6b5a99a11d1cdca77257fe147b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          tags: step0,common"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        - name: get rabbitmq node names"},{"line_number":195,"context_line":"          tags: step0,pre-upgrade"},{"line_number":196,"context_line":"          command: hiera rabbitmq_node_names"},{"line_number":197,"context_line":"          register: rmq_node_names"},{"line_number":198,"context_line":"        - name: get_rabbitmq_user"},{"line_number":199,"context_line":"          tags: step0,pre-upgrade"},{"line_number":200,"context_line":"          command: hiera nova::rabbit_userid"},{"line_number":201,"context_line":"          register: nova_rmq_user"},{"line_number":202,"context_line":"        - name: get rabbitmq password"},{"line_number":203,"context_line":"          tags: step0,pre-upgrade"},{"line_number":204,"context_line":"          command: hiera nova::rabbit_password"},{"line_number":205,"context_line":"          register: nova_rmq_pass"},{"line_number":206,"context_line":"        - name: get rabbitmq port"},{"line_number":207,"context_line":"          tags: step0,pre-upgrade"},{"line_number":208,"context_line":"          command: hiera nova::rabbit_port"},{"line_number":209,"context_line":"          register: nova_rmq_port"},{"line_number":210,"context_line":"        - name: get rabbitmq use ssl"},{"line_number":211,"context_line":"          tags: step0,pre-upgrade"},{"line_number":212,"context_line":"          command: hiera nova::rabbit_use_ssl"},{"line_number":213,"context_line":"          register: nova_rmq_ssl"},{"line_number":214,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step0,pre-upgrade"},{"line_number":223,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_f17f9314","line":220,"range":{"start_line":194,"start_character":0,"end_line":220,"end_character":91},"in_reply_to":"fa31d9ce_562db5a6","updated":"2017-02-14 16:25:09.000000000","message":"yes i was thinking of using puppet.\nI think it a good approach and probably clearer and more robust than the ansible tasks.","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2142898041a2ea2e89d4a5b00bbaa19d31b1fe70","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          tags: step0,common"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        - name: get rabbitmq node names"},{"line_number":195,"context_line":"          tags: step0,pre-upgrade"},{"line_number":196,"context_line":"          command: hiera rabbitmq_node_names"},{"line_number":197,"context_line":"          register: rmq_node_names"},{"line_number":198,"context_line":"        - name: get_rabbitmq_user"},{"line_number":199,"context_line":"          tags: step0,pre-upgrade"},{"line_number":200,"context_line":"          command: hiera nova::rabbit_userid"},{"line_number":201,"context_line":"          register: nova_rmq_user"},{"line_number":202,"context_line":"        - name: get rabbitmq password"},{"line_number":203,"context_line":"          tags: step0,pre-upgrade"},{"line_number":204,"context_line":"          command: hiera nova::rabbit_password"},{"line_number":205,"context_line":"          register: nova_rmq_pass"},{"line_number":206,"context_line":"        - name: get rabbitmq port"},{"line_number":207,"context_line":"          tags: step0,pre-upgrade"},{"line_number":208,"context_line":"          command: hiera nova::rabbit_port"},{"line_number":209,"context_line":"          register: nova_rmq_port"},{"line_number":210,"context_line":"        - name: get rabbitmq use ssl"},{"line_number":211,"context_line":"          tags: step0,pre-upgrade"},{"line_number":212,"context_line":"          command: hiera nova::rabbit_use_ssl"},{"line_number":213,"context_line":"          register: nova_rmq_ssl"},{"line_number":214,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step0,pre-upgrade"},{"line_number":223,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_e7f0b1ff","line":220,"range":{"start_line":194,"start_character":0,"end_line":220,"end_character":91},"in_reply_to":"fa31d9ce_ec0fb836","updated":"2017-02-14 16:49:56.000000000","message":"well \"yes\" but just because we say so i.e. we ask that you update to the latest version of what you\u0027re currently on, before performing the major upgrade.\n\nso if this would fail otherwise we\u0027d know about it soon enough (perhaps we need this in the notes/docs too as disclaimer, when we get them/write them at some point obviously... )","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"557bb01f9fd4d28dedf11338353a5295be62bc47","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          tags: step0,common"},{"line_number":192,"context_line":"          set_fact: is_bootstrap_node\u003d{{bootstrap_node.stdout \u003d\u003d ansible_hostname}}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        - name: get rabbitmq node names"},{"line_number":195,"context_line":"          tags: step0,pre-upgrade"},{"line_number":196,"context_line":"          command: hiera rabbitmq_node_names"},{"line_number":197,"context_line":"          register: rmq_node_names"},{"line_number":198,"context_line":"        - name: get_rabbitmq_user"},{"line_number":199,"context_line":"          tags: step0,pre-upgrade"},{"line_number":200,"context_line":"          command: hiera nova::rabbit_userid"},{"line_number":201,"context_line":"          register: nova_rmq_user"},{"line_number":202,"context_line":"        - name: get rabbitmq password"},{"line_number":203,"context_line":"          tags: step0,pre-upgrade"},{"line_number":204,"context_line":"          command: hiera nova::rabbit_password"},{"line_number":205,"context_line":"          register: nova_rmq_pass"},{"line_number":206,"context_line":"        - name: get rabbitmq port"},{"line_number":207,"context_line":"          tags: step0,pre-upgrade"},{"line_number":208,"context_line":"          command: hiera nova::rabbit_port"},{"line_number":209,"context_line":"          register: nova_rmq_port"},{"line_number":210,"context_line":"        - name: get rabbitmq use ssl"},{"line_number":211,"context_line":"          tags: step0,pre-upgrade"},{"line_number":212,"context_line":"          command: hiera nova::rabbit_use_ssl"},{"line_number":213,"context_line":"          register: nova_rmq_ssl"},{"line_number":214,"context_line":"        - name: get transport_url as pre-upgrade step"},{"line_number":215,"context_line":"          tags: step0,pre-upgrade"},{"line_number":216,"context_line":"          register: transport_url"},{"line_number":217,"context_line":"          shell: |"},{"line_number":218,"context_line":"            echo rabbitmq://{{nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027 + rmq_node_names.stdout|from_json |"},{"line_number":219,"context_line":"              join(\u0027:\u0027 + nova_rmq_port.stdout + \u0027,\u0027 + nova_rmq_user.stdout + \u0027:\u0027 + nova_rmq_pass.stdout + \u0027@\u0027) + \u0027:\u0027 +"},{"line_number":220,"context_line":"              nova_rmq_port.stdout}}?ssl\u003d{%if nova_rmq_ssl.stdout|bool%}1{%else%}0{%endif%}"},{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step0,pre-upgrade"},{"line_number":223,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_0c708cdb","line":220,"range":{"start_line":194,"start_character":0,"end_line":220,"end_character":91},"in_reply_to":"fa31d9ce_f17f9314","updated":"2017-02-14 16:45:35.000000000","message":"damn, os_transport_url wasn\u0027t added to puppet until Ocata: https://github.com/openstack/puppet-openstacklib/commit/7ef2f7b0d726f8657d3c370979c52c5bd6440ea1","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d11e51fea4b9d190e00209b02beb19c192276be2","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        - name: set nova api transport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step0,pre-upgrade"},{"line_number":223,"context_line":"          shell: crudini --set /etc/nova/nova.conf DEFAULT transport_url {{transport_url.stdout}}"},{"line_number":224,"context_line":"        - name: restart nova_api service"},{"line_number":225,"context_line":"          tags: step0,pre-upgrade"},{"line_number":226,"context_line":"          service: name\u003dopenstack-nova-api state\u003drestarted"},{"line_number":227,"context_line":"          ignore_errors: true"},{"line_number":228,"context_line":"        - name: Extra migration for nova tripleo/+bug/1656791"},{"line_number":229,"context_line":"          tags: step0,pre-upgrade"},{"line_number":230,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_b0443cb7","line":227,"range":{"start_line":224,"start_character":0,"end_line":227,"end_character":29},"updated":"2017-02-14 14:57:57.000000000","message":"Have we confirmed that this is necessary? I didn\u0027t think it would be","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e1d4101ea79086b36e32623adb34a3168807544b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"          tags: step2"},{"line_number":202,"context_line":"          service: name\u003dopenstack-nova-api state\u003dstopped enabled\u003dno"},{"line_number":203,"context_line":"        - name: Create puppet manifest to set transport_url in nova.conf"},{"line_number":204,"context_line":"          tags: step5"},{"line_number":205,"context_line":"          when: is_bootstrap_node"},{"line_number":206,"context_line":"          copy:"},{"line_number":207,"context_line":"            dest: /root/nova-api_upgrade_manifest.pp"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_fe7af7ef","line":204,"range":{"start_line":204,"start_character":16,"end_line":204,"end_character":21},"updated":"2017-02-14 19:58:12.000000000","message":"I think it\u0027s fine to move this to step 5, where will will have Ocata pkgs and can use os_tranport_url.\nAlso removed the service restart task assuming it was there to pick up the new conf.","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"610f9136c52aecb43dd7c86086f30b94c893d8ae","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_4efc183e","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"updated":"2017-02-15 10:10:31.000000000","message":"last run just now with v41 failed on this... note that it wasn\u0027t a \u0027clean\u0027 environment but one that i\u0027d run the upgrade steps on before (not sure if significant), trace like\n\nFeb 15 09:48:40 overcloud-controller-0.localdomain os-collect-config[544490]: TASK [Setup cell_v2 (get cell uuid)] *******************************************\nFeb 15 09:48:40 overcloud-controller-0.localdomain os-collect-config[544490]: changed: [localhost]\nFeb 15 09:48:40 overcloud-controller-0.localdomain os-collect-config[544490]: TASK [Setup cell_v2 (migrate instances)] ***************************************\nFeb 15 09:48:40 overcloud-controller-0.localdomain os-collect-config[544490]: fatal: [localhost]: FAILED! \u003d\u003e {\"changed\": true, \"cmd\": [\"nova-manage\", \"cell_v2\", \"map_instances\", \"--cell_uuid\", \"1bac7cb3-28b9-491c-a446-3f8aadbc55c9\", \"8adf3472-34ae-4ac8-923d-f3325f4e91c4\"], \"delta\": \"0:00:10.451711\", \"end\": \"2017-02-15 09:48:39.846298\", \"failed\": true, \"rc\": 1, \"start\": \"2017-02-15 09:48:29.394587\", \"stderr\": \"\", \"stdout\": \"An error has occurred:\\nTraceback (most recent call last):\\n  File \\\"/usr/lib/python2.7/site-packages/nova/cmd/manage.py\\\", line 1587, in main\\n    ret \u003d fn(*fn_args, **fn_kwargs)\\nTypeError: map_instances() got multiple values for keyword argument \u0027cell_uuid\u0027\", \"stdout_lines\": [\"An error has occurred:\", \"Traceback (most recent call last):\", \"  File \\\"/usr/lib/python2.7/site-packages/nova/cmd/manage.py\\\", line 1587, in main\", \"    ret \u003d fn(*fn_args, **fn_kwargs)\", \"TypeError: map_instances() got multiple values for keyword argument \u0027cell_uuid\u0027\"], \"warnings\": []}\nFeb 15 09:48:40 overcloud-controller-0.localdomain os-collect-config[544490]: to retry, use: --limit @/var/lib/heat-config/heat-config-ansible/c3a94498-f133-4bd1-9788-97bb6461d2bf_playbook.retry","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5a37005329bc3cdfea7fbad3c567d06499c1e1eb","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_44887471","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_16015606","updated":"2017-02-15 11:37:48.000000000","message":"seems to have done the trick, at least we\u0027re passed the ansible steps now and onto the PostDeploy ... cells now look like\n\n[root@overcloud-controller-1 ~]# nova-manage cell_v2 list_cells\n+---------+--------------------------------------+\n|   Name  |                 UUID                 |\n+---------+--------------------------------------+\n|   None  | 490c3dfb-849f-45a3-9f54-030a31fad3b2 |\n|  cell0  | 00000000-0000-0000-0000-000000000000 |\n| default | d1185550-5474-4c63-9669-47d9a9a397cb |\n+---------+--------------------------------------+\n[root@overcloud-controller-1 ~]#","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b16838603d21028bc586fc3d2adc872b3473b9d7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_56502e32","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_16f79659","updated":"2017-02-15 11:10:30.000000000","message":"shouldn\u0027t have the cell with no name though. To fully clean this try this\n\nOpen an api db shell (sudo mysql nova_api on a controller) then delete all the mappings:\n\n   delete from instance_mapping;\n   delete from host_mappings;\n   delete from cell_mappings;","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2e8d0cb928cd4b06e2225f73dc8d86e95dc0ccc8","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_16f79659","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_36073a83","updated":"2017-02-15 11:07:13.000000000","message":"so for anyone else following, i just deleted them with (seemingly) little fuss:\n\n[root@overcloud-controller-0 heat-admin]# nova-manage cell_v2 delete_cell --cell_uuid 1bac7cb3-28b9-491c-a446-3f8aadbc55c9\n[root@overcloud-controller-0 heat-admin]# nova-manage cell_v2 delete_cell --cell_uuid 8adf3472-34ae-4ac8-923d-f3325f4e91c4\n[root@overcloud-controller-0 heat-admin]# nova-manage cell_v2 list_cells\n+-------+--------------------------------------+\n|  Name |                 UUID                 |\n+-------+--------------------------------------+\n|  None | 490c3dfb-849f-45a3-9f54-030a31fad3b2 |\n| cell0 | 00000000-0000-0000-0000-000000000000 |\n+-------+--------------------------------------+","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f1c8b5cd1b5c4ab22666ec9a74c44d0086706169","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_8400ac67","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_44887471","updated":"2017-02-15 11:47:41.000000000","message":"ok, you might find that hosts/instances are mapped to the \u0027None\u0027 cell instead of the \u0027default\u0027 cell but if we don\u0027t see this with a clean env I think we are good","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9ec2f9c16c1d5f7d6dcef4473ae79fc1bc7d7887","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_9300f867","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_4efc183e","updated":"2017-02-15 10:45:55.000000000","message":"Yea, that\u0027s expected if the transport_url wasn\u0027t correct last time - there will be 2 \u0027default\u0027 cells with slightly different transport_urls.","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4df734c1e9147f06ed6710b7a4a93884277cbc84","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_16015606","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_56502e32","updated":"2017-02-15 11:12:07.000000000","message":"thanks! it just started the update so will do on next run","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6c0a580b29ff162489f25254a686aa2b87b2c95b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - name: Setup cell_v2 (migrate instances)"},{"line_number":257,"context_line":"          tags: step5"},{"line_number":258,"context_line":"          when: is_bootstrap_node"},{"line_number":259,"context_line":"          command: nova-manage cell_v2 map_instances --cell_uuid {{nova_api_cell_uuid.stdout}}"},{"line_number":260,"context_line":"        - name: Sync nova_api DB"},{"line_number":261,"context_line":"          tags: step5"},{"line_number":262,"context_line":"          command: nova-manage api_db sync"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_36073a83","line":259,"range":{"start_line":259,"start_character":0,"end_line":259,"end_character":94},"in_reply_to":"fa31d9ce_9300f867","updated":"2017-02-15 11:02:20.000000000","message":"thanks owalsh... it was actually v 42 I tested but accidentaly commented here... in any case its what you said like:\n\n[root@overcloud-controller-0 heat-admin]# nova-manage cell_v2 list_cells\n+---------+--------------------------------------+\n|   Name  |                 UUID                 |\n+---------+--------------------------------------+\n|   None  | 490c3dfb-849f-45a3-9f54-030a31fad3b2 |\n|  cell0  | 00000000-0000-0000-0000-000000000000 |\n| default | 1bac7cb3-28b9-491c-a446-3f8aadbc55c9 |\n| default | 8adf3472-34ae-4ac8-923d-f3325f4e91c4 |\n+---------+--------------------------------------+\n[root@overcloud-controller-0 heat-admin]# nova-manage cell_v2 list_cells | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"default\" {print $4}\u0027\n1bac7cb3-28b9-491c-a446-3f8aadbc55c9\n8adf3472-34ae-4ac8-923d-f3325f4e91c4\n\n\ncan i try and delete them? i\u0027ll reset at some point but would rather not just yet as it takes a couple hours...","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"de039bfcf2a8979d360be5ca7b3306fc946f3d41","unresolved":false,"context_lines":[{"line_number":217,"context_line":"              })"},{"line_number":218,"context_line":"              oslo::messaging::default { \u0027nova_config\u0027:"},{"line_number":219,"context_line":"                transport_url \u003d\u003e $transport_url"},{"line_number":220,"context_line":"              }"},{"line_number":221,"context_line":"        - name: Run puppet apply to set tranport_url in nova.conf"},{"line_number":222,"context_line":"          tags: step5"},{"line_number":223,"context_line":"          when: is_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"fa31d9ce_e13dcf2b","line":220,"updated":"2017-02-15 15:19:47.000000000","message":"Technically we could probably do all the subsequent ansible tasks with a single puppet run here if we didn\u0027t want to manage it in two places. Something similar to what we do in the undercloud, https://github.com/openstack/instack-undercloud/blob/master/elements/puppet-stack-config/puppet-stack-config.pp#L660-L688.  But if this works let\u0027s just move on and not repeat again :D","commit_id":"5353f1c7c9cd4408d10745206165aa4950ad76c6"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"a9b83249707712d12d22aedf4c3c0b8dec36a12e","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        - name: Online data migration for nova"},{"line_number":265,"context_line":"          tags: step5"},{"line_number":266,"context_line":"          when: is_bootstrap_node"},{"line_number":267,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"fa31d9ce_04610ea9","line":267,"updated":"2017-02-15 16:31:48.000000000","message":"So, what would happen now, if this command fails? It would still continue and just log it, or will it interrupt the upgrade?","commit_id":"5353f1c7c9cd4408d10745206165aa4950ad76c6"}],"puppet/services/nova-base.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ee2b0458cc8857a61ac4480f7cae096db9d54875","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    description: Nova Compute upgrade level"},{"line_number":72,"context_line":"    default: auto"},{"line_number":73,"context_line":"  NovaCronArchiveDeleteRowsMinute:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a461143_ca9b2fc8","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":17},"updated":"2017-01-26 16:07:38.000000000","message":"Still need a reload with this set to auto (see \"After maintenance window\" in http://docs.openstack.org/developer/nova/upgrade.html).\n\nI think we can leave the default as \u0027\u0027 and set auto in the upgrade environment.","commit_id":"0c2e3d77ef5a1d94fb325ab3c239fb1f21f14854"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"db4f505317f70f5431875523d3763128fca6e78e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    description: Nova Compute upgrade level"},{"line_number":72,"context_line":"    default: auto"},{"line_number":73,"context_line":"  NovaCronArchiveDeleteRowsMinute:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a461143_c0d20000","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":17},"in_reply_to":"3a461143_ca9b2fc8","updated":"2017-01-27 15:19:03.000000000","message":"So, to clarify we should set it to auto for both update and converge, or newton (upgrade environment), then auto (converge environment) ?","commit_id":"0c2e3d77ef5a1d94fb325ab3c239fb1f21f14854"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"48237e60a90fb68a7f1b4f8c53be9791e7756553","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    description: Nova Compute upgrade level"},{"line_number":72,"context_line":"    default: \u0027auto\u0027"},{"line_number":73,"context_line":"  NovaCronArchiveDeleteRowsMinute:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1a430d35_fbb17b90","line":72,"range":{"start_line":72,"start_character":14,"end_line":72,"end_character":18},"updated":"2017-02-06 15:29:07.000000000","message":"This must be set to \u0027\u0027 in nova-base. We only want this set to auto/newton during the upgrade.","commit_id":"6be55375d1edf4d626cc37ea6cec6c68a3f38a44"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"74dbecd86157f05e10728920e7d624450c559414","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    description: Nova Compute upgrade level"},{"line_number":72,"context_line":"    default: \u0027auto\u0027"},{"line_number":73,"context_line":"  NovaCronArchiveDeleteRowsMinute:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1a430d35_f6c5128e","line":72,"range":{"start_line":72,"start_character":14,"end_line":72,"end_character":18},"in_reply_to":"1a430d35_3b08632c","updated":"2017-02-06 15:35:11.000000000","message":"ack sorry I misunderstood your comment, fixing..","commit_id":"6be55375d1edf4d626cc37ea6cec6c68a3f38a44"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0e205bcc92b6144f2d3eacd38b759aa9ddb6fc7d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":70,"context_line":"    type: string"},{"line_number":71,"context_line":"    description: Nova Compute upgrade level"},{"line_number":72,"context_line":"    default: \u0027auto\u0027"},{"line_number":73,"context_line":"  NovaCronArchiveDeleteRowsMinute:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1a430d35_3b08632c","line":72,"range":{"start_line":72,"start_character":14,"end_line":72,"end_character":18},"in_reply_to":"1a430d35_fbb17b90","updated":"2017-02-06 15:31:19.000000000","message":"Should have said must default to \u0027\u0027.","commit_id":"6be55375d1edf4d626cc37ea6cec6c68a3f38a44"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c3f49bfb5f045fc10110e34ba23db228296621da","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        Cron to move deleted instances to another table - Until complete"},{"line_number":117,"context_line":"    default: false"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"conditions:"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  compute_upgrade_level_empty: {equals : [{get_param: UpgradeLevelNovaCompute}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_b041aeab","side":"PARENT","line":119,"updated":"2017-02-07 08:58:25.000000000","message":"remove me on next pass (no biggie just seen this a few times now)","commit_id":"d5b4b4fdee8aac0337eb10631a346167f7a61bd6"}],"puppet/services/nova-compute.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"c8f6996a753f4d388838dfea496cf2fcff5873c2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # If not already set by puppet (e.g a pre-ocata version), set the"},{"line_number":154,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":155,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":156,"context_line":"          tags: step3"},{"line_number":157,"context_line":"          command:"},{"line_number":158,"context_line":"            str_replace:"},{"line_number":159,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf upgrade_levels compute LEVEL\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_2ded9a25","line":156,"updated":"2016-12-02 11:39:34.000000000","message":"On step 3 we also need to move the current value from 0.\ni.e. \"crudini  --set /etc/nova/nova.conf DEFAULT osapi_compute_workers 4\"","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"de1df4eadf038f92b59fddc36c3d772f1daa145c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":156,"context_line":"          tags: step3"},{"line_number":157,"context_line":"          command:"},{"line_number":158,"context_line":"            str_replace:"},{"line_number":159,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf upgrade_levels compute LEVEL\""},{"line_number":160,"context_line":"              params:"},{"line_number":161,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_ee23a403","line":158,"updated":"2016-12-23 00:46:34.000000000","message":"Trying wrap my head around this: under upgrade_tasks is Ansible yaml but str_replace is expanded by HOT in order to insert parameter values?","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"124fb816690ff109814ed1ec29e51f87e3b30948","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":156,"context_line":"          tags: step3"},{"line_number":157,"context_line":"          command:"},{"line_number":158,"context_line":"            str_replace:"},{"line_number":159,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf upgrade_levels compute LEVEL\""},{"line_number":160,"context_line":"              params:"},{"line_number":161,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_e6c49f60","line":158,"in_reply_to":"da4df55a_ee23a403","updated":"2016-12-23 09:30:14.000000000","message":"Yes, exactly that :)","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"de1df4eadf038f92b59fddc36c3d772f1daa145c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          tags: step3"},{"line_number":157,"context_line":"          command:"},{"line_number":158,"context_line":"            str_replace:"},{"line_number":159,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf upgrade_levels compute LEVEL\""},{"line_number":160,"context_line":"              params:"},{"line_number":161,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_ae5fdc70","line":159,"updated":"2016-12-23 00:46:34.000000000","message":"Would be nicer to use Ansible\u0027s ini_file module http://docs.ansible.com/ansible/ini_file_module.html","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"de1df4eadf038f92b59fddc36c3d772f1daa145c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            str_replace:"},{"line_number":159,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf upgrade_levels compute LEVEL\""},{"line_number":160,"context_line":"              params:"},{"line_number":161,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_29492660","line":161,"updated":"2016-12-23 00:46:34.000000000","message":"Instead of HOT string replacing, could parameters be pushed to Ansible as variables?","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"124fb816690ff109814ed1ec29e51f87e3b30948","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            str_replace:"},{"line_number":159,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf upgrade_levels compute LEVEL\""},{"line_number":160,"context_line":"              params:"},{"line_number":161,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_e6d73feb","line":161,"in_reply_to":"da4df55a_29492660","updated":"2016-12-23 09:30:14.000000000","message":"Possibly we could - the reason I did it this way was it\u0027s arguably a little more explicit, e.g all inputs to upgrade_tasks are defined in this service template.\n\nOne way to maintain that might be to add an upgrade_vars section too, where you could do e.g:\n\n  upgrade_vars:\n    upgrade_level_nova_compute: {get_param:pgradeLevelNovaCompute}\n  upgrade_tasks:\n     name: foo\n     tags: step3\n     command: \"crudini  --set /etc/nova/nova.conf upgrade_levels {{upgrade_level_novacompute}}\n\n\nThe disadvantage of this approach is we\u0027d have to merge upgrade_vars for all services (as we apply the tasks for all services together, for each upgrade step), and atm I can\u0027t think of a good way to validate to prevent naming collisions.\n\nSo you might find this approach ends up being more complex and harder to debug, when folks have ansible variables  silently overwritten by other services.\n\nIn this particular case I\u0027m not sure we need the str_replace anyway - I think we can probably unconditionally set the nova upgrade level to \"auto\" ?","commit_id":"a3f177eb73de12f31df894c5fa333e29f7317712"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        - name: Stop nova-compute service"},{"line_number":150,"context_line":"          tags: step2"},{"line_number":151,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstopped"},{"line_number":152,"context_line":"        # If not already set by puppet (e.g a pre-ocata version), set the"},{"line_number":153,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":154,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":155,"context_line":"          tags: step3"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_74a02a44","line":152,"range":{"start_line":152,"start_character":40,"end_line":152,"end_character":63},"updated":"2017-01-27 17:54:59.000000000","message":"(nit) comment is no longer valid, will be unset at the end of an ocata upgrade","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"          tags: step2"},{"line_number":151,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstopped"},{"line_number":152,"context_line":"        # If not already set by puppet (e.g a pre-ocata version), set the"},{"line_number":153,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":154,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":155,"context_line":"          tags: step3"},{"line_number":156,"context_line":"          ini_file:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_81163753","line":153,"range":{"start_line":153,"start_character":39,"end_line":153,"end_character":45},"updated":"2017-01-27 17:54:59.000000000","message":"(nit) it will be newton with the current environment file","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstopped"},{"line_number":152,"context_line":"        # If not already set by puppet (e.g a pre-ocata version), set the"},{"line_number":153,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":154,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":155,"context_line":"          tags: step3"},{"line_number":156,"context_line":"          ini_file:"},{"line_number":157,"context_line":"            str_replace:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_c1083f30","line":154,"range":{"start_line":154,"start_character":45,"end_line":154,"end_character":49},"updated":"2017-01-27 17:54:59.000000000","message":"(nit) it will be newton with the current environment file","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":159,"context_line":"              params:"},{"line_number":160,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":161,"context_line":"        - name: Start nova-compute service"},{"line_number":162,"context_line":"          tags: step6"},{"line_number":163,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_a1033341","line":163,"range":{"start_line":161,"start_character":8,"end_line":163,"end_character":60},"updated":"2017-01-27 17:54:59.000000000","message":"I guess this means we may have to deal with any e.g deprecated conf here as puppet will not run until later.","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ecdc74f67db299b1a66ede8d66c9002dd6afc0f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":159,"context_line":"              params:"},{"line_number":160,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":161,"context_line":"        - name: Start nova-compute service"},{"line_number":162,"context_line":"          tags: step6"},{"line_number":163,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_3f757631","line":163,"range":{"start_line":161,"start_character":8,"end_line":163,"end_character":60},"in_reply_to":"3a461143_a1033341","updated":"2017-01-30 08:26:27.000000000","message":"why do we want to explicitly start nova-compute I thought we would let puppet do that. Also, since this is nova-compute (so typically not on the controller role but on a compute) these steps actually won\u0027t be executed this cycle at least. We\u0027ll use the upgrade_non_controller.sh to execute the upgrade and also the puppet run.\n\n We skip these ansible upgrade_tasks https://github.com/openstack/tripleo-heat-templates/blob/5e575fbb57d3057d4bb9c1a9dd017ffc918a836b/puppet/major_upgrade_steps.j2.yaml#L99 here using a flag in the roles_data.yaml","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b466c1bcb8536455dccd80fc591c031e78dbd97","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":154,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":155,"context_line":"          tags: step3"},{"line_number":156,"context_line":"          ini_file:"},{"line_number":157,"context_line":"            str_replace:"},{"line_number":158,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":159,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_15b1ca8f","line":156,"range":{"start_line":156,"start_character":10,"end_line":156,"end_character":18},"updated":"2017-02-06 09:10:24.000000000","message":"nice this is ansible crudini then :)","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"b8a8c0613afd68d8aac8f2d586a9ac0723df9c00","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":154,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":155,"context_line":"          tags: step3"},{"line_number":156,"context_line":"          ini_file:"},{"line_number":157,"context_line":"            str_replace:"},{"line_number":158,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":159,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_f85b53f4","line":156,"range":{"start_line":156,"start_character":10,"end_line":156,"end_character":18},"in_reply_to":"1a430d35_15b1ca8f","updated":"2017-02-06 09:16:57.000000000","message":"yep :)","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bcb18d78d908760879de680f3d738ed9f1ca0f24","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        - name: Stop nova-compute service"},{"line_number":150,"context_line":"          tags: step2"},{"line_number":151,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstopped"},{"line_number":152,"context_line":"        # If not already set by puppet (e.g a pre-ocata version), set the"},{"line_number":153,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":154,"context_line":"        - name: Set compute upgrade level to auto"},{"line_number":155,"context_line":"          tags: step3"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1a430d35_37fa41be","line":152,"range":{"start_line":152,"start_character":40,"end_line":152,"end_character":63},"updated":"2017-02-06 12:26:11.000000000","message":"(nit) default in nova-base.yaml is still \u0027\u0027, so this comment is not correct","commit_id":"bea3f18e821f178f64f4a6fba0bfc5ce5a136b91"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0e205bcc92b6144f2d3eacd38b759aa9ddb6fc7d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":79,"context_line":"    type: string"},{"line_number":80,"context_line":"    description: Nova Compute upgrade level"},{"line_number":81,"context_line":"    default: auto"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"resources:"},{"line_number":84,"context_line":"  NovaBase:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1a430d35_d62496b0","line":81,"range":{"start_line":81,"start_character":13,"end_line":81,"end_character":17},"updated":"2017-02-06 15:31:19.000000000","message":"defaulting to auto is ok here as it\u0027s only referenced in upgrade_tasks","commit_id":"6be55375d1edf4d626cc37ea6cec6c68a3f38a44"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c3f49bfb5f045fc10110e34ba23db228296621da","unresolved":false,"context_lines":[{"line_number":158,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":159,"context_line":"              params:"},{"line_number":160,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":161,"context_line":"        - name: Start nova-compute service"},{"line_number":162,"context_line":"          tags: step6"},{"line_number":163,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a430d35_5067aa4c","line":163,"range":{"start_line":161,"start_character":0,"end_line":163,"end_character":60},"updated":"2017-02-07 08:58:25.000000000","message":"remove me?\n\nThis isn\u0027t going to be run at the moment, granted (on the compute node). Just might be confusing since we\u0027ve removed all the ansible start tasks from all services as puppet will handle that. I think the same applies to the compute too.","commit_id":"37637870d3aeaefa785c1751fdb36bfd3ea651c4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a200c68224b2d2fd3aa599aa1ad229536dee83a4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":164,"context_line":"              params:"},{"line_number":165,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":166,"context_line":"        - name: Start nova-compute service"},{"line_number":167,"context_line":"          tags: step6"},{"line_number":168,"context_line":"          service: name\u003dopenstack-nova-compute state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_9c2f5987","line":168,"range":{"start_line":166,"start_character":0,"end_line":168,"end_character":60},"updated":"2017-02-14 13:04:17.000000000","message":"remove please\n\n(I\u0027ve commented on previous versions... even though we aren\u0027t applying running ansible steps where the nova-compute would be running as we will do that with the upgrade script, we should remove it here anyway in line with the \u0027puppet will be starting services\u0027 for later when we *do* switch to using ansible to drive the upgrade for this, too)","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"}],"puppet/services/nova-conductor.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"55bd3b534dd0e793d867d5c52612804f30fd094a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"          tags: step2"},{"line_number":79,"context_line":"          command:"},{"line_number":80,"context_line":"            str_replace:"},{"line_number":81,"context_line":"              template: \"crudini  --set /etc/nova/nova.conf DEFAULT metadata_workers WORKERS\""},{"line_number":82,"context_line":"              params:"},{"line_number":83,"context_line":"                WORKERS: {get_param: NovaMetaDataWorkers}"},{"line_number":84,"context_line":"        - name: update nova conductor"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a3c09a3_b36a89ec","line":81,"range":{"start_line":81,"start_character":25,"end_line":81,"end_character":32},"updated":"2017-01-17 08:45:45.000000000","message":"do we need this in both places (you are setting in nova-compute.yaml)","commit_id":"14b9afc004cee95bd9467e92b7a503ff39177b28"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"473ab750dc753ebbdbe0a64950fc224868d496cc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"          tags: step3"},{"line_number":91,"context_line":"          ini_file:"},{"line_number":92,"context_line":"            str_replace:"},{"line_number":93,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":94,"context_line":"              params:"},{"line_number":95,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":96,"context_line":"        - name: Sync nova_conductor DB"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_cbd47ced","line":93,"updated":"2017-01-18 08:08:22.000000000","message":"so thinking about this a little more after my comment on v7 (and whilst poking at the compute script delivery and placement config that will run before these), I think we do need to set it here, because this will be running on the controller role. But the setting on nova-compute is *currently* redundant, since we won\u0027t be running the playbook for compute role based services (like nova-compute) and instead use the existing upgrade scripts. \n\nI guess we can leave it there since we ultimately want to be running both via ansible.","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"df581a2fe7b7eeee0b61f06845f5bc5cc44a73b0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"          tags: step3"},{"line_number":91,"context_line":"          ini_file:"},{"line_number":92,"context_line":"            str_replace:"},{"line_number":93,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":94,"context_line":"              params:"},{"line_number":95,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":96,"context_line":"        - name: Sync nova_conductor DB"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7a3c09a3_90a7fb09","line":93,"in_reply_to":"7a3c09a3_cbd47ced","updated":"2017-01-18 10:13:13.000000000","message":"Note that we *do* want to run the compute upgrade steps in CI, so we have them working for when we want to drive that via ansible in future, or for other all-in-one environments where you don\u0027t want to upgrade manually.","commit_id":"32202584e1abed337705b35ad5318f290eb354b7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ecdc74f67db299b1a66ede8d66c9002dd6afc0f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      step_config: |"},{"line_number":71,"context_line":"        include tripleo::profile::base::nova::conductor"},{"line_number":72,"context_line":"      upgrade_tasks:"},{"line_number":73,"context_line":"        - name: Stop nova_conductor service"},{"line_number":74,"context_line":"          tags: step2"},{"line_number":75,"context_line":"          service: name\u003dopenstack-nova-conductor state\u003dstopped"},{"line_number":76,"context_line":"        # TODO matbu, use ini module instead"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_7f145e9f","line":73,"updated":"2017-01-30 08:26:27.000000000","message":"do you want to also add the step0,validation here and for the other services to check if running like  https://review.openstack.org/#/c/414598/","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":94,"context_line":"              params:"},{"line_number":95,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":96,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":97,"context_line":"          tags: step5"},{"line_number":98,"context_line":"          command: nova-manage db sync"},{"line_number":99,"context_line":"        - name: DB online migrations"},{"line_number":100,"context_line":"          tags: step5"},{"line_number":101,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_54edee23","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":38},"updated":"2017-01-27 17:54:59.000000000","message":"do we need this when nova-api.yaml already runs it?","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4d9ece00a2bc2e54943c21a28d92a929abf0781a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":96,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":97,"context_line":"          tags: step5"},{"line_number":98,"context_line":"          command: nova-manage db sync"},{"line_number":99,"context_line":"        - name: DB online migrations"},{"line_number":100,"context_line":"          tags: step5"},{"line_number":101,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_94459618","line":101,"range":{"start_line":98,"start_character":38,"end_line":101,"end_character":56},"updated":"2017-01-27 17:54:59.000000000","message":"AFAIK puppet will run this now https://review.openstack.org/421249","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ecdc74f67db299b1a66ede8d66c9002dd6afc0f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":96,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":97,"context_line":"          tags: step5"},{"line_number":98,"context_line":"          command: nova-manage db sync"},{"line_number":99,"context_line":"        - name: DB online migrations"},{"line_number":100,"context_line":"          tags: step5"},{"line_number":101,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_bfaec67e","line":101,"range":{"start_line":98,"start_character":38,"end_line":101,"end_character":56},"in_reply_to":"3a461143_94459618","updated":"2017-01-30 08:26:27.000000000","message":"so I think we can let this happen for now and then fixup. I mean, yes, that review adds the puppet-nova bits for the online_data_migrations and I\u0027ve got a review at https://review.openstack.org/#/c/421262/ adding it to the puppet-stack-config.pp for the undercloud. I didn\u0027t yet get round to wiring this up for the overcloud - will try and make some progress on that today","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"8df95c313b98137e74b5e0905139901d28a2e86d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":96,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":97,"context_line":"          tags: step5"},{"line_number":98,"context_line":"          command: nova-manage db sync"},{"line_number":99,"context_line":"        - name: DB online migrations"},{"line_number":100,"context_line":"          tags: step5"},{"line_number":101,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_7018d3d3","line":101,"range":{"start_line":98,"start_character":38,"end_line":101,"end_character":56},"in_reply_to":"3a461143_bfaec67e","updated":"2017-01-31 15:12:49.000000000","message":"I think we should keep the db sync and the _following_ db online_data_migration together, don\u0027t you think? why doing one here and the other in puppet? they belong together somehow, IIUC. (I\u0027m not talking about the saftey pre-upgrade online_data_migration, which is independent)","commit_id":"0282f59e410caea2ee2ce973987f0ae8ab188b46"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"10b4778ebc12e5ea3d571d4bc11e0dbe6af5d326","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  UpgradeLevelNovaCompute:"},{"line_number":34,"context_line":"    type: string"},{"line_number":35,"context_line":"    description: Nova Compute upgrade level"},{"line_number":36,"context_line":"    default: auto"},{"line_number":37,"context_line":"  NovaMetaDataWorkers:"},{"line_number":38,"context_line":"    default: 1"},{"line_number":39,"context_line":"    description: Number of metadata workers for nova conductor"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a461143_7fc32538","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":17},"updated":"2017-02-01 08:30:02.000000000","message":"sanity check against https://review.openstack.org/#/c/405241/20/environments/major-upgrade-composable-steps.yaml","commit_id":"65c5754e7928a742c08eff600327faba846db074"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5be057aa0aeacf6a27cb120109555002891b4c67","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":95,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":96,"context_line":"          tags: step5"},{"line_number":97,"context_line":"          command: nova-manage db sync"},{"line_number":98,"context_line":"        - name: DB online migrations"},{"line_number":99,"context_line":"          tags: step5"},{"line_number":100,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_f6a51704","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":38},"updated":"2017-02-13 08:25:57.000000000","message":"remove this (to be done by puppet?)","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7028800eb070d9a1eb08e2314ba4b05296fbdd9f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":95,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":96,"context_line":"          tags: step5"},{"line_number":97,"context_line":"          command: nova-manage db sync"},{"line_number":98,"context_line":"        - name: DB online migrations"},{"line_number":99,"context_line":"          tags: step5"},{"line_number":100,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_687e9baf","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":38},"in_reply_to":"fa31d9ce_f6a51704","updated":"2017-02-13 12:00:30.000000000","message":"yes, I think so. It\u0027s done by nova-api.yaml","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5be057aa0aeacf6a27cb120109555002891b4c67","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          command: nova-manage db sync"},{"line_number":98,"context_line":"        - name: DB online migrations"},{"line_number":99,"context_line":"          tags: step5"},{"line_number":100,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_d6d3b35d","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":56},"updated":"2017-02-13 08:25:57.000000000","message":"same?\n\nif we do need to keep this one for example then we should add similar \u0027is_bootstrap_node\u0027 like for nova-api","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7028800eb070d9a1eb08e2314ba4b05296fbdd9f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          command: nova-manage db sync"},{"line_number":98,"context_line":"        - name: DB online migrations"},{"line_number":99,"context_line":"          tags: step5"},{"line_number":100,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"fa31d9ce_e848cb89","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":56},"in_reply_to":"fa31d9ce_d6d3b35d","updated":"2017-02-13 12:00:30.000000000","message":"yes","commit_id":"aa2734ba719d5d7c67f0203fbe457447f297e80a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aba90bc4bce6628b648395a9f9baab02e90ed0ea","unresolved":false,"context_lines":[{"line_number":92,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dupgrade_levels option\u003dcompute value\u003dLEVEL\""},{"line_number":93,"context_line":"              params:"},{"line_number":94,"context_line":"                LEVEL: {get_param: UpgradeLevelNovaCompute}"},{"line_number":95,"context_line":"        - name: Sync nova_conductor DB"},{"line_number":96,"context_line":"          tags: step5"},{"line_number":97,"context_line":"          command: nova-manage db sync"},{"line_number":98,"context_line":"        - name: DB online migrations"},{"line_number":99,"context_line":"          tags: step5"},{"line_number":100,"context_line":"          command: nova-manage db online_data_migrations"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"fa31d9ce_371694f1","line":100,"range":{"start_line":95,"start_character":0,"end_line":100,"end_character":56},"updated":"2017-02-14 08:18:46.000000000","message":"remove please (I have these removed in my env locally) see comments at https://review.openstack.org/#/c/405241/36/puppet/services/nova-conductor.yaml","commit_id":"df9100b71e57797f3a6304f4c4cb3d3ab9bec044"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d11e51fea4b9d190e00209b02beb19c192276be2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    description: Nova Compute upgrade level"},{"line_number":36,"context_line":"    default: auto"},{"line_number":37,"context_line":"  NovaMetaDataWorkers:"},{"line_number":38,"context_line":"    default: 1"},{"line_number":39,"context_line":"    description: Number of metadata workers for nova conductor"},{"line_number":40,"context_line":"    type: number"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_4b97d147","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":14},"updated":"2017-02-14 14:57:57.000000000","message":"should this default to 0 and set to ansible_processor_vcpus when nova_workers_zero is true","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d11e51fea4b9d190e00209b02beb19c192276be2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        - name: Stop nova_conductor service"},{"line_number":74,"context_line":"          tags: step2"},{"line_number":75,"context_line":"          service: name\u003dopenstack-nova-conductor state\u003dstopped"},{"line_number":76,"context_line":"        - name: Set metadata_workers"},{"line_number":77,"context_line":"          tags: step2"},{"line_number":78,"context_line":"          ini_file:"},{"line_number":79,"context_line":"            str_replace:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_cb902146","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":36},"updated":"2017-02-14 14:57:57.000000000","message":"Should this be in nova-api.yaml?","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a200c68224b2d2fd3aa599aa1ad229536dee83a4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dDEFAULT option\u003dmetadata_workers value\u003dWORKERS\""},{"line_number":81,"context_line":"              params:"},{"line_number":82,"context_line":"                WORKERS: {get_param: NovaMetaDataWorkers}"},{"line_number":83,"context_line":"        - name: update nova conductor"},{"line_number":84,"context_line":"          tags: step2"},{"line_number":85,"context_line":"          yum: name\u003dopenstack-nova-conductor state\u003dlatest"},{"line_number":86,"context_line":"        # If not already set by puppet (e.g a pre-ocata version), set the"},{"line_number":87,"context_line":"        # upgrade_level for compute to \"auto\""},{"line_number":88,"context_line":"        - name: Set compute upgrade level to auto"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_3c158d3f","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":57},"updated":"2017-02-14 13:04:17.000000000","message":"remove please sorry missed it on last revision","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"cb636275aa95fdc726ca7299812b4f67e45efeb7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    description: Nova Compute upgrade level"},{"line_number":36,"context_line":"    default: auto"},{"line_number":37,"context_line":"  NovaMetaDataWorkers:"},{"line_number":38,"context_line":"    default: 1"},{"line_number":39,"context_line":"    description: Number of metadata workers for nova conductor"},{"line_number":40,"context_line":"    type: number"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_9e01fb3a","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":14},"updated":"2017-02-14 20:02:00.000000000","message":"(from previous review) should this default to 0 and set to ansible_processor_vcpus when nova_workers_zero is true","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"cb636275aa95fdc726ca7299812b4f67e45efeb7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        - name: Stop nova_conductor service"},{"line_number":74,"context_line":"          tags: step2"},{"line_number":75,"context_line":"          service: name\u003dopenstack-nova-conductor state\u003dstopped"},{"line_number":76,"context_line":"        - name: Set metadata_workers"},{"line_number":77,"context_line":"          tags: step2"},{"line_number":78,"context_line":"          ini_file:"},{"line_number":79,"context_line":"            str_replace:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_de8e13cf","line":76,"range":{"start_line":76,"start_character":16,"end_line":76,"end_character":36},"updated":"2017-02-14 20:02:00.000000000","message":"(from previous review) Should this be in nova-api.yaml?","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1aec6e29ecd695df7202d3c2b1357707e432f85a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          tags: step2"},{"line_number":78,"context_line":"          ini_file:"},{"line_number":79,"context_line":"            str_replace:"},{"line_number":80,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dDEFAULT option\u003dmetadata_workers value\u003dWORKERS\""},{"line_number":81,"context_line":"              params:"},{"line_number":82,"context_line":"                WORKERS: {get_param: NovaMetaDataWorkers}"},{"line_number":83,"context_line":"        - name: update nova conductor"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_5f8bfac2","line":80,"updated":"2017-02-14 22:58:48.000000000","message":"shouldn\u0027t it be:\n  section\u003dconductor option\u003dworkers ?","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"cb0687b235815471dd5d67cd56becb51cc4b53d8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          tags: step2"},{"line_number":78,"context_line":"          ini_file:"},{"line_number":79,"context_line":"            str_replace:"},{"line_number":80,"context_line":"              template: \"dest\u003d/etc/nova/nova.conf section\u003dDEFAULT option\u003dmetadata_workers value\u003dWORKERS\""},{"line_number":81,"context_line":"              params:"},{"line_number":82,"context_line":"                WORKERS: {get_param: NovaMetaDataWorkers}"},{"line_number":83,"context_line":"        - name: update nova conductor"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"fa31d9ce_7a252c07","line":80,"in_reply_to":"fa31d9ce_5f8bfac2","updated":"2017-02-14 23:22:57.000000000","message":"I don\u0027t think this is required at all, now that puppet is starting the services","commit_id":"61a74c8ca088899bf938bf9f4866984fa72e1366"}],"puppet/services/nova-scheduler.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b466c1bcb8536455dccd80fc591c031e78dbd97","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          service: name\u003dopenstack-nova-scheduler state\u003dstopped"},{"line_number":70,"context_line":"        - name: update nova scheduler"},{"line_number":71,"context_line":"          tags: step2"},{"line_number":72,"context_line":"          yum: name\u003dopenstack-nova-scheduler state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_3508862d","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":57},"updated":"2017-02-06 09:10:24.000000000","message":"so do we need all nova services on controllers updated at step 2 for some reason then ?","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"b8a8c0613afd68d8aac8f2d586a9ac0723df9c00","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          service: name\u003dopenstack-nova-scheduler state\u003dstopped"},{"line_number":70,"context_line":"        - name: update nova scheduler"},{"line_number":71,"context_line":"          tags: step2"},{"line_number":72,"context_line":"          yum: name\u003dopenstack-nova-scheduler state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a430d35_58f2a7d3","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":57},"in_reply_to":"1a430d35_3508862d","updated":"2017-02-06 09:16:57.000000000","message":"yep this for the CI all-in-one case, those services should be upgrade before, if not it will cause some hanging of nova-compute during the yum update","commit_id":"f67e30d52e28d4f090bc39e44c5364ab738cb82c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a200c68224b2d2fd3aa599aa1ad229536dee83a4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        - name: Stop nova_scheduler service"},{"line_number":68,"context_line":"          tags: step2"},{"line_number":69,"context_line":"          service: name\u003dopenstack-nova-scheduler state\u003dstopped"},{"line_number":70,"context_line":"        - name: update nova scheduler"},{"line_number":71,"context_line":"          tags: step2"},{"line_number":72,"context_line":"          yum: name\u003dopenstack-nova-scheduler state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"fa31d9ce_1c2369a8","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":57},"updated":"2017-02-14 13:04:17.000000000","message":"remove?","commit_id":"6ea8c7e7f383773c3a58d06db62b726a6ce35a41"}],"puppet/services/rabbitmq.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5de437f15ac7865c6f56bc5ba1636f43cc989e04","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          tags: step2"},{"line_number":108,"context_line":"          service: name\u003drabbitmq-server state\u003dstopped"},{"line_number":109,"context_line":"        - name: Start rabbitmq service"},{"line_number":110,"context_line":"          tags: step4"},{"line_number":111,"context_line":"          service: name\u003drabbitmq-server state\u003dstarted"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a3c09a3_26e32aa5","line":110,"range":{"start_line":110,"start_character":16,"end_line":110,"end_character":21},"updated":"2017-01-13 14:10:40.000000000","message":"I made a mistake when rebasing - this needs to be in the neutron patch now at the start of the series.","commit_id":"38868a28bd8a0b26487115cbc9f058d47910de00"}]}