)]}'
{"puppet/services/panko-api.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"67059dae6adcf9365ed78eb33d53e9c07c3f08bd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0"},{"line_number":98,"context_line":"          tags: step0,validation"},{"line_number":99,"context_line":"        - name: Stop panko-api service (running under httpd)"},{"line_number":100,"context_line":"          tags: step1"},{"line_number":101,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":102,"context_line":"        # The panko API isn\u0027t installed in newton images, so install"},{"line_number":103,"context_line":"        # it on upgrade"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_f172b748","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":21},"updated":"2017-02-28 10:49:19.000000000","message":"Should we do this on step2? based on https://review.openstack.org/#/c/438090/ ??\n\nStopped in step2 with the other control plane services??","commit_id":"a6a8972fbc5be2a14423be2501c15f18b1ebe307"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"b2748020245c37f3e86609847a928375cc0ad508","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0"},{"line_number":98,"context_line":"          tags: step0,validation"},{"line_number":99,"context_line":"        - name: Stop panko-api service (running under httpd)"},{"line_number":100,"context_line":"          tags: step1"},{"line_number":101,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":102,"context_line":"        # The panko API isn\u0027t installed in newton images, so install"},{"line_number":103,"context_line":"        # it on upgrade"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_48aa1f1b","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":21},"in_reply_to":"ba2be162_c8c9afae","updated":"2017-02-28 13:25:25.000000000","message":":$ ajaja let me ask folks about that","commit_id":"a6a8972fbc5be2a14423be2501c15f18b1ebe307"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"3f9bc04173e9faa03e9c0b633c2c02fe1801ae77","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0"},{"line_number":98,"context_line":"          tags: step0,validation"},{"line_number":99,"context_line":"        - name: Stop panko-api service (running under httpd)"},{"line_number":100,"context_line":"          tags: step1"},{"line_number":101,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":102,"context_line":"        # The panko API isn\u0027t installed in newton images, so install"},{"line_number":103,"context_line":"        # it on upgrade"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_c8c9afae","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":21},"in_reply_to":"da36d5c6_5825605a","updated":"2017-02-28 13:10:43.000000000","message":"Well if you look at https://review.openstack.org/#/c/438090/5/puppet/services/keystone.yaml httpd is stopped in step1 already for keystone and other httpd based services. So we might as well do the same for panko as its the same httpd?","commit_id":"a6a8972fbc5be2a14423be2501c15f18b1ebe307"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"52ef6a0715381a6ee8a4754d421f8a2dd5d8a25c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0"},{"line_number":98,"context_line":"          tags: step0,validation"},{"line_number":99,"context_line":"        - name: Stop panko-api service (running under httpd)"},{"line_number":100,"context_line":"          tags: step1"},{"line_number":101,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":102,"context_line":"        # The panko API isn\u0027t installed in newton images, so install"},{"line_number":103,"context_line":"        # it on upgrade"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_5825605a","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":21},"in_reply_to":"da36d5c6_bdcd6e5f","updated":"2017-02-28 13:02:41.000000000","message":"Hey Prad, what I mean is if for example a ceilometer agent tries to communicate with panko and apache is not working we will have errors right?, so, I think we need to stop the ceilometer services first (i.e. https://review.openstack.org/#/c/438090/5/puppet/services/ceilometer-agent-compute.yaml) and then stop httpd.\nThe ceilo agents are stopped on step 1 so, we should stop httpd on step2, right?","commit_id":"a6a8972fbc5be2a14423be2501c15f18b1ebe307"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c7eaf8d0340f2e7a94f375c71161e326ebb21c1a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0"},{"line_number":98,"context_line":"          tags: step0,validation"},{"line_number":99,"context_line":"        - name: Stop panko-api service (running under httpd)"},{"line_number":100,"context_line":"          tags: step1"},{"line_number":101,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":102,"context_line":"        # The panko API isn\u0027t installed in newton images, so install"},{"line_number":103,"context_line":"        # it on upgrade"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_bdcd6e5f","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":21},"in_reply_to":"da36d5c6_f172b748","updated":"2017-02-28 12:38:26.000000000","message":"Based on the commit you mentioned this is done in step1, not step2 ? So i think what i have is correct.","commit_id":"a6a8972fbc5be2a14423be2501c15f18b1ebe307"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"3f9bc04173e9faa03e9c0b633c2c02fe1801ae77","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # it on upgrade"},{"line_number":104,"context_line":"        - name: Install openstack-panko-api packages on upgrade"},{"line_number":105,"context_line":"          tags: step3"},{"line_number":106,"context_line":"          yum: name\u003dopenstack-panko-api state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_787224af","line":106,"updated":"2017-02-28 13:10:43.000000000","message":"I also removed these lines. This should only be applicable to Newton -\u003e Ocata as this package will already be in ocata images.","commit_id":"a6a8972fbc5be2a14423be2501c15f18b1ebe307"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b3f7d1db957c95ccc1115db4f3ad4748dc006dbe","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      metadata_settings:"},{"line_number":86,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":87,"context_line":"      upgrade_tasks:"},{"line_number":88,"context_line":"        - name: Check if httpd is deployed"},{"line_number":89,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":90,"context_line":"          tags: step0,validation"},{"line_number":91,"context_line":"          ignore_errors: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba2be162_391eed63","line":88,"updated":"2017-03-01 12:04:58.000000000","message":"sanity check pradk did you really intend to remove the openstack-panko-api package installation, I thought this was required for upgrading newton to ocata? i.e. add these other steps sure, but why remove that step3 for the package update just leave it in no? you had it up to v3 so just sanity checking?","commit_id":"cb6be83c6934818705842b770daa2980feb4ffdb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"84fef177e3732fd50fd56d037dc0911a8b1b57ac","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      metadata_settings:"},{"line_number":86,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":87,"context_line":"      upgrade_tasks:"},{"line_number":88,"context_line":"        - name: Check if httpd is deployed"},{"line_number":89,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":90,"context_line":"          tags: step0,validation"},{"line_number":91,"context_line":"          ignore_errors: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba2be162_d9e23103","line":88,"in_reply_to":"ba2be162_391eed63","updated":"2017-03-01 12:13:34.000000000","message":"Yeahp, indeed we will have issues when backporting this to stable/ocata  (breaking N-\u003eO).\nAs I said before, we can merge this with the package install, backport it to stable/ocata and then in a new submission we can remove the package install in master.","commit_id":"cb6be83c6934818705842b770daa2980feb4ffdb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"e98779bae5d7ae5b46fb2a476f5424090cdc28e9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      metadata_settings:"},{"line_number":86,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":87,"context_line":"      upgrade_tasks:"},{"line_number":88,"context_line":"        - name: Check if httpd is deployed"},{"line_number":89,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":90,"context_line":"          tags: step0,validation"},{"line_number":91,"context_line":"          ignore_errors: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba2be162_05c29a85","line":88,"in_reply_to":"ba2be162_6574369c","updated":"2017-03-01 13:46:14.000000000","message":"Hey, thanks for clarifying that won\u0027t be backported.","commit_id":"cb6be83c6934818705842b770daa2980feb4ffdb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0a300d80ac5eabd4aaa9706256d3cfe86ba05044","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      metadata_settings:"},{"line_number":86,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"},{"line_number":87,"context_line":"      upgrade_tasks:"},{"line_number":88,"context_line":"        - name: Check if httpd is deployed"},{"line_number":89,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":90,"context_line":"          tags: step0,validation"},{"line_number":91,"context_line":"          ignore_errors: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba2be162_6574369c","line":88,"in_reply_to":"ba2be162_d9e23103","updated":"2017-03-01 13:42:19.000000000","message":"so it seems this is not for newton to ocata, but only for ocata to pike... n to o will just get the step3 package install part we are removing here.\n\nin which case fine (i.e. this is not going to be backported carlos)","commit_id":"cb6be83c6934818705842b770daa2980feb4ffdb"}]}