)]}'
{"environments/cinder-netapp-config.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"438865f2e5fa028f032d1b5a91bbcdd3bb0307d5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  CinderNetappStoragePools: \u0027\u0027"},{"line_number":28,"context_line":"  CinderNetappHostType: \u0027\u0027"},{"line_number":29,"context_line":"  CinderNetappWebservicePath: \u0027/devmgr/v2\u0027"},{"line_number":30,"context_line":"  CinderNetappNasSecureFileOperations: false"},{"line_number":31,"context_line":"  CinderNetappNasSecureFilePermissions: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f044301_1e21fbb0","line":30,"updated":"2017-05-10 16:12:38.000000000","message":"should these default to auto as per the default in the templates?","commit_id":"7cfe877f28026283a56596f94c53f35c9537830a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2aad5ff6350d9fdbf99ba8931488ee96a8630cdd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  CinderNetappStoragePools: \u0027\u0027"},{"line_number":28,"context_line":"  CinderNetappHostType: \u0027\u0027"},{"line_number":29,"context_line":"  CinderNetappWebservicePath: \u0027/devmgr/v2\u0027"},{"line_number":30,"context_line":"  CinderNetappNasSecureFileOperations: false"},{"line_number":31,"context_line":"  CinderNetappNasSecureFilePermissions: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f044301_a449d831","line":30,"in_reply_to":"3f044301_1e21fbb0","updated":"2017-05-10 17:19:29.000000000","message":"Actually, the intent is to \"suggest\" they be set false in order to disable the feature. This is because the feature can problematic, and typically requires patching things in the overcloud before it works.","commit_id":"7cfe877f28026283a56596f94c53f35c9537830a"}],"environments/storage-environment.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"438865f2e5fa028f032d1b5a91bbcdd3bb0307d5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  ## For new deployments, \u0027auto\u0027 behaves the same as \u0027true\u0027, otherwise \u0027auto\u0027"},{"line_number":38,"context_line":"  ## behaves the same as \u0027false\u0027. Enabling these features may cause some"},{"line_number":39,"context_line":"  ## cinder operations to fail."},{"line_number":40,"context_line":"  # CinderNasSecureFileOperations: false"},{"line_number":41,"context_line":"  # CinderNasSecureFilePermissions: false"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f044301_7e2c7fab","line":40,"updated":"2017-05-10 16:12:38.000000000","message":"shall we default to auto in the environment file as well?","commit_id":"7cfe877f28026283a56596f94c53f35c9537830a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2aad5ff6350d9fdbf99ba8931488ee96a8630cdd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  ## For new deployments, \u0027auto\u0027 behaves the same as \u0027true\u0027, otherwise \u0027auto\u0027"},{"line_number":38,"context_line":"  ## behaves the same as \u0027false\u0027. Enabling these features may cause some"},{"line_number":39,"context_line":"  ## cinder operations to fail."},{"line_number":40,"context_line":"  # CinderNasSecureFileOperations: false"},{"line_number":41,"context_line":"  # CinderNasSecureFilePermissions: false"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f044301_040d2ce7","line":40,"in_reply_to":"3f044301_7e2c7fab","updated":"2017-05-10 17:19:29.000000000","message":"As the comment hints, the suggestion is to disable the feature because it can be problematic. See my comment in the other file.","commit_id":"7cfe877f28026283a56596f94c53f35c9537830a"}],"puppet/services/cinder-backend-netapp.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"04c2c601b80da6da9231e1e1b4f4693f03da5cbd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    default: \u0027/devmgr/v2\u0027"},{"line_number":74,"context_line":"  CinderNetappNasSecureFileOperations:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \u0027auto\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027auto\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f044301_6dc73366","line":76,"updated":"2017-05-10 20:22:46.000000000","message":"should this default to false, as the environment file?","commit_id":"6aef00596a8085db4d9ecc513254aa841a91aa38"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2e6b273cc7cf2d6a611993d0693981e77a33f2d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    default: \u0027/devmgr/v2\u0027"},{"line_number":74,"context_line":"  CinderNetappNasSecureFileOperations:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \u0027auto\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027auto\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f013ff3_6a668754","line":76,"in_reply_to":"3f044301_6dc73366","updated":"2017-05-12 18:52:37.000000000","message":"Done","commit_id":"6aef00596a8085db4d9ecc513254aa841a91aa38"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"04c2c601b80da6da9231e1e1b4f4693f03da5cbd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    default: \u0027auto\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027auto\u0027"},{"line_number":80,"context_line":"  # DEPRECATED options for compatibility with older versions"},{"line_number":81,"context_line":"  CinderNetappEseriesHostType:"},{"line_number":82,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f044301_4dc4775f","line":79,"updated":"2017-05-10 20:22:46.000000000","message":"this too","commit_id":"6aef00596a8085db4d9ecc513254aa841a91aa38"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2e6b273cc7cf2d6a611993d0693981e77a33f2d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    default: \u0027auto\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027auto\u0027"},{"line_number":80,"context_line":"  # DEPRECATED options for compatibility with older versions"},{"line_number":81,"context_line":"  CinderNetappEseriesHostType:"},{"line_number":82,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f013ff3_4a5bcb86","line":79,"in_reply_to":"3f044301_4dc4775f","updated":"2017-05-12 18:52:37.000000000","message":"Done","commit_id":"6aef00596a8085db4d9ecc513254aa841a91aa38"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"902789b3d6a7d49fd8d64db74e0ad62ffcb0c84b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    type: string"},{"line_number":73,"context_line":"    default: \u0027/devmgr/v2\u0027"},{"line_number":74,"context_line":"  CinderNetappNasSecureFileOperations:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \u0027false\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_abf73d8b","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":16},"updated":"2017-06-05 04:46:44.000000000","message":"Why not take it as boolean instead of string, as per puppet code, it takes True or False?\n\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/backend/nfs.pp#L52","commit_id":"f3327736c363c589a0dd28f3bf25b2523a0b0829"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"14835b409e7e79a7629c3c35f42d1a64bfa29fb4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    type: string"},{"line_number":73,"context_line":"    default: \u0027/devmgr/v2\u0027"},{"line_number":74,"context_line":"  CinderNetappNasSecureFileOperations:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \u0027false\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_7fb9da12","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":16},"in_reply_to":"df140735_abf73d8b","updated":"2017-06-05 11:43:46.000000000","message":"It\u0027s actually not a boolean (see https://github.com/openstack/puppet-cinder/blob/master/manifests/backend/nfs.pp#L56-57)\n\nThese are existing Cinder settings, and all I\u0027m doing is wiring them up. Per the prevalent convention, the puppet-cinder comment matches a corresponding comment in the cinder code.","commit_id":"f3327736c363c589a0dd28f3bf25b2523a0b0829"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9fb1253dc42388d38206b435503cc5d252b878a7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    default: \u0027/devmgr/v2\u0027"},{"line_number":74,"context_line":"  CinderNetappNasSecureFileOperations:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \u0027false\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027false\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f013ff3_154a8426","line":76,"updated":"2017-05-12 19:31:16.000000000","message":"quotes shouldn\u0027t hurt but are not needed","commit_id":"f3327736c363c589a0dd28f3bf25b2523a0b0829"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f68f2e257c4e1c658795de9dd1960e6262b4b1ce","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    default: \u0027/devmgr/v2\u0027"},{"line_number":74,"context_line":"  CinderNetappNasSecureFileOperations:"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"    default: \u0027false\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027false\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f013ff3_75c0a851","line":76,"in_reply_to":"1f013ff3_154a8426","updated":"2017-05-12 19:43:25.000000000","message":"I chose to leave them in this file (but removed them from the other file) because all the other strings in this file are quoted. I felt consistency within the file was warranted, but can remove them if you prefer.\n\nI could also remove the rest of the unnecessary quotes from this file, but that seems like a lot of churn.","commit_id":"f3327736c363c589a0dd28f3bf25b2523a0b0829"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9fb1253dc42388d38206b435503cc5d252b878a7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    default: \u0027false\u0027"},{"line_number":77,"context_line":"  CinderNetappNasSecureFilePermissions:"},{"line_number":78,"context_line":"    type: string"},{"line_number":79,"context_line":"    default: \u0027false\u0027"},{"line_number":80,"context_line":"  # DEPRECATED options for compatibility with older versions"},{"line_number":81,"context_line":"  CinderNetappEseriesHostType:"},{"line_number":82,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f013ff3_f546f821","line":79,"updated":"2017-05-12 19:31:16.000000000","message":"same","commit_id":"f3327736c363c589a0dd28f3bf25b2523a0b0829"}],"puppet/services/cinder-volume.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"438865f2e5fa028f032d1b5a91bbcdd3bb0307d5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      CinderEnableNfsBackend is true."},{"line_number":42,"context_line":"    type: comma_delimited_list"},{"line_number":43,"context_line":"  CinderNasSecureFileOperations:"},{"line_number":44,"context_line":"    default: \u0027auto\u0027"},{"line_number":45,"context_line":"    description: \u003e"},{"line_number":46,"context_line":"      Controls whether security enhanced NFS file operations are enabled."},{"line_number":47,"context_line":"      Valid values are \u0027auto\u0027, \u0027true\u0027 or \u0027false\u0027. Effective when"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f044301_9e5e2b42","line":44,"updated":"2017-05-10 16:12:38.000000000","message":"this shouldn\u0027t need quotes","commit_id":"7cfe877f28026283a56596f94c53f35c9537830a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2aad5ff6350d9fdbf99ba8931488ee96a8630cdd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      CinderEnableNfsBackend is true."},{"line_number":42,"context_line":"    type: comma_delimited_list"},{"line_number":43,"context_line":"  CinderNasSecureFileOperations:"},{"line_number":44,"context_line":"    default: \u0027auto\u0027"},{"line_number":45,"context_line":"    description: \u003e"},{"line_number":46,"context_line":"      Controls whether security enhanced NFS file operations are enabled."},{"line_number":47,"context_line":"      Valid values are \u0027auto\u0027, \u0027true\u0027 or \u0027false\u0027. Effective when"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f044301_c423c455","line":44,"in_reply_to":"3f044301_9e5e2b42","updated":"2017-05-10 17:19:29.000000000","message":"Done","commit_id":"7cfe877f28026283a56596f94c53f35c9537830a"}]}