)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"333b2ab52cb9fa5511bdd4223ead6a00dfa2a618","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  service_workflow_tasks:"},{"line_number":16,"context_line":"    step2:"},{"line_number":17,"context_line":"      name: my_action_name"},{"line_number":18,"context_line":"      action: std.echo"},{"line_number":19,"context_line":"      input:"},{"line_number":20,"context_line":"        output: \u0027hello world\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_8144bcb8","line":17,"updated":"2017-05-08 13:18:03.000000000","message":"this is supposed to be a list actually, so the example should be\"\n\n  step2:\n    - name: my_action_name\n      action: std.echo\n      input:\n        output: \u0027helo world\u0027\n    - name: another_action\n      ...","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"}],"docker/docker-steps.j2":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"32fb2a84b28ff851044b2d3fda89aa3729666700","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    depends_on:"},{"line_number":331,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":332,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":333,"context_line":"    {% for role in roles %}"},{"line_number":334,"context_line":"      - {{role.name}}PreConfig"},{"line_number":335,"context_line":"      - {{role.name}}ArtifactsDeploy"},{"line_number":336,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f044301_7c48e385","line":333,"updated":"2017-05-12 13:32:20.000000000","message":"Could be \u0027for dep in roles\u0027 to follow the pattern below, and distinguish from the already set \u0027role\u0027 variable. (I hope jinja2 variable scoping is strict and won\u0027t mangle the role variable defined outside the cycle. Do you know if that\u0027s the case?)","commit_id":"f7ccc1433507e8c7bfbc31ff82d578b2332d1cdc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3b00efdc9a0129349ff73ac4dac54be15d8fb6a8","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    depends_on:"},{"line_number":331,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":332,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":333,"context_line":"    {% for role in roles %}"},{"line_number":334,"context_line":"      - {{role.name}}PreConfig"},{"line_number":335,"context_line":"      - {{role.name}}ArtifactsDeploy"},{"line_number":336,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f013ff3_5ed6f151","line":333,"in_reply_to":"1f013ff3_db6573e3","updated":"2017-05-12 14:57:04.000000000","message":"yeah no worries I\u0027ll change this anyway as there seems to be a syntax issue with the new patchset","commit_id":"f7ccc1433507e8c7bfbc31ff82d578b2332d1cdc"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"1e7337461758b0165c57ed511392e46113ac0e13","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    depends_on:"},{"line_number":331,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":332,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":333,"context_line":"    {% for role in roles %}"},{"line_number":334,"context_line":"      - {{role.name}}PreConfig"},{"line_number":335,"context_line":"      - {{role.name}}ArtifactsDeploy"},{"line_number":336,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f013ff3_db6573e3","line":333,"in_reply_to":"3f044301_7c48e385","updated":"2017-05-12 13:46:30.000000000","message":"Just to clarify -- i don\u0027t think of this as a blocker, if we\u0027re sure that the shadowing will work fine (without writing into the outer variable).","commit_id":"f7ccc1433507e8c7bfbc31ff82d578b2332d1cdc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7f96f614effa0709c272ffe8fa18a7109327653","unresolved":false,"context_lines":[{"line_number":328,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":329,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":330,"context_line":"    depends_on:"},{"line_number":331,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":332,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":333,"context_line":"    {% for dep in roles %}"},{"line_number":334,"context_line":"      - {{dep.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1f013ff3_07c92c77","line":331,"range":{"start_line":331,"start_character":8,"end_line":331,"end_character":26},"updated":"2017-05-15 07:40:59.000000000","message":"o/ this depends on the WorkflowTasks_Step{{step}} resource above (which I assume is the \u0027config\u0027 resource? My point is do you actually want to depend on the WorkflowTasks_Step{{step}}_Execution\n\nalso do you need the conditional here in case the WorkflowTasks_Step isn\u0027t defined?","commit_id":"82590da36480199669b9c8823a67adb63f133ec9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c6d1b8343b7f4ecb2df3515fa18404a3e5a14a40","unresolved":false,"context_lines":[{"line_number":328,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":329,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":330,"context_line":"    depends_on:"},{"line_number":331,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":332,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":333,"context_line":"    {% for dep in roles %}"},{"line_number":334,"context_line":"      - {{dep.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1f013ff3_13ff0435","line":331,"range":{"start_line":331,"start_character":8,"end_line":331,"end_character":26},"in_reply_to":"1f013ff3_07c92c77","updated":"2017-05-16 13:02:56.000000000","message":"right it should depend on the Execution resource, thanks!","commit_id":"82590da36480199669b9c8823a67adb63f133ec9"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"3cf42d7718fcfd5f37f45e74b23f3570ab76af6f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"conditions:"},{"line_number":43,"context_line":"{% for step in range(1, 6) %}"},{"line_number":44,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":45,"context_line":"    or:"},{"line_number":46,"context_line":"    {% for role in roles %}"},{"line_number":47,"context_line":"      - not:"},{"line_number":48,"context_line":"          equals:"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f201791_85976991","line":45,"range":{"start_line":45,"start_character":6,"end_line":45,"end_character":7},"updated":"2017-06-21 14:37:25.000000000","message":"The undercloud containers job is failing, I think it\u0027s because it only renders the templates for a single role which means this or fails validation?","commit_id":"1a9b91319994d3e16e0a9f2765b39ad2e61ca929"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c178d9f1e015cbb7050833d06423af10d1c3c486","unresolved":false,"context_lines":[{"line_number":42,"context_line":"conditions:"},{"line_number":43,"context_line":"{% for step in range(1, 6) %}"},{"line_number":44,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":45,"context_line":"    or:"},{"line_number":46,"context_line":"    {% for role in roles %}"},{"line_number":47,"context_line":"      - not:"},{"line_number":48,"context_line":"          equals:"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f201791_b69dfd5a","line":45,"range":{"start_line":45,"start_character":6,"end_line":45,"end_character":7},"in_reply_to":"5f201791_85976991","updated":"2017-06-21 16:13:37.000000000","message":"sorry I rebased this and missed the outer loop on roles, thanks!","commit_id":"1a9b91319994d3e16e0a9f2765b39ad2e61ca929"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"180abe00a5e7d7937a1d14d5c9c1822cb576b970","unresolved":false,"context_lines":[{"line_number":42,"context_line":"conditions:"},{"line_number":43,"context_line":"{% for step in range(1, 6) %}"},{"line_number":44,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":45,"context_line":"    or:"},{"line_number":46,"context_line":"    {% for role in roles %}"},{"line_number":47,"context_line":"      - not:"},{"line_number":48,"context_line":"          equals:"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f201791_5680e98b","line":45,"range":{"start_line":45,"start_character":6,"end_line":45,"end_character":7},"in_reply_to":"5f201791_b69dfd5a","updated":"2017-06-21 16:24:07.000000000","message":"sorry I misread the initial comment, I guess I can add a fake false item to the or: list ?","commit_id":"1a9b91319994d3e16e0a9f2765b39ad2e61ca929"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"82f8992539fd307d7c4b47d18df19c054ec038ad","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    type: json"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"conditions:"},{"line_number":43,"context_line":"{% for step in range(1, 6) %}"},{"line_number":44,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":45,"context_line":"    or:"},{"line_number":46,"context_line":"    {% for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"5f201791_08f57c83","line":43,"range":{"start_line":43,"start_character":3,"end_line":43,"end_character":26},"updated":"2017-06-23 00:06:34.000000000","message":"Can this be \"for step in range(1, deploy_steps_max)\"? Or is there some other way to avoid hardcoding the number of steps here?","commit_id":"64862cc0453cfcab09e72a21cd49a8ae72036bf1"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"a4b5f4941f47c468ead62593325ac4e8c6de9da7","unresolved":false,"context_lines":[{"line_number":260,"context_line":"      - {{dep.name}}ArtifactsDeploy"},{"line_number":261,"context_line":"    {% endfor %}"},{"line_number":262,"context_line":"    {% else %}"},{"line_number":263,"context_line":"    {% for dep in roles %}"},{"line_number":264,"context_line":"      - {{dep.name}}Deployment_Step{{step -1}}"},{"line_number":265,"context_line":"    {% endfor %}"},{"line_number":266,"context_line":"    {% endif %}"},{"line_number":267,"context_line":"    properties:"},{"line_number":268,"context_line":"      name: {{role.name}}Deployment_Step{{step}}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f201791_39917948","line":265,"range":{"start_line":263,"start_character":4,"end_line":265,"end_character":16},"updated":"2017-06-26 07:57:24.000000000","message":"WorkflowTasks_Step{{step}}_Execution depends_on {{dep.name}}Deployment_Step{{step -1}} so I think you can remove this dependency here - it\u0027s redundant now?","commit_id":"47af8a1b1df580150caae706eab44fb8fe71d2ad"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6077c74a7cd7c466207314074ddf3e34fce90bed","unresolved":false,"context_lines":[{"line_number":260,"context_line":"      - {{dep.name}}ArtifactsDeploy"},{"line_number":261,"context_line":"    {% endfor %}"},{"line_number":262,"context_line":"    {% else %}"},{"line_number":263,"context_line":"    {% for dep in roles %}"},{"line_number":264,"context_line":"      - {{dep.name}}Deployment_Step{{step -1}}"},{"line_number":265,"context_line":"    {% endfor %}"},{"line_number":266,"context_line":"    {% endif %}"},{"line_number":267,"context_line":"    properties:"},{"line_number":268,"context_line":"      name: {{role.name}}Deployment_Step{{step}}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f201791_823a52c9","line":265,"range":{"start_line":263,"start_character":4,"end_line":265,"end_character":16},"in_reply_to":"5f201791_39917948","updated":"2017-06-26 09:14:33.000000000","message":"right and I think the deps on PreConfig and ArtifactsDeploy are redundant as well, for the same reason","commit_id":"47af8a1b1df580150caae706eab44fb8fe71d2ad"}],"puppet/post.j2.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"32fb2a84b28ff851044b2d3fda89aa3729666700","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      Setting this to a unique value will re-run any deployment tasks which"},{"line_number":25,"context_line":"      perform configuration on a Heat stack-update."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"resources:"},{"line_number":28,"context_line":"{% include \u0027puppet-steps.j2\u0027 %}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f044301_bcc42bf6","side":"PARENT","line":27,"updated":"2017-05-12 13:32:20.000000000","message":"haha","commit_id":"5fc8d234dd962b641c4daeae241b98c63f3fa84d"}],"puppet/puppet-steps.j2":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c07f07821a1e4ac1da165225e585707a7b86e014","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":29,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":30,"context_line":"    depends_on:"},{"line_number":31,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":32,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":33,"context_line":"    {% for role in roles %}"},{"line_number":34,"context_line":"      - {{role.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f044301_a12218ff","line":31,"updated":"2017-05-08 13:19:05.000000000","message":"purpose is to run the puppet steps *after* the workflow; should they run together?","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8db766e2f01db5dd81ae3a60fd8fe3b8028732cb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":29,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":30,"context_line":"    depends_on:"},{"line_number":31,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":32,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":33,"context_line":"    {% for role in roles %}"},{"line_number":34,"context_line":"      - {{role.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f044301_11f1c895","line":31,"in_reply_to":"3f044301_36728cae","updated":"2017-05-12 12:17:00.000000000","message":"ack, same situation but I haven\u0027t hit that when testing locally ... I think CI itself should be testing this as we don\u0027t have services populating service_workflow_tasks in this submission","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ecd2c355953d679b7672ae3db72ffacc89d3ad69","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":29,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":30,"context_line":"    depends_on:"},{"line_number":31,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":32,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":33,"context_line":"    {% for role in roles %}"},{"line_number":34,"context_line":"      - {{role.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f044301_36728cae","line":31,"in_reply_to":"3f044301_a12218ff","updated":"2017-05-11 12:12:29.000000000","message":"I think strict ordering is good here. Assuming the workflows and puppet steps can both read and write machine state and they are both pluggable interfaces meant to be performing software configuration tasks, they\u0027d better not run at the same time :)\n\nI wonder if we hit the depends_on+conditionals bug here haha :))","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ecd2c355953d679b7672ae3db72ffacc89d3ad69","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      always_update: true"},{"line_number":112,"context_line":"{% endfor %}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"conditions:"},{"line_number":115,"context_line":"{% for step in range(1, 6) %}"},{"line_number":116,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":117,"context_line":"    or:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f044301_16c79098","line":114,"updated":"2017-05-11 12:12:29.000000000","message":"nit: i\u0027d move the condition section between the parameters and resources sections, which seems to be becoming a convention (at least from what i\u0027ve observed)","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8db766e2f01db5dd81ae3a60fd8fe3b8028732cb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      always_update: true"},{"line_number":112,"context_line":"{% endfor %}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"conditions:"},{"line_number":115,"context_line":"{% for step in range(1, 6) %}"},{"line_number":116,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":117,"context_line":"    or:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f044301_b137b4ff","line":114,"in_reply_to":"3f044301_16c79098","updated":"2017-05-12 12:17:00.000000000","message":"will do","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"32fb2a84b28ff851044b2d3fda89aa3729666700","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    depends_on:"},{"line_number":44,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":45,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":46,"context_line":"    {% for role in roles %}"},{"line_number":47,"context_line":"      - {{role.name}}PreConfig"},{"line_number":48,"context_line":"      - {{role.name}}ArtifactsDeploy"},{"line_number":49,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f044301_dc1b777e","line":46,"updated":"2017-05-12 13:32:20.000000000","message":"ditto i just noticed this... i think the \u0027for dep in role\u0027 was a bit better","commit_id":"f7ccc1433507e8c7bfbc31ff82d578b2332d1cdc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7f96f614effa0709c272ffe8fa18a7109327653","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":42,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":43,"context_line":"    depends_on:"},{"line_number":44,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":45,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":46,"context_line":"    {% for dep in roles %}"},{"line_number":47,"context_line":"      - {{dep.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1f013ff3_6704707c","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":26},"updated":"2017-05-15 07:40:59.000000000","message":"is it ok that the WorkflowTasks_Step resources are defined after this declaration - also do you need the conditional here (what if there are no tasks enabled)","commit_id":"82590da36480199669b9c8823a67adb63f133ec9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c6d1b8343b7f4ecb2df3515fa18404a3e5a14a40","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":42,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":43,"context_line":"    depends_on:"},{"line_number":44,"context_line":"      - WorkflowTasks_Step{{step}}"},{"line_number":45,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":46,"context_line":"    {% for dep in roles %}"},{"line_number":47,"context_line":"      - {{dep.name}}PreConfig"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1f013ff3_53bb4c71","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":26},"in_reply_to":"1f013ff3_6704707c","updated":"2017-05-16 13:02:56.000000000","message":"it should be okay to depend on resources conditionally disabled, but this should depend on _Execution as well","commit_id":"82590da36480199669b9c8823a67adb63f133ec9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5717f8169be0b51ec4f6723d26aa2864a45138fe","unresolved":false,"context_lines":[{"line_number":89,"context_line":"{% for step in range(1, 6) %}"},{"line_number":90,"context_line":"  WorkflowTasks_Step{{step}}:"},{"line_number":91,"context_line":"    type: OS::Mistral::Workflow"},{"line_number":92,"context_line":"    condition: WorkflowTasks_Step{{step}}_Enabled"},{"line_number":93,"context_line":"    depends_on:"},{"line_number":94,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":95,"context_line":"    {% for dep in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ff0f0b1f_94332363","line":92,"updated":"2017-05-26 11:38:10.000000000","message":"fwiw this only creates the workflow for a given deployment step if there is any service needing to run something on that step","commit_id":"af07f954837641d02d1d5b4839f16ef530b23836"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"82f8992539fd307d7c4b47d18df19c054ec038ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"conditions:"},{"line_number":2,"context_line":"{% for step in range(1, 6) %}"},{"line_number":3,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":4,"context_line":"    or:"},{"line_number":5,"context_line":"    {% for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"5f201791_88e06cce","line":2,"range":{"start_line":2,"start_character":24,"end_line":2,"end_character":25},"updated":"2017-06-23 00:06:34.000000000","message":"It seems like a red flag that this is hardcoded in multiple spots. Is it set in stone that there will only ever be steps 1-5? Otherwise, is there a way to introspect the max number of steps?","commit_id":"64862cc0453cfcab09e72a21cd49a8ae72036bf1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4367752ea896c1b7ed0de7fc8c4e8dabbf024499","unresolved":false,"context_lines":[{"line_number":1,"context_line":"conditions:"},{"line_number":2,"context_line":"{% for step in range(1, 6) %}"},{"line_number":3,"context_line":"  WorkflowTasks_Step{{step}}_Enabled:"},{"line_number":4,"context_line":"    or:"},{"line_number":5,"context_line":"    {% for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"5f201791_5b933750","line":2,"range":{"start_line":2,"start_character":24,"end_line":2,"end_character":25},"in_reply_to":"5f201791_88e06cce","updated":"2017-06-23 08:30:51.000000000","message":"ack, will do","commit_id":"64862cc0453cfcab09e72a21cd49a8ae72036bf1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3725f9e3a4abe6df620c11a751f94a77a89d5477","unresolved":false,"context_lines":[{"line_number":43,"context_line":"{% for step in range(1, deploy_steps_max) %}"},{"line_number":44,"context_line":"  {{role.name}}Deployment_Step{{step}}:"},{"line_number":45,"context_line":"    type: OS::Heat::StructuredDeploymentGroup"},{"line_number":46,"context_line":"    depends_on:"},{"line_number":47,"context_line":"      - WorkflowTasks_Step{{step}}_Execution"},{"line_number":48,"context_line":"    {% if step \u003d\u003d 1 %}"},{"line_number":49,"context_line":"    {% for dep in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f201791_f9b30109","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":14},"updated":"2017-06-26 07:54:45.000000000","message":"so actually a given step N workflow will be executed before the step N puppet config and just noticed is same at https://review.openstack.org/#/c/463324/12/docker/docker-steps.j2@255 (probably worth highlighting in the release note)\n\nEDIT: nm i see you already did","commit_id":"47af8a1b1df580150caae706eab44fb8fe71d2ad"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"a4b5f4941f47c468ead62593325ac4e8c6de9da7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      - {{dep.name}}ArtifactsDeploy"},{"line_number":52,"context_line":"    {% endfor %}"},{"line_number":53,"context_line":"    {% else %}"},{"line_number":54,"context_line":"    {% for dep in roles %}"},{"line_number":55,"context_line":"      - {{dep.name}}Deployment_Step{{step -1}}"},{"line_number":56,"context_line":"    {% endfor %}"},{"line_number":57,"context_line":"    {% endif %}"},{"line_number":58,"context_line":"    properties:"},{"line_number":59,"context_line":"      name: {{role.name}}Deployment_Step{{step}}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f201791_79aa5171","line":56,"range":{"start_line":54,"start_character":3,"end_line":56,"end_character":16},"updated":"2017-06-26 07:57:24.000000000","message":"As in docker_steps I think this dependency is now redundant, because it\u0027s covered via WorkflowTasks_Step*_Execution?","commit_id":"47af8a1b1df580150caae706eab44fb8fe71d2ad"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9de81aebe93945d9341e6339767c9d593f852460","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      - {{dep.name}}ArtifactsDeploy"},{"line_number":52,"context_line":"    {% endfor %}"},{"line_number":53,"context_line":"    {% else %}"},{"line_number":54,"context_line":"    {% for dep in roles %}"},{"line_number":55,"context_line":"      - {{dep.name}}Deployment_Step{{step -1}}"},{"line_number":56,"context_line":"    {% endfor %}"},{"line_number":57,"context_line":"    {% endif %}"},{"line_number":58,"context_line":"    properties:"},{"line_number":59,"context_line":"      name: {{role.name}}Deployment_Step{{step}}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f201791_e738f8ee","line":56,"range":{"start_line":54,"start_character":3,"end_line":56,"end_character":16},"in_reply_to":"5f201791_79aa5171","updated":"2017-06-26 09:11:41.000000000","message":"yep","commit_id":"47af8a1b1df580150caae706eab44fb8fe71d2ad"}],"puppet/services/README.rst":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ecd2c355953d679b7672ae3db72ffacc89d3ad69","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"It is also possible to use Mistral actions or workflows during a"},{"line_number":66,"context_line":"deployment step, these are executed before puppet apply. To describe"},{"line_number":67,"context_line":"actions or workflows from within a service use:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * service_workflow_tasks"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_b62fbc86","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":20},"updated":"2017-05-11 12:12:29.000000000","message":"I see the inline tasks example below, but is it possible to trigger a predefined workflow this way somehow too? I\u0027m not deeply familiar with Mistral sorry...","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8db766e2f01db5dd81ae3a60fd8fe3b8028732cb","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"It is also possible to use Mistral actions or workflows during a"},{"line_number":66,"context_line":"deployment step, these are executed before puppet apply. To describe"},{"line_number":67,"context_line":"actions or workflows from within a service use:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * service_workflow_tasks"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_91115860","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":20},"in_reply_to":"3f044301_b62fbc86","updated":"2017-05-12 12:17:00.000000000","message":"yes OS::Mistral::Workflow tasks map accepts a \"workflow\" key and that can be pointed to a pre-existing workflow","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e78521e8d29143cbd3dd6e7243647c0672b36700","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  service_workflow_tasks:"},{"line_number":75,"context_line":"    step2:"},{"line_number":76,"context_line":"      name: echo"},{"line_number":77,"context_line":"      action: std.echo output\u003dHello"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Batch Upgrade Steps"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_e16dc032","line":76,"updated":"2017-05-08 13:20:33.000000000","message":"this should be a list ...","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8db766e2f01db5dd81ae3a60fd8fe3b8028732cb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  service_workflow_tasks:"},{"line_number":75,"context_line":"    step2:"},{"line_number":76,"context_line":"      name: echo"},{"line_number":77,"context_line":"      action: std.echo output\u003dHello"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Batch Upgrade Steps"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_7116cc57","line":76,"in_reply_to":"3f044301_e16dc032","updated":"2017-05-12 12:17:00.000000000","message":"will add a workflow example","commit_id":"5fcc1bc63b9e32532056222deec95d7df2c1aec7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"32fb2a84b28ff851044b2d3fda89aa3729666700","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        action: std.echo output\u003dHello"},{"line_number":78,"context_line":"    step3:"},{"line_number":79,"context_line":"      - name: external"},{"line_number":80,"context_line":"        workflow: my-pre-existing-workflow-name"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Batch Upgrade Steps"},{"line_number":83,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f044301_fc019307","line":80,"updated":"2017-05-12 13:32:20.000000000","message":"Nice, thanks!","commit_id":"f7ccc1433507e8c7bfbc31ff82d578b2332d1cdc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3b00efdc9a0129349ff73ac4dac54be15d8fb6a8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        action: std.echo output\u003dHello"},{"line_number":78,"context_line":"    step3:"},{"line_number":79,"context_line":"      - name: external"},{"line_number":80,"context_line":"        workflow: my-pre-existing-workflow-name"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Batch Upgrade Steps"},{"line_number":83,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f013ff3_3e0e85e5","line":80,"in_reply_to":"3f044301_fc019307","updated":"2017-05-12 14:57:04.000000000","message":"actually I will add inputs too","commit_id":"f7ccc1433507e8c7bfbc31ff82d578b2332d1cdc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7f96f614effa0709c272ffe8fa18a7109327653","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   5) Service activation (Pacemaker)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"It is also possible to use Mistral actions or workflows together with"},{"line_number":66,"context_line":"a deployment step, these are executed before puppet apply. To describe"},{"line_number":67,"context_line":"actions or workflows from within a service use:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * service_workflow_tasks: One or more workflow task properties"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f013ff3_a71838d3","line":66,"range":{"start_line":66,"start_character":45,"end_line":66,"end_character":57},"updated":"2017-05-15 07:40:59.000000000","message":"the main configuration run - puppet or docker run maybe \"deployment step\" as in your release note","commit_id":"82590da36480199669b9c8823a67adb63f133ec9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c6d1b8343b7f4ecb2df3515fa18404a3e5a14a40","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   5) Service activation (Pacemaker)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"It is also possible to use Mistral actions or workflows together with"},{"line_number":66,"context_line":"a deployment step, these are executed before puppet apply. To describe"},{"line_number":67,"context_line":"actions or workflows from within a service use:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * service_workflow_tasks: One or more workflow task properties"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f013ff3_f3ab781a","line":66,"range":{"start_line":66,"start_character":45,"end_line":66,"end_character":57},"in_reply_to":"1f013ff3_a71838d3","updated":"2017-05-16 13:02:56.000000000","message":"ack thanks","commit_id":"82590da36480199669b9c8823a67adb63f133ec9"}],"puppet/services/services.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a1d9efa2830187f5a53d66bf706c218fdf87868a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        yaql:"},{"line_number":116,"context_line":"          expression: $.data.role_data.where($ !\u003d null).select($.get(\u0027service_config_settings\u0027)).where($ !\u003d null).reduce($1.mergeWith($2), {})"},{"line_number":117,"context_line":"          data: {role_data: {get_attr: [ServiceChain, role_data]}}"},{"line_number":118,"context_line":"      service_workflow_tasks:"},{"line_number":119,"context_line":"        yaql:"},{"line_number":120,"context_line":"          expression: $.data.role_data.where($ !\u003d null).select($.get(\u0027service_workflow_tasks\u0027)).where($ !\u003d null).reduce($1.mergeWith($2), {})"},{"line_number":121,"context_line":"          data: {role_data: {get_attr: [ServiceChain, role_data]}}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff0f0b1f_d5452b45","line":118,"updated":"2017-05-25 21:41:34.000000000","message":"sorry this misses its counterpart in docker/services/services.yaml","commit_id":"ff18b1372d68bd17b631b5232ee3d5969bf320ac"}]}