)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f2a34142370b7b061d7c3898b04f16a3c75963d7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add novajoin puppet/docker service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds the relevant templates to enable novajoin in a containerized"},{"line_number":10,"context_line":"undercloud environment. Note that this is not meant for the overcloud"},{"line_number":11,"context_line":"(yet), and since there are several limitations that need to be addressed"},{"line_number":12,"context_line":"first. So, given this, we set up novajoin to be accessed directly and"},{"line_number":13,"context_line":"not via a load balancer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f231b9d_1f1b5d81","line":10,"range":{"start_line":9,"start_character":59,"end_line":10,"end_character":17},"updated":"2017-06-14 07:47:50.000000000","message":"maybe worth a release note to explain this doesn\u0027t work for overcloud.\n\nI asked before but maybe you missed it - do you want this in the undercloud roles_data or rather now probably in the new roles/Undercloud.yaml?","commit_id":"be91ac360038b691852c776d2320417aa50bfe9a"}],"docker/services/novajoin.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9d61437428f5916ce177e42612c2d5fccdd62210","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            path: /var/log/containers/novajoin_notifier"},{"line_number":150,"context_line":"            state: directory"},{"line_number":151,"context_line":"        - name: Request kerberos keytab"},{"line_number":152,"context_line":"          command: /usr/bin/kinit -kt /etc/krb5.keytab \u0026\u0026 ipa-getkeytab -s $(grep xmlrpc_uri /etc/ipa/default.conf  | cut -d/ -f3) -p nova/{{ ansible_nodename }} -k /etc/nova/krb5.keytab\""},{"line_number":153,"context_line":"      upgrade_tasks:"},{"line_number":154,"context_line":"        - name: Stop and disable novajoin-server service"},{"line_number":155,"context_line":"          tags: step2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_6409c693","line":152,"updated":"2017-05-31 15:30:06.000000000","message":"this needs to be shell, not command.","commit_id":"1cffda0689ac278d786ed0cc89bbf9ca817cef50"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f2a34142370b7b061d7c3898b04f16a3c75963d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: pike"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized novajoin service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  DockerNamespace:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f231b9d_9f252dc5","line":4,"range":{"start_line":4,"start_character":2,"end_line":4,"end_character":11},"updated":"2017-06-14 07:47:50.000000000","message":"note: undercloud only for now (or at least not ready for overcloud yet)","commit_id":"be91ac360038b691852c776d2320417aa50bfe9a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"cbbc5ab3ae78ee4de4d278733255f8c381a1d3e9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                - \u0027/\u0027"},{"line_number":91,"context_line":"                - [ {get_param: DockerNamespace}, {get_param: DockerNovajoinServerImage} ]"},{"line_number":92,"context_line":"            user: root"},{"line_number":93,"context_line":"            command: [\u0027/bin/bash\u0027, \u0027-c\u0027, \u0027mkdir -p /var/log/novajoin\u0027]"},{"line_number":94,"context_line":"            volumes:"},{"line_number":95,"context_line":"              - /var/log/containers/novajoin_server:/var/log/novajoin"},{"line_number":96,"context_line":"          novajoin_notifier_init_log:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff346bd7_86f4b3d0","line":93,"range":{"start_line":93,"start_character":42,"end_line":93,"end_character":68},"updated":"2017-07-26 00:04:37.000000000","message":"is this necessary? looks like the host_prep_task below will create the directory","commit_id":"be91ac360038b691852c776d2320417aa50bfe9a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5d00052316b0fea16e6cd7cc8561375ec47cb26b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: pike"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized novajoin service"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_b396ceef","line":1,"updated":"2018-03-14 10:44:31.000000000","message":"rocky or queens?","commit_id":"ff7c3e456f1507cbfe95c806745bc14f110041b5"}],"puppet/services/novajoin.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f2a34142370b7b061d7c3898b04f16a3c75963d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: pike"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack Novajoin vendordata service configured with Puppet"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  ServiceNetMap:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f231b9d_df46057d","line":4,"updated":"2017-06-14 07:47:50.000000000","message":"do you want to add a note here that this is not yet tested with overcloud and probably wouldn\u0027t work yet","commit_id":"be91ac360038b691852c776d2320417aa50bfe9a"}]}