)]}'
{"docker/services/manila-share.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cfa895c0b5e85f2e1694186d70e02a1a57b91cd5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"               - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":99,"context_line":"               - /etc/hosts:/etc/hosts:ro"},{"line_number":100,"context_line":"               - /etc/localtime:/etc/localtime:ro"},{"line_number":101,"context_line":"               - /var/log/containers/manila:/var/log/manila"},{"line_number":102,"context_line":"            environment:"},{"line_number":103,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":104,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_72b96a2c","line":101,"updated":"2017-07-03 19:22:10.000000000","message":"can you add:\n\n  - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible","commit_id":"b860af0eb3fd554d1523540e3d70bff5883ecbf8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"44467d378b822269808bbe82a622f5806f772d0d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            volumes:"},{"line_number":91,"context_line":"               - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":92,"context_line":"               - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":93,"context_line":"               - /etc/hosts:/etc/hosts:ro"},{"line_number":94,"context_line":"               - /etc/localtime:/etc/localtime:ro"},{"line_number":95,"context_line":"               - /var/log/containers/manila:/var/log/manila"},{"line_number":96,"context_line":"               - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":97,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f1d235d_47f0f967","line":94,"range":{"start_line":93,"start_character":15,"end_line":94,"end_character":49},"updated":"2017-07-11 20:02:54.000000000","message":"containers-common.yaml already includes this. Can change this block to:\n\nvolumes:\n  list_concat:\n    - {get_attr: [ContainersCommon, volumes]}\n    -\n      - /var/lib/kolla/config_file/...\n      - /var/lib/config_data/...\n      - ...","commit_id":"2de03395e09ab40af5ec041c6afcf65796a8e9e7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a2193101dd31dfac2f5c248a3ff67858e6e52b07","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            volumes:"},{"line_number":91,"context_line":"               - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":92,"context_line":"               - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":93,"context_line":"               - /etc/hosts:/etc/hosts:ro"},{"line_number":94,"context_line":"               - /etc/localtime:/etc/localtime:ro"},{"line_number":95,"context_line":"               - /var/log/containers/manila:/var/log/manila"},{"line_number":96,"context_line":"               - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":97,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f1d235d_ca73f07f","line":94,"range":{"start_line":93,"start_character":15,"end_line":94,"end_character":49},"in_reply_to":"3f1d235d_47f0f967","updated":"2017-07-11 20:17:39.000000000","message":"Done","commit_id":"2de03395e09ab40af5ec041c6afcf65796a8e9e7"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"9fb7ee4c8675a44fe0713fbfa63ff77db9d7e67c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                   - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":95,"context_line":"                   - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":96,"context_line":"                   - /var/log/containers/manila:/var/log/manila"},{"line_number":97,"context_line":"                   - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":98,"context_line":"            environment:"},{"line_number":99,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":100,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_2669dbbd","line":97,"updated":"2017-07-12 14:07:04.000000000","message":"Related to what Dan wrote, we ideally shouldn\u0027t mount /etc/ceph directly either, for the same reasons (updates breakage). The new approach can be taken from here:\n\nhttps://review.openstack.org/#/c/482500/3/docker/services/cinder-backup.yaml","commit_id":"b283499f3a127319860934c760dfbb67934e191c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"9017ac99ca4611c343d99867be5083a3d3e7eaf2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                   - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":95,"context_line":"                   - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":96,"context_line":"                   - /var/log/containers/manila:/var/log/manila"},{"line_number":97,"context_line":"                   - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":98,"context_line":"            environment:"},{"line_number":99,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":100,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_28708572","line":97,"in_reply_to":"1f1a1f67_2552f068","updated":"2017-07-12 15:31:29.000000000","message":"Right, the patch i linked to also takes the data from /etc/ceph on the host, so from that point it should work fine even now IIUC.\n\nWhat i meant is that instead of a direct :ro mount into /etc/ceph within the container, we should mount like:\n\n  /etc/ceph:/var/lib/kolla/config_files/src-ceph:ro\n\nand then use kolla copying mechanism to copy files from /var/lib/kolla/config_files/src-ceph into /etc/ceph in the container.\n\nWe have to use this indirection to avoid hitting https://bugs.launchpad.net/tripleo/+bug/1698323","commit_id":"b283499f3a127319860934c760dfbb67934e191c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"6d30139f279497c22e0aedc0fbe1ffba56e76354","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                   - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":95,"context_line":"                   - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":96,"context_line":"                   - /var/log/containers/manila:/var/log/manila"},{"line_number":97,"context_line":"                   - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":98,"context_line":"            environment:"},{"line_number":99,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":100,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_2552f068","line":97,"in_reply_to":"1f1a1f67_2669dbbd","updated":"2017-07-12 15:15:53.000000000","message":"I agree but at the moment ceph-ansible is putting it in /etc/ceph on the container host. However, we have an open issue for ceph-ansible to have an option to to generate and store the config in a way more consistent with the rest of TripleO. Thus, the line above is a stopgap until that lands. \n\nhttps://github.com/ceph/ceph-ansible/issues/1618","commit_id":"b283499f3a127319860934c760dfbb67934e191c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"276c8614484733bf38431d9a200f073f587fd561","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                   - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":95,"context_line":"                   - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":96,"context_line":"                   - /var/log/containers/manila:/var/log/manila"},{"line_number":97,"context_line":"                   - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":98,"context_line":"            environment:"},{"line_number":99,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":100,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_4bc5fb8d","line":97,"in_reply_to":"1f1a1f67_28708572","updated":"2017-07-12 15:50:47.000000000","message":"Apologies Jiri and thanks for explaining.","commit_id":"b283499f3a127319860934c760dfbb67934e191c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"1c093117b61fc52f3bdcb953a338ddaedb30963b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                   - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":95,"context_line":"                   - /var/lib/config-data/manila/etc/manila/:/etc/manila/:ro"},{"line_number":96,"context_line":"                   - /var/log/containers/manila:/var/log/manila"},{"line_number":97,"context_line":"                   - /etc/ceph/:/etc/ceph/:ro # NOTE(gfidente): uses the version created by ceph-ansible"},{"line_number":98,"context_line":"            environment:"},{"line_number":99,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":100,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_ebe2872f","line":97,"in_reply_to":"1f1a1f67_28708572","updated":"2017-07-12 15:50:46.000000000","message":"Done","commit_id":"b283499f3a127319860934c760dfbb67934e191c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b3345bb6051b453a913dc09505c66790a80a0e76","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                   - /var/lib/kolla/config_files/manila_share.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":105,"context_line":"                   - /var/lib/config-data/puppet-generated/manila/:/var/lib/kolla/config_files/src:ro"},{"line_number":106,"context_line":"                   - /var/log/containers/manila:/var/log/manila"},{"line_number":107,"context_line":"                   - /etc/ceph/:/var/log/kolla/config_files/src-ceph:ro"},{"line_number":108,"context_line":"            environment:"},{"line_number":109,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":110,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f1a1f67_eb9a876c","line":107,"range":{"start_line":107,"start_character":32,"end_line":107,"end_character":40},"updated":"2017-07-12 15:56:18.000000000","message":"/var/lib\n\notherwise lgtm :)","commit_id":"43b2cb9a0443baf979ef7b7bddf9f3795b2818fe"}],"environments/services-docker/manila.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"dd9c88e6159d09692fe7d91151e13aa358252268","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::ManilaApi: ../../docker/services/manila-api.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::ManilaScheduler: ../../docker/services/manila-scheduler.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Services::ManilaShare: ../../docker/services/manila-share.yaml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f1a1f67_e5517910","line":4,"updated":"2017-07-13 09:37:12.000000000","message":"In a follow up patch we should actually switch containerized scenario 004 to use the containerized manila-share variant, so that this is actually tested in CI too.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/0b8d09b249aa5c5daf827f59ec588d3afb413c44/ci/environments/scenario004-multinode-containers.yaml#L20\n\nI\u0027d just go ahead and merge this patch right now though, as it looks to be in a good shape and i think we don\u0027t want to wait for the best practices (e.g. /etc mounting vs. copying) to change yet again before this is merged :)\n\nAny potential issues can also be ironed out subsequently.","commit_id":"d1a350f5cb43cd30c4b8fc0df85bfdf51298470b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"65b0872177617db4f0b46768ee83877ffa5e05ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::ManilaApi: ../../docker/services/manila-api.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::ManilaScheduler: ../../docker/services/manila-scheduler.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Services::ManilaShare: ../../docker/services/manila-share.yaml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f1a1f67_90dfdc0b","line":4,"in_reply_to":"1f1a1f67_e5517910","updated":"2017-07-19 19:12:14.000000000","message":"https://review.openstack.org/485331","commit_id":"d1a350f5cb43cd30c4b8fc0df85bfdf51298470b"}]}