)]}'
{"ci/environments/multinode-container-upgrade.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"cf3b23ce2afc0ddd7118d9ec0518475e8fb465b2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    - OS::TripleO::Services::TripleoPackages"},{"line_number":57,"context_line":"    - OS::TripleO::Services::NovaCompute"},{"line_number":58,"context_line":"    - OS::TripleO::Services::NovaLibvirt"},{"line_number":59,"context_line":"    - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":60,"context_line":"    - OS::TripleO::Services::Sshd"},{"line_number":61,"context_line":"  ControllerExtraConfig:"},{"line_number":62,"context_line":"    nova::compute::libvirt::services::libvirt_virt_type: qemu"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_0b612337","line":59,"updated":"2017-06-12 14:27:52.000000000","message":"The upgrade job fails on this, we\u0027ll need to map this to OS::Heat::None, see line 15 in this file. (We\u0027ll need to do this in all the container related CI environments, as they\u0027re all going to be used for at least one upgrade job.)\n\nThis one in particular is on its way to be deleted and replaced with multinode-containers.yaml fully, but the change hasn\u0027t been merged yet.\n\nhttps://review.openstack.org/#/c/469073/","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"44fbf847dc23a8eb0db1f07f1a54331cc88d3ff6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    - OS::TripleO::Services::TripleoPackages"},{"line_number":57,"context_line":"    - OS::TripleO::Services::NovaCompute"},{"line_number":58,"context_line":"    - OS::TripleO::Services::NovaLibvirt"},{"line_number":59,"context_line":"    - OS::TripleO::Services::NovaMigrationTarget"},{"line_number":60,"context_line":"    - OS::TripleO::Services::Sshd"},{"line_number":61,"context_line":"  ControllerExtraConfig:"},{"line_number":62,"context_line":"    nova::compute::libvirt::services::libvirt_virt_type: qemu"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_ae1c7d6a","line":59,"in_reply_to":"7f231b9d_0b612337","updated":"2017-06-12 14:35:09.000000000","message":"Actually we need to do the mapping in all container env files but this one, as this file isn\u0027t used for anything anymore, so editing it will just do a conflict with the patch that removes it.","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"}],"ci/environments/multinode-containers.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f12de69099d379275fe311426f15ea5f3d4fe38d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  # overcloud-resource-registry.yaml there doesn\u0027t have this Docker"},{"line_number":13,"context_line":"  # mapping at all. After we stop CI\u0027ing Ocata-\u003ePike upgrade, we can"},{"line_number":14,"context_line":"  # remove this."},{"line_number":15,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"parameter_defaults:"},{"line_number":18,"context_line":"  ControllerServices:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_ee3b95ce","line":15,"updated":"2017-06-12 14:36:11.000000000","message":"we should add NovaMigrationTarget here","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a5cf4b75514d50a00f48547bf5d5f3e40a3aa43e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  # overcloud-resource-registry.yaml there doesn\u0027t have this Docker"},{"line_number":13,"context_line":"  # mapping at all. After we stop CI\u0027ing Ocata-\u003ePike upgrade, we can"},{"line_number":14,"context_line":"  # remove this."},{"line_number":15,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"parameter_defaults:"},{"line_number":18,"context_line":"  ControllerServices:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_66a36c01","line":15,"in_reply_to":"7f231b9d_ee3b95ce","updated":"2017-06-19 11:22:38.000000000","message":"Done","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"}],"ci/environments/scenario001-multinode-containers.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f12de69099d379275fe311426f15ea5f3d4fe38d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  # overcloud-resource-registry.yaml there doesn\u0027t have this Docker"},{"line_number":21,"context_line":"  # mapping at all. After we stop CI\u0027ing Ocata-\u003ePike upgrade, we can"},{"line_number":22,"context_line":"  # remove this."},{"line_number":23,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"parameter_defaults:"},{"line_number":26,"context_line":"  ControllerServices:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_4e528915","line":23,"updated":"2017-06-12 14:36:11.000000000","message":"ditto","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"}],"ci/environments/scenario002-multinode-containers.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f12de69099d379275fe311426f15ea5f3d4fe38d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  # overcloud-resource-registry.yaml there doesn\u0027t have this Docker"},{"line_number":15,"context_line":"  # mapping at all. After we stop CI\u0027ing Ocata-\u003ePike upgrade, we can"},{"line_number":16,"context_line":"  # remove this."},{"line_number":17,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"parameter_defaults:"},{"line_number":20,"context_line":"  ControllerServices:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_0e5c9123","line":17,"updated":"2017-06-12 14:36:11.000000000","message":"ditto","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"}],"ci/environments/scenario004-multinode-containers.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f12de69099d379275fe311426f15ea5f3d4fe38d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  # overcloud-resource-registry.yaml there doesn\u0027t have this Docker"},{"line_number":24,"context_line":"  # mapping at all. After we stop CI\u0027ing Ocata-\u003ePike upgrade, we can"},{"line_number":25,"context_line":"  # remove this."},{"line_number":26,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"parameter_defaults:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f231b9d_2e706da5","line":26,"updated":"2017-06-12 14:36:11.000000000","message":"ditto","commit_id":"e917cf061037164f20b1878fb09a1b622c5f8c22"}],"docker/services/iscsid.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"db5569bc649c2d4b8ed6c5ef4b4c86841f1d51d3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          file:"},{"line_number":93,"context_line":"            path: /etc/iscsi"},{"line_number":94,"context_line":"            state: directory"},{"line_number":95,"context_line":"        # We need to reset the iSCSI initiator name to make it unique"},{"line_number":96,"context_line":"        # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1244328"},{"line_number":97,"context_line":"        - name: reset iscsi initiator name"},{"line_number":98,"context_line":"          shell: /bin/echo InitiatorName\u003d$(/usr/sbin/iscsi-iname) \u003e /etc/iscsi/initiatorname.iscsi \u0026\u0026 touch /etc/iscsi/.initiator_reset"},{"line_number":99,"context_line":"          args:"},{"line_number":100,"context_line":"            creates: /etc/iscsi/.initiator_reset"},{"line_number":101,"context_line":"        - name: stat /lib/systemd/system/iscsid.socket"},{"line_number":102,"context_line":"          stat: path\u003d/lib/systemd/system/iscsid.socket"},{"line_number":103,"context_line":"          register: stat_iscsid_socket"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f1d235d_bc9d1abd","line":100,"range":{"start_line":95,"start_character":8,"end_line":100,"end_character":48},"updated":"2017-07-07 01:18:14.000000000","message":"Taken from https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/nova/compute.pp#L49\n\nI\u0027m not sure this is absolutely necessary... looks like we might be stripping the initiator name from the image nowadays...","commit_id":"f0207a8a426f04290b3fd9e1719323e96d10a67a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3759b92047b7ce77bad1954a190d8699274f0705","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          file:"},{"line_number":93,"context_line":"            path: /etc/iscsi"},{"line_number":94,"context_line":"            state: directory"},{"line_number":95,"context_line":"        # We need to reset the iSCSI initiator name to make it unique"},{"line_number":96,"context_line":"        # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1244328"},{"line_number":97,"context_line":"        - name: reset iscsi initiator name"},{"line_number":98,"context_line":"          shell: /bin/echo InitiatorName\u003d$(/usr/sbin/iscsi-iname) \u003e /etc/iscsi/initiatorname.iscsi \u0026\u0026 touch /etc/iscsi/.initiator_reset"},{"line_number":99,"context_line":"          args:"},{"line_number":100,"context_line":"            creates: /etc/iscsi/.initiator_reset"},{"line_number":101,"context_line":"        - name: stat /lib/systemd/system/iscsid.socket"},{"line_number":102,"context_line":"          stat: path\u003d/lib/systemd/system/iscsid.socket"},{"line_number":103,"context_line":"          register: stat_iscsid_socket"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f1d235d_49fe316c","line":100,"range":{"start_line":95,"start_character":8,"end_line":100,"end_character":48},"in_reply_to":"3f1d235d_bc9d1abd","updated":"2017-07-07 15:44:08.000000000","message":"@mandre just thinking... when https://review.openstack.org/476153 lands, the puppet generated /etc/iscsi/initiatorname.iscsi would be automagically mounted in the nova-compute docker container, correct?\nIf so I can probably remove this.","commit_id":"f0207a8a426f04290b3fd9e1719323e96d10a67a"}],"docker/services/nova-compute.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"79feab019adcbd7af9cec34fbb09ed0eeef05ee0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                  - /var/lib/kolla/config_files/nova_compute.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":106,"context_line":"                  - /var/lib/config-data/nova_libvirt/etc/nova/:/etc/nova/:ro"},{"line_number":107,"context_line":"                  - /dev:/dev"},{"line_number":108,"context_line":"                  - /etc/iscsi:/etc/iscsi"},{"line_number":109,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":110,"context_line":"                  - /run:/run"},{"line_number":111,"context_line":"                  - /var/lib/nova:/var/lib/nova"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f1d235d_c536d351","line":108,"range":{"start_line":108,"start_character":18,"end_line":108,"end_character":41},"updated":"2017-07-06 13:33:07.000000000","message":"This needs to be the puppet generated iscsi config (https://bugzilla.redhat.com/show_bug.cgi?id\u003d1244328)","commit_id":"9707fe54eef708213d2f4b3a1aada48bc23b53ce"}]}