)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fa590aaf991963fc11f4d3f31ab5abc26c29c64d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-06-16 11:02:59 -0700"},{"line_number":4,"context_line":"Commit:     Guil Barros \u003cgbarros@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-16 15:24:48 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch moves Contrail roles communication from public/external"},{"line_number":8,"context_line":"to internal_api network for OpenStack API."},{"line_number":9,"context_line":"It also adds the option to enable dpdk"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_4b48972b","line":6,"updated":"2017-06-16 20:31:42.000000000","message":"please a title first.\n\nExample:\n\nDo this thing\n\nIn this patch, we do this thing because X and Y. etc","commit_id":"f92b3bc05195271ea6355d7b161a92b486d56d41"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Henkel \u003cmhenkel@juniper.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-28 09:03:06 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch moves Contrail roles communication from public/external"},{"line_number":8,"context_line":"to internal_api network for OpenStack API."},{"line_number":9,"context_line":"It also adds the option to enable dpdk."},{"line_number":10,"context_line":"Monolithic firstboot script is broken down into small pre-network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f201791_051b9ec9","line":7,"updated":"2017-06-28 07:42:06.000000000","message":"Modify the commit message heading to be one-line with required description.","commit_id":"1128a1e6b028d507ce40ab4435e72dfe502aa983"}],"environments/contrail/compute_pre_network.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57168d33a5ef666e439ef4b9b6ad7ce97fa2d5d1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"               for member in ${bond_int_member_list}; do"},{"line_number":124,"context_line":"                   ip link set dev $member master ${bond_int}"},{"line_number":125,"context_line":"               done"},{"line_number":126,"context_line":"            fi "},{"line_number":127,"context_line":"            if [[ ${vlan_parent} ]]; then"},{"line_number":128,"context_line":"                vlanId\u003d`echo ${phy_int} | awk -F\"vlan\" \u0027{print $2}\u0027`"},{"line_number":129,"context_line":"                ip link add name ${phy_int} link ${vlan_parent} type vlan id ${vlanId}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f201791_214900b6","line":126,"range":{"start_line":126,"start_character":14,"end_line":126,"end_character":15},"updated":"2017-06-27 19:52:31.000000000","message":"whitespace","commit_id":"4e5e99fc6210d60ab983911662c4c8e2ffe09a16"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57168d33a5ef666e439ef4b9b6ad7ce97fa2d5d1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                ip link add name ${phy_int} link ${vlan_parent} type vlan id ${vlanId}"},{"line_number":130,"context_line":"            fi"},{"line_number":131,"context_line":"            if [[ ${contrail_repo} ]]; then"},{"line_number":132,"context_line":"              yumdownloader contrail-vrouter --destdir /tmp"},{"line_number":133,"context_line":"              cd /tmp"},{"line_number":134,"context_line":"              rpm2cpio /tmp/contrail-vrouter*.rpm | cpio -idmv"},{"line_number":135,"context_line":"              cp `find /tmp/lib/modules -name vrouter.ko |tail -1` /tmp"},{"line_number":136,"context_line":"              insmod /tmp/vrouter.ko"},{"line_number":137,"context_line":"            else"},{"line_number":138,"context_line":"              modprobe vrouter"},{"line_number":139,"context_line":"            fi"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f201791_e1f54858","line":136,"range":{"start_line":132,"start_character":0,"end_line":136,"end_character":36},"updated":"2017-06-27 19:52:31.000000000","message":"This is really ugly but I guess we have no choice? can\u0027t you manage that with puppet-contrail?","commit_id":"4e5e99fc6210d60ab983911662c4c8e2ffe09a16"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# parent template, it can be specified via the parameter_defaults"},{"line_number":5,"context_line":"# in the resource_registry instead, if you want to override the default"},{"line_number":6,"context_line":"# and/or share values with other templates in the tree."},{"line_number":7,"context_line":"parameters:"},{"line_number":8,"context_line":"  ContrailRepo:"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"    default: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f201791_e578a290","line":7,"updated":"2017-06-28 07:42:06.000000000","message":"PreNetworkConfig takes ServiceNames and RoleParameter as mandatory parameters, without which the latest templates will fail. \n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/compute-role.yaml#L418","commit_id":"1128a1e6b028d507ce40ab4435e72dfe502aa983"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"42be529a3b42d2d70495c5b7c8cc3d8e3913432e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            bond_policy\u003d$bond_policy"},{"line_number":73,"context_line":"            vlan_parent\u003d$vlan_parent"},{"line_number":74,"context_line":"            contrail_repo\u003d$contrail_repo"},{"line_number":75,"context_line":"            if [[ ${contrail_repo} ]]; then"},{"line_number":76,"context_line":"              cat \u003c\u003cEOF \u003e /etc/yum.repos.d/contrail.repo"},{"line_number":77,"context_line":"            [Contrail]"},{"line_number":78,"context_line":"            name\u003dContrail Repo"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f201791_5db3aae9","line":75,"updated":"2017-06-28 09:52:42.000000000","message":"NodeUserData will be completed before the PreNetworkConfig, in which case we can remove this. Check if it is possible.","commit_id":"284aada93283999b2f64d71802070822f5e83272"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    type: string"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"description: \u003e"},{"line_number":46,"context_line":"  This module installs the Contrail kernel module  packages in order"},{"line_number":47,"context_line":"  to bring vhost0 interface up. Vhost0 interface must be up before"},{"line_number":48,"context_line":"  os-net-config takes over."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_cf106251","line":46,"range":{"start_line":46,"start_character":7,"end_line":46,"end_character":13},"updated":"2017-07-05 13:11:45.000000000","message":"s/module/template","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":147,"context_line":"              fi"},{"line_number":148,"context_line":"            fi"},{"line_number":149,"context_line":"          params:"},{"line_number":150,"context_line":"            $phy_int: {get_param: ContrailVrouterPhysicalInterface}"},{"line_number":151,"context_line":"            $bond_int: {get_param: ContrailBondInterface}"},{"line_number":152,"context_line":"            $bond_int_members: {get_param: ContrailBondInterfaceMembers}"},{"line_number":153,"context_line":"            $vlan_parent: {get_param: ContrailVlanParentInterface}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_8f8b8a66","line":150,"range":{"start_line":150,"start_character":13,"end_line":150,"end_character":20},"updated":"2017-07-05 13:11:45.000000000","message":"Instead of using str_replace here, you could define inputs with these names, and pass the get_param values via input_values to the SoftwareDeployment, e.g:\n\nhttps://github.com/openstack/heat-templates/blob/master/hot/software-config/example-templates/example-script-template.yaml#L28..L43\n\nThe input_values get exported in the environment before the heat hook runs the script, which also means you can use get_file to put the script into a separate file if you wish (which can make manual testing a bit easier).","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        vlan_parent: {get_param: ContrailVlanParentInterface}"},{"line_number":63,"context_line":"        contrail_repo: {get_param: ContrailRepo}"},{"line_number":64,"context_line":"        bond_mode: {get_param: ContrailBondMode}"},{"line_number":65,"context_line":"        bond_policy: {get_param: ContrailBondPolicy} "},{"line_number":66,"context_line":"      actions: [\u0027CREATE\u0027] # Only do this on CREATE"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  ContrailVrouterModuleConfig:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_7e4ccfc6","line":65,"range":{"start_line":65,"start_character":52,"end_line":65,"end_character":53},"updated":"2017-07-13 13:38:15.000000000","message":"trailing whitespace","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  # Note this is new-for-kilo, an alternative is returning a value then using"},{"line_number":168,"context_line":"  # get_attr in the parent template instead."},{"line_number":169,"context_line":"  OS::stack_id:"},{"line_number":170,"context_line":"    value: {get_resource: userdata}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_fea33f4e","line":170,"range":{"start_line":170,"start_character":26,"end_line":170,"end_character":34},"updated":"2017-07-13 13:38:15.000000000","message":"This output is invalid as it references a non-existent resource, copy/paste error?  I guess it can be removed?","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"}],"environments/contrail/contrail_analytics_database_extra_config.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57168d33a5ef666e439ef4b9b6ad7ce97fa2d5d1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          template: |"},{"line_number":19,"context_line":"            #!/bin/bash"},{"line_number":20,"context_line":"            contrail_repo\u003d$contrail_repo"},{"line_number":21,"context_line":"            sed -i \u0027/\\[main\\]/a \\ \\ \\ \\ \\parser \u003d future\u0027 /etc/puppet/puppet.conf"},{"line_number":22,"context_line":"            if [[ ${contrail_repo} ]]; then"},{"line_number":23,"context_line":"               cat \u003c\u003cEOF \u003e /etc/yum.repos.d/contrail.repo"},{"line_number":24,"context_line":"            [Contrail]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f201791_a4a63e0e","line":21,"updated":"2017-06-27 19:52:31.000000000","message":"I\u0027m not sure we support future parser (neither we gate on it). I\u0027m not in favor of doing so.","commit_id":"4e5e99fc6210d60ab983911662c4c8e2ffe09a16"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57168d33a5ef666e439ef4b9b6ad7ce97fa2d5d1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            contrail_repo\u003d$contrail_repo"},{"line_number":21,"context_line":"            sed -i \u0027/\\[main\\]/a \\ \\ \\ \\ \\parser \u003d future\u0027 /etc/puppet/puppet.conf"},{"line_number":22,"context_line":"            if [[ ${contrail_repo} ]]; then"},{"line_number":23,"context_line":"               cat \u003c\u003cEOF \u003e /etc/yum.repos.d/contrail.repo"},{"line_number":24,"context_line":"            [Contrail]"},{"line_number":25,"context_line":"            name\u003dContrail Repo"},{"line_number":26,"context_line":"            baseurl\u003d${contrail_repo}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f201791_64aca6ec","line":23,"updated":"2017-06-27 19:52:31.000000000","message":"should be managed by tripleo-puppet-elements instead like it\u0027s done for some other packages (see midonet etc).","commit_id":"4e5e99fc6210d60ab983911662c4c8e2ffe09a16"}],"environments/contrail/contrail_analytics_extra_config.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            #!/bin/bash"},{"line_number":20,"context_line":"            contrail_repo\u003d$contrail_repo"},{"line_number":21,"context_line":"            sed -i \u0027/\\[main\\]/a \\ \\ \\ \\ \\parser \u003d future\u0027 /etc/puppet/puppet.conf"},{"line_number":22,"context_line":"            yum remove -y python-redis"},{"line_number":23,"context_line":"            if [[ ${contrail_repo} ]]; then"},{"line_number":24,"context_line":"               cat \u003c\u003cEOF \u003e /etc/yum.repos.d/contrail.repo"},{"line_number":25,"context_line":"            [Contrail]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f201791_a5398af2","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":38},"updated":"2017-06-28 07:42:06.000000000","message":"This is the only difference between analytics and controller extra config. Can\u0027t this be managed in a better way rather than 2 different files? May like includepkgs in repo file or based on host name or some other parameter, it could be managed rather than 2 files with one line difference.","commit_id":"1128a1e6b028d507ce40ab4435e72dfe502aa983"}],"environments/contrail/contrail_dpdk_pre_network.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# parent template, it can be specified via the parameter_defaults"},{"line_number":5,"context_line":"# in the resource_registry instead, if you want to override the default"},{"line_number":6,"context_line":"# and/or share values with other templates in the tree."},{"line_number":7,"context_line":"parameters:"},{"line_number":8,"context_line":"  ContrailRepo:"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"    default: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f201791_659a52b9","line":7,"updated":"2017-06-28 07:42:06.000000000","message":"same here - need to add ServiceNames and RoleParameters parameters.","commit_id":"1128a1e6b028d507ce40ab4435e72dfe502aa983"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            echo \"vm.nr_hugepages \u003d 2048\" \u003e\u003e /etc/sysctl.conf"},{"line_number":65,"context_line":"            echo \"vm.max_map_count \u003d 128960\" \u003e\u003e /etc/sysctl.conf"},{"line_number":66,"context_line":"            echo \"kernel.core_pattern \u003d /var/crashes/core.%e.%p.%h.%t\" \u003e\u003e /etc/sysctl.conf"},{"line_number":67,"context_line":"            echo \"net.ipv4.tcp_keepalive_time \u003d 5\" \u003e\u003e /etc/sysctl.conf"},{"line_number":68,"context_line":"            echo \"net.ipv4.tcp_keepalive_probes \u003d 5\" \u003e\u003e /etc/sysctl.conf"},{"line_number":69,"context_line":"            echo \"net.ipv4.tcp_keepalive_intvl \u003d 1\" \u003e\u003e /etc/sysctl.conf"},{"line_number":70,"context_line":"            /sbin/sysctl --system"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f201791_25533ae4","line":67,"updated":"2017-06-28 07:42:06.000000000","message":"These values are configured on kernel puppet service [1]. Do you need these configurations to be available before the actual puppet service runs?\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/85b07fd36c959f20eaa820e14db7531298d451d1/puppet/services/kernel.yaml#L70-L75","commit_id":"1128a1e6b028d507ce40ab4435e72dfe502aa983"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"42be529a3b42d2d70495c5b7c8cc3d8e3913432e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  to bring vhost0 interface up. Vhost0 interface must be up before"},{"line_number":48,"context_line":"  os-net-config takes over."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  ContrailVrouterDpdkDeployment:"},{"line_number":51,"context_line":"    type: OS::Heat::SoftwareDeployment"},{"line_number":52,"context_line":"    properties:"},{"line_number":53,"context_line":"      name: ContrailVrouterDpdkDeployment"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f201791_3d06ae53","line":50,"updated":"2017-06-28 09:52:42.000000000","message":"missing \"resources:\" section header.","commit_id":"284aada93283999b2f64d71802070822f5e83272"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    type: string"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"description: \u003e"},{"line_number":46,"context_line":"  This module installs the Contrail dpdk packages in order"},{"line_number":47,"context_line":"  to bring vhost0 interface up. Vhost0 interface must be up before"},{"line_number":48,"context_line":"  os-net-config takes over."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_efc67e9a","line":46,"range":{"start_line":46,"start_character":7,"end_line":46,"end_character":13},"updated":"2017-07-05 13:11:45.000000000","message":"s/module/template","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: pike"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE: You don\u0027t need to pass the parameter explicitly from the"},{"line_number":4,"context_line":"# parent template, it can be specified via the parameter_defaults"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_3e51b737","line":1,"range":{"start_line":1,"start_character":22,"end_line":1,"end_character":23},"updated":"2017-07-13 13:38:15.000000000","message":"Did this get checked in by mistake, or in the wrong place?\n\nIt\u0027s a heat template, not an environment, so it shouldn\u0027t live under the environments/* directory?","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  # Note this is new-for-kilo, an alternative is returning a value then using"},{"line_number":174,"context_line":"  # get_attr in the parent template instead."},{"line_number":175,"context_line":"  OS::stack_id:"},{"line_number":176,"context_line":"    value: {get_resource: userdata}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_9eab2b1c","line":176,"range":{"start_line":176,"start_character":26,"end_line":176,"end_character":34},"updated":"2017-07-13 13:38:15.000000000","message":"Same as in the other template, I think the outputs section can be removed?","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"}],"environments/contrail/enable_contrail_repo.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  ContrailRepo:"},{"line_number":5,"context_line":"    type: string"},{"line_number":6,"context_line":"    default: \u0027\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  userdata:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_4f0b32d5","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"updated":"2017-07-05 13:11:45.000000000","message":"Is there a better default than this, e.g a URL?","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":24,"context_line":"               cat \u003c\u003cEOF \u003e /etc/yum.repos.d/contrail.repo"},{"line_number":25,"context_line":"            [Contrail]"},{"line_number":26,"context_line":"            name\u003dContrail Repo"},{"line_number":27,"context_line":"            baseurl\u003d${contrail_repo}"},{"line_number":28,"context_line":"            enabled\u003d1"},{"line_number":29,"context_line":"            gpgcheck\u003d0"},{"line_number":30,"context_line":"            protect\u003d1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_cf718278","line":27,"range":{"start_line":27,"start_character":22,"end_line":27,"end_character":35},"updated":"2017-07-05 13:11:45.000000000","message":"One disadvantage of doing this via useradata is you can never change ContrailRepo (well, you could, but it\u0027ll be ignored because cloud-init only runs once).\n\nI know the pre-network stuff currently only runs on CREATE, but what if you discover a bug in the pre-network configuration?  Just thinking prepending the repo setup to the pre-network script might be safer (although we can obviously still do that later if/when required..)","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"}],"environments/contrail/install_vrouter_kmod.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6b8c19874e7c413400ae6d02907ffc4bd51dcc6d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      - config: {get_resource: vrouter_module_config}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  vrouter_module_config:"},{"line_number":43,"context_line":"    type: OS::Heat::SoftwareConfig"},{"line_number":44,"context_line":"    properties:"},{"line_number":45,"context_line":"      config:"},{"line_number":46,"context_line":"        str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f231b9d_0b705f07","line":43,"updated":"2017-06-16 20:49:14.000000000","message":"TBH a bunch of these things could have been achieved in puppet-contrail.\n\nI\u0027m not in favor of using bash for doing this kind of things, it\u0027s not idempotent and really not efficient with the model of how TripleO works.","commit_id":"228923e08ddb9f1e65004656efce5d4d9d0ce3bf"}],"environments/contrail/roles_data_contrail.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    - OS::TripleO::Services::SensuClient"},{"line_number":246,"context_line":"    - OS::TripleO::Services::FluentdClient"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"- name: ContrailDpdk"},{"line_number":249,"context_line":"  ServicesDefault:"},{"line_number":250,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":251,"context_line":"    - OS::TripleO::Services::CertmongerUser"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_be0a6723","line":248,"range":{"start_line":248,"start_character":8,"end_line":248,"end_character":20},"updated":"2017-07-13 13:38:15.000000000","message":"It\u0027d be good (in another patch) to refactor this into the roles/* structure, then this could be generated via openstack roles generated (new way for generating roles_data added this release).\n\nAlso note that the default roles_data has networks defined in it now, so you probably need to update this to match (or, the roles in roles/* if/when you do that)","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"},{"author":{"_account_id":18810,"name":"alexey-mr","email":"alexey.morlang@gmail.com","username":"alexey-mr"},"change_message_id":"101d8a81f058df4e70cac588f8427c9d307d4d4a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"  ServicesDefault:"},{"line_number":250,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":251,"context_line":"    - OS::TripleO::Services::CertmongerUser"},{"line_number":252,"context_line":"    - OS::TripleO::Services::ContrailTsn"},{"line_number":253,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":254,"context_line":"    - OS::TripleO::Services::Ntp"},{"line_number":255,"context_line":"    - OS::TripleO::Services::Timezone"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ff346bd7_74d0b2ca","line":252,"range":{"start_line":252,"start_character":29,"end_line":252,"end_character":40},"updated":"2017-07-23 08:50:34.000000000","message":"should not it be OS::TripleO::Services::ContrailDpdk service?","commit_id":"319a176b4e8c43eed6ad2c85b5195ed83b0d348e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e9f0451330acb6266e560c87e6ea73a2528e43b1","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    - OS::TripleO::Services::Snmp"},{"line_number":257,"context_line":"    - OS::TripleO::Services::TripleoPackages"},{"line_number":258,"context_line":"    - OS::TripleO::Services::SensuClient"},{"line_number":259,"context_line":"    - OS::TripleO::Services::FluentdClient"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_7949f2b4","line":259,"updated":"2017-07-18 21:58:16.000000000","message":"Just as a note, these should get split apart and put in to the roles/ directory","commit_id":"319a176b4e8c43eed6ad2c85b5195ed83b0d348e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d5d113cf704a8ef7ba5ba87a8597ecdc85c05ba1","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    - OS::TripleO::Services::Snmp"},{"line_number":257,"context_line":"    - OS::TripleO::Services::TripleoPackages"},{"line_number":258,"context_line":"    - OS::TripleO::Services::SensuClient"},{"line_number":259,"context_line":"    - OS::TripleO::Services::FluentdClient"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_8789e875","line":259,"in_reply_to":"1f1a1f67_7949f2b4","updated":"2017-07-19 17:37:51.000000000","message":"ack Alex, comment on IRC:\n\n  (gbarros) there are a few suggestions but I\u0027d like to push those as a separate patch after so we dont have to rush things too much this week","commit_id":"319a176b4e8c43eed6ad2c85b5195ed83b0d348e"}],"environments/contrail/roles_data_contrail.yaml.new":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Specifies which roles (groups of nodes) will be deployed"},{"line_number":2,"context_line":"# Note this is used as an input to the various *.j2.yaml"},{"line_number":3,"context_line":"# jinja2 templates, so that they are converted into *.yaml"},{"line_number":4,"context_line":"# during the plan creation (via a mistral action/workflow)."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# The format is a list, with the following format:"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1f1a1f67_921c3f6b","line":3,"range":{"start_line":3,"start_character":37,"end_line":3,"end_character":46},"updated":"2017-07-13 13:38:15.000000000","message":"Did this get checked in my mistake, as it\u0027s a yaml.new file?","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"}],"environments/ssl/tls-endpoints-public-dns.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a4e2443d2babd6a0d2213b53b38fa0a9410258fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# *******************************************************************"},{"line_number":2,"context_line":"# This file was created automatically by the sample environment"},{"line_number":3,"context_line":"# generator. Developers should use `tox -e genconfig` to update it."},{"line_number":4,"context_line":"# Users are recommended to make changes to a copy of the file instead"},{"line_number":5,"context_line":"# of the original, if any customizations are needed."},{"line_number":6,"context_line":"# *******************************************************************"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f436f4f_141cbb68","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":67},"updated":"2017-08-08 21:33:06.000000000","message":"Please note the comment at the top of this file.  It is generated, not handwritten, and should be updated via the tool.  Otherwise the changes will be overwritten the next time the environments are updated.","commit_id":"aa5194f878bb0c9fb98891abd6005b1b252eff3e"}],"network/config/contrail/contrail-nic-config-compute.yaml":[{"author":{"_account_id":18810,"name":"alexey-mr","email":"alexey.morlang@gmail.com","username":"alexey-mr"},"change_message_id":"6dc64257857593deeaf4d48b5b79ef1be1b8fa41","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      config:"},{"line_number":94,"context_line":"        str_replace:"},{"line_number":95,"context_line":"          template:"},{"line_number":96,"context_line":"            get_file: ../../network/scripts/run-os-net-config.sh"},{"line_number":97,"context_line":"          params:"},{"line_number":98,"context_line":"            $network_config:"},{"line_number":99,"context_line":"              network_config:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ff346bd7_363795e6","line":96,"range":{"start_line":96,"start_character":28,"end_line":96,"end_character":35},"updated":"2017-07-25 10:00:41.000000000","message":"it looks to be just ../../scripts/run-os-net-config.sh","commit_id":"43c4d3d383867932aae838f0c3d0bbe2ae2a7477"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dac57f374b569b9171a405fa320747852732137d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      config:"},{"line_number":94,"context_line":"        str_replace:"},{"line_number":95,"context_line":"          template:"},{"line_number":96,"context_line":"            get_file: ../../network/scripts/run-os-net-config.sh"},{"line_number":97,"context_line":"          params:"},{"line_number":98,"context_line":"            $network_config:"},{"line_number":99,"context_line":"              network_config:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ff346bd7_d29dee57","line":96,"range":{"start_line":96,"start_character":28,"end_line":96,"end_character":35},"in_reply_to":"ff346bd7_363795e6","updated":"2017-07-25 13:37:33.000000000","message":"yea Alexey is right, this is the wrong path","commit_id":"43c4d3d383867932aae838f0c3d0bbe2ae2a7477"}],"network/config/contrail/contrail-nic-config.yaml":[{"author":{"_account_id":18810,"name":"alexey-mr","email":"alexey.morlang@gmail.com","username":"alexey-mr"},"change_message_id":"6dc64257857593deeaf4d48b5b79ef1be1b8fa41","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      config:"},{"line_number":94,"context_line":"        str_replace:"},{"line_number":95,"context_line":"          template:"},{"line_number":96,"context_line":"            get_file: ../../network/scripts/run-os-net-config.sh"},{"line_number":97,"context_line":"          params:"},{"line_number":98,"context_line":"            $network_config:"},{"line_number":99,"context_line":"              network_config:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ff346bd7_d6284987","line":96,"range":{"start_line":96,"start_character":28,"end_line":96,"end_character":35},"updated":"2017-07-25 10:00:41.000000000","message":"it looks to be just ../../scripts/run-os-net-config.sh","commit_id":"43c4d3d383867932aae838f0c3d0bbe2ae2a7477"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dac57f374b569b9171a405fa320747852732137d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      config:"},{"line_number":94,"context_line":"        str_replace:"},{"line_number":95,"context_line":"          template:"},{"line_number":96,"context_line":"            get_file: ../../network/scripts/run-os-net-config.sh"},{"line_number":97,"context_line":"          params:"},{"line_number":98,"context_line":"            $network_config:"},{"line_number":99,"context_line":"              network_config:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ff346bd7_92a766a8","line":96,"range":{"start_line":96,"start_character":28,"end_line":96,"end_character":35},"in_reply_to":"ff346bd7_d6284987","updated":"2017-07-25 13:37:33.000000000","message":"same","commit_id":"43c4d3d383867932aae838f0c3d0bbe2ae2a7477"}],"puppet/services/network/contrail-analytics.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":38,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":39,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":40,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":41,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f201791_855d6e7a","side":"PARENT","line":40,"updated":"2017-06-28 07:42:06.000000000","message":"Why has this been removed in all the contrail services file? I know it is not being used. But I don\u0027t see a reason to remove it with this review.","commit_id":"d10741e526f7868a2330014f35678d327b4984a2"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":30,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":31,"context_line":"    type: json"},{"line_number":32,"context_line":"  ContrailAnalyticsCollectorHttp:"},{"line_number":33,"context_line":"    default: 8089"},{"line_number":34,"context_line":"    description: Contrail Analytics Collector http port"},{"line_number":35,"context_line":"    type: number"},{"line_number":36,"context_line":"  ContrailAnalyticsCollectorSandesh:"},{"line_number":37,"context_line":"    default: 8086"},{"line_number":38,"context_line":"    description: Contrail Analytics Collector sandesh port"},{"line_number":39,"context_line":"    type: number"},{"line_number":40,"context_line":"  ContrailAnalyticsHttp:"},{"line_number":41,"context_line":"    default: 8090"},{"line_number":42,"context_line":"    description: Contrail Analytics http  port"},{"line_number":43,"context_line":"    type: number"},{"line_number":44,"context_line":"  ContrailAnalyticsRedis:"},{"line_number":45,"context_line":"    default: 6379"},{"line_number":46,"context_line":"    description: Contrail Analytics redis  port"},{"line_number":47,"context_line":"    type: number"},{"line_number":48,"context_line":"  ContrailAnalyticsApi:"},{"line_number":49,"context_line":"    default: 8081"},{"line_number":50,"context_line":"    description: Contrail Analytics Api  port"},{"line_number":51,"context_line":"    type: number"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"resources:"},{"line_number":54,"context_line":"  ContrailBase:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_efa31e9d","line":51,"range":{"start_line":32,"start_character":2,"end_line":51,"end_character":16},"updated":"2017-07-05 13:11:45.000000000","message":"If we\u0027re no longer using the EndpointMap, can the EndpointMap entries be removed?","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    default: 6379"},{"line_number":46,"context_line":"    description: Contrail Analytics redis  port"},{"line_number":47,"context_line":"    type: number"},{"line_number":48,"context_line":"  ContrailAnalyticsApi:"},{"line_number":49,"context_line":"    default: 8081"},{"line_number":50,"context_line":"    description: Contrail Analytics Api  port"},{"line_number":51,"context_line":"    type: number"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_f25b732b","line":49,"range":{"start_line":48,"start_character":2,"end_line":49,"end_character":17},"updated":"2017-07-13 13:38:15.000000000","message":"If these ports are all hardcoded parameters now, can we remove the Contrail data from the endpoint_map?","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"06cb8f78faaea7de925446bc15c5fd06dd0feb4d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":34,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":35,"context_line":"    type: json"},{"line_number":36,"context_line":"  ContrailAnalyticsCollectorHttp:"},{"line_number":37,"context_line":"    default: 8089"},{"line_number":38,"context_line":"    description: Contrail Analytics Collector http port"},{"line_number":39,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_e89b2063","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":32},"updated":"2017-07-17 18:01:55.000000000","message":"Would it be better if all of these parameters were called ContrailFooPort to clarify they accept port numbers?","commit_id":"319a176b4e8c43eed6ad2c85b5195ed83b0d348e"}],"puppet/services/network/contrail-base.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  AuthPortPublic:"},{"line_number":58,"context_line":"    default: 5000"},{"line_number":59,"context_line":"    description: Keystone Public port"},{"line_number":60,"context_line":"    type: number"},{"line_number":61,"context_line":"  AuthPortSSLPublic:"},{"line_number":62,"context_line":"    default: 13000"},{"line_number":63,"context_line":"    description: Keystone Public SSL port"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_6f2cae01","line":60,"range":{"start_line":60,"start_character":10,"end_line":60,"end_character":16},"updated":"2017-07-05 13:11:45.000000000","message":"This should come from EndpointMap, e.g\n\n  {get_param: [EndpointMap, KeystonePublic, port}\n\nIf you do that, you also don\u0027t need the AuthPortSSL","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  AuthProtocol:"},{"line_number":66,"context_line":"    default: \u0027http\u0027"},{"line_number":67,"context_line":"    description: Keystone authentication protocol"},{"line_number":68,"context_line":"    type: string"},{"line_number":69,"context_line":"  ContrailAuth:"},{"line_number":70,"context_line":"    default: \u0027keystone\u0027"},{"line_number":71,"context_line":"    description: Keystone authentication method"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_4f31f259","line":68,"range":{"start_line":68,"start_character":10,"end_line":68,"end_character":16},"updated":"2017-07-05 13:11:45.000000000","message":"This should come from EndpointMap, e.g\n\n  {get_param: [EndpointMap, KeystonePublic, protocol}","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"06cb8f78faaea7de925446bc15c5fd06dd0feb4d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    description: Keystone authentication method"},{"line_number":60,"context_line":"    type: string"},{"line_number":61,"context_line":"  ContrailAnalyticsVIP:"},{"line_number":62,"context_line":"    default: \u0027\u0027"},{"line_number":63,"context_line":"    description: Contrail Analytics Api Virtual IP address"},{"line_number":64,"context_line":"    type: string"},{"line_number":65,"context_line":"  ContrailConfigPort:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_08b09cdc","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":13},"updated":"2017-07-17 18:01:55.000000000","message":"I suspect these defaults will never work?  If so you may wish to omit them, so the operator is forced to provide values or else get a validation error","commit_id":"319a176b4e8c43eed6ad2c85b5195ed83b0d348e"}],"puppet/services/network/contrail-control.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"de4c5b43181f141c5e995b4589903039693fe7ae","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    type: number"},{"line_number":35,"context_line":"    default: 64512"},{"line_number":36,"context_line":"  ContrailControlRNDCSecret:"},{"line_number":37,"context_line":"    description: RNDCSecret"},{"line_number":38,"context_line":"    type: string"},{"line_number":39,"context_line":"    hidden: true"},{"line_number":40,"context_line":"  ContrailControlManageNamed:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f1a1f67_12702fa5","line":37,"range":{"start_line":37,"start_character":17,"end_line":37,"end_character":27},"updated":"2017-07-13 13:38:15.000000000","message":"FWIW I liked the old description better, as this gives no clue at all about how to generate a valid secret?","commit_id":"6df14ca2aec8173d8bc5ba8c7097ab9c054d7a13"}],"puppet/services/network/contrail-provision.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"d5882351f04617dce2e6d981c11d19b06b6fead4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  Provision Contrail services after deployment"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  ContrailBlabla:"},{"line_number":8,"context_line":"    default: blabla"},{"line_number":9,"context_line":"    description: blbla"},{"line_number":10,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f201791_05bf1eaa","line":7,"updated":"2017-06-28 07:42:06.000000000","message":"Looks like this is a test code?","commit_id":"1128a1e6b028d507ce40ab4435e72dfe502aa983"}],"puppet/services/network/contrail-vrouter.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  ContrailVrouterControlNodeIps:"},{"line_number":46,"context_line":"    description: List of Contrail Node IPs"},{"line_number":47,"context_line":"    type: comma_delimited_list"},{"line_number":48,"context_line":"    default: \u0027\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"resources:"},{"line_number":51,"context_line":"  ContrailBase:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_af4c06c8","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":15},"updated":"2017-07-05 13:11:45.000000000","message":"This parameter should not be needed if you add the contrail_vrouter service into the ServiceNetMap (it\u0027ll be generated automatically as contrail_vrouter_node_ips)","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e2ee8d86866e301c78785557f7716f3c6dfcc419","unresolved":false,"context_lines":[{"line_number":75,"context_line":"              \u0027111 contrail_vrouter_8085\u0027:"},{"line_number":76,"context_line":"                dport: 8085"},{"line_number":77,"context_line":"              \u0027112 contrail_vrouter_8097\u0027:"},{"line_number":78,"context_line":"                dport: 8097"},{"line_number":79,"context_line":"      step_config: |"},{"line_number":80,"context_line":"        include ::tripleo::network::contrail::vrouter"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f1d235d_afe1a69d","line":78,"range":{"start_line":78,"start_character":23,"end_line":78,"end_character":27},"updated":"2017-07-05 13:11:45.000000000","message":"These ports are specified in more than one template, should they be parameterized?","commit_id":"8bb1dd135f8657e09f33e8a09f8d973a8d42a802"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"06cb8f78faaea7de925446bc15c5fd06dd0feb4d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    description: vRouter netmask"},{"line_number":48,"context_line":"    type: string"},{"line_number":49,"context_line":"  ContrailVrouterControlNodeIps:"},{"line_number":50,"context_line":"    description: List of Contrail Node IPs"},{"line_number":51,"context_line":"    type: comma_delimited_list"},{"line_number":52,"context_line":"    default: \u0027\u0027"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_28e478e0","line":50,"range":{"start_line":50,"start_character":25,"end_line":50,"end_character":33},"updated":"2017-07-17 18:01:55.000000000","message":"Can you clarify what this is used for - is it different from the automatically generated contrail_vrouter_node_ips if you leave the service in the ServiceNetMap?","commit_id":"319a176b4e8c43eed6ad2c85b5195ed83b0d348e"}]}