)]}'
{"environments/neutron-ml2-bigswitch.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c7dc548e4c2a9eaf0561895200feacfe807dfaf8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  NeutronBigswitchRestproxyServerAuth:"},{"line_number":14,"context_line":"  NeutronMechanismDrivers: openvswitch,bsn_ml2"},{"line_number":15,"context_line":"  NeutronServicePlugins: bsn_l3,bsn_service_plugin"},{"line_number":16,"context_line":"  KeystoneNotificationDriver: messaging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  # Optional:"},{"line_number":19,"context_line":"  # NeutronBigswitchRestproxyAutoSyncOnFailure:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f1a1f67_193d19bb","side":"PARENT","line":16,"updated":"2017-07-12 16:40:15.000000000","message":"Hmm, I wonder if this is a safe change.  The messaging and messagingv2 formats are not compatible, so this could break the bigswitch services if they\u0027re expecting notifications in the older format.","commit_id":"322f2dbd4c1d9c8617186bcb9211d7a1fe10ba3f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b7ac5e5d73c9a025ab799c507bf7fe7af377731b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  NeutronBigswitchRestproxyServerAuth:"},{"line_number":14,"context_line":"  NeutronMechanismDrivers: openvswitch,bsn_ml2"},{"line_number":15,"context_line":"  NeutronServicePlugins: bsn_l3,bsn_service_plugin"},{"line_number":16,"context_line":"  KeystoneNotificationDriver: messaging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  # Optional:"},{"line_number":19,"context_line":"  # NeutronBigswitchRestproxyAutoSyncOnFailure:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f1a1f67_c43575f9","side":"PARENT","line":16,"in_reply_to":"1f1a1f67_193d19bb","updated":"2017-07-12 20:20:41.000000000","message":"I checked with Julien Danjou and and it seels like Bigswitch might be compatible with messagingv2, since it should be transparent for the app.\n\nI was curious about https://github.com/openstack/networking-bigswitch/blob/9a88aa29b6c849c2d92c24049b5b031b1228fc6e/networking_bigswitch/plugins/bigswitch/plugin.py#L106 but in fact this is the RPC version and not the version of the driver, so it\u0027s not related.\n\nI\u0027ll try to poke folks from Bigswitch to make sure we\u0027re saying it right and that we can deploy bigswitch with messagingv2 notification backend.","commit_id":"322f2dbd4c1d9c8617186bcb9211d7a1fe10ba3f"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"00137e46350bd700463a16dafaa2661768f5fa1f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  NeutronBigswitchRestproxyServerAuth:"},{"line_number":14,"context_line":"  NeutronMechanismDrivers: openvswitch,bsn_ml2"},{"line_number":15,"context_line":"  NeutronServicePlugins: bsn_l3,bsn_service_plugin"},{"line_number":16,"context_line":"  KeystoneNotificationDriver: messaging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  # Optional:"},{"line_number":19,"context_line":"  # NeutronBigswitchRestproxyAutoSyncOnFailure:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f1a1f67_e79ab3c3","side":"PARENT","line":16,"in_reply_to":"1f1a1f67_c43575f9","updated":"2017-07-12 20:28:35.000000000","message":"If they\u0027re consuming notifications via telemetry then that should be fine.  I don\u0027t know enough about how their stuff works to say though.","commit_id":"322f2dbd4c1d9c8617186bcb9211d7a1fe10ba3f"}],"puppet/services/nova-base.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"8f7cc2c316e5cd390dc0b9dba4fbfba5fee0daa7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    default: \u0027\u0027"},{"line_number":36,"context_line":"    description: Driver or drivers to handle sending notifications."},{"line_number":37,"context_line":"    constraints:"},{"line_number":38,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027noop\u0027 ]"},{"line_number":39,"context_line":"  NovaPassword:"},{"line_number":40,"context_line":"    description: The password for the nova service and db account, used by nova-api."},{"line_number":41,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_2a93e05e","line":38,"updated":"2017-07-07 19:01:11.000000000","message":"We should probably allow messaging and messagingv2, at least.  There are a few others, although I admit I don\u0027t know what they\u0027re used for so I\u0027m not sure if it matters: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/notifier.py#L34\n\nI believe the puppet modules default to messagingv2, so it\u0027s probably good to mention that in the description too.","commit_id":"aa42bf1d6e42ccb1e79ad2228b0719f5021ed3d3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ee48a5ffa33326ce520bc4b37750ccf22d280856","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    default: \u0027\u0027"},{"line_number":36,"context_line":"    description: Driver or drivers to handle sending notifications."},{"line_number":37,"context_line":"    constraints:"},{"line_number":38,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027noop\u0027 ]"},{"line_number":39,"context_line":"  NovaPassword:"},{"line_number":40,"context_line":"    description: The password for the nova service and db account, used by nova-api."},{"line_number":41,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_6981e34a","line":38,"in_reply_to":"3f1d235d_2a93e05e","updated":"2017-07-07 21:21:41.000000000","message":"puppet modules default to nothing, so they rely on what oslo messaging provides. See: https://github.com/openstack/puppet-oslo/blob/master/manifests/messaging/notifications.pp#L14 and https://github.com/openstack/puppet-nova/blob/master/manifests/init.pp#L308\n\nThat\u0027s why I didn\u0027t add messaging and messaging v2, to maintain previous behavior. I\u0027m concerned about letting users change the version of messaging for now, as i\u0027m not sure we expose all necessary options.","commit_id":"aa42bf1d6e42ccb1e79ad2228b0719f5021ed3d3"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0854bfb223db12f9632aac35283c0e2abde1fcd8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    default: \u0027\u0027"},{"line_number":36,"context_line":"    description: Driver or drivers to handle sending notifications."},{"line_number":37,"context_line":"    constraints:"},{"line_number":38,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027noop\u0027 ]"},{"line_number":39,"context_line":"  NovaPassword:"},{"line_number":40,"context_line":"    description: The password for the nova service and db account, used by nova-api."},{"line_number":41,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_42400e36","line":38,"in_reply_to":"3f1d235d_6981e34a","updated":"2017-07-10 21:13:22.000000000","message":"Hmm, I could have sworn the puppet module I looked at was defaulting to messagingv2.  Maybe it was in a notifications class which existed solely to enable notifications?  I guess I can live with this either way, but since we\u0027re already going to be touching all the service templates I\u0027d mildly prefer to just list all the possible values now to avoid having to do this exercise again later.","commit_id":"aa42bf1d6e42ccb1e79ad2228b0719f5021ed3d3"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a28e65f342fc9ef61b4dcf9147284ece28a5c8eb","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          if:"},{"line_number":249,"context_line":"          - notification_driver_unset"},{"line_number":250,"context_line":"            # backward compatibility"},{"line_number":251,"context_line":"          - nova::notification_driver: messagingv2"},{"line_number":252,"context_line":"          - nova::notification_driver: {get_param: NotificationDriver}"},{"line_number":253,"context_line":"      service_config_settings:"},{"line_number":254,"context_line":"        mysql:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f1d235d_2264f2e4","line":251,"range":{"start_line":251,"start_character":39,"end_line":251,"end_character":50},"updated":"2017-07-10 21:14:37.000000000","message":"Couldn\u0027t we just default the parameter to messagingv2 and skip the condition?","commit_id":"ef1cc7408b2a2a37845e1f358496dbde488e2b33"}]}