)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5db37fd5ad57dc9743eb426b1605c6f1797cc4d5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is running before stopping it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia8c25827d0d6f34e0345c3946dfd6839a7116e04"},{"line_number":14,"context_line":"Partial-Bug: #1470033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_ef636adb","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":21},"updated":"2017-07-14 09:11:04.000000000","message":"err i think wrong bug? :) I get  Pressing \"Enter\" on the \"Reply to SMS\" field of the SMS notification will clear the notification and erase the typed text, but the reply is not sent.","commit_id":"2350b2937df29506e746a6f66a7576440dffedf7"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"cb42fde7c0517a71de4860cffd8776cc219c692e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is running before stopping it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia8c25827d0d6f34e0345c3946dfd6839a7116e04"},{"line_number":14,"context_line":"Partial-Bug: #1470033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_3f518b0f","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":21},"updated":"2017-07-14 12:36:33.000000000","message":"This should be the launchpad bug id.\n\nHere is using instead the BZ id\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1470033","commit_id":"bb283e66a67459aaa73b8d87706f3593db9fb785"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"25bdaae2c5a79ec97840864739fafe6f08337c78","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is running before stopping it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia8c25827d0d6f34e0345c3946dfd6839a7116e04"},{"line_number":14,"context_line":"Partial-Bug: #1470033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_c5aacad0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":21},"in_reply_to":"1f1a1f67_3f518b0f","updated":"2017-07-14 13:40:12.000000000","message":"Done","commit_id":"bb283e66a67459aaa73b8d87706f3593db9fb785"}],"docker/services/mistral-executor.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"27ffa542aa00656b45ac80608a1eccf72cb2a576","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          when: mistral_executor_enabled.rc \u003d\u003d 0"},{"line_number":129,"context_line":"          tags: step0,validation"},{"line_number":130,"context_line":"        - name: Stop and disable mistral_executor service"},{"line_number":131,"context_line":"          tags: step1"},{"line_number":132,"context_line":"          when: mistral_executor_enabled.rc \u003d\u003d 0"},{"line_number":133,"context_line":"          service: name\u003dopenstack-mistral-executor state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_39dbf0ed","line":131,"range":{"start_line":131,"start_character":20,"end_line":131,"end_character":21},"updated":"2017-07-14 08:21:25.000000000","message":"copy/pasta nit?","commit_id":"2350b2937df29506e746a6f66a7576440dffedf7"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"700481affbed3b6bb898eee27bd4d96a31559e1f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          when: mistral_executor_enabled.rc \u003d\u003d 0"},{"line_number":129,"context_line":"          tags: step0,validation"},{"line_number":130,"context_line":"        - name: Stop and disable mistral_executor service"},{"line_number":131,"context_line":"          tags: step1"},{"line_number":132,"context_line":"          when: mistral_executor_enabled.rc \u003d\u003d 0"},{"line_number":133,"context_line":"          service: name\u003dopenstack-mistral-executor state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_ac8a2018","line":131,"range":{"start_line":131,"start_character":20,"end_line":131,"end_character":21},"in_reply_to":"1f1a1f67_39dbf0ed","updated":"2017-07-14 08:49:45.000000000","message":"nope, I changed it on purpose as the stop task in puppet services is tagged always as step1 (but as I am still not sure about the use of these tags I rather having a second and third opinion)","commit_id":"2350b2937df29506e746a6f66a7576440dffedf7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"30b9d955259f9e4c891defed6d183a6114b1c729","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          when: mistral_executor_enabled.rc \u003d\u003d 0"},{"line_number":129,"context_line":"          tags: step0,validation"},{"line_number":130,"context_line":"        - name: Stop and disable mistral_executor service"},{"line_number":131,"context_line":"          tags: step1"},{"line_number":132,"context_line":"          when: mistral_executor_enabled.rc \u003d\u003d 0"},{"line_number":133,"context_line":"          service: name\u003dopenstack-mistral-executor state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_4cbb8c71","line":131,"range":{"start_line":131,"start_character":20,"end_line":131,"end_character":21},"in_reply_to":"1f1a1f67_ac8a2018","updated":"2017-07-14 09:05:14.000000000","message":"I don\u0027t think we should change these here.\n\nIn puppet/services/*, the upgrade_tasks collected for the O..P upgrade use step1 for the service stop (and step2 for \u0027core\u0027 services like rabbit/database). \n\nIn docker/services/*, the upgrade_tasks as above use step2 for the service stop (they actually don\u0027t really use anything else as we discussed yesterday Jose, they jus want to stop all/most of the things since they\u0027ll become containers).\n\nNot sure of the history or why \u0027step2\u0027 was chosen here but it doesn\u0027t make much difference since there are no other steps defined anyway (I\u0027ll add a step3 at https://review.openstack.org/#/c/480202/6/puppet/services/pacemaker.yaml@150 .. you may also notice that _that_ one is puppet/services... well, just for fun that is a special case since even in the docker environment it still points to that file not a docker one, so the upgrade_tasks used are the ones in the puppet/services/pacemaker.yaml even when containers https://github.com/openstack/tripleo-heat-templates/blob/master/environments/docker-ha.yaml#L9 )","commit_id":"2350b2937df29506e746a6f66a7576440dffedf7"}]}