)]}'
{"puppet/extraconfig/all_nodes/neutron-ml2-cisco-nexus-ucsm.j2.yaml":[{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"f7ffe53dc68d1b84a4e3624c59624b3364767f65","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      config: {get_resource: CollectMacConfig}"},{"line_number":183,"context_line":"      actions: [\u0027CREATE\u0027] # Only do this on CREATE"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"{% for role in roles %}"},{"line_number":186,"context_line":"  CollectMacDeploymentsCompute:"},{"line_number":187,"context_line":"    type: OS::Heat::SoftwareDeployments"},{"line_number":188,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_9fc39b89","line":185,"updated":"2017-07-18 16:08:34.000000000","message":"If all roles are covered in this \"loop\", do we need separate blocks for CollectMacDeploymentsController, CollectMacDeploymentsCompute, CollectMacDeploymentsBlockStorage and CollectMacDeploymentsObjectStorage?","commit_id":"bacf019c7d744d2ad30ba1c76f3266b2b590a579"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"13aba2da26da8526c42cd1566e9b384cab33ec7a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      config: {get_resource: CollectMacConfig}"},{"line_number":183,"context_line":"      actions: [\u0027CREATE\u0027] # Only do this on CREATE"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"{% for role in roles %}"},{"line_number":186,"context_line":"  CollectMacDeploymentsCompute:"},{"line_number":187,"context_line":"    type: OS::Heat::SoftwareDeployments"},{"line_number":188,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_bf8bf7c0","line":185,"in_reply_to":"1f1a1f67_9fc39b89","updated":"2017-07-18 16:19:04.000000000","message":"No you can remove them all and replace \"Compute\" below with {{role.name}}.\n\nIf you run ./tools/process-templates.py the yaml file will be rendered, so you can check it is what you expect (I find it useful to copy the file before renaming it to *.j2.yaml, then diff it with the generated version.","commit_id":"bacf019c7d744d2ad30ba1c76f3266b2b590a579"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"cd3eead24a4a3e279a2c3b87a08ad08b96d857b9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      servers:  {get_param: [servers, {{role.name}}]}"},{"line_number":183,"context_line":"      config: {get_resource: CollectMacConfig}"},{"line_number":184,"context_line":"      actions: [\u0027CREATE\u0027] # Only do this on CREATE"},{"line_number":185,"context_line":"{% endfor %}"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  # Now we calculate the additional nexus config based on the mappings"},{"line_number":188,"context_line":"  MappingToNexusConfig:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_91336bab","line":185,"updated":"2017-07-19 14:36:38.000000000","message":"The code generated after running ./tools/process-templates.py looks correct after the above change. Thanks!","commit_id":"9d60b8b94b98ef16842441d2b56ed18c3e097b3e"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"cd3eead24a4a3e279a2c3b87a08ad08b96d857b9","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # we can\u0027t use list_join or str_replace.  Possible Heat TODO."},{"line_number":268,"context_line":"        # TODO(sadasu): This needs to be modified based on modifications to"},{"line_number":269,"context_line":"        # generate CollectMacDeployments\u003crole\u003e."},{"line_number":270,"context_line":"        controller_mappings: {get_attr: [CollectMacDeploymentsController, deploy_stdouts]}"},{"line_number":271,"context_line":"        compute_mappings: {get_attr: [CollectMacDeploymentsCompute, deploy_stdouts]}"},{"line_number":272,"context_line":"        blockstorage_mappings: {get_attr: [CollectMacDeploymentsBlockStorage, deploy_stdouts]}"},{"line_number":273,"context_line":"        objectstorage_mappings: {get_attr: [CollectMacDeploymentsObjectStorage, deploy_stdouts]}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_31fb77c1","line":270,"updated":"2017-07-19 14:36:38.000000000","message":"How should this code be modified?","commit_id":"9d60b8b94b98ef16842441d2b56ed18c3e097b3e"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"cf05ccaf32cb333b274952a956134cd34c13d5ec","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    properties:"},{"line_number":191,"context_line":"      group: script"},{"line_number":192,"context_line":"      inputs:"},{"line_number":193,"context_line":"     {% for role in roles %} "},{"line_number":194,"context_line":"      - name: {{role.name}}_mappings"},{"line_number":195,"context_line":"     {% endfor %}"},{"line_number":196,"context_line":"      - name: nexus_config"},{"line_number":197,"context_line":"      config: |"},{"line_number":198,"context_line":"        #!/bin/python"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f1a1f67_1d272567","line":195,"range":{"start_line":193,"start_character":1,"end_line":195,"end_character":17},"updated":"2017-07-21 09:00:54.000000000","message":"This will render a little more cleanly if you escape the newlines, e.g:\n\n {%- for role in roles %} \n - name: {{role.name}}_mappings\n {%- endfor %}","commit_id":"62de64933b3c14bf332153180bf3cb5b4f9a34e4"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"de24d6545cc5614a9657f8859a3875937624c279","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    properties:"},{"line_number":191,"context_line":"      group: script"},{"line_number":192,"context_line":"      inputs:"},{"line_number":193,"context_line":"     {% for role in roles %} "},{"line_number":194,"context_line":"      - name: {{role.name}}_mappings"},{"line_number":195,"context_line":"     {% endfor %}"},{"line_number":196,"context_line":"      - name: nexus_config"},{"line_number":197,"context_line":"      config: |"},{"line_number":198,"context_line":"        #!/bin/python"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff346bd7_f2260817","line":195,"range":{"start_line":193,"start_character":1,"end_line":195,"end_character":17},"in_reply_to":"1f1a1f67_1d272567","updated":"2017-07-21 17:37:43.000000000","message":"Done","commit_id":"62de64933b3c14bf332153180bf3cb5b4f9a34e4"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"cf05ccaf32cb333b274952a956134cd34c13d5ec","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        mappings \u003d [{% for role in roles %}"},{"line_number":205,"context_line":"                    \u0027{{role.name}}_mappings\u0027,"},{"line_number":206,"context_line":"                    {% endfor %}"},{"line_number":207,"context_line":"                    \u0027nexus_config\u0027]"},{"line_number":208,"context_line":"        mapdict_list \u003d []"},{"line_number":209,"context_line":"        nexus \u003d {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f1a1f67_1ddcc544","line":206,"range":{"start_line":206,"start_character":23,"end_line":206,"end_character":29},"updated":"2017-07-21 09:00:54.000000000","message":"Same here, you could render this without the additional whitespace by doing:\n\n  {%- for role in roles %}\n  \u0027{{role.name}}_mappings\u0027,\n  {%- endfor %}","commit_id":"62de64933b3c14bf332153180bf3cb5b4f9a34e4"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"de24d6545cc5614a9657f8859a3875937624c279","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        mappings \u003d [{% for role in roles %}"},{"line_number":205,"context_line":"                    \u0027{{role.name}}_mappings\u0027,"},{"line_number":206,"context_line":"                    {% endfor %}"},{"line_number":207,"context_line":"                    \u0027nexus_config\u0027]"},{"line_number":208,"context_line":"        mapdict_list \u003d []"},{"line_number":209,"context_line":"        nexus \u003d {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff346bd7_d2230405","line":206,"range":{"start_line":206,"start_character":23,"end_line":206,"end_character":29},"in_reply_to":"1f1a1f67_1ddcc544","updated":"2017-07-21 17:37:43.000000000","message":"Done","commit_id":"62de64933b3c14bf332153180bf3cb5b4f9a34e4"}]}
