)]}'
{"network/ports/net_ip_map.j2.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"e6e71f5200868aa41f5bb448c53a004ead134b1b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  {{network.name}}Ip:"},{"line_number":13,"context_line":"    default: \u0027\u0027"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"  {{network.name}}IpSubnet:"},{"line_number":16,"context_line":"    default: \u0027\u0027"},{"line_number":17,"context_line":"    type: string"},{"line_number":18,"context_line":"  {{network.name}}IpUri:"},{"line_number":19,"context_line":"    default: \u0027\u0027"},{"line_number":20,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff346bd7_63dc7d46","line":17,"range":{"start_line":15,"start_character":2,"end_line":17,"end_character":16},"updated":"2017-07-22 12:02:52.000000000","message":"I think you need to add a description here - description\u0027: \u0027IP address/subnet on the {{name.lower}} network\u0027\n\npep8 is failing with:\nMismatched parameter definitions found for \"ManagementIpSubnet\"\n2017-07-22 05:51:52.262289 | Definitions found:\n2017-07-22 05:51:52.262314 |   ./net-config-bridge.yaml:\n2017-07-22 05:51:52.262353 |     {\u0027default\u0027: \u0027\u0027, \u0027description\u0027: \u0027IP address/subnet on the management network\u0027, \u0027type\u0027: \u0027string\u0027}\n..\n2017-07-22 05:51:52.264660 |   ./network/config/single-nic-linux-bridge-vlans/networker.yaml:\n2017-07-22 05:51:52.264695 |     {\u0027default\u0027: \u0027\u0027, \u0027description\u0027: \u0027IP address/subnet on the management network\u0027, \u0027type\u0027: \u0027string\u0027}\n2017-07-22 05:51:52.264715 |   ./network/ports/net_ip_map.yaml:\n2017-07-22 05:51:52.264735 |     {\u0027default\u0027: \u0027\u0027, \u0027type\u0027: \u0027string\u0027}\n\nIn all other cases ManagementIpSubnet has a description.","commit_id":"0c025485b8826aa19f3ada8f43f343bfda0eeb98"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"4118cebbd0c7832da3419ddb7041976153ffc6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff346bd7_2ae28c02","updated":"2017-07-25 08:49:58.000000000","message":"Not sure if this will be useful - http://paste.openstack.org/show/616400/\n\nBut it improves the readability (for me at least).","commit_id":"13150610e244cf6469bf7b806f47e7641e4386d6"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"4118cebbd0c7832da3419ddb7041976153ffc6b9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"  {{network.name}}IpSubnet:"},{"line_number":16,"context_line":"    default: \u0027\u0027"},{"line_number":17,"context_line":"    description: \u0027IP address/subnet on the {{name.lower}} network\u0027"},{"line_number":18,"context_line":"    type: string"},{"line_number":19,"context_line":"  {{network.name}}IpUri:"},{"line_number":20,"context_line":"    default: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_456f0192","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":55},"updated":"2017-07-25 08:49:58.000000000","message":"should be network.name_lower?","commit_id":"13150610e244cf6469bf7b806f47e7641e4386d6"}],"puppet/role.role.j2.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"4118cebbd0c7832da3419ddb7041976153ffc6b9","unresolved":false,"context_lines":[{"line_number":658,"context_line":"          PRIMARYHOST: {get_attr: [{{server_resource_name}}, name]}"},{"line_number":659,"context_line":"  {%- for network in networks %}"},{"line_number":660,"context_line":"          {{network.name.upper()}}IP: {get_attr: [{{network.name}}Port, ip_address]}"},{"line_number":661,"context_line":"          {{network.name.upper()}}HOST: {get_attr: [NetHostMap, value, {{network.name_lower|default(network.name.lower())}}, short]}"},{"line_number":662,"context_line":"  {%- endfor %}"},{"line_number":663,"context_line":"          CTLPLANEIP: {get_attr: [{{server_resource_name}}, networks, ctlplane, 0]}"},{"line_number":664,"context_line":"          CTLPLANEHOST: {get_attr: [NetHostMap, value, ctlplane, short]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_6aead4ac","line":661,"range":{"start_line":661,"start_character":71,"end_line":661,"end_character":123},"updated":"2017-07-25 08:49:58.000000000","message":"nit: Could be changed to \"{{network.name_lower}}\" as lower is defined by default and we do use it above.","commit_id":"13150610e244cf6469bf7b806f47e7641e4386d6"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"4118cebbd0c7832da3419ddb7041976153ffc6b9","unresolved":false,"context_lines":[{"line_number":677,"context_line":"          PRIMARYHOST: {get_attr: [{{server_resource_name}}, name]}"},{"line_number":678,"context_line":"  {%- for network in networks %}"},{"line_number":679,"context_line":"          {{network.name.upper()}}IP: {get_attr: [{{network.name}}Port, ip_address]}"},{"line_number":680,"context_line":"          {{network.name.upper()}}HOST: {get_attr: [NetHostMap, value, {{network.name_lower|default(network.name.lower())}}, short]}"},{"line_number":681,"context_line":"  {%- endfor %}"},{"line_number":682,"context_line":"          CTLPLANEIP: {get_attr: [{{server_resource_name}}, networks, ctlplane, 0]}"},{"line_number":683,"context_line":"          CTLPLANEHOST: {get_attr: [NetHostMap, value, ctlplane, short]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_0adb481b","line":680,"range":{"start_line":680,"start_character":71,"end_line":680,"end_character":123},"updated":"2017-07-25 08:49:58.000000000","message":"same here","commit_id":"13150610e244cf6469bf7b806f47e7641e4386d6"}]}