)]}'
{"docker/services/heat-api-cfn.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8d9295b7a9b7266c5a8074a0387416a7372f8bfc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api-cfn is running\""},{"line_number":134,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api-cfn\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":135,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0"},{"line_number":136,"context_line":"          tags: step0,validation"},{"line_number":137,"context_line":"        - name: check for heat_api_cfn running under apache (post upgrade)"},{"line_number":138,"context_line":"          tags: step2"},{"line_number":139,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_cfn_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf3e73b7_a234954b","line":136,"updated":"2017-08-07 09:23:13.000000000","message":"IIUC, the result of this step should be evaluated somewhere, yet it doesn\u0027t","commit_id":"77af0ede6fd7800536e4904ea76101800d15d31b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7bd062f856a0a81d1c1963a4d4f90f2553ee251d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"          tags: common"},{"line_number":131,"context_line":"          ignore_errors: True"},{"line_number":132,"context_line":"          register: heat_api_cfn_enabled"},{"line_number":133,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api-cfn is running\""},{"line_number":134,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api-cfn\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":135,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0"},{"line_number":136,"context_line":"          tags: step0,validation"},{"line_number":137,"context_line":"        - name: check for heat_api_cfn running under apache (post upgrade)"},{"line_number":138,"context_line":"          tags: step2"},{"line_number":139,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_cfn_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_902c409a","line":136,"range":{"start_line":133,"start_character":0,"end_line":136,"end_character":32},"updated":"2017-08-08 15:43:06.000000000","message":"Idem","commit_id":"8e0004bf4e6f1114fba319538736bb82ae4659af"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0f26baa9b48e14c51ab5826d2f62d24d266cd343","unresolved":false,"context_lines":[{"line_number":139,"context_line":"          service: name\u003dopenstack-heat-api-cfn state\u003dstopped enabled\u003dno"},{"line_number":140,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0"},{"line_number":141,"context_line":"        - name: check for heat_api_cfn running under apache (post upgrade)"},{"line_number":142,"context_line":"          tags: step0"},{"line_number":143,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_cfn_wsgi\""},{"line_number":144,"context_line":"          register: heat_api_cfn_apache"},{"line_number":145,"context_line":"          ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f436f4f_1235d446","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":21},"updated":"2017-08-09 15:42:55.000000000","message":"do we need \u0027common\u0027 here as well then so that heat_api_cfn_apache is available across steps (now it will be checked again in step2 for example line 151)\n\nOR,\n\nwhy are you moving this to step0? if there is no need/reason moving it back to same step it is checked in should remove the need for \u0027common\u0027 tag","commit_id":"9cf2a6e1b7b5ce60ffac3f213b55e9e2f17399ba"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"781ae6eb39649dbb32f6236bac6733a3fc0c23c7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"          service: name\u003dopenstack-heat-api-cfn state\u003dstopped enabled\u003dno"},{"line_number":140,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0"},{"line_number":141,"context_line":"        - name: check for heat_api_cfn running under apache (post upgrade)"},{"line_number":142,"context_line":"          tags: step0"},{"line_number":143,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_cfn_wsgi\""},{"line_number":144,"context_line":"          register: heat_api_cfn_apache"},{"line_number":145,"context_line":"          ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f436f4f_86a5f706","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":21},"in_reply_to":"9f436f4f_1235d446","updated":"2017-08-10 06:36:58.000000000","message":"Yep, you are right. I changed it as a refactoring so it was clearer the steps but I should not have changed the tags for the httpd service. \nWhen testing it I got the following error during upgrade (in heat-api where I did the same change):\n\n    TASK [Stop heat_api service (running under httpd)] *****************************\n    fatal: [localhost]: FAILED! \u003d\u003e {\"failed\": true, \"msg\": \"The conditional check \u0027heat_api_apache.rc \u003d\u003d 0\u0027 failed. The error was: error while evaluating conditional (heat_api_apache.rc \u003d\u003d 0): \u0027heat_api_apache\u0027 is undefined\"}\n    \tto retry, use: --limit @/var/lib/heat-config/heat-config-ansible/2a66567c-aad9-463a-8f08-a40cabfe9db8_playbook.retry\n\nI will move the tag back to \u0027step2\u0027","commit_id":"9cf2a6e1b7b5ce60ffac3f213b55e9e2f17399ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6a36a9d38b202c21a44bb48008d9e57dbc1a6ed1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"          tags: step0,validation"},{"line_number":148,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_cfn_wsgi\""},{"line_number":149,"context_line":"          register: heat_api_cfn_apache"},{"line_number":150,"context_line":"          ignore_errors: true"},{"line_number":151,"context_line":"          changed_when: false"},{"line_number":152,"context_line":"          check_mode: no"},{"line_number":153,"context_line":"          when: heat_api_cfn_enabled.rc !\u003d 0 and httpd_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f436f4f_9a335b14","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":29},"updated":"2017-08-17 06:44:41.000000000","message":"same","commit_id":"392ec38e89823b033d87d6e302db084af875c9b1"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"cc2720f4d1c3cc5a18ac41c42e6e3f0b1573f57b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"          ignore_errors: True"},{"line_number":132,"context_line":"          register: heat_api_cfn_enabled"},{"line_number":133,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api-cfn is running\""},{"line_number":134,"context_line":"          command: systemctl is-active --quiet openstack-heat-api-cfn"},{"line_number":135,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0"},{"line_number":136,"context_line":"          tags: step0,validation"},{"line_number":137,"context_line":"        - name: Stop and disable heat_api_cfn service (pre-upgrade not under httpd)"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7f287b81_6218fed2","line":134,"updated":"2017-08-22 11:01:10.000000000","message":"Service might be \u0027enabled\u0027 but not running. Worth adding \u0027ignore_errors\u0027 as in previous task.","commit_id":"fdb4ed7ba89de9efcd7b447cf91ea0a41646084a"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"cc2720f4d1c3cc5a18ac41c42e6e3f0b1573f57b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        - name: Stop and disable heat_api_cfn service (pre-upgrade not under httpd)"},{"line_number":138,"context_line":"          tags: step2"},{"line_number":139,"context_line":"          service: name\u003dopenstack-heat-api-cfn state\u003dstopped enabled\u003dno"},{"line_number":140,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0"},{"line_number":141,"context_line":"        - name: Check for heat_api_cfn running under apache"},{"line_number":142,"context_line":"          tags: common"},{"line_number":143,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_cfn_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7f287b81_02037a44","line":140,"updated":"2017-08-22 11:01:10.000000000","message":"Don\u0027t know how probable this is, but what about if service is disabled but running ? Worth using OR - running OR enabled","commit_id":"fdb4ed7ba89de9efcd7b447cf91ea0a41646084a"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"cc2720f4d1c3cc5a18ac41c42e6e3f0b1573f57b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"          register: httpd_running"},{"line_number":151,"context_line":"        - name: \"PreUpgrade step0,validation: Check if heat_api_cfn_wsgi is running\""},{"line_number":152,"context_line":"          tags: step0,validation"},{"line_number":153,"context_line":"          shell: /usr/bin/systemctl status \u0027httpd\u0027 | grep -q heat_api_cfn_wsgi"},{"line_number":154,"context_line":"          when: heat_api_cfn_enabled.rc !\u003d 0 and httpd_enabled.rc \u003d\u003d 0 and httpd_running.rc \u003d\u003d 0"},{"line_number":155,"context_line":"        - name: Stop heat_api_cfn service (running under httpd)"},{"line_number":156,"context_line":"          tags: step2"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7f287b81_c2d9f222","line":153,"updated":"2017-08-22 11:01:10.000000000","message":"In \u0027PreUpgrade step0,validation: Check service openstack-heat-api-cfn is running\u0027 U use \u0027systemctl\u0027 and here \u0027/usr/bin/systemctl\u0027. Please make them consistent.","commit_id":"fdb4ed7ba89de9efcd7b447cf91ea0a41646084a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b4274c58112752735047e68a944d600c14c980d6","unresolved":false,"context_lines":[{"line_number":150,"context_line":"          register: httpd_running"},{"line_number":151,"context_line":"        - name: \"PreUpgrade step0,validation: Check if heat_api_cfn_wsgi is running\""},{"line_number":152,"context_line":"          tags: step0,validation"},{"line_number":153,"context_line":"          shell: systemctl status \u0027httpd\u0027 | grep -q heat_api_cfn_wsgi"},{"line_number":154,"context_line":"          when: heat_api_cfn_enabled.rc \u003d\u003d 0 and httpd_enabled.rc \u003d\u003d 0 and httpd_running.rc \u003d\u003d 0"},{"line_number":155,"context_line":"        - name: Stop heat_api_cfn service (running under httpd)"},{"line_number":156,"context_line":"          tags: step2"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7f287b81_760ff636","line":153,"range":{"start_line":153,"start_character":17,"end_line":153,"end_character":69},"updated":"2017-08-29 08:04:24.000000000","message":"hmmm i was going to suggest doing like line 135 but that is if they are defined (DUMP_VHOSTS) but may not necessarily be running.","commit_id":"2cff0815ea2d5a9e54d1b9a9f44c5e216dc875bb"}],"docker/services/heat-api.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8d9295b7a9b7266c5a8074a0387416a7372f8bfc","unresolved":false,"context_lines":[{"line_number":157,"context_line":"          ignore_errors: True"},{"line_number":158,"context_line":"          register: heat_api_enabled"},{"line_number":159,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api is running\""},{"line_number":160,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":161,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":162,"context_line":"          tags: step0,validation"},{"line_number":163,"context_line":"        - name: check for heat_api running under apache (post upgrade)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf3e73b7_2248a5ca","line":160,"updated":"2017-08-07 09:23:13.000000000","message":"ditto","commit_id":"77af0ede6fd7800536e4904ea76101800d15d31b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"74aeb1f44b84fc43410783a0161f75276d64ba99","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          tags: common"},{"line_number":157,"context_line":"          ignore_errors: True"},{"line_number":158,"context_line":"          register: heat_api_enabled"},{"line_number":159,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api is running\""},{"line_number":160,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":161,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":162,"context_line":"          tags: step0,validation"},{"line_number":163,"context_line":"        - name: check for heat_api running under apache (post upgrade)"},{"line_number":164,"context_line":"          tags: step2"},{"line_number":165,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_f506de20","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":32},"updated":"2017-08-08 15:42:51.000000000","message":"¿Does this service runs under httpd ?","commit_id":"8e0004bf4e6f1114fba319538736bb82ae4659af"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8175b0ae34ef3e0349a7ff7f7e384701565fc2c0","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          tags: common"},{"line_number":157,"context_line":"          ignore_errors: True"},{"line_number":158,"context_line":"          register: heat_api_enabled"},{"line_number":159,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api is running\""},{"line_number":160,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":161,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":162,"context_line":"          tags: step0,validation"},{"line_number":163,"context_line":"        - name: check for heat_api running under apache (post upgrade)"},{"line_number":164,"context_line":"          tags: step2"},{"line_number":165,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_d6c5205d","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":32},"in_reply_to":"9f436f4f_90932050","updated":"2017-08-08 17:11:07.000000000","message":"So as we discussed, check this example:\nhttps://review.openstack.org/#/c/489940/4/docker/services/cinder-api.yaml","commit_id":"8e0004bf4e6f1114fba319538736bb82ae4659af"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"eacaa6f10af08b701b98cc7cd452e581ed17d65b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          tags: common"},{"line_number":157,"context_line":"          ignore_errors: True"},{"line_number":158,"context_line":"          register: heat_api_enabled"},{"line_number":159,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api is running\""},{"line_number":160,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":161,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":162,"context_line":"          tags: step0,validation"},{"line_number":163,"context_line":"        - name: check for heat_api running under apache (post upgrade)"},{"line_number":164,"context_line":"          tags: step2"},{"line_number":165,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_a8d0e651","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":32},"in_reply_to":"9f436f4f_d6c5205d","updated":"2017-08-09 08:59:25.000000000","message":"Done! Also did some re-ordering for heat-api-cfn","commit_id":"8e0004bf4e6f1114fba319538736bb82ae4659af"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"7a9f020cfc69feab9a30292bbd7eb8e42404b355","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          tags: common"},{"line_number":157,"context_line":"          ignore_errors: True"},{"line_number":158,"context_line":"          register: heat_api_enabled"},{"line_number":159,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api is running\""},{"line_number":160,"context_line":"          shell: /usr/bin/systemctl show \u0027openstack-heat-api\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":161,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":162,"context_line":"          tags: step0,validation"},{"line_number":163,"context_line":"        - name: check for heat_api running under apache (post upgrade)"},{"line_number":164,"context_line":"          tags: step2"},{"line_number":165,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_90932050","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":32},"in_reply_to":"9f436f4f_f506de20","updated":"2017-08-08 15:59:44.000000000","message":"ommit","commit_id":"8e0004bf4e6f1114fba319538736bb82ae4659af"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"fd3604938b5f6d228f7a61573537b1e9f9eb1969","unresolved":false,"context_lines":[{"line_number":165,"context_line":"          service: name\u003dopenstack-heat-api state\u003dstopped enabled\u003dno"},{"line_number":166,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":167,"context_line":"        - name: Check if httpd service is running"},{"line_number":168,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":169,"context_line":"          tags: common"},{"line_number":170,"context_line":"          ignore_errors: True"},{"line_number":171,"context_line":"          register: httpd_enabled  "}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_7c71ee75","line":168,"updated":"2017-08-16 09:46:04.000000000","message":"it would be better to check if the service is running instead of being enabled, right?","commit_id":"ce7118cf07295c7547490a68df237dd175512678"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0ad28ced0e68f0aa348cde1c70e0601fbe7cfb45","unresolved":false,"context_lines":[{"line_number":165,"context_line":"          service: name\u003dopenstack-heat-api state\u003dstopped enabled\u003dno"},{"line_number":166,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0"},{"line_number":167,"context_line":"        - name: Check if httpd service is running"},{"line_number":168,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":169,"context_line":"          tags: common"},{"line_number":170,"context_line":"          ignore_errors: True"},{"line_number":171,"context_line":"          register: httpd_enabled  "}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_5caaaa18","line":168,"in_reply_to":"9f436f4f_7c71ee75","updated":"2017-08-16 10:05:46.000000000","message":"yeah i think so. i initially started to write \"well both, check running only if enabled\" but for this case, just checking it is running is enough. we have \u0027ignore_errors\u0027 here to deal with the case it isn\u0027t enabled or running.","commit_id":"ce7118cf07295c7547490a68df237dd175512678"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0ad28ced0e68f0aa348cde1c70e0601fbe7cfb45","unresolved":false,"context_lines":[{"line_number":168,"context_line":"          command: systemctl is-enabled httpd"},{"line_number":169,"context_line":"          tags: common"},{"line_number":170,"context_line":"          ignore_errors: True"},{"line_number":171,"context_line":"          register: httpd_enabled  "},{"line_number":172,"context_line":"        - name: check for heat_api running under apache (post upgrade)"},{"line_number":173,"context_line":"          tags: step0,validation"},{"line_number":174,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_1c66622b","line":171,"range":{"start_line":171,"start_character":33,"end_line":171,"end_character":35},"updated":"2017-08-16 10:05:46.000000000","message":"whitespace","commit_id":"ce7118cf07295c7547490a68df237dd175512678"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6a36a9d38b202c21a44bb48008d9e57dbc1a6ed1","unresolved":false,"context_lines":[{"line_number":173,"context_line":"          tags: step0,validation"},{"line_number":174,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""},{"line_number":175,"context_line":"          register: heat_api_apache"},{"line_number":176,"context_line":"          ignore_errors: true"},{"line_number":177,"context_line":"          changed_when: false"},{"line_number":178,"context_line":"          check_mode: no"},{"line_number":179,"context_line":"          when: heat_api_enabled.rc !\u003d 0 and httpd_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f436f4f_da57a325","line":176,"range":{"start_line":176,"start_character":10,"end_line":176,"end_character":28},"updated":"2017-08-17 06:44:41.000000000","message":"i think we want to remove this one now since we\u0027re guarding with the when (so we know there is no standalone heat-api and httpd is running so we can expect the vhost to be there, or there is a problem, wdyt?)","commit_id":"392ec38e89823b033d87d6e302db084af875c9b1"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7ce17da1e8bec359ca31d9439807506dab80537b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        - name: Stop heat_api service (running under httpd)"},{"line_number":180,"context_line":"          tags: step2"},{"line_number":181,"context_line":"          service: name\u003dhttpd state\u003dstopped"},{"line_number":182,"context_line":"          when: heat_api_apache.rc \u003d\u003d 0"},{"line_number":183,"context_line":"      metadata_settings:"},{"line_number":184,"context_line":"        get_attr: [HeatBase, role_data, metadata_settings]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f436f4f_abe0edfb","line":182,"updated":"2017-08-18 11:20:34.000000000","message":"Do not use heat_api_apache variable, as it won\u0027t be registered if the condition in previous step is not fulfilled","commit_id":"10b2ea226f3a69cfcdaa8e74beef4acc9a17497c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"040431e9978ba168fc44541a19eac7f584475d06","unresolved":false,"context_lines":[{"line_number":168,"context_line":"          shell: \"httpd -t -D DUMP_VHOSTS | grep -q heat_api_wsgi\""},{"line_number":169,"context_line":"          ignore_errors: True"},{"line_number":170,"context_line":"          register: httpd_enabled"},{"line_number":171,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-api is running\""},{"line_number":172,"context_line":"          command: systemctl is-active --quiet openstack-heat-api"},{"line_number":173,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0 and httpd_enabled.rc !\u003d 0"},{"line_number":174,"context_line":"          tags: step0,validation"},{"line_number":175,"context_line":"        - name: Stop and disable heat_api service (pre-upgrade not under httpd)"},{"line_number":176,"context_line":"          tags: step2"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ff5d4b2f_7ed1b957","line":173,"range":{"start_line":171,"start_character":34,"end_line":173,"end_character":38},"updated":"2017-09-19 07:12:36.000000000","message":"I had to go and check about this, I wasn\u0027t sure if we had already migrated heat-api to apache in the previous cycle.\n\nLooks like this is needed in fact, afaics. In stable/ocata we don\u0027t have the \u0027is apache or not\u0027 dance in the upgrade_tasks https://github.com/openstack/tripleo-heat-templates/blob/stable/ocata/puppet/services/heat-api.yaml but we do have them for stable/pike. So this must have happened during the P cycle and we need to check here.","commit_id":"522f10a7872ffb416e6388f65e9d2953cbe338dd"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"80646ce2d743d62ba0623fb54e33288302d9b3ca","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        - name: \"PreUpgrade step0,validation: Check if heat_api_wsgi is running\""},{"line_number":185,"context_line":"          shell: systemctl status \u0027httpd\u0027 | grep -q heat_api_wsgi"},{"line_number":186,"context_line":"          tags: step0,validation"},{"line_number":187,"context_line":"          when: heat_api_enabled.rc \u003d\u003d 0 and httpd_enabled.rc \u003d\u003d 0 and httpd_running.rc \u003d\u003d 0"},{"line_number":188,"context_line":"        - name: Stop heat_api service (running under httpd)"},{"line_number":189,"context_line":"          tags: step2"},{"line_number":190,"context_line":"          service: name\u003dhttpd state\u003dstopped"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ff5d4b2f_763b159c","line":187,"updated":"2017-09-19 14:31:19.000000000","message":"Need to rework this, with so many changes I missplaced the service_enabled.rc \u003d\u003d 0 condition when the service is running under httpd. This condition is exclusive, either we have the service running under systemctl (service_enabled \u003d\u003d 0) or under httpd (service_enabled !\u003d 0)","commit_id":"522f10a7872ffb416e6388f65e9d2953cbe338dd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3a72851636e8739f283fa4ac56a766064344ffd4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"          command: systemctl is-active --quiet httpd"},{"line_number":182,"context_line":"          ignore_errors: True"},{"line_number":183,"context_line":"          register: httpd_running"},{"line_number":184,"context_line":"        - name: \"PreUpgrade step0,validation: Check if heat_api_wsgi is running\""},{"line_number":185,"context_line":"          shell: systemctl status \u0027httpd\u0027 | grep -q heat_api_wsgi"},{"line_number":186,"context_line":"          tags: step0,validation"},{"line_number":187,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0 and httpd_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7f515b1d_206273af","line":184,"updated":"2017-09-27 08:51:41.000000000","message":"\"is running under httpd\"\n\nI should -1 for that ^^^ but then I\u0027d have to assume a new identity and enter the witness protection program probably, so I won\u0027t I guess. /me shrugs.","commit_id":"2addd5833e25d6baf36bad6abc2384218c582259"}],"docker/services/heat-engine.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"79463d447328319c54ed5868247e3b8945af8379","unresolved":false,"context_lines":[{"line_number":140,"context_line":"          ignore_errors: True"},{"line_number":141,"context_line":"          register: heat_engine_enabled"},{"line_number":142,"context_line":"        - name: \"PreUpgrade step0,validation: Check service openstack-heat-engine is running\""},{"line_number":143,"context_line":"          commaned: systemctl is-active --quiet openstack-heat-engine"},{"line_number":144,"context_line":"          when: heat_engine_enabled.rc \u003d\u003d 0"},{"line_number":145,"context_line":"          tags: step0,validation"},{"line_number":146,"context_line":"        - name: Stop and disable heat_engine service"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f436f4f_7ed09d54","line":143,"updated":"2017-08-17 15:13:05.000000000","message":"commaned instead of command. This is typo makes most of the jobs fail","commit_id":"392ec38e89823b033d87d6e302db084af875c9b1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"040431e9978ba168fc44541a19eac7f584475d06","unresolved":false,"context_lines":[{"line_number":145,"context_line":"          tags: step0,validation"},{"line_number":146,"context_line":"        - name: Stop and disable heat_engine service"},{"line_number":147,"context_line":"          tags: step2"},{"line_number":148,"context_line":"          when: heat_engine_enabled.rc \u003d\u003d 0"},{"line_number":149,"context_line":"          service: name\u003dopenstack-heat-engine state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ff5d4b2f_5e51550e","line":148,"range":{"start_line":148,"start_character":11,"end_line":148,"end_character":38},"updated":"2017-09-19 07:12:36.000000000","message":"do we need this one (see discussion at https://review.openstack.org/#/c/489957/11/docker/services/neutron-ovs-agent.yaml ) i.e. why can\u0027t we just stop and disable even if it is already stopped/running/enabled/disabled does it matter?","commit_id":"522f10a7872ffb416e6388f65e9d2953cbe338dd"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ae4b30baca46ec9eb0041ffe4cb9d4c0a1feaea5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"          command: systemctl is-active --quiet openstack-heat-engine"},{"line_number":144,"context_line":"          when: heat_engine_enabled.rc \u003d\u003d 0"},{"line_number":145,"context_line":"          tags: step0,validation"},{"line_number":146,"context_line":"        - name: Stop and disable heat_engine service"},{"line_number":147,"context_line":"          tags: step2"},{"line_number":148,"context_line":"          service: name\u003dopenstack-heat-engine state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4b6375_b33402e0","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":70},"updated":"2017-10-18 08:58:43.000000000","message":"Hey, quick question, we are stopping/disabling services without any check. What if is not installed? If you dont have the ignore errors this will fail.","commit_id":"0518b220ba01ce9eb813439c76874cc28606ffa7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2ce7e4bded34efc89df1826e0692dc7ce7197a5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"          command: systemctl is-active --quiet openstack-heat-engine"},{"line_number":144,"context_line":"          when: heat_engine_enabled.rc \u003d\u003d 0"},{"line_number":145,"context_line":"          tags: step0,validation"},{"line_number":146,"context_line":"        - name: Stop and disable heat_engine service"},{"line_number":147,"context_line":"          tags: step2"},{"line_number":148,"context_line":"          service: name\u003dopenstack-heat-engine state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4b6375_f167f624","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":70},"in_reply_to":"3f4b6375_b33402e0","updated":"2017-10-19 07:21:30.000000000","message":"as i just commented here https://review.openstack.org/#/c/502037/7/docker/services/ironic-conductor.yaml repeating:\n\nso we discussed this already a while back. the answer is if the service isn\u0027t _enabled_ i.e. in tripleo, with roles data and resource registry, then this file isn\u0027t included and these tasks aren\u0027t run.\n\nIf this isn\u0027t true or fails for some other reason then lets add them","commit_id":"0518b220ba01ce9eb813439c76874cc28606ffa7"}]}