)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"59b35c0f1bfc9dac6b71a96f67e3e1aa9c0e0043","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This change should ensure br-ex exists after step 3."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ie425148b0ad0f38e149c5fa0a97d98ec35d0a5bb"},{"line_number":22,"context_line":"Closes-Bug: #1699261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_ca4ad253","line":22,"updated":"2017-08-24 20:51:28.000000000","message":"Should be #1691403","commit_id":"14a4a969122ffc52e851b3554aaa2253cdc612ee"}],"docker/services/neutron-ovs-agent.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8257b9bb56362056e745bf775c2ca21fbc293d97","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":62,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":63,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":64,"context_line":"      NeutronBridgeMappings: {get_param: NeutronBridgeMappings}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"outputs:"},{"line_number":67,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f436f4f_80b9df15","line":64,"updated":"2017-08-15 15:31:15.000000000","message":"Maybe I am missing something, but if this is already defaulting to datacentre:br-ex in neutron-ovs-agent.yaml, how does this change make a difference?","commit_id":"f666d7522224363921ae840ce17f8b518c113080"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"975185470ac70523bc7da49f6a5a659bd10421ed","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                  - /var/lib/config-data/puppet-generated/neutron/:/var/lib/kolla/config_files/src:ro"},{"line_number":111,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":112,"context_line":"                  - /run:/run"},{"line_number":113,"context_line":"                  - /var/log/containers/neutron:/var/log/neutron"},{"line_number":114,"context_line":"            environment:"},{"line_number":115,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":116,"context_line":"        step_4:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_bc7a7885","line":113,"updated":"2017-08-23 01:35:59.000000000","message":"Need to mount in /etc/puppet","commit_id":"118a5355c7522be1c0c1f466ecef73c3745808eb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ca81dfc62675747774629b66bba3bd7ca9009f6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            detach: false"},{"line_number":84,"context_line":"            image: {get_param: DockerNeutronConfigImage}"},{"line_number":85,"context_line":"            net: host"},{"line_number":86,"context_line":"            pid: host"},{"line_number":87,"context_line":"            privileged: true"},{"line_number":88,"context_line":"            command:"},{"line_number":89,"context_line":"              - puppet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_105b68f7","line":86,"updated":"2017-08-25 01:43:54.000000000","message":"user: root","commit_id":"14a4a969122ffc52e851b3554aaa2253cdc612ee"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ca81dfc62675747774629b66bba3bd7ca9009f6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            privileged: true"},{"line_number":88,"context_line":"            command:"},{"line_number":89,"context_line":"              - puppet"},{"line_number":90,"context_line":"              - apply"},{"line_number":91,"context_line":"              - --tags"},{"line_number":92,"context_line":"              - neutron::plugins::ovs::bridge"},{"line_number":93,"context_line":"              - -v"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_f0cfbcad","line":90,"updated":"2017-08-25 01:43:54.000000000","message":"needs\n\n  - --modulepath\n  - /usr/share/openstack-puppet/modules","commit_id":"14a4a969122ffc52e851b3554aaa2253cdc612ee"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ca81dfc62675747774629b66bba3bd7ca9009f6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"              - puppet"},{"line_number":90,"context_line":"              - apply"},{"line_number":91,"context_line":"              - --tags"},{"line_number":92,"context_line":"              - neutron::plugins::ovs::bridge"},{"line_number":93,"context_line":"              - -v"},{"line_number":94,"context_line":"              - -e"},{"line_number":95,"context_line":"              - include neutron::agents::ml2::ovs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_303b049d","line":92,"updated":"2017-08-25 01:43:54.000000000","message":"should be\n\n  - file,file_line,concat,augeas,neutron::plugins::ovs::bridge","commit_id":"14a4a969122ffc52e851b3554aaa2253cdc612ee"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ca81dfc62675747774629b66bba3bd7ca9009f6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                  - /var/lib/config-data/puppet-generated/neutron/:/var/lib/kolla/config_files/src:ro"},{"line_number":102,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":103,"context_line":"                  - /run:/run"},{"line_number":104,"context_line":"                  - /etc/puppet:/etc/puppet:ro"},{"line_number":105,"context_line":"            environment:"},{"line_number":106,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":107,"context_line":"        step_4:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_905518c9","line":104,"updated":"2017-08-25 01:43:54.000000000","message":"missing\n\n  - /usr/share/openstack-puppet/modules/:/usr/share/openstack-puppet/modules/:ro\n  - /var/run/openvswitch/db.sock:/var/run/openvswitch/db.sock","commit_id":"14a4a969122ffc52e851b3554aaa2253cdc612ee"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"a9af7cbc3ab83b085fe3f2b41d90ecfddb5cfc68","unresolved":false,"context_lines":[{"line_number":90,"context_line":"              - puppet"},{"line_number":91,"context_line":"              - apply"},{"line_number":92,"context_line":"              - --modulepath"},{"line_number":93,"context_line":"              - /usr/share/openstack-puppet/modules"},{"line_number":94,"context_line":"              - --tags"},{"line_number":95,"context_line":"              - file,file_line,concat,augeas,neutron::plugins::ovs::bridge"},{"line_number":96,"context_line":"              - -v"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f287b81_b69c576a","line":93,"updated":"2017-08-28 12:28:28.000000000","message":"I think the correct location is /etc/puppet/modules. Some of our scripts may extract modules there without necessarily adding in the soft links to the RPM version location you have here.","commit_id":"40b615ba10af755c9383a78843189a8ce8d718fd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"416e86ab3bea632269162118c717bda5ca9d3cd8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"              - puppet"},{"line_number":91,"context_line":"              - apply"},{"line_number":92,"context_line":"              - --modulepath"},{"line_number":93,"context_line":"              - /usr/share/openstack-puppet/modules"},{"line_number":94,"context_line":"              - --tags"},{"line_number":95,"context_line":"              - file,file_line,concat,augeas,neutron::plugins::ovs::bridge"},{"line_number":96,"context_line":"              - -v"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f287b81_962030ae","line":93,"in_reply_to":"7f287b81_b69c576a","updated":"2017-08-28 19:46:46.000000000","message":"I\u0027ll just do something like this https://github.com/openstack/tripleo-heat-templates/blob/be8f4afdafe2e968e9b3e7f627b6b31d1f0560fa/common/deploy-steps-tasks.yaml#L12","commit_id":"40b615ba10af755c9383a78843189a8ce8d718fd"}]}
