)]}'
{"docker/services/database/mongodb.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"181d805aab78ce56b09256d35fd12d93eb11c2ff","unresolved":false,"context_lines":[{"line_number":164,"context_line":"          register: mongod_service"},{"line_number":165,"context_line":"        - name: \"PreUpgrade step0,validation: Check if mongod is running\""},{"line_number":166,"context_line":"          command: systemctl is-active --quiet mongod"},{"line_number":167,"context_line":"          when: mongod_enabled.rc \u003d\u003d 0"},{"line_number":168,"context_line":"          tags: step0,validation"},{"line_number":169,"context_line":"        - name: Stop and disable mongodb service"},{"line_number":170,"context_line":"          tags: step2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_fd535de1","line":167,"updated":"2017-09-22 08:58:50.000000000","message":"I think you meant mongod_service.rc","commit_id":"f5cb07476d5541985257aeb401d3d406570edd86"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"bded5e98471cc4d33fb5ee4b9a273b2923205d4a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"          register: mongod_service"},{"line_number":165,"context_line":"        - name: \"PreUpgrade step0,validation: Check if mongod is running\""},{"line_number":166,"context_line":"          command: systemctl is-active --quiet mongod"},{"line_number":167,"context_line":"          when: mongod_enabled.rc \u003d\u003d 0"},{"line_number":168,"context_line":"          tags: step0,validation"},{"line_number":169,"context_line":"        - name: Stop and disable mongodb service"},{"line_number":170,"context_line":"          tags: step2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_3d557551","line":167,"in_reply_to":"7f515b1d_fd535de1","updated":"2017-09-22 09:14:00.000000000","message":"Great catch! thanks","commit_id":"f5cb07476d5541985257aeb401d3d406570edd86"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":166,"context_line":"          command: systemctl is-active --quiet mongod"},{"line_number":167,"context_line":"          when: mongod_enabled.rc \u003d\u003d 0"},{"line_number":168,"context_line":"          tags: step0,validation"},{"line_number":169,"context_line":"        - name: Stop and disable mongodb service"},{"line_number":170,"context_line":"          tags: step2"},{"line_number":171,"context_line":"          service: name\u003dmongod state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_93a7c650","line":171,"range":{"start_line":169,"start_character":0,"end_line":171,"end_character":55},"updated":"2017-10-18 09:23:50.000000000","message":"Hey, quick question, we are stopping/disabling services without any check. What if is not installed? If you dont have the ignore errors this will fail.","commit_id":"f320f72884e48ef193587202aba11a47dd006913"}],"docker/services/database/mysql.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":218,"context_line":"          command: systemctl is-active --quiet mariadb"},{"line_number":219,"context_line":"          when: mariadb_enabled.rc \u003d\u003d 0"},{"line_number":220,"context_line":"          tags: step0,validation"},{"line_number":221,"context_line":"        - name: Stop and disable mysql service"},{"line_number":222,"context_line":"          tags: step2"},{"line_number":223,"context_line":"          service: name\u003dmariadb state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_336c9207","line":223,"range":{"start_line":221,"start_character":0,"end_line":223,"end_character":56},"updated":"2017-10-18 09:23:50.000000000","message":"Ditto","commit_id":"f320f72884e48ef193587202aba11a47dd006913"}],"docker/services/iscsid.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3bcf60e6084024f4bc527c1e3f96c4b12e57b209","unresolved":false,"context_lines":[{"line_number":125,"context_line":"          tags: step0,validation"},{"line_number":126,"context_line":"        - name: Stop and disable iscsid.socket service"},{"line_number":127,"context_line":"          tags: step2"},{"line_number":128,"context_line":"          service: name\u003discsid.socket state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_1fe28ad6","line":128,"updated":"2017-09-25 07:27:00.000000000","message":"went looking for the review that added this since it is a \u0027special\u0027 case (I mean it was doing stat on the iscsid.service  and has explicit when for the stop).\n\nThis should be fine afaics (especially wrt not checking and always invoking the stop, since it shouldn\u0027t matter if it is already stopped or not) but going to add dprince since he landed this originally https://review.openstack.org/#/c/462538/10/docker/services/iscsid.yaml@94\n\nThe upgrade job will also be good to check to make sure these tasks are executed OK","commit_id":"cd2c7395dd44627644e6760c2a9330e8c8c7fb00"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"          command: systemctl is-active --quiet iscsid"},{"line_number":112,"context_line":"          when: iscsid_enabled.rc \u003d\u003d 0"},{"line_number":113,"context_line":"          tags: step0,validation"},{"line_number":114,"context_line":"        - name: Stop and disable iscsid service"},{"line_number":115,"context_line":"          tags: step2"},{"line_number":116,"context_line":"          service: name\u003discsid state\u003dstopped enabled\u003dno"},{"line_number":117,"context_line":"        - name: Check if iscsid.socket service is deployed"},{"line_number":118,"context_line":"          tags: common"},{"line_number":119,"context_line":"          command: systemctl is-enabled --quiet iscsid.socket"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_b37f62aa","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":55},"updated":"2017-10-18 09:23:50.000000000","message":"Ditto","commit_id":"f320f72884e48ef193587202aba11a47dd006913"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"          command: systemctl is-active --quiet iscsid.socket"},{"line_number":124,"context_line":"          when: iscsid_socket_enabled.rc \u003d\u003d 0"},{"line_number":125,"context_line":"          tags: step0,validation"},{"line_number":126,"context_line":"        - name: Stop and disable iscsid.socket service"},{"line_number":127,"context_line":"          tags: step2"},{"line_number":128,"context_line":"          service: name\u003discsid.socket state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_137196e1","line":128,"range":{"start_line":126,"start_character":0,"end_line":128,"end_character":62},"updated":"2017-10-18 09:23:50.000000000","message":"Ditto","commit_id":"f320f72884e48ef193587202aba11a47dd006913"}],"docker/services/sensu-client.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":150,"context_line":"          command: systemctl is-active --quiet sensu-client"},{"line_number":151,"context_line":"          when: sensu_enabled.rc \u003d\u003d 0"},{"line_number":152,"context_line":"          tags: step0,validation"},{"line_number":153,"context_line":"        - name: Stop and disable sensu-client service"},{"line_number":154,"context_line":"          tags: step2"},{"line_number":155,"context_line":"          service: name\u003dsensu-client state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_937c66b6","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":61},"updated":"2017-10-18 09:23:50.000000000","message":"Ditto","commit_id":"f320f72884e48ef193587202aba11a47dd006913"}],"docker/services/tacker.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"          command: systemctl is-active --quiet openstack-tacker-server"},{"line_number":145,"context_line":"          when: tacker_enabled.rc \u003d\u003d 0"},{"line_number":146,"context_line":"          tags: step0,validation"},{"line_number":147,"context_line":"        - name: Stop and disable tacker-server service"},{"line_number":148,"context_line":"          tags: step2"},{"line_number":149,"context_line":"          service: name\u003dopenstack-tacker-server state\u003dstopped enabled\u003dno"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_3345b271","line":149,"range":{"start_line":147,"start_character":0,"end_line":149,"end_character":72},"updated":"2017-10-18 09:23:50.000000000","message":"Ditto","commit_id":"f320f72884e48ef193587202aba11a47dd006913"}],"docker/services/zaqar.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"1615380f916f87018490a6d33fdf4ca69d7e7ba2","unresolved":false,"context_lines":[{"line_number":201,"context_line":"          shell: systemctl status \u0027httpd\u0027 | grep -q zaqar_wsgi"},{"line_number":202,"context_line":"          tags: step0,validation"},{"line_number":203,"context_line":"          when: httpd_enabled.rc \u003d\u003d 0 and httpd_running.rc \u003d\u003d 0"},{"line_number":204,"context_line":"        - name: Stop and disable zaqar service"},{"line_number":205,"context_line":"          tags: step2"},{"line_number":206,"context_line":"          service: name\u003dhttpd state\u003dstopped enabled\u003dno"},{"line_number":207,"context_line":"      metadata_settings:"},{"line_number":208,"context_line":"        get_attr: [ZaqarBase, role_data, metadata_settings]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_93558620","line":206,"range":{"start_line":204,"start_character":0,"end_line":206,"end_character":54},"updated":"2017-10-18 09:23:50.000000000","message":"Ditto","commit_id":"f320f72884e48ef193587202aba11a47dd006913"}]}