)]}'
{"environments/compute-instanceha.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3fc8e0e88d68e7a8ace403da1c1e92021756d09a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# An environment which enables instance HA"},{"line_number":2,"context_line":"# Needs to be combined with environments/puppet-pacemaker.yaml"},{"line_number":3,"context_line":"# The ComputeInstanceHA *and* PacemakerRemote services need to be added"},{"line_number":4,"context_line":"# to your Compute role"},{"line_number":5,"context_line":"resource_registry:"},{"line_number":6,"context_line":"  OS::TripleO::Services::ComputeInstanceHA: ../puppet/services/pacemaker/compute-instanceha.yaml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_360b8d24","line":4,"updated":"2017-12-08 08:54:57.000000000","message":"I am trying to understand why is this manual addition of services to compute role for these 2 services. The idea of introducing roles/* yaml files is to provided pre-configured roles so that, the lesser modifications for roles_data files for users. This change is forcing a modification in the roles_data (generated), eventhough, enabling of this feature is controlled by an environment file. Why not modify the roles file to add these services (as it already disabled by default).","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b6ec4d88a06c0eef623de34091ed960265fb0925","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# An environment which enables instance HA"},{"line_number":2,"context_line":"# Needs to be combined with environments/puppet-pacemaker.yaml"},{"line_number":3,"context_line":"# The ComputeInstanceHA *and* PacemakerRemote services need to be added"},{"line_number":4,"context_line":"# to your Compute role"},{"line_number":5,"context_line":"resource_registry:"},{"line_number":6,"context_line":"  OS::TripleO::Services::ComputeInstanceHA: ../puppet/services/pacemaker/compute-instanceha.yaml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_c9e5c9dd","line":4,"in_reply_to":"df87a7cf_360b8d24","updated":"2017-12-09 14:12:05.000000000","message":"The reason for this is that we will want to allow operators to configure both traditional compute nodes *and* IHA compute nodes (which will get their VMs evacuated after a compute node failure). Also this is the firs pass of IHA in tripleo, and we ill need to gauge how operators will want to use it hence we prefer not to hardcode the services in the roles at this stage","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"3e773522f1864ca2a1c36b68fe92d1b0b302b512","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# An environment which enables instance HA"},{"line_number":2,"context_line":"# Needs to be combined with environments/puppet-pacemaker.yaml"},{"line_number":3,"context_line":"# The ComputeInstanceHA *and* PacemakerRemote services need to be added"},{"line_number":4,"context_line":"# to your Compute role"},{"line_number":5,"context_line":"resource_registry:"},{"line_number":6,"context_line":"  OS::TripleO::Services::ComputeInstanceHA: ../puppet/services/pacemaker/compute-instanceha.yaml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_8b3fa385","line":4,"in_reply_to":"df87a7cf_97810ec6","updated":"2017-12-11 10:26:11.000000000","message":"Note that I will submit a proper documentation patch that will explain this so folks don\u0027t have to dig into code to figure stuff out","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"887b62758609847b2bca27ad8284ad66939b7ab9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# An environment which enables instance HA"},{"line_number":2,"context_line":"# Needs to be combined with environments/puppet-pacemaker.yaml"},{"line_number":3,"context_line":"# The ComputeInstanceHA *and* PacemakerRemote services need to be added"},{"line_number":4,"context_line":"# to your Compute role"},{"line_number":5,"context_line":"resource_registry:"},{"line_number":6,"context_line":"  OS::TripleO::Services::ComputeInstanceHA: ../puppet/services/pacemaker/compute-instanceha.yaml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_f76e5bc7","line":4,"in_reply_to":"df87a7cf_c9e5c9dd","updated":"2017-12-11 06:25:29.000000000","message":"Thanks for the details. Could this be added as comments? The comments explains what to do, and doesn\u0027t say why is it different from implicit method. Could be useful (at-least to ppl like me).","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"624e16b262dfddafcccc5e9e47ff9910af792b58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# An environment which enables instance HA"},{"line_number":2,"context_line":"# Needs to be combined with environments/puppet-pacemaker.yaml"},{"line_number":3,"context_line":"# The ComputeInstanceHA *and* PacemakerRemote services need to be added"},{"line_number":4,"context_line":"# to your Compute role"},{"line_number":5,"context_line":"resource_registry:"},{"line_number":6,"context_line":"  OS::TripleO::Services::ComputeInstanceHA: ../puppet/services/pacemaker/compute-instanceha.yaml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_97810ec6","line":4,"in_reply_to":"df87a7cf_f76e5bc7","updated":"2017-12-11 08:50:13.000000000","message":"Sure will do","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"}],"puppet/services/keystone.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e46722e54de545aeca82ffcc836046bcb3b66e19","unresolved":false,"context_lines":[{"line_number":402,"context_line":"          keystone::endpoint::internal_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix]}"},{"line_number":403,"context_line":"          keystone::endpoint::admin_url: {get_param: [EndpointMap, KeystoneAdmin, uri_no_suffix]}"},{"line_number":404,"context_line":"          keystone::endpoint::region: {get_param: KeystoneRegion}"},{"line_number":405,"context_line":"          keystone::admin_password: {get_param: AdminPassword}"},{"line_number":406,"context_line":"        horizon:"},{"line_number":407,"context_line":"          if:"},{"line_number":408,"context_line":"          - keystone_ldap_domain_enabled"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_d1d0b0cc","line":405,"updated":"2017-12-04 06:45:29.000000000","message":"uhm... why does pacemaker need the keystone credentials?","commit_id":"baebbd972c3716aba492c80159534b500ac866b2"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b2ec2af0f0e470179ef39b33fa559cc99d659f8c","unresolved":false,"context_lines":[{"line_number":402,"context_line":"          keystone::endpoint::internal_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix]}"},{"line_number":403,"context_line":"          keystone::endpoint::admin_url: {get_param: [EndpointMap, KeystoneAdmin, uri_no_suffix]}"},{"line_number":404,"context_line":"          keystone::endpoint::region: {get_param: KeystoneRegion}"},{"line_number":405,"context_line":"          keystone::admin_password: {get_param: AdminPassword}"},{"line_number":406,"context_line":"        horizon:"},{"line_number":407,"context_line":"          if:"},{"line_number":408,"context_line":"          - keystone_ldap_domain_enabled"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_6c47874d","line":405,"in_reply_to":"df87a7cf_d1d0b0cc","updated":"2017-12-04 06:55:19.000000000","message":"Because there is a component which needs to talk to nova to do the evacuation of the VMs of a failed compute node (we do this already when configuring IHA manually on OSP \u003c\u003d 12)","commit_id":"baebbd972c3716aba492c80159534b500ac866b2"}],"puppet/services/pacemaker.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3fc8e0e88d68e7a8ace403da1c1e92021756d09a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                - {get_param: PcsdPassword}"},{"line_number":149,"context_line":"                - {get_param: [DefaultPasswords, pcsd_password]}"},{"line_number":150,"context_line":"        tripleo::profile::base::pacemaker::remote_authkey: {get_param: PacemakerRemoteAuthkey}"},{"line_number":151,"context_line":"      global_config_settings:"},{"line_number":152,"context_line":"        tripleo::instanceha: {get_param: EnableInstanceHA}"},{"line_number":153,"context_line":"      step_config: |"},{"line_number":154,"context_line":"        include ::tripleo::profile::base::pacemaker"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_d63ca1c9","line":151,"updated":"2017-12-08 08:54:57.000000000","message":"Can this been moved to ComputeInstanceHA service as a global setting, so that we don\u0027t need \u0027config_settings\u0027 separately for ComputeInstanceHA services as it is applied to all roles?","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b6ec4d88a06c0eef623de34091ed960265fb0925","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                - {get_param: PcsdPassword}"},{"line_number":149,"context_line":"                - {get_param: [DefaultPasswords, pcsd_password]}"},{"line_number":150,"context_line":"        tripleo::profile::base::pacemaker::remote_authkey: {get_param: PacemakerRemoteAuthkey}"},{"line_number":151,"context_line":"      global_config_settings:"},{"line_number":152,"context_line":"        tripleo::instanceha: {get_param: EnableInstanceHA}"},{"line_number":153,"context_line":"      step_config: |"},{"line_number":154,"context_line":"        include ::tripleo::profile::base::pacemaker"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_c9fe296a","line":151,"in_reply_to":"df87a7cf_d63ca1c9","updated":"2017-12-09 14:12:05.000000000","message":"Sure can do","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"}],"puppet/services/pacemaker/compute-instanceha.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c5faf560458fb4e91fc02109be17bcb2c94793ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: pike"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack Compute InstanceHA services configured with Puppet"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_99789dc4","line":1,"updated":"2017-12-07 17:48:50.000000000","message":"all templates should be queens now.","commit_id":"baebbd972c3716aba492c80159534b500ac866b2"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"dd55a72b242777bc1bf630eaa24a236c4cee9efb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: pike"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack Compute InstanceHA services configured with Puppet"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_421f6c5a","line":1,"in_reply_to":"df87a7cf_99789dc4","updated":"2017-12-08 07:54:24.000000000","message":"ack will fix it up","commit_id":"baebbd972c3716aba492c80159534b500ac866b2"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3fc8e0e88d68e7a8ace403da1c1e92021756d09a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    value:"},{"line_number":44,"context_line":"      service_name: compute_instanceha"},{"line_number":45,"context_line":"      config_settings:"},{"line_number":46,"context_line":"        tripleo::instanceha: {get_param: EnableInstanceHA}"},{"line_number":47,"context_line":"      step_config: |"},{"line_number":48,"context_line":"        include ::tripleo::profile::pacemaker::compute_instanceha"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df87a7cf_36594d34","line":46,"range":{"start_line":46,"start_character":29,"end_line":46,"end_character":58},"updated":"2017-12-08 08:54:57.000000000","message":"Is there a possibility that this service is enabled but the instance HA is disabled? If no, can this be set as \"true\" instead of the parameter. And if the global settings can be moved here, we don\u0027t need the extra parameter and the features could be controlled by the environment itself.","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3fc8e0e88d68e7a8ace403da1c1e92021756d09a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"df87a7cf_567731a1","line":49,"updated":"2017-12-08 08:54:57.000000000","message":"Is there any specific upgrade_steps, as i remember upgrade with instance HA has some limitations.","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b6ec4d88a06c0eef623de34091ed960265fb0925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"df87a7cf_09e091cc","line":49,"in_reply_to":"df87a7cf_567731a1","updated":"2017-12-09 14:12:05.000000000","message":"No, there are none. As opposed to previous IHA iterations this one changes nothing on the compute plane and only adds a couple of pcmk resources","commit_id":"2ffb0d712d7a1434f661ba5fe9443152008e131b"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a28f7923685b24631692e4fba1419875c59270b7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    value:"},{"line_number":44,"context_line":"      service_name: compute_instanceha"},{"line_number":45,"context_line":"      global_config_settings:"},{"line_number":46,"context_line":"        tripleo::instanceha: {get_param: EnableInstanceHA}"},{"line_number":47,"context_line":"      step_config: |"},{"line_number":48,"context_line":"        include ::tripleo::profile::pacemaker::compute_instanceha"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df87a7cf_3787e364","line":46,"range":{"start_line":46,"start_character":41,"end_line":46,"end_character":57},"updated":"2017-12-11 06:28:29.000000000","message":"Is there any possibility to add this service to a role but set EnableInstanceHA as false?","commit_id":"c56cdc8dda9d1b71d6e70b3bf2d7765fb9a71b31"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"624e16b262dfddafcccc5e9e47ff9910af792b58","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    value:"},{"line_number":44,"context_line":"      service_name: compute_instanceha"},{"line_number":45,"context_line":"      global_config_settings:"},{"line_number":46,"context_line":"        tripleo::instanceha: {get_param: EnableInstanceHA}"},{"line_number":47,"context_line":"      step_config: |"},{"line_number":48,"context_line":"        include ::tripleo::profile::pacemaker::compute_instanceha"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df87a7cf_1ac8c371","line":46,"range":{"start_line":46,"start_character":41,"end_line":46,"end_character":57},"in_reply_to":"df87a7cf_3787e364","updated":"2017-12-11 08:50:13.000000000","message":"I could add this service to the compute role but then \nthe operator would still need to add pacemakerremote manually to the compute role and I can\u0027t really add it there without impacting HA baremetal setups a lot because https://github.com/openstack/tripleo-heat-templates/blob/master/environments/puppet-pacemaker.yaml#L15 enables pacemakerremote explicitely","commit_id":"c56cdc8dda9d1b71d6e70b3bf2d7765fb9a71b31"}]}