)]}'
{"docker/services/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e3a2760a56a3878481ef800e2aa6c69876566b34","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    default: volumes"},{"line_number":81,"context_line":"    type: string"},{"line_number":82,"context_line":"  CinderRbdExtraPools:"},{"line_number":83,"context_line":"    default: \u0027\u0027"},{"line_number":84,"context_line":"    description: \u003e"},{"line_number":85,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":86,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_41b2aae6","line":83,"updated":"2017-11-07 19:37:09.000000000","message":"default should be [], shouldn\u0027t it?","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0825fbf0187dc16cafa6c52255d96fb96907463a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    default: volumes"},{"line_number":81,"context_line":"    type: string"},{"line_number":82,"context_line":"  CinderRbdExtraPools:"},{"line_number":83,"context_line":"    default: \u0027\u0027"},{"line_number":84,"context_line":"    description: \u003e"},{"line_number":85,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":86,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_4114ea4c","line":83,"in_reply_to":"3f4b6375_41b2aae6","updated":"2017-11-07 20:00:21.000000000","message":"Yeah, I think I was following another example that uses a blank string, but [] is more precise. I\u0027ll update.","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e3a2760a56a3878481ef800e2aa6c69876566b34","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                          - {get_param: GlanceRbdPoolName}"},{"line_number":230,"context_line":"                          - {get_param: GnocchiRbdPoolName}"},{"line_number":231,"context_line":"                        # CinderRbdExtraPools is a list (do not indent further)"},{"line_number":232,"context_line":"                        - {get_param: CinderRbdExtraPools}"},{"line_number":233,"context_line":"              - {get_param: CephPools}"},{"line_number":234,"context_line":"          openstack_keys: \u0026openstack_keys"},{"line_number":235,"context_line":"          - name:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_21cd6e65","line":232,"updated":"2017-11-07 19:37:09.000000000","message":"does this even work if the value is \u0027\u0027? If it does I guess Heat must be casting that to an empty list.\n\nI really think we ought to fix the default value though.","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0825fbf0187dc16cafa6c52255d96fb96907463a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                          - {get_param: GlanceRbdPoolName}"},{"line_number":230,"context_line":"                          - {get_param: GnocchiRbdPoolName}"},{"line_number":231,"context_line":"                        # CinderRbdExtraPools is a list (do not indent further)"},{"line_number":232,"context_line":"                        - {get_param: CinderRbdExtraPools}"},{"line_number":233,"context_line":"              - {get_param: CephPools}"},{"line_number":234,"context_line":"          openstack_keys: \u0026openstack_keys"},{"line_number":235,"context_line":"          - name:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_010a7224","line":232,"in_reply_to":"3f4b6375_21cd6e65","updated":"2017-11-07 20:00:21.000000000","message":"It does work, but I\u0027ll update the default value.","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"}],"puppet/services/ceph-base.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8edf946aa23eee985f1677d817eab923907da412","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  CinderRbdPoolName:"},{"line_number":24,"context_line":"    default: volumes"},{"line_number":25,"context_line":"    type: string"},{"line_number":26,"context_line":"  CinderRbdExtraPools:"},{"line_number":27,"context_line":"    default: \u0027\u0027"},{"line_number":28,"context_line":"    description: \u003e"},{"line_number":29,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_3879dcfb","line":26,"updated":"2017-09-25 09:31:50.000000000","message":"if we want to preserve compatibility with puppet-ceph we need to add them in [1] too\n\n1. https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/ceph-mon.yaml#L116","commit_id":"e042be3d3634bc7cc6831a0a94302228eb9fa953"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1cdeff06513c6ee5083c7b1fe01f2cc5654c284b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  CinderRbdPoolName:"},{"line_number":24,"context_line":"    default: volumes"},{"line_number":25,"context_line":"    type: string"},{"line_number":26,"context_line":"  CinderRbdExtraPools:"},{"line_number":27,"context_line":"    default: \u0027\u0027"},{"line_number":28,"context_line":"    description: \u003e"},{"line_number":29,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_f1547acc","line":26,"in_reply_to":"7f515b1d_3879dcfb","updated":"2017-09-25 13:02:30.000000000","message":"Good catch, I will do that. I figure it\u0027s best to keep puppet-ceph stuff up to date until it\u0027s fully deprecated.","commit_id":"e042be3d3634bc7cc6831a0a94302228eb9fa953"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e3a2760a56a3878481ef800e2aa6c69876566b34","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    default: volumes"},{"line_number":25,"context_line":"    type: string"},{"line_number":26,"context_line":"  CinderRbdExtraPools:"},{"line_number":27,"context_line":"    default: \u0027\u0027"},{"line_number":28,"context_line":"    description: \u003e"},{"line_number":29,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":30,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_a1defe0d","line":27,"updated":"2017-11-07 19:37:09.000000000","message":"ditto","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0825fbf0187dc16cafa6c52255d96fb96907463a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    default: volumes"},{"line_number":25,"context_line":"    type: string"},{"line_number":26,"context_line":"  CinderRbdExtraPools:"},{"line_number":27,"context_line":"    default: \u0027\u0027"},{"line_number":28,"context_line":"    description: \u003e"},{"line_number":29,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":30,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_ac003502","line":27,"in_reply_to":"3f4b6375_a1defe0d","updated":"2017-11-07 20:00:21.000000000","message":"Done","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"}],"puppet/services/ceph-mon.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e3a2760a56a3878481ef800e2aa6c69876566b34","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    default: volumes"},{"line_number":42,"context_line":"    type: string"},{"line_number":43,"context_line":"  CinderRbdExtraPools:"},{"line_number":44,"context_line":"    default: \u0027\u0027"},{"line_number":45,"context_line":"    description: \u003e"},{"line_number":46,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":47,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_81e1c2d2","line":44,"updated":"2017-11-07 19:37:09.000000000","message":"ditto","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0825fbf0187dc16cafa6c52255d96fb96907463a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    default: volumes"},{"line_number":42,"context_line":"    type: string"},{"line_number":43,"context_line":"  CinderRbdExtraPools:"},{"line_number":44,"context_line":"    default: \u0027\u0027"},{"line_number":45,"context_line":"    description: \u003e"},{"line_number":46,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":47,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_6c06bd1e","line":44,"in_reply_to":"3f4b6375_81e1c2d2","updated":"2017-11-07 20:00:21.000000000","message":"Done","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"}],"puppet/services/cinder-volume.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e3a2760a56a3878481ef800e2aa6c69876566b34","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    default: volumes"},{"line_number":59,"context_line":"    type: string"},{"line_number":60,"context_line":"  CinderRbdExtraPools:"},{"line_number":61,"context_line":"    default: \u0027\u0027"},{"line_number":62,"context_line":"    description: \u003e"},{"line_number":63,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":64,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_41e74ae4","line":61,"updated":"2017-11-07 19:37:09.000000000","message":"ditto","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0825fbf0187dc16cafa6c52255d96fb96907463a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    default: volumes"},{"line_number":59,"context_line":"    type: string"},{"line_number":60,"context_line":"  CinderRbdExtraPools:"},{"line_number":61,"context_line":"    default: \u0027\u0027"},{"line_number":62,"context_line":"    description: \u003e"},{"line_number":63,"context_line":"      List of extra Ceph pools for use with RBD backends for Cinder. An"},{"line_number":64,"context_line":"      extra Cinder RBD backend driver is created for each pool in the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_4c09c128","line":61,"in_reply_to":"3f4b6375_41e74ae4","updated":"2017-11-07 20:00:21.000000000","message":"Done","commit_id":"f3ce3eded98e4a3423bd9df97696d334e1a00c22"}]}