)]}'
{"docker/docker-puppet.py":[{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"97a4aac48bc25d280070962165efde4e5cc9427d","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    for k, v in infile_data.iteritems():"},{"line_number":374,"context_line":"        config_volume \u003d match_config_volume(config_volume_prefix, v)"},{"line_number":375,"context_line":"        if config_volume is None:"},{"line_number":376,"context_line":"            config_volume \u003d match_config_volume(config_volume_prefix_pg, v)"},{"line_number":377,"context_line":"        if config_volume:"},{"line_number":378,"context_line":"            config_hash \u003d get_config_hash(config_volume_prefix, config_volume)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_8570d909","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":33},"updated":"2017-09-29 09:18:14.000000000","message":"config_volume would be \"puppet-generated\" and not \"service\" but it won\u0027t be None.","commit_id":"fc30d954f6b14d790fbcd14a4c0541f1c13813a1"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"481576efaca1af0aae38792c515f23911937c7d4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        log.debug(cmd_stderr)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def match_config_volume(prefix, config):"},{"line_number":87,"context_line":"    # Match the mounted config volume - we can\u0027t just use the"},{"line_number":88,"context_line":"    # key as e.g \"novacomute\" consumes config-data/nova"},{"line_number":89,"context_line":"    volumes \u003d config.get(\u0027volumes\u0027, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_febfc5cd","line":86,"updated":"2017-10-04 16:16:40.000000000","message":"I\u0027ve never really looked in detail at what this code does until now and I realize there is a pretty big limitation because we make an assumption there can be only one mounted config_volume in the container. Unfortunately this is not always true [1] and this means there is a risk paunch doesn\u0027t restart a container after a config update.\n\nI know this is not the topic of this patch but wanted to raise the issue nonetheless as I\u0027m seing it. Definitely something we\u0027ll want to fix soon.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/cinder-volume.yaml#L132-L133","commit_id":"3a932b056914d148fa460b8890fc0e631c817a40"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"76db6b6d25adfee89f0e75f9d327186bdb295d3f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        log.debug(cmd_stderr)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def match_config_volume(prefix, config):"},{"line_number":87,"context_line":"    # Match the mounted config volume - we can\u0027t just use the"},{"line_number":88,"context_line":"    # key as e.g \"novacomute\" consumes config-data/nova"},{"line_number":89,"context_line":"    volumes \u003d config.get(\u0027volumes\u0027, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_79652fe1","line":86,"in_reply_to":"7f515b1d_febfc5cd","updated":"2017-10-04 16:29:08.000000000","message":"Reported in bug 1721306","commit_id":"3a932b056914d148fa460b8890fc0e631c817a40"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"481576efaca1af0aae38792c515f23911937c7d4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        if v.startswith(prefix):"},{"line_number":93,"context_line":"            config_volume \u003d os.path.dirname(v.split(\":\")[0])"},{"line_number":94,"context_line":"            break"},{"line_number":95,"context_line":"    return config_volume"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def get_config_hash(config_volume):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_be870d10","line":95,"updated":"2017-10-04 16:16:40.000000000","message":"This should really return a list.","commit_id":"3a932b056914d148fa460b8890fc0e631c817a40"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"481576efaca1af0aae38792c515f23911937c7d4","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        infile_data \u003d json.load(f)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    for k, v in infile_data.iteritems():"},{"line_number":374,"context_line":"        config_volume \u003d match_config_volume(config_volume_prefix, v)"},{"line_number":375,"context_line":"        if config_volume:"},{"line_number":376,"context_line":"            config_hash \u003d get_config_hash(config_volume)"},{"line_number":377,"context_line":"            if config_hash:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_de33e961","line":374,"updated":"2017-10-04 16:16:40.000000000","message":"this now returns the path of the config_volume, maybe update the variable to avoid confusion with the other \u0027config_volume\u0027 variables used all over this file containing the name of the config_volume.","commit_id":"3a932b056914d148fa460b8890fc0e631c817a40"}]}