)]}'
{"extraconfig/services/kubernetes-master.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1caba0db43b8668899e13e067e4b0013f3f7668","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        kubectl_localhost: true"},{"line_number":124,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":125,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":126,"context_line":"                        loadbalancer_apiserver:"},{"line_number":127,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":128,"context_line":"                          port: 6443"},{"line_number":129,"context_line":"                        access_ip:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_5ec6726a","line":126,"updated":"2017-11-02 09:41:35.000000000","message":"it seems we need to define apiserver_loadbalancer_domain_name as well: https://github.com/kubernetes-incubator/kubespray/blob/master/docs/ha-mode.md","commit_id":"bc01a04aa6db912af4ff9821adf9cfe32885180c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e72ff0428e4cb7ec4cb0461a3fc9e08f8ca7e9ea","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        access_ip:"},{"line_number":130,"context_line":"                          str_replace:"},{"line_number":131,"context_line":"                            # This variable is set via tripleo-ansible-inventory"},{"line_number":132,"context_line":"                            template: \u0027{{NETWORK_ip}}\u0027"},{"line_number":133,"context_line":"                            params:"},{"line_number":134,"context_line":"                              NETWORK: {get_param: [ServiceNetMap, KubernetesMasterNetwork]}"},{"line_number":135,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_4be12b2a","line":132,"range":{"start_line":132,"start_character":51,"end_line":132,"end_character":54},"updated":"2017-11-01 17:20:21.000000000","message":"Ok this doesn\u0027t work because we\u0027re not using the vars from tripleo-ansible-inventory in the inner ansible-playbook run, I guess we\u0027ll need to map this via the hostvars in the generated inventory instead?","commit_id":"bc01a04aa6db912af4ff9821adf9cfe32885180c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a5a8604cd6e9ad11bbed692a4bad3c5c2c93b420","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        access_ip:"},{"line_number":130,"context_line":"                          str_replace:"},{"line_number":131,"context_line":"                            # This variable is set via tripleo-ansible-inventory"},{"line_number":132,"context_line":"                            template: \u0027{{NETWORK_ip}}\u0027"},{"line_number":133,"context_line":"                            params:"},{"line_number":134,"context_line":"                              NETWORK: {get_param: [ServiceNetMap, KubernetesMasterNetwork]}"},{"line_number":135,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff82abbf_9a445a1d","line":132,"range":{"start_line":132,"start_character":51,"end_line":132,"end_character":54},"in_reply_to":"3f4b6375_4be12b2a","updated":"2017-11-22 09:42:30.000000000","message":"as you removed custom vars (access_ip) from the inner stanza, shouldn\u0027t the loadbalancer_apiserver* vars go away as well? They won\u0027t take any effect, right?","commit_id":"bc01a04aa6db912af4ff9821adf9cfe32885180c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4e0b71de0a300c8ff70743efa794fac1ba5b6427","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        access_ip:"},{"line_number":130,"context_line":"                          str_replace:"},{"line_number":131,"context_line":"                            # This variable is set via tripleo-ansible-inventory"},{"line_number":132,"context_line":"                            template: \u0027{{NETWORK_ip}}\u0027"},{"line_number":133,"context_line":"                            params:"},{"line_number":134,"context_line":"                              NETWORK: {get_param: [ServiceNetMap, KubernetesMasterNetwork]}"},{"line_number":135,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_9e950a43","line":132,"range":{"start_line":132,"start_character":51,"end_line":132,"end_character":54},"in_reply_to":"3f4b6375_4be12b2a","updated":"2017-11-02 09:43:19.000000000","message":"yeah, or adding an override file with -e@inner-overrides.yaml","commit_id":"bc01a04aa6db912af4ff9821adf9cfe32885180c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"3b8380afb3fada42c95748b893a1d6ed457386fc","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                            ansible_user: {{ hostvars.raw_get(host)[\u0027ansible_user\u0027] | default(hostvars.raw_get(host)[\u0027ansible_ssh_user\u0027]) | default(\u0027root\u0027) }}"},{"line_number":111,"context_line":"                            ansible_host: {{ hostvars.raw_get(host)[\u0027ansible_host\u0027] | default(host) }}"},{"line_number":112,"context_line":"                            ip: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":113,"context_line":"                            kube_apiserver_bind_address: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":114,"context_line":"                            apiserver_loadbalancer_domain_name: NETWORK_VIP"},{"line_number":115,"context_line":"                          {% endfor %}"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_53aca28b","line":113,"range":{"start_line":113,"start_character":28,"end_line":113,"end_character":98},"updated":"2017-11-21 10:00:11.000000000","message":"This line is to get the k8s API to bind only to the e.g internal_api nic, and not 0.0.0.0, then we bind haproxy to the vip referenced via NETWORK_VIP below","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cfc44270ace1baf0c5e1d4fbe206a5e83dd6493d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                            ansible_host: {{ hostvars.raw_get(host)[\u0027ansible_host\u0027] | default(host) }}"},{"line_number":112,"context_line":"                            ip: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":113,"context_line":"                            kube_apiserver_bind_address: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":114,"context_line":"                            apiserver_loadbalancer_domain_name: NETWORK_VIP"},{"line_number":115,"context_line":"                          {% endfor %}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"                      kube-node:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_3432ac5f","line":114,"updated":"2017-11-27 09:29:54.000000000","message":"I think this needs a rebase to pick \u0027ansible_become: true\u0027 from the master branch. I can not deploy from this patch w/o become","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cfc44270ace1baf0c5e1d4fbe206a5e83dd6493d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                          {{ hostvars.raw_get(host)[\u0027ansible_hostname\u0027] }}:"},{"line_number":121,"context_line":"                            ansible_user: {{ hostvars.raw_get(host)[\u0027ansible_user\u0027] | default(hostvars.raw_get(host)[\u0027ansible_ssh_user\u0027]) | default(\u0027root\u0027) }}"},{"line_number":122,"context_line":"                            ansible_host: {{ hostvars.raw_get(host)[\u0027ansible_host\u0027] | default(host) }}"},{"line_number":123,"context_line":"                            ip: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":124,"context_line":"                          {% endfor %}"},{"line_number":125,"context_line":"    "},{"line_number":126,"context_line":"                      etcd:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_143d282a","line":123,"updated":"2017-11-27 09:29:54.000000000","message":"ditto","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"10e5db43c183c091f139773ba7d71e761c0a56ee","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                      JSON:"},{"line_number":142,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":143,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":144,"context_line":"                        loadbalancer_apiserver:"},{"line_number":145,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":146,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"},{"line_number":147,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_fa6d6698","line":144,"updated":"2017-11-22 09:43:09.000000000","message":"as you removed custom vars (access_ip) from the inner stanza, shouldn\u0027t the loadbalancer_apiserver* vars go away as well? They won\u0027t take any effect, right?","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"af43167eea208993a0deb48eff22ff9948248281","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                      JSON:"},{"line_number":142,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":143,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":144,"context_line":"                        loadbalancer_apiserver:"},{"line_number":145,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":146,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"},{"line_number":147,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_a2046f4b","line":144,"in_reply_to":"ff82abbf_6078a729","updated":"2017-11-23 12:37:18.000000000","message":"in the patchset 2, there was access_ip here","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f74631fb3a87e59c18ed118ecaef05bcb3ddbc0e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                      JSON:"},{"line_number":142,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":143,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":144,"context_line":"                        loadbalancer_apiserver:"},{"line_number":145,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":146,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"},{"line_number":147,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_1398be19","line":144,"in_reply_to":"ff82abbf_62163258","updated":"2017-11-28 11:52:16.000000000","message":"right, that\u0027s clear now thanks :)\nI\u0027d also test with inner playbooks running \u0027ansible_verbose: true\u0027 and \u0027ansible_verbosity: 2\u0027 added as well, which gives more insights for the deployment process, like facts evaluated etc. How could this be done?","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2cbfa234dd69c5f3a762a58a7596e34f9eb0943b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                      JSON:"},{"line_number":142,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":143,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":144,"context_line":"                        loadbalancer_apiserver:"},{"line_number":145,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":146,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"},{"line_number":147,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_e2b83777","line":144,"in_reply_to":"ff82abbf_a2046f4b","updated":"2017-11-23 12:38:51.000000000","message":"and kubeconfig_localhost, kubectl_localhost as well. So those had been removed starting from the set 3. With the comment \"Ok this doesn\u0027t work because we\u0027re not using the vars from tripleo-ansible-inventory in the inner ansible-playbook run\"","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"ad41757e599deccae6b97ec62e2d2f524632b53e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                      JSON:"},{"line_number":142,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":143,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":144,"context_line":"                        loadbalancer_apiserver:"},{"line_number":145,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":146,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"},{"line_number":147,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_62163258","line":144,"in_reply_to":"ff82abbf_e2b83777","updated":"2017-11-27 11:46:37.000000000","message":"Yeah I think removing the kubeconfig/kubectl localhost vars is a mistake, I thought they were related to the localhost mode for the cluster nodes, but they\u0027re controlling the client stuff on the undercloud.\n\nRe access_ip I\u0027m not sure - I removed it because that interface didn\u0027t cause kuebspray to access the cluster via the VIP, but I\u0027ll re-test since there have been more changes since then.\n\nEssentially what I need is a working example of what vars kubespray actually needs to configure a working cluster with an external LB and VIP - the docs are pretty sparse so I\u0027ve basically been trying different things and attempting to understand the kubespray roles enough to figure it out.","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"ba5bba632e1f6a5670e9b71ccfd846f392a531ab","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                      JSON:"},{"line_number":142,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":143,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":144,"context_line":"                        loadbalancer_apiserver:"},{"line_number":145,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":146,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"},{"line_number":147,"context_line":"            - name: generate kubespray playbook"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_6078a729","line":144,"in_reply_to":"ff82abbf_fa6d6698","updated":"2017-11-23 08:05:18.000000000","message":"Sorry I don\u0027t follow - where have I removed access_ip?\n\nAnd I think we need loadbalancer_apiserver* because these are the variables that tell kubespray to reference an external LB?","commit_id":"2017d93ce88b37c94f913cac36b771600dbb66e4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9d1c3dfb4781bca19f787625a627979abe9aa95c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    description: Role data for the Kubernetes Service"},{"line_number":39,"context_line":"    value:"},{"line_number":40,"context_line":"      service_name: kubernetes_master"},{"line_number":41,"context_line":"      config_settings:"},{"line_number":42,"context_line":"        tripleo.kubernetes_master.firewall_rules:"},{"line_number":43,"context_line":"          \u0027200 kubernetes-master api\u0027:"},{"line_number":44,"context_line":"            dport: 6443"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff82abbf_1ab2f149","line":41,"updated":"2017-11-29 10:49:40.000000000","message":"looking into https://review.openstack.org/#/c/516407, it seems we need to enable kubernetes_master_enabled, right?","commit_id":"406e81ab4c5da801669ae4132247c8698c1f135c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"3dc62586b0bc6bad5893adeb330888db111f358e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    description: Role data for the Kubernetes Service"},{"line_number":39,"context_line":"    value:"},{"line_number":40,"context_line":"      service_name: kubernetes_master"},{"line_number":41,"context_line":"      config_settings:"},{"line_number":42,"context_line":"        tripleo.kubernetes_master.firewall_rules:"},{"line_number":43,"context_line":"          \u0027200 kubernetes-master api\u0027:"},{"line_number":44,"context_line":"            dport: 6443"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff82abbf_5a92b958","line":41,"in_reply_to":"ff82abbf_1ab2f149","updated":"2017-11-29 11:00:03.000000000","message":"No this is automatically generated here for all services:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/all-nodes-config.j2.yaml#L96","commit_id":"406e81ab4c5da801669ae4132247c8698c1f135c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc8c73f206fcb3b54dcb989c5e2dabb342a3d901","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    description: Role data for the Kubernetes Service"},{"line_number":39,"context_line":"    value:"},{"line_number":40,"context_line":"      service_name: kubernetes_master"},{"line_number":41,"context_line":"      config_settings:"},{"line_number":42,"context_line":"        tripleo.kubernetes_master.firewall_rules:"},{"line_number":43,"context_line":"          \u0027200 kubernetes-master api\u0027:"},{"line_number":44,"context_line":"            dport: 6443"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff82abbf_9aa04144","line":41,"in_reply_to":"ff82abbf_5a92b958","updated":"2017-11-29 11:13:58.000000000","message":"okay, just local testing shows its nil","commit_id":"406e81ab4c5da801669ae4132247c8698c1f135c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d790616fd6075591d4b27ab6087576d18428ef33","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                            ansible_become: true"},{"line_number":113,"context_line":"                            ip: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":114,"context_line":"                            kube_apiserver_bind_address: {{ hostvars.raw_get(host)[\u0027NETWORK_ip\u0027]}}"},{"line_number":115,"context_line":"                            apiserver_loadbalancer_domain_name: NETWORK_VIP"},{"line_number":116,"context_line":"                          {% endfor %}"},{"line_number":117,"context_line":"    "},{"line_number":118,"context_line":"                      kube-node:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff82abbf_8c01ef6c","line":115,"updated":"2017-11-29 09:47:49.000000000","message":"so this seems like produces an empty value, at least for my test env","commit_id":"406e81ab4c5da801669ae4132247c8698c1f135c"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"035151bd1d0a360adf446bd825de0ac4bb8f48a5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                  str_replace:"},{"line_number":105,"context_line":"                    params:"},{"line_number":106,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, KubernetesMasterNetwork]}"},{"line_number":107,"context_line":"                      NETWORK_VIP: {get_param: [EndpointMap, cloud_endpoints, {get_param: [ServiceNetMap, KubernetesMasterNetwork]}]}"},{"line_number":108,"context_line":"                    template: |"},{"line_number":109,"context_line":"                      kube-master:"},{"line_number":110,"context_line":"                        hosts:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_db89eb74","line":107,"range":{"start_line":107,"start_character":48,"end_line":107,"end_character":59},"updated":"2017-11-29 13:17:47.000000000","message":"Ok this still isn\u0027t working as it uses the hostname which doesn\u0027t resolve by default on the undercloud, it needs to be an IP","commit_id":"cbbfc17184a274e0a67c4a52f7427dccc1468e1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"29c354adb0c09ffd93e65c4c77fe1cde90f3cbe1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                        kubeconfig_localhost: true"},{"line_number":149,"context_line":"                        kubectl_localhost: true"},{"line_number":150,"context_line":"                        artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":151,"context_line":"                        loadbalancer_apiserver_localhost: false"},{"line_number":152,"context_line":"                        loadbalancer_apiserver:"},{"line_number":153,"context_line":"                          address: {get_param: [EndpointMap, KubernetesInternal, host]}"},{"line_number":154,"context_line":"                          port: {get_param: [EndpointMap, KubernetesInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_00fcbe3b","line":151,"updated":"2017-11-29 12:57:30.000000000","message":"as we discussed on IRC, let\u0027s use this (true) for internal cluster-aware loadbalancing as well, as @jistr proposed","commit_id":"cbbfc17184a274e0a67c4a52f7427dccc1468e1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e3b73885bc2a61fabe139b9cca8d0b979b1f319f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                      artifacts_dir: \u0027{{playbook_dir}}/kubespray/artifacts\u0027"},{"line_number":151,"context_line":"                      ignore_assert_errors: IGNORE_ASSERT_ERRORS"},{"line_number":152,"context_line":"                      kubelet_fail_swap_on: KUBELET_FAIL_SWAP_ON"},{"line_number":153,"context_line":"                      apiserver_loadbalancer_domain_name: ADDRESS"},{"line_number":154,"context_line":"                      loadbalancer_apiserver:"},{"line_number":155,"context_line":"                        address: ADDRESS"},{"line_number":156,"context_line":"                        port: PORT"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f91af0f_e33b78ce","line":153,"updated":"2018-01-04 11:20:40.000000000","message":"going to test these vars in a configuration that plays the best and fits those kubespray HA docs changes proposed in https://github.com/kubernetes-incubator/kubespray/pull/2126","commit_id":"c2e44d8e4df29ba4ea2e99a1df90ecf1046023dc"}],"network/endpoints/endpoint_map.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"8b38af4abc0a354db0ac7c4b8fc58cb9451d1202","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      KeystoneAdmin: {protocol: http, port: \u002735357\u0027, host: IP_ADDRESS}"},{"line_number":63,"context_line":"      KeystoneInternal: {protocol: http, port: \u00275000\u0027, host: IP_ADDRESS}"},{"line_number":64,"context_line":"      KeystonePublic: {protocol: http, port: \u00275000\u0027, host: IP_ADDRESS}"},{"line_number":65,"context_line":"      KubernetesAdmin: {protocol: http, port: \u00278443\u0027, host: IP_ADDRESS}"},{"line_number":66,"context_line":"      KubernetesInternal: {protocol: http, port: \u00278443\u0027, host: IP_ADDRESS}"},{"line_number":67,"context_line":"      KubernetesPublic: {protocol: http, port: \u00278443\u0027, host: IP_ADDRESS}"},{"line_number":68,"context_line":"      ManilaAdmin: {protocol: http, port: \u00278786\u0027, host: IP_ADDRESS}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_85cdb586","line":65,"updated":"2017-11-02 12:51:34.000000000","message":"Hmm strange that it generated 8443 when the source data says 6443 -- probably not generated by the latest state of endpoint_data?","commit_id":"00740a7a65d8afea672ce23a36b9746e79bccf0b"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e85f57e54f239a3824e57c8d511ddffef59e47ed","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      KeystoneAdmin: {protocol: http, port: \u002735357\u0027, host: IP_ADDRESS}"},{"line_number":63,"context_line":"      KeystoneInternal: {protocol: http, port: \u00275000\u0027, host: IP_ADDRESS}"},{"line_number":64,"context_line":"      KeystonePublic: {protocol: http, port: \u00275000\u0027, host: IP_ADDRESS}"},{"line_number":65,"context_line":"      KubernetesAdmin: {protocol: http, port: \u00278443\u0027, host: IP_ADDRESS}"},{"line_number":66,"context_line":"      KubernetesInternal: {protocol: http, port: \u00278443\u0027, host: IP_ADDRESS}"},{"line_number":67,"context_line":"      KubernetesPublic: {protocol: http, port: \u00278443\u0027, host: IP_ADDRESS}"},{"line_number":68,"context_line":"      ManilaAdmin: {protocol: http, port: \u00278786\u0027, host: IP_ADDRESS}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_26372802","line":65,"in_reply_to":"3f4b6375_85cdb586","updated":"2017-11-02 14:03:38.000000000","message":"Yeah I think I started with the vip listening on 8443 because that\u0027s the setup in the kubespray docs, but I\u0027m not sure it\u0027s easy in puppet-tripleo to make an enpoint listen on a different port for the vip vs the services, so I think we can just use 6443 everywhere, will update - thanks!","commit_id":"00740a7a65d8afea672ce23a36b9746e79bccf0b"}]}