)]}'
{"puppet/extraconfig/tls/tls-cert-inject.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3c9e163cee448ac682a3f4c9d2669f38830c6712","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        #!/bin/sh"},{"line_number":55,"context_line":"        # If the HAProxy container tried to load this, it\u0027ll be a directory and"},{"line_number":56,"context_line":"        # will make this fail."},{"line_number":57,"context_line":"        rm -rf ${cert_path}"},{"line_number":58,"context_line":"        cat \u003e ${cert_path} \u003c\u003c EOF"},{"line_number":59,"context_line":"        ${cert_chain_content}"},{"line_number":60,"context_line":"        EOF"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4b6375_ceea6272","line":57,"updated":"2017-11-06 18:16:44.000000000","message":"if [ -d ${cert_path ]; then\n  rm -rf ${cert_path}\nfi","commit_id":"fc6363ef223329d285126a42970d62beeb8a915d"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e211279756b1e01a454aced274ff3678807b2d5e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        #!/bin/sh"},{"line_number":55,"context_line":"        # If the HAProxy container tried to load this, it\u0027ll be a directory and"},{"line_number":56,"context_line":"        # will make this fail."},{"line_number":57,"context_line":"        if [ -d ${cert_path ]; then"},{"line_number":58,"context_line":"            rm -rf ${cert_path}"},{"line_number":59,"context_line":"        fi"},{"line_number":60,"context_line":"        cat \u003e ${cert_path} \u003c\u003c EOF"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_2af67490","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":28},"updated":"2017-11-07 08:58:09.000000000","message":"missing } ?","commit_id":"4814f9e1f9a5a1fc9a20bdb94fb6841c40e6a6ed"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"ece83c28f66818c5c72fca28e9224c125ea74621","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        #!/bin/sh"},{"line_number":55,"context_line":"        # If the HAProxy container tried to load this, it\u0027ll be a directory and"},{"line_number":56,"context_line":"        # will make this fail."},{"line_number":57,"context_line":"        if [ -d ${cert_path ]; then"},{"line_number":58,"context_line":"            rm -rf ${cert_path}"},{"line_number":59,"context_line":"        fi"},{"line_number":60,"context_line":"        cat \u003e ${cert_path} \u003c\u003c EOF"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_aa66e44f","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":28},"in_reply_to":"3f4b6375_0a1f38b7","updated":"2017-11-07 09:02:11.000000000","message":"right, we could have done without the if. But without the missing bracket bash will explode on us","commit_id":"4814f9e1f9a5a1fc9a20bdb94fb6841c40e6a6ed"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"5494b89dee47702c0632779b5845fe2aefa438bf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        #!/bin/sh"},{"line_number":55,"context_line":"        # If the HAProxy container tried to load this, it\u0027ll be a directory and"},{"line_number":56,"context_line":"        # will make this fail."},{"line_number":57,"context_line":"        if [ -d ${cert_path ]; then"},{"line_number":58,"context_line":"            rm -rf ${cert_path}"},{"line_number":59,"context_line":"        fi"},{"line_number":60,"context_line":"        cat \u003e ${cert_path} \u003c\u003c EOF"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_0a74d8fc","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":28},"in_reply_to":"3f4b6375_0a1f38b7","updated":"2017-11-07 09:01:22.000000000","message":"yeah, that\u0027s what I had initially https://review.openstack.org/#/c/517984/1/puppet/extraconfig/tls/tls-cert-inject.yaml","commit_id":"4814f9e1f9a5a1fc9a20bdb94fb6841c40e6a6ed"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fcd438f5900538249916371814d76d038f550ac6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        #!/bin/sh"},{"line_number":55,"context_line":"        # If the HAProxy container tried to load this, it\u0027ll be a directory and"},{"line_number":56,"context_line":"        # will make this fail."},{"line_number":57,"context_line":"        if [ -d ${cert_path ]; then"},{"line_number":58,"context_line":"            rm -rf ${cert_path}"},{"line_number":59,"context_line":"        fi"},{"line_number":60,"context_line":"        cat \u003e ${cert_path} \u003c\u003c EOF"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_0a1f38b7","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":28},"in_reply_to":"3f4b6375_2af67490","updated":"2017-11-07 08:59:56.000000000","message":"basically, rm -rf returns 0 for non-existing dirs as well...","commit_id":"4814f9e1f9a5a1fc9a20bdb94fb6841c40e6a6ed"}]}