)]}'
{"puppet/services/manila-base.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d2fa3223adf7567e2666c8b3b196b7651882c162","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      - allowed_values: [ \u0027messagingv2\u0027, \u0027noop\u0027 ]"},{"line_number":71,"context_line":"  NetworkPluginIPv4Enabled:"},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"    default: true"},{"line_number":74,"context_line":"  NetworkPluginIPv6Enabled:"},{"line_number":75,"context_line":"    type: boolean"},{"line_number":76,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_a0cc5dbc","line":73,"updated":"2017-12-06 21:05:18.000000000","message":"Please add descriptions: to these to and it would be beneficial to document the fact they are mutually exclusive here as this shows up in the UI. Additionally do we not have some sort of global flag indicating ipv4 vs ipv6 that we could leverage to do this automatically?","commit_id":"0fb5a09e72825f4b92f7e7ce0a5f9cef54078e7c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2a09a941b41556cb5b42369bfd80ed72329edddd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      - allowed_values: [ \u0027messagingv2\u0027, \u0027noop\u0027 ]"},{"line_number":71,"context_line":"  NetworkPluginIPv4Enabled:"},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"    default: true"},{"line_number":74,"context_line":"  NetworkPluginIPv6Enabled:"},{"line_number":75,"context_line":"    type: boolean"},{"line_number":76,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_19632d44","line":73,"in_reply_to":"df87a7cf_a0cc5dbc","updated":"2017-12-19 01:03:13.000000000","message":"Yeah, setting this on the basis of global address family settings seems to be the way to go.","commit_id":"0fb5a09e72825f4b92f7e7ce0a5f9cef54078e7c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a151363579d923aa10af50b78ccb62278275125d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Currently the address family network plugins are mutually exclusive"},{"line_number":109,"context_line":"        # and IPv4 is the default."},{"line_number":110,"context_line":"        manila::network::neutron::network_plugin_ipv4_enabled:"},{"line_number":111,"context_line":"          equals: [{get_param: ManilaIPv6}, \u0027false\u0027]"},{"line_number":112,"context_line":"      service_config_settings:"},{"line_number":113,"context_line":"        mysql:"},{"line_number":114,"context_line":"          manila::db::mysql::password: {get_param: ManilaPassword}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df87a7cf_16c8c9a5","line":111,"updated":"2017-12-19 15:12:42.000000000","message":"This doesn\u0027t work like that, you\u0027ll have to use conditionals.\n\nFrom http://logs.openstack.org/29/522229/2/check/tripleo-ci-centos-7-scenario004-multinode-oooq-container/8e9ab0f/logs/subnode-2/etc/puppet/hieradata/service_configs.json.txt.gz\n\n    \"manila::network::neutron::network_plugin_ipv4_enabled\": {\n        \"equals\": [\n            false,\n            \"false\"\n        ]\n    },","commit_id":"9c33d7342c9ad7d58be50eb05aff7f0055387bc5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"31b4b96a6904b8e2450d3eedb72d39ccc1a13bf5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # and IPv4 is the default."},{"line_number":110,"context_line":"        if $manila::network::neutron::network_plugin_ipv6_enabled {"},{"line_number":111,"context_line":"          manila::network::neutron::network_plugin_ipv4_enabled \u003d false"},{"line_number":112,"context_line":"        }"},{"line_number":113,"context_line":"      service_config_settings:"},{"line_number":114,"context_line":"        mysql:"},{"line_number":115,"context_line":"          manila::db::mysql::password: {get_param: ManilaPassword}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_3b7fee66","line":112,"updated":"2017-12-19 20:25:14.000000000","message":"No this would need to be a heat conditional.  Example of conditional, https://github.com/openstack/tripleo-heat-templates/commit/ca05268dcf638ac5847c46e37896c5fee412b15a","commit_id":"d6def0b448cea0f512c5b97d6388bf9590478c60"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4320042d8b503f68a957847bc234a350db9c286d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # and IPv4 is the default."},{"line_number":110,"context_line":"        if $manila::network::neutron::network_plugin_ipv6_enabled {"},{"line_number":111,"context_line":"          manila::network::neutron::network_plugin_ipv4_enabled \u003d false"},{"line_number":112,"context_line":"        }"},{"line_number":113,"context_line":"      service_config_settings:"},{"line_number":114,"context_line":"        mysql:"},{"line_number":115,"context_line":"          manila::db::mysql::password: {get_param: ManilaPassword}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_1be0e925","line":112,"in_reply_to":"df87a7cf_3b7fee66","updated":"2017-12-19 21:05:47.000000000","message":"Thanks for the clue and example.","commit_id":"d6def0b448cea0f512c5b97d6388bf9590478c60"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c97618794ef75b6312d233ffe7a94000658bea9e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            query:"},{"line_number":106,"context_line":"              read_default_file: /etc/my.cnf.d/tripleo.cnf"},{"line_number":107,"context_line":"              read_default_group: tripleo"},{"line_number":108,"context_line":"        manila::network::neutron::network_plugin_ipv6_enabled:"},{"line_number":109,"context_line":"          if:"},{"line_number":110,"context_line":"          - manila_ipv6"},{"line_number":111,"context_line":"          - true"},{"line_number":112,"context_line":"          - false"},{"line_number":113,"context_line":"        # Currently the address family parameters are mutually exclusive"},{"line_number":114,"context_line":"        manila::network::neutron::network_plugin_ipv4_enabled:"},{"line_number":115,"context_line":"          if:"},{"line_number":116,"context_line":"          - manila_ipv6"},{"line_number":117,"context_line":"          - false"},{"line_number":118,"context_line":"          - true"},{"line_number":119,"context_line":"      service_config_settings:"},{"line_number":120,"context_line":"        mysql:"},{"line_number":121,"context_line":"          manila::db::mysql::password: {get_param: ManilaPassword}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df87a7cf_3bdb6ded","line":118,"range":{"start_line":108,"start_character":0,"end_line":118,"end_character":16},"updated":"2017-12-19 21:36:49.000000000","message":"close but nope. I think you can just do...\n\n        \n  manila::network::neutron::network_plugin_ipv6_enabled: {get_param: ManilaIPv6}\n\n  # Currently the address family parameters are mutually exclusive\n  manila::network::neutron::network_plugin_ipv4_enabled: {if: [\"manila_ipv6\", false, true]}\n\n\nhttps://docs.openstack.org/heat/latest/template_guide/hot_spec.html#if","commit_id":"10cbc510625151b03868aee8a7035ffa51fb6a01"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"27b963aa7e50e682335fc69124d61cc670956176","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      - allowed_values: [ \u0027messagingv2\u0027, \u0027noop\u0027 ]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"conditions:"},{"line_number":77,"context_line":"  service_debug_unset: {equals : [{get_param: ManilaDebug}, \u0027\u0027]}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"outputs:"},{"line_number":80,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df87a7cf_3ef91bc7","line":77,"updated":"2017-12-19 22:02:07.000000000","message":"You still needed   manila_ipv6: {equals : [{get_param: ManilaIPv6}, true]}","commit_id":"b445b55f4fc350219dd5ab0eb2cef1cdf6940ca9"}]}