)]}'
{"docker/services/opendaylight-api.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c03950de6e8c835659aa7fc8929a1eec3e105423","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          - get_attr: [OpenDaylightBase, role_data, config_settings]"},{"line_number":70,"context_line":"          - if:"},{"line_number":71,"context_line":"            - internal_tls_enabled"},{"line_number":72,"context_line":"            - tripleo::certmonger::opendaylight::postsave_cmd: \"sudo docker ps | grep -q opendaylight_api \u0026\u0026 sudo docker restart opendaylight_api\""},{"line_number":73,"context_line":"            - {}"},{"line_number":74,"context_line":"      logging_source: {get_attr: [OpenDaylightBase, role_data, logging_source]}"},{"line_number":75,"context_line":"      logging_groups: {get_attr: [OpenDaylightBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_9aef90af","line":72,"range":{"start_line":72,"start_character":64,"end_line":72,"end_character":68},"updated":"2018-01-22 14:29:32.000000000","message":"This is kind of an ugly pattern, e.g having puppet run some arbitrary command...","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"63cc45e882faa303324a37c165ee819fc5557025","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          - get_attr: [OpenDaylightBase, role_data, config_settings]"},{"line_number":70,"context_line":"          - if:"},{"line_number":71,"context_line":"            - internal_tls_enabled"},{"line_number":72,"context_line":"            - tripleo::certmonger::opendaylight::postsave_cmd: \"sudo docker ps | grep -q opendaylight_api \u0026\u0026 sudo docker restart opendaylight_api\""},{"line_number":73,"context_line":"            - {}"},{"line_number":74,"context_line":"      logging_source: {get_attr: [OpenDaylightBase, role_data, logging_source]}"},{"line_number":75,"context_line":"      logging_groups: {get_attr: [OpenDaylightBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_bcd5a11d","line":72,"range":{"start_line":72,"start_character":64,"end_line":72,"end_character":68},"in_reply_to":"7f96bb07_9aef90af","updated":"2018-01-22 18:51:34.000000000","message":"I agree, right now in the other services this is just \"true\" with a comment saying TODO:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/rabbitmq.yaml#L83\n\nFor ODL, I\u0027m not even sure restarting the container will be enough.  We probably need to re-run puppet in the container to rebuild the container keystore.  Perhaps I should just change this to true for now with a TODO.","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"842e7fa8c94a351e67873d67ccf38c83dcd144d3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                      - /etc/pki/tls/private/odl.key:/etc/pki/tls/private/odl.key:ro"},{"line_number":125,"context_line":"                      - \u0027\u0027"},{"line_number":126,"context_line":"            environment:"},{"line_number":127,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":128,"context_line":"      host_prep_tasks:"},{"line_number":129,"context_line":"        - name: create persistent directories"},{"line_number":130,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_65bc66bb","line":127,"updated":"2018-01-22 13:11:15.000000000","message":"you\u0027re missing the metadata_settings, which you should get from the OpenDaylightBase base resource.","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"d9d2dfd29b7224c26f9dbe3eb66e703d65ed3a6f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                      - /etc/pki/tls/private/odl.key:/etc/pki/tls/private/odl.key:ro"},{"line_number":125,"context_line":"                      - \u0027\u0027"},{"line_number":126,"context_line":"            environment:"},{"line_number":127,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":128,"context_line":"      host_prep_tasks:"},{"line_number":129,"context_line":"        - name: create persistent directories"},{"line_number":130,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_777f3dab","line":127,"in_reply_to":"7f96bb07_65bc66bb","updated":"2018-01-22 14:05:56.000000000","message":"Done","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"}],"puppet/services/neutron-plugin-ml2-odl.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"842e7fa8c94a351e67873d67ccf38c83dcd144d3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          -"},{"line_number":67,"context_line":"            if:"},{"line_number":68,"context_line":"              - internal_tls_enabled"},{"line_number":69,"context_line":"              - neutron::plugins::ml2::opendaylight::ovsdb_connection: \u0027ssl:127.0.0.1:6639\u0027"},{"line_number":70,"context_line":"                tripleo::profile::base::neutron::plugins::ml2::opendaylight::conn_proto: \u0027https\u0027"},{"line_number":71,"context_line":"              - {}"},{"line_number":72,"context_line":"      step_config: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_05b1e2e1","line":69,"updated":"2018-01-22 13:11:15.000000000","message":"why 127.0.0.1?","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"d9d2dfd29b7224c26f9dbe3eb66e703d65ed3a6f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          -"},{"line_number":67,"context_line":"            if:"},{"line_number":68,"context_line":"              - internal_tls_enabled"},{"line_number":69,"context_line":"              - neutron::plugins::ml2::opendaylight::ovsdb_connection: \u0027ssl:127.0.0.1:6639\u0027"},{"line_number":70,"context_line":"                tripleo::profile::base::neutron::plugins::ml2::opendaylight::conn_proto: \u0027https\u0027"},{"line_number":71,"context_line":"              - {}"},{"line_number":72,"context_line":"      step_config: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_b70ce542","line":69,"in_reply_to":"7f96bb07_05b1e2e1","updated":"2018-01-22 14:05:56.000000000","message":"This tells the neutron agents how to connect to OVSDB to configure things like DHCP tap ports via neutron DHCP agent.  They will always be local to the machine.  We configure OVSDB to listen on for incoming SSL connections with the TLS everywhere deployment, so we need to connect with ssl rather than tcp here:\nhttps://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ml2/opendaylight.pp#L49","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c03950de6e8c835659aa7fc8929a1eec3e105423","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            if:"},{"line_number":68,"context_line":"              - internal_tls_enabled"},{"line_number":69,"context_line":"              - neutron::plugins::ml2::opendaylight::ovsdb_connection: \u0027ssl:127.0.0.1:6639\u0027"},{"line_number":70,"context_line":"                tripleo::profile::base::neutron::plugins::ml2::opendaylight::conn_proto: \u0027https\u0027"},{"line_number":71,"context_line":"              - {}"},{"line_number":72,"context_line":"      step_config: |"},{"line_number":73,"context_line":"        include ::tripleo::profile::base::neutron::plugins::ml2"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_da3af832","line":70,"range":{"start_line":70,"start_character":90,"end_line":70,"end_character":95},"updated":"2018-01-22 14:29:32.000000000","message":"If we land https://review.openstack.org/#/c/535783/ then you can move this out of the conditional and just reference the protocol via EndpointMap","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"63cc45e882faa303324a37c165ee819fc5557025","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            if:"},{"line_number":68,"context_line":"              - internal_tls_enabled"},{"line_number":69,"context_line":"              - neutron::plugins::ml2::opendaylight::ovsdb_connection: \u0027ssl:127.0.0.1:6639\u0027"},{"line_number":70,"context_line":"                tripleo::profile::base::neutron::plugins::ml2::opendaylight::conn_proto: \u0027https\u0027"},{"line_number":71,"context_line":"              - {}"},{"line_number":72,"context_line":"      step_config: |"},{"line_number":73,"context_line":"        include ::tripleo::profile::base::neutron::plugins::ml2"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_1ccff57f","line":70,"range":{"start_line":70,"start_character":90,"end_line":70,"end_character":95},"in_reply_to":"7f96bb07_da3af832","updated":"2018-01-22 18:51:34.000000000","message":"Sounds good","commit_id":"27074d2a4d312ef7107a737920b672812e2c6e44"}],"puppet/services/opendaylight-api.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"01525cc0e31797922de42a1e7b0620ed9f3cda6f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":124,"context_line":"                  principal:"},{"line_number":125,"context_line":"                    str_replace:"},{"line_number":126,"context_line":"                      template: \"opendaylight/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":127,"context_line":"                      params:"},{"line_number":128,"context_line":"                        NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":129,"context_line":"                opendaylight::tls_ca_cert_file: {get_param: InternalTLSCAFile}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_cca6a954","line":126,"updated":"2018-01-04 07:59:40.000000000","message":"if you want to make it short, the service principal could also be odl, nothing is using that. But you could use this, it was merely a suggestion.","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1e1fe662e696e5a0ebbffe5cd07ab8a0aea776f4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":124,"context_line":"                  principal:"},{"line_number":125,"context_line":"                    str_replace:"},{"line_number":126,"context_line":"                      template: \"opendaylight/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":127,"context_line":"                      params:"},{"line_number":128,"context_line":"                        NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":129,"context_line":"                opendaylight::tls_ca_cert_file: {get_param: InternalTLSCAFile}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_8105bfc4","line":126,"in_reply_to":"9f91af0f_cca6a954","updated":"2018-01-04 17:30:22.000000000","message":"Done","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"01525cc0e31797922de42a1e7b0620ed9f3cda6f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                opendaylight::tls_keystore_password: {get_param: OpenDaylightTLSKeystorePassword}"},{"line_number":131,"context_line":"              - {}"},{"line_number":132,"context_line":"      step_config: |"},{"line_number":133,"context_line":"        include tripleo::profile::base::neutron::opendaylight"},{"line_number":134,"context_line":"      upgrade_tasks:"},{"line_number":135,"context_line":"        - name: Check if opendaylight is deployed"},{"line_number":136,"context_line":"          command: systemctl is-enabled opendaylight"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_2c9f1504","line":133,"updated":"2018-01-04 07:59:40.000000000","message":"you will need to add metadata_settings as well: https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/apache.yaml#L114","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1e1fe662e696e5a0ebbffe5cd07ab8a0aea776f4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                opendaylight::tls_keystore_password: {get_param: OpenDaylightTLSKeystorePassword}"},{"line_number":131,"context_line":"              - {}"},{"line_number":132,"context_line":"      step_config: |"},{"line_number":133,"context_line":"        include tripleo::profile::base::neutron::opendaylight"},{"line_number":134,"context_line":"      upgrade_tasks:"},{"line_number":135,"context_line":"        - name: Check if opendaylight is deployed"},{"line_number":136,"context_line":"          command: systemctl is-enabled opendaylight"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_01d0cf1e","line":133,"in_reply_to":"9f91af0f_2c9f1504","updated":"2018-01-04 17:30:22.000000000","message":"Done","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"}],"puppet/services/opendaylight-ovs.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"01525cc0e31797922de42a1e7b0620ed9f3cda6f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                        NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":177,"context_line":"                  principal:"},{"line_number":178,"context_line":"                    str_replace:"},{"line_number":179,"context_line":"                       template: \"openvswitch/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":180,"context_line":"                       params:"},{"line_number":181,"context_line":"                         NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":182,"context_line":"                neutron::plugins::ovs::opendaylight::tls_ca_cert_file: {get_param: InternalTLSCAFile}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_ecb12d91","line":179,"updated":"2018-01-04 07:59:40.000000000","message":"the service principal could also be ovs; nothing is using that :) But you could use this, it was merely a suggestion.","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1e1fe662e696e5a0ebbffe5cd07ab8a0aea776f4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                        NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":177,"context_line":"                  principal:"},{"line_number":178,"context_line":"                    str_replace:"},{"line_number":179,"context_line":"                       template: \"openvswitch/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":180,"context_line":"                       params:"},{"line_number":181,"context_line":"                         NETWORK: {get_param: [ServiceNetMap, OpendaylightApiNetwork]}"},{"line_number":182,"context_line":"                neutron::plugins::ovs::opendaylight::tls_ca_cert_file: {get_param: InternalTLSCAFile}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_e1c4cb61","line":179,"in_reply_to":"9f91af0f_ecb12d91","updated":"2018-01-04 17:30:22.000000000","message":"Done","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"01525cc0e31797922de42a1e7b0620ed9f3cda6f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"          - get_attr: [Ovs, role_data, config_settings]"},{"line_number":185,"context_line":"          - get_attr: [RoleParametersValue, value]"},{"line_number":186,"context_line":"      step_config: |"},{"line_number":187,"context_line":"        include tripleo::profile::base::neutron::plugins::ovs::opendaylight"},{"line_number":188,"context_line":"      upgrade_tasks:"},{"line_number":189,"context_line":"        list_concat:"},{"line_number":190,"context_line":"          - get_attr: [Ovs, role_data, upgrade_tasks]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_ac9245f5","line":187,"updated":"2018-01-04 07:59:40.000000000","message":"you\u0027ll need metadata_settings https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/apache.yaml#L114","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1e1fe662e696e5a0ebbffe5cd07ab8a0aea776f4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"          - get_attr: [Ovs, role_data, config_settings]"},{"line_number":185,"context_line":"          - get_attr: [RoleParametersValue, value]"},{"line_number":186,"context_line":"      step_config: |"},{"line_number":187,"context_line":"        include tripleo::profile::base::neutron::plugins::ovs::opendaylight"},{"line_number":188,"context_line":"      upgrade_tasks:"},{"line_number":189,"context_line":"        list_concat:"},{"line_number":190,"context_line":"          - get_attr: [Ovs, role_data, upgrade_tasks]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_c1c98778","line":187,"in_reply_to":"9f91af0f_ac9245f5","updated":"2018-01-04 17:30:22.000000000","message":"Done","commit_id":"8a7a56bd9c455a87185030148493dad8bd705526"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e033d9f28303b17f21122f0a6ab0e3a21225adda","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  OpenDaylightConnectionProtocol:"},{"line_number":21,"context_line":"    description: L7 protocol used for REST access"},{"line_number":22,"context_line":"    type: string"},{"line_number":23,"context_line":"    default: \u0027http\u0027"},{"line_number":24,"context_line":"  OpenDaylightCheckURL:"},{"line_number":25,"context_line":"    description: URL postfix to verify ODL has finished starting up"},{"line_number":26,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_fab6d48a","side":"PARENT","line":23,"range":{"start_line":23,"start_character":18,"end_line":23,"end_character":19},"updated":"2018-01-22 14:32:53.000000000","message":"You should add a release note saying this has been removed, and what the alternative interface is (if you get https://review.openstack.org/#/c/535783/ then it could just be the EndpointMap parameter, like all other services)","commit_id":"d5ddb1d860ac5504b090145aee118cf16533f784"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"63cc45e882faa303324a37c165ee819fc5557025","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  OpenDaylightConnectionProtocol:"},{"line_number":21,"context_line":"    description: L7 protocol used for REST access"},{"line_number":22,"context_line":"    type: string"},{"line_number":23,"context_line":"    default: \u0027http\u0027"},{"line_number":24,"context_line":"  OpenDaylightCheckURL:"},{"line_number":25,"context_line":"    description: URL postfix to verify ODL has finished starting up"},{"line_number":26,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_5cb1fde0","side":"PARENT","line":23,"range":{"start_line":23,"start_character":18,"end_line":23,"end_character":19},"in_reply_to":"7f96bb07_fab6d48a","updated":"2018-01-22 18:51:34.000000000","message":"I think we should list this as deprecated.  Will do.  I don\u0027t mind using the endpoint map to reference the protocol, but I also don\u0027t want to hold this patch up as a dependency on that commit.  If that one gets in first then I will rebase and change accordingly.  If this patch is in first then then we can fix it in the other patch.","commit_id":"d5ddb1d860ac5504b090145aee118cf16533f784"}]}