)]}'
{"environments/compute-real-time-example.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f1177ac8919ad58c57ef9970141186110165e0c2","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"parameter_defaults:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  ## Only uncomment this line to overwrite the default image name"},{"line_number":13,"context_line":"  ComputeRealTimeImage: \"overcloud-realtime-compute\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  ComputeRealTimeParameters:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_e378442c","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":19},"updated":"2018-01-23 15:07:36.000000000","message":"it\u0027s not commented","commit_id":"2e89082905d03c2a56b519fb48b377cf7fdf1b86"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"014f9681ae49937416cdba8a969dc9ab98dcae4a","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"parameter_defaults:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  ## Only uncomment this line to overwrite the default image name"},{"line_number":13,"context_line":"  ComputeRealTimeImage: \"overcloud-realtime-compute\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  ComputeRealTimeParameters:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_4e283f85","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":19},"in_reply_to":"7f96bb07_e378442c","updated":"2018-01-23 15:18:19.000000000","message":"Done","commit_id":"2e89082905d03c2a56b519fb48b377cf7fdf1b86"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"11c65b342c08a3e40ce5974faeacbb2fa4db0cbf","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  ## Only uncomment this line to overwrite the default image name"},{"line_number":15,"context_line":"  #ComputeRealTimeImage: \"overcloud-realtime-compute\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  ComputeRealTimeParameters:"},{"line_number":18,"context_line":"    ## Host configuration Parameters"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f96bb07_eebc84dd","line":16,"updated":"2018-01-24 15:12:23.000000000","message":"Shouldn\u0027t this be \n\n  RoleParameters:\n    ComputeRealTimeParameters:\n      ...","commit_id":"52f58dc4de1d24f92a19bb7e7502f4c12f3534e8"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"8d8b3fb274bee1d648caf27c0c11d2fc07d37785","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  ## Only uncomment this line to overwrite the default image name"},{"line_number":15,"context_line":"  #ComputeRealTimeImage: \"overcloud-realtime-compute\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  ComputeRealTimeParameters:"},{"line_number":18,"context_line":"    ## Host configuration Parameters"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f93b717_119f1c51","line":16,"in_reply_to":"7f96bb07_eebc84dd","updated":"2018-01-24 17:51:18.000000000","message":"You mean with your change to allow defaults for Image/Flavor/RoleParameters this becomes necessary? Because I used a file like this here to test it.","commit_id":"52f58dc4de1d24f92a19bb7e7502f4c12f3534e8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e9fbfc59e651fdd80735450e8f25ab86c31fabfe","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    ## Space separated kernel args to configure hugepage. Deploying real-time"},{"line_number":28,"context_line":"    ## requires enabling hugepages for the overcloud compute nodes."},{"line_number":29,"context_line":"    ## Adapt the hugepages according to the memory of the real-time compute nodes."},{"line_number":30,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ## Only uncomment these lines to overwrite the defaults"},{"line_number":33,"context_line":"    #TunedProfileName: \"realtime-virtual-host\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f93b717_d29a126d","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":65},"updated":"2018-01-24 19:27:57.000000000","message":"suggested on IRC that (since this is an example only) maybe it should demonstrate 2mb hugepages too e.g\n\n    default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d1 hugepagesz\u003d2M hugepages\u003d512\n\n... but it\u0027s just a slight nit","commit_id":"52f58dc4de1d24f92a19bb7e7502f4c12f3534e8"}],"environments/compute-real-time.yaml":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"d0c097e23c51665a38ac8ace5eb6c98e4dbb75a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f96bb07_0194ac8a","updated":"2018-01-10 15:55:02.000000000","message":"If you could provide those parameters with defaults for those in RoleParameterDefaults in role definition (provided by shardy\u0027s patch) it would be better as that information could be displayed in GUI and this environment would not be almost needed. Empty environment file with comments is not useful for GUI and actually clutters environments listing (unrelated note: we should provide doc or find a specific place for such environments to filter them out in listing)\n\nAlso if the parameters description provided here is specific to compute real time role, it would be good to ensure that these descriptions are included in templates where the parameter is defined (which is where GUI gets the description, type etc. for parameters)","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"30aba35c6bd3fd783454e8dfeb016de7686570de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment that can be used to deploy DPDK with OVS"},{"line_number":2,"context_line":"# Deploying DPDK requires enabling hugepages for the overcloud nodes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"parameter_defaults:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_5e6180a8","line":1,"updated":"2018-01-09 08:13:09.000000000","message":"There is no specific parameters for realtime, it is using the existing parameters. I don\u0027t see a need for this environment with all entries commented. I would suggest a document better way to explain the environment file with only commented items.","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"30aba35c6bd3fd783454e8dfeb016de7686570de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment that can be used to deploy DPDK with OVS"},{"line_number":2,"context_line":"# Deploying DPDK requires enabling hugepages for the overcloud nodes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"parameter_defaults:"},{"line_number":5,"context_line":"  #ComputeRealTimeParameters:"},{"line_number":6,"context_line":"    ## Host configuration Parameters"},{"line_number":7,"context_line":"    #TunedProfileName: \"realtime-virtual-host\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_de4b5028","line":4,"updated":"2018-01-09 08:13:09.000000000","message":"Emtpy parameter_defaults should not be provided, if required, comment it.","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"}],"roles/ComputeRealTime.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"30aba35c6bd3fd783454e8dfeb016de7686570de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"###############################################################################"},{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_dec6f09a","line":1,"updated":"2018-01-09 08:13:09.000000000","message":"As far as I understand, any role could be deployed with realtime kernel. And there is also discussion of DPDK with realtime kernels. What is the differentiation for ComputeRealTime from Compute role? \n\nIn other words, what are the changes required to make a Compute role to a ComputeRealTime role?","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"f83b092a5b3cc7970bbf54248d98899214c4fffc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"###############################################################################"},{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_bf80aaf6","line":1,"in_reply_to":"9f91af0f_9f8b6666","updated":"2018-01-10 09:26:40.000000000","message":"\u003e So, do we need a separate role for this? (Although the role would look identical to the normal compute role.)\n\nIf it\u0027s identical then it\u0027s just renaming an existing role, which would probably be better handled without this duplication, but it seems the requirement is actually to combine the role with a specific image and parameters?\n\nI pushed https://review.openstack.org/532465 which shows how we might include such data, feedback welcome.","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"7e006bcc16ec423c8b47230e970d57cd618b581b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"###############################################################################"},{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_a2fe4e68","line":1,"in_reply_to":"9f91af0f_bf80aaf6","updated":"2018-01-10 13:41:26.000000000","message":"is there the possibility to \"include\" another role yaml and just overwrite the few changes? That would avoid any duplication. As far as I understand we need the separate role to deploy compute _and_ compute-realtime nodes in parallel, correct?","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"014b24c1690cef79f95cdef13c3d1218193b51b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"###############################################################################"},{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_e960d6d1","line":1,"in_reply_to":"9f91af0f_dec6f09a","updated":"2018-01-09 15:06:30.000000000","message":"Apart from BIOS settings, which are out of scope, a real-time compute node needs the following:\n\n - enabling the RT repository\n - installing the real-time kernel and kvm modules\n - installing and configuring real-time related packages (tuned, by default installed already, if I\u0027m not mistaken)\n - setting additional boot parameters (default_hugepages)\n - updating bootloader\n - permanently set hugepage reservation\n(/sys/devices/system/node/nodeY/hugepages/hugepages-1048576kB/nr_hugepages)\n - reboot\n - configure nova for real time (this can be done with normal deployment methods)\n\nSo, I assume we can get the first three points from a real-time custom overcloud image (as described here: https://etherpad.openstack.org/p/tripleo-real-time-compute), and all the rest from THT, using the parameters TunedProfileName, IsolCpusList, KernelArgs and NovaVcpuPinSet.\n\nWe would like to be able to deploy some compute nodes as RT compute nodes and some as normal compute nodes. So, do we need a separate role for this? (Although the role would look identical to the normal compute role.)","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"07149be41fe5865f6754c79318993fc4646217e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"###############################################################################"},{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_9f8b6666","line":1,"in_reply_to":"9f91af0f_e960d6d1","updated":"2018-01-10 08:49:34.000000000","message":"Thanks for details. As of now the roles/* list is the differentiated based on the Services. ComputeRealTime is like a Compute role with different parameters. \n\nI understand that realtime could be enabled with ComputeOvsDpdk or ComputeSriov role for NFV deployments. If it is a required to have Compute and ComputeRealTime in a deployment, then I agree with this approach. Just that we need to add additional  description explaining the similarity with Compute and update tools/yaml-validate.py to validate.","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"8ed9a85d2e8712caff9b34c6dab37606fc710aeb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"},{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"    Compute Real-Time Role"},{"line_number":7,"context_line":"  CountDefault: 1"},{"line_number":8,"context_line":"  networks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f91af0f_dada5c76","line":5,"updated":"2018-01-10 09:38:09.000000000","message":"Can you please provide proper role description which will document the purpose and usage of that role? Description is presented to the user in GUI when selecting roles for deployment","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"96e47bd786cd1ba4f98552643be92d7cc3b66ff2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Role: ComputeRealTime                                                               #"},{"line_number":3,"context_line":"###############################################################################"},{"line_number":4,"context_line":"- name: ComputeRealTime"},{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"    Compute Real-Time Role"},{"line_number":7,"context_line":"  CountDefault: 1"},{"line_number":8,"context_line":"  networks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_619490e9","line":5,"in_reply_to":"9f91af0f_dada5c76","updated":"2018-01-12 13:52:14.000000000","message":"Done","commit_id":"32b22d13742d77aa919569133e16101ee73a6a40"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"11401797121458739a7c205682a666117b810a66","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1GB hugepagesz\u003d1G hugepages\u003d60\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"},{"line_number":22,"context_line":"    NovaVcpuPinSet: \"\"  # according to the hardware of real-time nodes"},{"line_number":23,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_605b1887","line":20,"range":{"start_line":20,"start_character":64,"end_line":20,"end_character":66},"updated":"2018-01-11 08:24:50.000000000","message":"Is that going to work? IIRC we already reserve 4GB for nova. I assume we would need to leave some memory for everything else, and maybe a bit for page cache too.","commit_id":"678f3f3757c94c8e235013f80f00d222d45018f2"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"96e47bd786cd1ba4f98552643be92d7cc3b66ff2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1GB hugepagesz\u003d1G hugepages\u003d60\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"},{"line_number":22,"context_line":"    NovaVcpuPinSet: \"\"  # according to the hardware of real-time nodes"},{"line_number":23,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_bc0fe42c","line":20,"range":{"start_line":20,"start_character":64,"end_line":20,"end_character":66},"in_reply_to":"7f96bb07_605b1887","updated":"2018-01-12 13:52:14.000000000","message":"Good question, I thought I took it from the RT docs, but they just set it to 16, so it seems I got this number from the commented out line in host-config-and-reboot.j2.yaml. Here they even set it to 64 for DPDK: https://github.com/krsacme/tht-dpdk/blob/master/osp12_ref/ml2-ovs-dpdk-env.yaml\n\nBut I think we better stick with the value from the docs, that is 16. Will fix it. Good catch!","commit_id":"678f3f3757c94c8e235013f80f00d222d45018f2"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"e9b58d29f81a49436ab06f4f0c3501351d2e88d5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_de74b66a","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"updated":"2018-01-17 06:47:31.000000000","message":"FYI. IIRC, this default value is not merged with user provided value via environment files. User provided values take precedence. If the role-specific parameter is overridden by the user, then all the values (provided here) should also be provided in user environment.","commit_id":"1fffa85d46668e9dee5b5d38ca8412713ba98eb8"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"f75419894122e446a639c1f1daf8a7e87e46b29c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_53a2864d","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"in_reply_to":"7f96bb07_29ac349d","updated":"2018-01-19 12:33:39.000000000","message":"Great, thanks!","commit_id":"1fffa85d46668e9dee5b5d38ca8412713ba98eb8"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"13e83f19dfe551b541c635d7014ceed4d36bf199","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_29ac349d","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"in_reply_to":"7f96bb07_840d46e9","updated":"2018-01-19 05:49:40.000000000","message":"Yes, thats the reason I am trying to find a solution to merge  the parameters. I have updated the patch https://review.openstack.org/#/c/532465/ with merging of RoleParameters, which should take care of this.","commit_id":"1fffa85d46668e9dee5b5d38ca8412713ba98eb8"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"22b1018883a052e955981093f2a4aac3cf9b6729","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_840d46e9","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"in_reply_to":"7f96bb07_de74b66a","updated":"2018-01-18 14:14:48.000000000","message":"Ok, but then I don\u0027t see the advantage of RoleParametersDefault in this case, because IsolCpusList always has to be provided.","commit_id":"1fffa85d46668e9dee5b5d38ca8412713ba98eb8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f1177ac8919ad58c57ef9970141186110165e0c2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"},{"line_number":22,"context_line":"    NovaVcpuPinSet: \"\"  # according to the hardware of real-time nodes"},{"line_number":23,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_23038c75","line":20,"range":{"start_line":20,"start_character":53,"end_line":20,"end_character":65},"updated":"2018-01-23 15:07:36.000000000","message":"is this safe, and does it make sense? It\u0027s will almost always need to be changed.","commit_id":"2e89082905d03c2a56b519fb48b377cf7fdf1b86"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"dd13f48db6b2a4d278f480afeb153f4b186a9fa5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"},{"line_number":22,"context_line":"    NovaVcpuPinSet: \"\"  # according to the hardware of real-time nodes"},{"line_number":23,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_4363381b","line":20,"range":{"start_line":20,"start_character":53,"end_line":20,"end_character":65},"in_reply_to":"7f96bb07_23038c75","updated":"2018-01-23 15:15:51.000000000","message":"I can\u0027t really tell. I took it from RT docs, and I thought it\u0027s good enough for a default. You think it\u0027s better to not set a default at all?","commit_id":"2e89082905d03c2a56b519fb48b377cf7fdf1b86"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"3eac9beeadfc9d2229515965b0ee58d64f8ba30f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"},{"line_number":22,"context_line":"    NovaVcpuPinSet: \"\"  # according to the hardware of real-time nodes"},{"line_number":23,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_abe3ced7","line":20,"range":{"start_line":20,"start_character":53,"end_line":20,"end_character":65},"in_reply_to":"7f96bb07_29cfedb0","updated":"2018-01-24 14:44:15.000000000","message":"IIRC it even booted when I had it still at 64. But I get the concern, and an environment file is necessary anyway, so the default doesn\u0027t help a lot. I removed the default and uncommented it in the example.","commit_id":"2e89082905d03c2a56b519fb48b377cf7fdf1b86"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"6307aad1efbdfca0a2963c774b0319aef4245eec","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\""},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # these must be set in an environment file or similar"},{"line_number":22,"context_line":"    NovaVcpuPinSet: \"\"  # according to the hardware of real-time nodes"},{"line_number":23,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_29cfedb0","line":20,"range":{"start_line":20,"start_character":53,"end_line":20,"end_character":65},"in_reply_to":"7f96bb07_4363381b","updated":"2018-01-23 15:48:28.000000000","message":"what if there aren\u0027t 16gb, will it even boot?","commit_id":"2e89082905d03c2a56b519fb48b377cf7fdf1b86"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"11c65b342c08a3e40ce5974faeacbb2fa4db0cbf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"\"      # these must be set in an environment file or similar"},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # according to the hardware of real-time nodes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f96bb07_2e182c1c","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"updated":"2018-01-24 15:12:23.000000000","message":"Doesn\u0027t this need the name of the role, e.g ComputeRealTime?","commit_id":"52f58dc4de1d24f92a19bb7e7502f4c12f3534e8"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"79764d187a151d6609eb8be93f4f99c1c70fdf60","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"\"      # these must be set in an environment file or similar"},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # according to the hardware of real-time nodes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f93b717_6cdc8318","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"in_reply_to":"5f93b717_d19a146d","updated":"2018-01-24 18:13:13.000000000","message":"Ok sorry, I think I got confused by the changes made by skramaja to my original patch, apologies, this should work I think because it merged role.RoleParametersDefault with the parameter templated as {{role.name}}Parameters.\n\nFor some reason I was thinking we got a RoleParameters map for all parameters, which I think was the case in an earlier version of the role specific parameters interface.","commit_id":"52f58dc4de1d24f92a19bb7e7502f4c12f3534e8"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"8d8b3fb274bee1d648caf27c0c11d2fc07d37785","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  HostnameFormatDefault: \u0027%stackname%-computerealtime-%index%\u0027"},{"line_number":16,"context_line":"  disable_upgrade_deployment: True"},{"line_number":17,"context_line":"  ImageDefault: overcloud-realtime-compute"},{"line_number":18,"context_line":"  RoleParametersDefault:"},{"line_number":19,"context_line":"    TunedProfileName: \"realtime-virtual-host\""},{"line_number":20,"context_line":"    KernelArgs: \"\"      # these must be set in an environment file or similar"},{"line_number":21,"context_line":"    IsolCpusList: \"\"    # according to the hardware of real-time nodes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f93b717_d19a146d","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":23},"in_reply_to":"7f96bb07_2e182c1c","updated":"2018-01-24 17:51:18.000000000","message":"I\u0027m a bit confused. The README of your patch says:\n* RoleParametersDefault: (map) optional default to the per-role RoleParameters\n  value, this enables roles to specify specific values appropriate to their\n  configuration, defaults to an empty map.\n\nSo \"Role\" is just a placeholder and it should be ComputeRealTimeParameterDefault?","commit_id":"52f58dc4de1d24f92a19bb7e7502f4c12f3534e8"}]}