)]}'
{"overcloud.j2.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"9ad9d96dcfbfbc54053348216974ecb01a3d0bd3","unresolved":false,"context_lines":[{"line_number":388,"context_line":"      RoleName: {{role.name}}"},{"line_number":389,"context_line":"      RoleParameters:"},{"line_number":390,"context_line":"        map_merge:"},{"line_number":391,"context_line":"          - {{role.RoleParametersDefault|default({})}}"},{"line_number":392,"context_line":"          - get_param: {{role.name}}Parameters"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  # Lookup of role_data via heat outputs is slow, so workaround this by caching"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f96bb07_d02097b3","line":391,"range":{"start_line":391,"start_character":19,"end_line":391,"end_character":40},"updated":"2018-01-22 15:38:39.000000000","message":"Would it be cleaner to add a new RoleParametersDefault parameter, which would make the default parameters a bit more discoverable, e.g via the UI?","commit_id":"d00671142620f06c23601be8e5de63df71afdfb4"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"b09abd6f51aaffb57e5f6465a928df546b4bf3df","unresolved":false,"context_lines":[{"line_number":388,"context_line":"      RoleName: {{role.name}}"},{"line_number":389,"context_line":"      RoleParameters:"},{"line_number":390,"context_line":"        map_merge:"},{"line_number":391,"context_line":"          - {{role.RoleParametersDefault|default({})}}"},{"line_number":392,"context_line":"          - get_param: {{role.name}}Parameters"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"  # Lookup of role_data via heat outputs is slow, so workaround this by caching"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f96bb07_e76862bb","line":391,"range":{"start_line":391,"start_character":19,"end_line":391,"end_character":40},"in_reply_to":"7f96bb07_d02097b3","updated":"2018-01-23 04:42:59.000000000","message":"Yes, I thought of as a parameter (and even proposed earlier), but I didn\u0027t see a real usage in exposing the defaults as a Parameter (as like other defaults from the roles_data.yaml). IMO, UI should NOT have a text box to list the default values for RoleParameters, and it should be able to override it with user values to the parameters of parameter using \"\u003cRoleName\u003eParameters\". \n\nHaving said that, if UI/User sees a value in exposing this default as an element in UI, I have no issues in exposing it as a parameter, I could add a patch on top of this.","commit_id":"d00671142620f06c23601be8e5de63df71afdfb4"}],"puppet/role.role.j2.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"07c7f9c3eaa7798e866d00728576f359416c1cec","unresolved":false,"context_lines":[{"line_number":211,"context_line":"  RoleParameters:"},{"line_number":212,"context_line":"    type: json"},{"line_number":213,"context_line":"    description: Parameters specific to the role"},{"line_number":214,"context_line":"    default: {{role.RoleParametersDefault|default({})}}"},{"line_number":215,"context_line":"  DeploymentSwiftDataMap:"},{"line_number":216,"context_line":"    type: json"},{"line_number":217,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_a9a16f48","line":214,"updated":"2018-01-17 09:42:47.000000000","message":"Is it worth to deep merge the parameter with RoleParametrsDefault rather than replacing the parameters? The reason is when user overrides \"ComputeParameters\" all the values provided in role-data.yaml will be overridden.\n\nTaking the ComputeRealTime example, the roles-data specifies, \"TunedProfileName\" parameter but all the hardware specific parameters like IsolCpusList should be provided by the user. It is possible to modify roles-data.yaml and add the parameter, but we are discouraging modifications to roles-data.yaml. So user has to provide environment file with below content:\n\nparameters_default:\n  ComputeRealTimeParameters:\n    IsolCpusList: \"1,2,3\"\n    # TunedProfileName need to be added here to (even though present in roles-data.yaml, because this will replace RoleParametersDefault)\n    TunedProfileName: realtime-virtual-host\n    KernelArgs: \"default_hugepagesz\u003d1G hugepagesz\u003d1G hugepages\u003d16\"","commit_id":"c6f101197031a1bdd49c8c7f273a03fbb01ae269"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"547ba0b4c34274d0ec3552392bd4a75cd5679421","unresolved":false,"context_lines":[{"line_number":211,"context_line":"  RoleParameters:"},{"line_number":212,"context_line":"    type: json"},{"line_number":213,"context_line":"    description: Parameters specific to the role"},{"line_number":214,"context_line":"    default: {{role.RoleParametersDefault|default({})}}"},{"line_number":215,"context_line":"  DeploymentSwiftDataMap:"},{"line_number":216,"context_line":"    type: json"},{"line_number":217,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_bba99290","line":214,"in_reply_to":"7f96bb07_2fd1df23","updated":"2018-01-18 06:39:41.000000000","message":"Thanks. I agree that it is inconsistent, but this parameter is parameter of actual parameters to be used for a role. So it is special in its implementation itself. \n\nI have thought of merging it by taking RoleParametersDefault as another parameter and merge it with the RoleParameters (which is the parameter_defaults provided value). But if it can be fixed in a better way, as mentioned by you, then I am Ok with it. Just that we need to caution that for now, this values will be replaced if overridden by parameter_defaults. May be a readme?","commit_id":"c6f101197031a1bdd49c8c7f273a03fbb01ae269"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c22825aec04527046406cdacfc16c2eb52ee4d6c","unresolved":false,"context_lines":[{"line_number":211,"context_line":"  RoleParameters:"},{"line_number":212,"context_line":"    type: json"},{"line_number":213,"context_line":"    description: Parameters specific to the role"},{"line_number":214,"context_line":"    default: {{role.RoleParametersDefault|default({})}}"},{"line_number":215,"context_line":"  DeploymentSwiftDataMap:"},{"line_number":216,"context_line":"    type: json"},{"line_number":217,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_e5644f4c","line":214,"in_reply_to":"7f96bb07_65435f43","updated":"2018-01-18 09:59:46.000000000","message":"I will update a revision to merge the parameters in this same patch. For now, I will block it with -1.","commit_id":"c6f101197031a1bdd49c8c7f273a03fbb01ae269"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4c7caadc0ed95b83e6226548e7952827c9c00a6b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"  RoleParameters:"},{"line_number":212,"context_line":"    type: json"},{"line_number":213,"context_line":"    description: Parameters specific to the role"},{"line_number":214,"context_line":"    default: {{role.RoleParametersDefault|default({})}}"},{"line_number":215,"context_line":"  DeploymentSwiftDataMap:"},{"line_number":216,"context_line":"    type: json"},{"line_number":217,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_2fd1df23","line":214,"in_reply_to":"7f96bb07_a9a16f48","updated":"2018-01-17 10:37:23.000000000","message":"Hmm, I\u0027m not sure we can really do this, as it is inconsistent with the behavior of all other parameters, e.g we can template this default in before deployment, and the parameter_defaults value takes precedence (if it exists) during the deployment.\n\nIn future, if/when https://bugs.launchpad.net/heat/+bug/1635409 is fixed we could move the defaults out of the templates into environment files, then use parameter_merge_strategy to do what you want, but for now I don\u0027t see any clean way to support it?","commit_id":"c6f101197031a1bdd49c8c7f273a03fbb01ae269"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"8c925473761fc20c6078b50e456c9f353d3fb3e4","unresolved":false,"context_lines":[{"line_number":211,"context_line":"  RoleParameters:"},{"line_number":212,"context_line":"    type: json"},{"line_number":213,"context_line":"    description: Parameters specific to the role"},{"line_number":214,"context_line":"    default: {{role.RoleParametersDefault|default({})}}"},{"line_number":215,"context_line":"  DeploymentSwiftDataMap:"},{"line_number":216,"context_line":"    type: json"},{"line_number":217,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_65435f43","line":214,"in_reply_to":"7f96bb07_bba99290","updated":"2018-01-18 09:35:06.000000000","message":"Yes we could add a RoleParametersDefault parameter if you prefer, should we do that here or as a follow-up?","commit_id":"c6f101197031a1bdd49c8c7f273a03fbb01ae269"}]}