)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"53f2cb14f7607563eaa12d4bfc2e032d089aeb57","unresolved":false,"context_lines":[{"line_number":10,"context_line":"around allows the network objects (ports, bridges) etc. to remain"},{"line_number":11,"context_line":"intact without the containers running."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1738768"},{"line_number":14,"context_line":"Change-Id: I092500e9ec0820347ba0f865f3c24f828980af3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_4d648222","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"updated":"2018-02-10 18:46:03.000000000","message":"I think we have two bugs:\n\n1. Neutron containers can\u0027t be restarted\n2. Stopping neutron containers breaks the dataplane\n\nThis patch would close bug#1 but to fix bug#2 we would need to do something else as, for example, stopping the DHCP agent container would also stop dnsmasq so even though we keep q-dhcp namespaces around, instances won\u0027t be able to fetch dhcp.\n\nI opened [0] to track #1. What do you think?\n\n[0] https://bugs.launchpad.net/neutron/+bug/1748658","commit_id":"e51274d0c8a691aae5b6863d767d0d05fc3e075f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b6910f03150c271a23c02e84eda3f2cec0fe472f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"around allows the network objects (ports, bridges) etc. to remain"},{"line_number":11,"context_line":"intact without the containers running."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1738768"},{"line_number":14,"context_line":"Change-Id: I092500e9ec0820347ba0f865f3c24f828980af3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_8edeee0e","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"in_reply_to":"3fa0c359_4d648222","updated":"2018-02-12 13:42:04.000000000","message":"nit: technically this can\u0027t be closing a neutron bug. We prolly need to address a tripleo bug for it","commit_id":"e51274d0c8a691aae5b6863d767d0d05fc3e075f"}],"docker/services/neutron-dhcp.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"bc67698c0d26f2c5c4f40923b2249b983df81bdb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_c9049481","line":129,"updated":"2018-02-15 13:01:53.000000000","message":"Is there an alternative to this? Seems to me mounting /run/ on a container if we have SELinux enabled in docker won\u0027t work :(","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ac804037f9d27350c3f65f9cf4a31eeb209d3fc8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_7f6e4eca","line":129,"in_reply_to":"3fa0c359_247c3db4","updated":"2018-02-15 13:50:56.000000000","message":"What about putting /run/ in a named shared volume? like:\n\nNeutronSharedRun:/run/netns:Z\n\nthe Z would make it shareable amongst other containers. So when you restart neutron, you just mount that again.","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6c52c2a26b931e6a80812bde5a1c49239a07253d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_bf9936d1","line":129,"in_reply_to":"3fa0c359_7f6e4eca","updated":"2018-02-15 13:51:46.000000000","message":"Uhm... but mounting /run/netns would make it a directory... is the path configurable? or does it have to be /run/netns ?","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"fa14cd213b0e1331eff7f4b4589c3e8e6120cfeb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_1fc14a2f","line":129,"in_reply_to":"3fa0c359_7f82ce02","updated":"2018-02-15 13:59:59.000000000","message":"ok, lets give it a try, if it doesn\u0027t work, then lets merge this.","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"d04171e0bd02f5d43c38bb877d218919fee4219e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_7f82ce02","line":129,"in_reply_to":"3fa0c359_bf9936d1","updated":"2018-02-15 13:58:40.000000000","message":"Sorry comments got out of sync. We can try the shared volume thing. The gotcha will be whether or not the namespaces actually persist if all of the containers are stopped so the network traffic isn\u0027t interrupted. Will test.\n\n(afaik, /run/netns is not configurable. It\u0027s a system level network namespaces thing, not neutron specific)","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"2ef5d8997bf017d2dfc8594dc5f4401005fd61dc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_247c3db4","line":129,"in_reply_to":"3fa0c359_c9049481","updated":"2018-02-15 13:44:23.000000000","message":"Oh! Good point Juan Antonio... unfortunately we need to persist the namespaces after the container is stopped/restarted. We could try placing all namespaces in a \u0027sidecar\u0027 container but that\u0027d have other drawbacks. Isn\u0027t there a way to get over the SELinux thing?","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ca7a9b02abff6193cc8097d43aa908f8db193d1c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":127,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":128,"context_line":"                  - /var/lib/neutron:/var/lib/neutron"},{"line_number":129,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":130,"context_line":"                -"},{"line_number":131,"context_line":"                  if:"},{"line_number":132,"context_line":"                    - internal_tls_enabled"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_5f6592e0","line":129,"in_reply_to":"3fa0c359_c9049481","updated":"2018-02-15 13:51:29.000000000","message":"There likely are alternatives.  For example, create a container for the namespaces to exist in and sharing the namespace amongst all of the agent containers. This was simply the quickest path to \"unbreaking\" the containers and was closer to how they were initially implemented.","commit_id":"fb27465c6fb734d7106130765f918ed91bc329ad"}],"docker/services/neutron-ovs-agent.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"84e2763a9bb7bf3e0d032e5379db88ca79934d4e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                  - /var/lib/config-data/puppet-generated/neutron/:/var/lib/kolla/config_files/src:ro"},{"line_number":148,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":149,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":150,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":151,"context_line":"            environment:"},{"line_number":152,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":153,"context_line":"      host_prep_tasks: {get_attr: [NeutronLogging, host_prep_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa0c359_de75a8cc","line":150,"updated":"2018-02-09 15:50:52.000000000","message":"I didn\u0027t think the OVS agent used namespaces, it\u0027s always in the \"root\" namespace.","commit_id":"caa8951a7f1915873e3ad95a1aff2546aaaac2a9"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"67e963bdf0fd9884e92afbed474b2039c7d3f2ba","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                  - /var/lib/config-data/puppet-generated/neutron/:/var/lib/kolla/config_files/src:ro"},{"line_number":148,"context_line":"                  - /lib/modules:/lib/modules:ro"},{"line_number":149,"context_line":"                  - /run/openvswitch:/run/openvswitch"},{"line_number":150,"context_line":"                  - /run/netns:/run/netns:shared"},{"line_number":151,"context_line":"            environment:"},{"line_number":152,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":153,"context_line":"      host_prep_tasks: {get_attr: [NeutronLogging, host_prep_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa0c359_393946a3","line":150,"in_reply_to":"3fa0c359_de75a8cc","updated":"2018-02-09 15:59:56.000000000","message":"Agree! Could you change it also for ovn metadata agent please? :)","commit_id":"caa8951a7f1915873e3ad95a1aff2546aaaac2a9"}]}