)]}'
{"docker/services/horizon.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"778b8b6fdb2c4256f3b491be68920acc715c4c96","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_b7e72847","side":"PARENT","line":74,"updated":"2018-02-15 05:54:36.000000000","message":"Why was this added in the first place? we could have a map_merge instead of removing this.","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"6b735f54dcfe76c690c17415a356a68a4307d980","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_e3fbb244","side":"PARENT","line":74,"in_reply_to":"3fa0c359_433ce6be","updated":"2018-02-15 10:13:34.000000000","message":"That sounds like a good thing.","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"8b3ff285759a6ddbaed2ee28c810b30d22a1c868","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_433ce6be","side":"PARENT","line":74,"in_reply_to":"3fa0c359_4872c5e5","updated":"2018-02-15 09:38:00.000000000","message":"map_merge is a heat statement that can merge... well maps. we\u0027re not talking about adding or changing the options here. we\u0027re talking about keeping the options, and merging them with whatever comes in the HorizonVhostExtraParams parameter. That parameter no longer works because, and it\u0027s what\u0027s being fixed here.","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3a2ac7ce471498e4c1c42e3cdad725ef63fc4d4d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_fddfd1d3","side":"PARENT","line":74,"in_reply_to":"3fa0c359_b7e72847","updated":"2018-02-15 08:29:04.000000000","message":"We prolly need a map merge, agree. Radomir, could you please comment?","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1a4e70de4b101a0034ba155f12c4526bef75d46c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_f487dc0e","side":"PARENT","line":74,"in_reply_to":"3fa0c359_e3fbb244","updated":"2018-02-15 16:36:57.000000000","message":"My problem is that we maintain 2 \"defaults\". In the code that I\u0027m removing and here:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/horizon.yaml#L82-L84\n\nWhere the delta is \"add_listen: true\".\nSo unless we need \"add_listen: true\" for docker deployments, I would keep removing this code and get the default from puppet/services/horizon.\n\nWhat do you think?","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":27069,"name":"Sai Ram Peesapati","email":"peesapatisairam@gmail.com","username":"sairamp"},"change_message_id":"55b53808ca72935282ccb426480b77fa48d68865","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_faf6e5f9","side":"PARENT","line":74,"in_reply_to":"3fa0c359_f487dc0e","updated":"2018-02-15 17:35:11.000000000","message":"I think \"add_listen: true\" is needed, so we can append \"add_listen: true\" as default value in https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/horizon.yaml#L82-L84 \n\nIt will work right?","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"507804488fc4bdbe249daf41f45778e32913aa68","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_f5ea76aa","side":"PARENT","line":74,"in_reply_to":"3fa0c359_faf6e5f9","updated":"2018-02-15 18:24:46.000000000","message":"add_listen is needed in the standalone horizon scenario, because it\u0027s not being added by any other configuration then","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"596dc6fe56c21cc04430f76c451f75a619f33147","unresolved":false,"context_lines":[{"line_number":71,"context_line":"              add_listen: true"},{"line_number":72,"context_line":"              priority: 10"},{"line_number":73,"context_line":"              access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":74,"context_line":"              options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"},{"line_number":75,"context_line":"          - horizon::secure_cookies: false"},{"line_number":76,"context_line":"      logging_source: {get_attr: [HorizonBase, role_data, logging_source]}"},{"line_number":77,"context_line":"      logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_4872c5e5","side":"PARENT","line":74,"in_reply_to":"3fa0c359_fddfd1d3","updated":"2018-02-15 09:29:34.000000000","message":"I will have to trust you on this, because I have no idea what you are talking about. This configuration was achieved by cargo-culting the other files and trial-and-error until it worked. If you think there is a better way to do it and actually understand how it works, please go ahead.","commit_id":"0834134fd633a531c3b0838d60864f2300f87263"}],"puppet/services/horizon.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a653e096315fc9da5162ddabbc0f4014822fa090","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                 services in the internal network."},{"line_number":80,"context_line":"  HorizonVhostExtraParams:"},{"line_number":81,"context_line":"    default:"},{"line_number":82,"context_line":"      add_listen: true"},{"line_number":83,"context_line":"      priority: 10"},{"line_number":84,"context_line":"      access_log_format: \u0027%a %l %u %t \\\"%r\\\" %\u003es %b \\\"%%{}{Referer}i\\\" \\\"%%{}{User-Agent}i\\\"\u0027"},{"line_number":85,"context_line":"      options: [\u0027FollowSymLinks\u0027,\u0027MultiViews\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_d2209bb3","line":82,"updated":"2018-02-16 16:16:30.000000000","message":"Weird, I thought this defaulted to true, based on my experience with https://review.openstack.org/#/c/472756/\n\nShould be fine though.  Having add_listen set to false broke Horizon for us so it\u0027s probably good to explicitly set it.","commit_id":"73d9d875478c41494bfc894115c187fc77bf24b5"}]}