)]}'
{"docker/services/nova-compute.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f8e9e76ccc99228204299cb8f2e60e5b987802f6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    description: NFS share to mount for nova storage (when NovaNfsEnabled is true)"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"  NovaNfsOptions:"},{"line_number":77,"context_line":"    default: \u0027_netdev,bg,intr,context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027"},{"line_number":78,"context_line":"    description: NFS mount options for nova storage (when NovaNfsEnabled is true)"},{"line_number":79,"context_line":"    type: string"},{"line_number":80,"context_line":"  NovaComputeOptVolumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f6a8fd7_d67bd5bb","line":77,"range":{"start_line":77,"start_character":14,"end_line":77,"end_character":73},"updated":"2018-04-26 18:19:26.000000000","message":"intr is ignored AFAIK.\n\nNot sure using bg for nova compute is a good idea. @mbooth, any thoughts?","commit_id":"2305023b0d9a4badd7575f0400f082a2474ee4c9"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f8e9e76ccc99228204299cb8f2e60e5b987802f6","unresolved":false,"context_lines":[{"line_number":223,"context_line":"          - name: Mount NFS on host"},{"line_number":224,"context_line":"            vars:"},{"line_number":225,"context_line":"              nfs_backend_enable: {get_param: NovaNfsEnabled}"},{"line_number":226,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{item.NFS_SHARE}}\" fstype\u003dnfs4 opts\u003d\"{{item.NFS_OPTIONS}}\" state\u003dmounted"},{"line_number":227,"context_line":"            with_items:"},{"line_number":228,"context_line":"              - NFS_SHARE: {get_param: NovaNfsShare}"},{"line_number":229,"context_line":"                NFS_OPTIONS: {get_param: NovaNfsOptions}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f6a8fd7_56490589","line":226,"range":{"start_line":226,"start_character":73,"end_line":226,"end_character":84},"updated":"2018-04-26 18:19:26.000000000","message":"if a version is also set in the options which is used?","commit_id":"2305023b0d9a4badd7575f0400f082a2474ee4c9"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"46cb06cb9e5c228e2cd2777b3c82342ec6baeecd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    description: NFS share to mount for nova storage (when NovaNfsEnabled is true)"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"  NovaNfsOptions:"},{"line_number":77,"context_line":"    default: \u0027_netdev,bg,vers\u003d4,nfsvers\u003d4,context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027"},{"line_number":78,"context_line":"    description: NFS mount options for nova storage (when NovaNfsEnabled is true)"},{"line_number":79,"context_line":"    type: string"},{"line_number":80,"context_line":"  NovaComputeOptVolumes:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_1f65cfb5","line":77,"range":{"start_line":77,"start_character":14,"end_line":77,"end_character":42},"updated":"2018-05-04 15:20:56.000000000","message":"should be removed","commit_id":"42f50b0531aee1d5d71840d2ecbd21d20c834ce1"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"46cb06cb9e5c228e2cd2777b3c82342ec6baeecd","unresolved":false,"context_lines":[{"line_number":232,"context_line":"          - name: Mount NFS on host"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              nfs_backend_enable: {get_param: NovaNfsEnabled}"},{"line_number":235,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{item.NFS_SHARE}}\" fstype\u003dnfs opts\u003d\"{{item.NFS_OPTIONS}}\" state\u003dmounted"},{"line_number":236,"context_line":"            with_items:"},{"line_number":237,"context_line":"                NFS_SHARE: {get_param: NovaNfsShare}"},{"line_number":238,"context_line":"                NFS_OPTIONS: {get_param: NovaNfsOptions}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_ff2d7346","line":235,"range":{"start_line":235,"start_character":84,"end_line":235,"end_character":111},"updated":"2018-05-04 15:20:56.000000000","message":"need something like this to match the puppet-nova behaviour: \n    \"_netdev,bg,{{item.NFS_OPTIONS}},vers\u003d4,nfsvers\u003d4\"","commit_id":"42f50b0531aee1d5d71840d2ecbd21d20c834ce1"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1b3ba7f3140013a96bf4e4c1bc365661939ca4c6","unresolved":false,"context_lines":[{"line_number":234,"context_line":"              nfs_backend_enable: {get_param: NovaNfsEnabled}"},{"line_number":235,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{item.NFS_SHARE}}\" fstype\u003dnfs opts\u003d\"_netdev,bg,{{item.NFS_OPTIONS}},vers\u003d4,nfsvers\u003d4\" state\u003dmounted"},{"line_number":236,"context_line":"            with_items:"},{"line_number":237,"context_line":"                NFS_SHARE: {get_param: NovaNfsShare}"},{"line_number":238,"context_line":"                NFS_OPTIONS: {get_param: NovaNfsOptions}"},{"line_number":239,"context_line":"            when:"},{"line_number":240,"context_line":"              - nfs_backend_enable"},{"line_number":241,"context_line":"          - name: ensure ceph configurations exist"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_814ad052","line":238,"range":{"start_line":237,"start_character":0,"end_line":238,"end_character":56},"updated":"2018-05-07 09:12:23.000000000","message":"have you tested this out?\n\nIf it works that\u0027s cool, but it seems to me that it\u0027s not the way to use the with_items statement. with_items is meant to loop over a list, and that\u0027s not really what you want here.\n\nYou would probably be better off by adding the NFS_SHARE and NFS_OPTIONS variables in the vars section above, and then use them in the mount statement.","commit_id":"13a111ffdcf9e62ebe904fae9b230d9e3b142994"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c0b4db4220664cbc994e9e29125fbfe14c39071c","unresolved":false,"context_lines":[{"line_number":234,"context_line":"              nfs_backend_enable: {get_param: NovaNfsEnabled}"},{"line_number":235,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{item.NFS_SHARE}}\" fstype\u003dnfs opts\u003d\"_netdev,bg,{{item.NFS_OPTIONS}},vers\u003d4,nfsvers\u003d4\" state\u003dmounted"},{"line_number":236,"context_line":"            with_items:"},{"line_number":237,"context_line":"                NFS_SHARE: {get_param: NovaNfsShare}"},{"line_number":238,"context_line":"                NFS_OPTIONS: {get_param: NovaNfsOptions}"},{"line_number":239,"context_line":"            when:"},{"line_number":240,"context_line":"              - nfs_backend_enable"},{"line_number":241,"context_line":"          - name: ensure ceph configurations exist"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_815410cc","line":238,"range":{"start_line":237,"start_character":0,"end_line":238,"end_character":56},"in_reply_to":"5f7c97a3_814ad052","updated":"2018-05-07 09:55:32.000000000","message":"Yes, it works.\n\nThe same way it is done in glance as well:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/glance-api.yaml#L257","commit_id":"13a111ffdcf9e62ebe904fae9b230d9e3b142994"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e519de1f519c18d4c2b2d6b6b3befbd99474e0ce","unresolved":false,"context_lines":[{"line_number":236,"context_line":"              nfs_options: {get_param: NovaNfsOptions}"},{"line_number":237,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{nfs_share}}\" fstype\u003dnfs opts\u003d\"_netdev,bg,{{nfs_options}},vers\u003d4,nfsvers\u003d4\" state\u003dmounted"},{"line_number":238,"context_line":"            when:"},{"line_number":239,"context_line":"              - nfs_backend_enable"},{"line_number":240,"context_line":"          - name: ensure ceph configurations exist"},{"line_number":241,"context_line":"            file:"},{"line_number":242,"context_line":"              path: /etc/ceph"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_4eea89ac","line":239,"updated":"2018-05-08 12:35:24.000000000","message":"please use nfs_backend_enable|bool","commit_id":"90404833b617440a4388aa7d9a6c62b4cea69fc1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3aee21103314b114f837c20681ed2abdce6b7c2a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            with_items:"},{"line_number":230,"context_line":"              - /var/lib/nova"},{"line_number":231,"context_line":"              - /var/lib/libvirt"},{"line_number":232,"context_line":"          - name: Mount NFS on host"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              nfs_backend_enable: {get_param: NovaNfsEnabled}"},{"line_number":235,"context_line":"              nfs_share: {get_param: NovaNfsShare}"},{"line_number":236,"context_line":"              nfs_options: {get_param: NovaNfsOptions}"},{"line_number":237,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{nfs_share}}\" fstype\u003dnfs opts\u003d\"_netdev,bg,{{nfs_options}},vers\u003d4,nfsvers\u003d4\" state\u003dmounted"},{"line_number":238,"context_line":"            when:"},{"line_number":239,"context_line":"              - nfs_backend_enable|bool"},{"line_number":240,"context_line":"          - name: ensure ceph configurations exist"},{"line_number":241,"context_line":"            file:"},{"line_number":242,"context_line":"              path: /etc/ceph"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_7e783c29","line":239,"range":{"start_line":232,"start_character":0,"end_line":239,"end_character":39},"updated":"2018-05-09 12:49:42.000000000","message":"so this handles all the bits you\u0027re adding in puppet I believe.  We shouldn\u0027t need both unless you plan on backporting this.","commit_id":"6e109b70b94995479f218646ba7cf2ca78808716"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"29479c74a72ffb683d5d8aec03c6e405836fb1bd","unresolved":false,"context_lines":[{"line_number":230,"context_line":"              nfs_options: {get_param: NovaNfsOptions}"},{"line_number":231,"context_line":"            mount: name\u003d/var/lib/nova/instances src\u003d\"{{nfs_share}}\" fstype\u003dnfs opts\u003d\"_netdev,bg,{{nfs_options}},vers\u003d4,nfsvers\u003d4\" state\u003dmounted"},{"line_number":232,"context_line":"            when:"},{"line_number":233,"context_line":"              - nfs_backend_enable|bool"},{"line_number":234,"context_line":"          - name: ensure ceph configurations exist"},{"line_number":235,"context_line":"            file:"},{"line_number":236,"context_line":"              path: /etc/ceph"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_d0824a00","line":233,"updated":"2018-05-14 12:38:10.000000000","message":"you don\u0027t need the same host_prep_tasks in both the docker and puppet service template. To avoid the repetition, use a list_concat here with \n\n  - {get_attr: [NovaComputeBase, role_data, host_prep_tasks]}\n\nas one of the items.\n\n\nsee glance-api.yaml for an example.","commit_id":"a74720fe25ff62b0785ec3242c9a6db27733ff37"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2eee45d4318a51453a22eff3df566e6cce03129e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      description: \u003e"},{"line_number":66,"context_line":"        The Ceph cluster name must be at least 1 character and contain only"},{"line_number":67,"context_line":"        letters and numbers."},{"line_number":68,"context_line":"  NovaNfsEnabled:"},{"line_number":69,"context_line":"    default: false"},{"line_number":70,"context_line":"    description: Whether to enable or not the NFS backend for Nova"},{"line_number":71,"context_line":"    type: boolean"},{"line_number":72,"context_line":"  NovaNfsShare:"},{"line_number":73,"context_line":"    default: \u0027\u0027"},{"line_number":74,"context_line":"    description: NFS share to mount for nova storage (when NovaNfsEnabled is true)"},{"line_number":75,"context_line":"    type: string"},{"line_number":76,"context_line":"  NovaNfsOptions:"},{"line_number":77,"context_line":"    default: \u0027context\u003dsystem_u:object_r:nova_var_lib_t:s0\u0027"},{"line_number":78,"context_line":"    description: NFS mount options for nova storage (when NovaNfsEnabled is true)"},{"line_number":79,"context_line":"    type: string"},{"line_number":80,"context_line":"  NovaComputeOptVolumes:"},{"line_number":81,"context_line":"    default: []"},{"line_number":82,"context_line":"    description: list of optional vo"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f7c97a3_0a5399e3","line":79,"range":{"start_line":68,"start_character":2,"end_line":79,"end_character":16},"updated":"2018-05-15 05:41:00.000000000","message":"These seems not necessary now.","commit_id":"352f8a4d510ac3e449c0bc113c4bdb58da2a34a8"}],"puppet/services/nova-compute.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ecdadf3e56a3cd559ea8256056d63930f6abc36b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            # In future versions of QEMU (2.6, mostly), danpb\u0027s native"},{"line_number":229,"context_line":"            # encryption work will obsolete the need to use TUNNELLED transport"},{"line_number":230,"context_line":"            # mode."},{"line_number":231,"context_line":"            nova::migration::live_migration_tunnelled: {get_param: NovaEnableRbdBackend}"},{"line_number":232,"context_line":"            nova::compute::neutron::libvirt_vif_driver: {get_param: NovaComputeLibvirtVifDriver}"},{"line_number":233,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the"},{"line_number":234,"context_line":"            # local node IP for the given network; replacement examples"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_e2de6a68","line":231,"range":{"start_line":231,"start_character":12,"end_line":231,"end_character":88},"updated":"2018-06-01 16:58:58.000000000","message":"expect we should enable this for NFS too","commit_id":"6b6ae966ba7880787d0584d7e8304e5d6c9c0093"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f0627e1289058db85c58683ecf4a50def958efc3","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            # In future versions of QEMU (2.6, mostly), danpb\u0027s native"},{"line_number":229,"context_line":"            # encryption work will obsolete the need to use TUNNELLED transport"},{"line_number":230,"context_line":"            # mode."},{"line_number":231,"context_line":"            nova::migration::live_migration_tunnelled: {get_param: NovaEnableRbdBackend}"},{"line_number":232,"context_line":"            nova::compute::neutron::libvirt_vif_driver: {get_param: NovaComputeLibvirtVifDriver}"},{"line_number":233,"context_line":"            # NOTE: bind IP is found in hiera replacing the network name with the"},{"line_number":234,"context_line":"            # local node IP for the given network; replacement examples"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_0f6982bc","line":231,"range":{"start_line":231,"start_character":12,"end_line":231,"end_character":88},"in_reply_to":"5f7c97a3_e2de6a68","updated":"2018-06-12 09:30:40.000000000","message":"Done in https://review.openstack.org/#/c/574675/","commit_id":"6b6ae966ba7880787d0584d7e8304e5d6c9c0093"}]}