)]}'
{"puppet/services/glance-api.yaml":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f13d22dd3e958c4a40e154219b975f515912acc1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    default: false"},{"line_number":132,"context_line":"    description: Whether to enable or not the Rbd backend for Nova"},{"line_number":133,"context_line":"    type: boolean"},{"line_number":134,"context_line":"  GlanceEnabledImportMethods:"},{"line_number":135,"context_line":"    default: \u0027web-download\u0027"},{"line_number":136,"context_line":"    description: \u003e"},{"line_number":137,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":138,"context_line":"      \u0027glance-direct\u0027 and \u0027web-download\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_82ea40d5","line":135,"range":{"start_line":134,"start_character":2,"end_line":135,"end_character":27},"updated":"2018-05-14 16:20:19.000000000","message":"This seems to output to the config:\n\"\"\"enabled_import_methods\u003dweb-download\"\"\"\nAs the config option in Glance is specified as ListOpt oslo expects it to be in form of \"\"\"enabled_import_methods\u003d[\u0027web-download\u0027]\"\"\" for it to be recognized as list. The option default help text that was rendered did not contain the []s either so this was quite well hidden. when there is multiple items in the list, the []s are not necessary.\n\nThere was bug and patch filed against oslo-config by Brian Rosmaita to make this behavior bit clearer but I have not been tracking the state of it.","commit_id":"383836ad33a07a17ebe4cd870c2560b5923d9a61"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6e563c1386475ec51e36418f9cc9c02843163c2b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  GlanceEnabledImportMethods:"},{"line_number":135,"context_line":"    default: \u0027web-download\u0027"},{"line_number":136,"context_line":"    description: \u003e"},{"line_number":137,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":138,"context_line":"      \u0027glance-direct\u0027 and \u0027web-download\u0027"},{"line_number":139,"context_line":"    type: comma_delimited_list"},{"line_number":140,"context_line":"  KeystoneRegion:"},{"line_number":141,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_359dd5bb","line":138,"range":{"start_line":137,"start_character":14,"end_line":138,"end_character":36},"updated":"2018-05-11 07:50:43.000000000","message":"you might consider using constraints here then? lots of examples in the tht e.g. https://github.com/openstack/tripleo-heat-templates/blob/7f23133651d15233f16b036f8baba27a002a9644/puppet/services/memcached.yaml#L50","commit_id":"383836ad33a07a17ebe4cd870c2560b5923d9a61"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"57fc630fe10a05dbecbb5638717901fbc45eee97","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  GlanceEnabledImportMethods:"},{"line_number":135,"context_line":"    default: \u0027web-download\u0027"},{"line_number":136,"context_line":"    description: \u003e"},{"line_number":137,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":138,"context_line":"      \u0027glance-direct\u0027 and \u0027web-download\u0027"},{"line_number":139,"context_line":"    type: comma_delimited_list"},{"line_number":140,"context_line":"  KeystoneRegion:"},{"line_number":141,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_4b21ceaf","line":138,"range":{"start_line":137,"start_character":14,"end_line":138,"end_character":36},"in_reply_to":"5f7c97a3_359dd5bb","updated":"2018-05-11 10:15:37.000000000","message":"I would like to add constraints, but don\u0027t see an easy way to add them to a comma_delimited_list. I looked over the HOT spec, and the \"allowed_values\" and \"allowed_pattern\" constraints are for strings (and numbers). Just to be clear, the two Glance import methods are not mutually exclusive.\n\nAn alternative would be to create separate boolean parameters for each import method, and synthesizing the string list passed down on L246.\n\nThoughts?","commit_id":"383836ad33a07a17ebe4cd870c2560b5923d9a61"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e1fdf85cc8243b5473a6728d6a0a81b4ed31808d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  GlanceEnabledImportMethods:"},{"line_number":135,"context_line":"    default: \u0027web-download\u0027"},{"line_number":136,"context_line":"    description: \u003e"},{"line_number":137,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":138,"context_line":"      \u0027glance-direct\u0027 and \u0027web-download\u0027"},{"line_number":139,"context_line":"    type: comma_delimited_list"},{"line_number":140,"context_line":"  KeystoneRegion:"},{"line_number":141,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_66e2c1a2","line":138,"range":{"start_line":137,"start_character":14,"end_line":138,"end_character":36},"in_reply_to":"5f7c97a3_467d457d","updated":"2018-05-11 11:15:16.000000000","message":"marios, I\u0027d go for comma_delimited without constraints more than string with constraints\n\nBut we can always play rock paper scissors","commit_id":"383836ad33a07a17ebe4cd870c2560b5923d9a61"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bc6085725a64d5119749ef0456d8f6f6336d384e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  GlanceEnabledImportMethods:"},{"line_number":135,"context_line":"    default: \u0027web-download\u0027"},{"line_number":136,"context_line":"    description: \u003e"},{"line_number":137,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":138,"context_line":"      \u0027glance-direct\u0027 and \u0027web-download\u0027"},{"line_number":139,"context_line":"    type: comma_delimited_list"},{"line_number":140,"context_line":"  KeystoneRegion:"},{"line_number":141,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_467d457d","line":138,"range":{"start_line":137,"start_character":14,"end_line":138,"end_character":36},"in_reply_to":"5f7c97a3_4b21ceaf","updated":"2018-05-11 10:23:24.000000000","message":"Or, make it a string with an allowed-pattern like \"[glance-direct|web-download|\\,]\" Not perfect, but better?","commit_id":"383836ad33a07a17ebe4cd870c2560b5923d9a61"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"15ea921553a674d85d6b391177443357dd89b161","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  GlanceEnabledImportMethods:"},{"line_number":135,"context_line":"    default: \u0027web-download\u0027"},{"line_number":136,"context_line":"    description: \u003e"},{"line_number":137,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":138,"context_line":"      \u0027glance-direct\u0027 and \u0027web-download\u0027"},{"line_number":139,"context_line":"    type: comma_delimited_list"},{"line_number":140,"context_line":"  KeystoneRegion:"},{"line_number":141,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_46530540","line":138,"range":{"start_line":137,"start_character":14,"end_line":138,"end_character":36},"in_reply_to":"5f7c97a3_66e2c1a2","updated":"2018-05-11 11:28:45.000000000","message":"yeah sorry i thought they were mutually exclusive and it was a switch i missed it was a list. Indeed I hadn\u0027t considered constraints for a list before and looking at https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#parameter-constraints i don\u0027t see it either. The only thing that might make sense is custom_constraint (looks like there\u0027s a list of things \u0027registered\u0027 by the various openstack things) but having to define something in a heat plugin to check the value of this param is kind of insane.\n\n \nthanks for checking no please lets not do any kind of string mangling to constrain the value or make me play rock paper scissors with faidentee please for the love of all that is friday.","commit_id":"383836ad33a07a17ebe4cd870c2560b5923d9a61"}]}