)]}'
{"environments/network-environment.j2.yaml":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"6e279af8cba6f75233150f76e27430d90c102c43","unresolved":false,"context_lines":[{"line_number":46,"context_line":"{%- endfor %}"},{"line_number":47,"context_line":"{#- FIXME: These global parameters should be defined in a YAML file, e.g. network_data.yaml. #}"},{"line_number":48,"context_line":"  # Define the DNS servers (maximum 2) for the overcloud nodes"},{"line_number":49,"context_line":"  # When the list is not set, empty. The nameservers on the ctlplane subnets will be used."},{"line_number":50,"context_line":"  # (ctlplane subnets nameservers are controlled by the ``undercloud_nameservers`` option in ``undercloud.conf``)"},{"line_number":51,"context_line":"  DnsServers: []"},{"line_number":52,"context_line":"  # List of Neutron network types for tenant networks (will be used in order)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_eb2d55fd","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":40},"updated":"2018-07-03 22:54:23.000000000","message":"The first sentence doesn\u0027t parse as a complete sentence, but you could use a comma and combine it with the sentence after:\n# When the list is not set or empty, the nameservers set on the ctlplane subnets will be used.","commit_id":"59b8ea7f19fbce2cf5a4322e634e58fd93b06a98"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"161eab9464dbfefbce9332b089e8afc3628abe97","unresolved":false,"context_lines":[{"line_number":46,"context_line":"{%- endfor %}"},{"line_number":47,"context_line":"{#- FIXME: These global parameters should be defined in a YAML file, e.g. network_data.yaml. #}"},{"line_number":48,"context_line":"  # Define the DNS servers (maximum 2) for the overcloud nodes"},{"line_number":49,"context_line":"  # When the list is not set, empty. The nameservers on the ctlplane subnets will be used."},{"line_number":50,"context_line":"  # (ctlplane subnets nameservers are controlled by the ``undercloud_nameservers`` option in ``undercloud.conf``)"},{"line_number":51,"context_line":"  DnsServers: []"},{"line_number":52,"context_line":"  # List of Neutron network types for tenant networks (will be used in order)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_93508f60","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":40},"in_reply_to":"5f7c97a3_eb2d55fd","updated":"2018-07-04 14:57:45.000000000","message":"Done","commit_id":"59b8ea7f19fbce2cf5a4322e634e58fd93b06a98"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"e629e88e69c553225ba4af3bf87f6ed86878bee8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"{%- endfor %}"},{"line_number":58,"context_line":"{#- FIXME: These global parameters should be defined in a YAML file, e.g. network_data.yaml. #}"},{"line_number":59,"context_line":"  # Define the DNS servers (maximum 2) for the overcloud nodes"},{"line_number":60,"context_line":"  # When the list is no set or empty, the nameservers on the ctlplane subnets will be used."},{"line_number":61,"context_line":"  # (ctlplane subnets nameservers are controlled by the ``undercloud_nameservers`` option in ``undercloud.conf``)"},{"line_number":62,"context_line":"  DnsServers: []"},{"line_number":63,"context_line":"  # List of Neutron network types for tenant networks (will be used in order)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_1e78917c","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":27},"updated":"2018-07-10 23:01:56.000000000","message":"s/no/not","commit_id":"ff004458b8f3d6a3a4421c82663955cad1669c31"}],"releasenotes/notes/use-subnet-attrs-dnsservers-f751ec1125a9f787.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"cf1537fdbd96809f198bbe38fa6a46ccd66fffdd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"              the ``ctlplane`` subnet(s) is correct. In case it is not, update"},{"line_number":18,"context_line":"              ``undercloud.conf`` with the correct configuration and re-run the"},{"line_number":19,"context_line":"              ``openstack undercloud install`` command to ensure the property"},{"line_number":20,"context_line":"              is set correctly."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    .. Note:: ``DnsServers`` is now passed to the network config template when"},{"line_number":23,"context_line":"              the resource is created. Because of this the parameter must be"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_0f3e62b8","line":20,"updated":"2018-07-06 14:39:45.000000000","message":"It would be useful to indicate that the property to set in undercloud.conf is \u0027undercloud_nameservers\u0027.","commit_id":"087c7c672eda45f6a6023fbf1645977eb9611604"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"dc403ff1a729b1b1a459ed3c8d4b23eed7941365","unresolved":false,"context_lines":[{"line_number":17,"context_line":"              the ``ctlplane`` subnet(s) is correct. In case it is not, update"},{"line_number":18,"context_line":"              ``undercloud.conf`` with the correct configuration and re-run the"},{"line_number":19,"context_line":"              ``openstack undercloud install`` command to ensure the property"},{"line_number":20,"context_line":"              is set correctly."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    .. Note:: ``DnsServers`` is now passed to the network config template when"},{"line_number":23,"context_line":"              the resource is created. Because of this the parameter must be"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_76da4ee6","line":20,"in_reply_to":"5f7c97a3_0f3e62b8","updated":"2018-07-06 20:51:00.000000000","message":"ack. I proposed to change the name to dns_nameservers in undercloud.conf, and depracate undercloud_nameservers here: https://review.openstack.org/580761\n\nI\u0027ll hold off updating this patch until there is feedback on that.","commit_id":"087c7c672eda45f6a6023fbf1645977eb9611604"}]}