)]}'
{"puppet/role.role.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1c8a198f12bddc25f3ec3d4a2c704af9a7c2ed20","unresolved":false,"context_lines":[{"line_number":519,"context_line":""},{"line_number":520,"context_line":"  {%- for network in networks %}"},{"line_number":521,"context_line":"      {{network.name}}IpSubnet: {get_attr: [{{network.name}}Port, ip_subnet]}"},{"line_number":522,"context_line":"      {{network.name}}InterfaceRoutes:"},{"line_number":523,"context_line":"        if:"},{"line_number":524,"context_line":"          - {{network.name_lower}}_interface_routes_set"},{"line_number":525,"context_line":"          - {get_param: {{network.name}}InterfaceRoutes}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfd5e7cf_cc1c676c","line":522,"range":{"start_line":522,"start_character":6,"end_line":522,"end_character":37},"updated":"2019-01-09 09:43:33.000000000","message":"This seems like a backward incompatible change if someone is using custom network config templates that does not have this parameter.","commit_id":"d27ec26e56685cc05426d6c0835c3ea84402ee87"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"dded9f7f62468dcec416b00bb76fa168e168f5db","unresolved":false,"context_lines":[{"line_number":519,"context_line":""},{"line_number":520,"context_line":"  {%- for network in networks %}"},{"line_number":521,"context_line":"      {{network.name}}IpSubnet: {get_attr: [{{network.name}}Port, ip_subnet]}"},{"line_number":522,"context_line":"      {{network.name}}InterfaceRoutes:"},{"line_number":523,"context_line":"        if:"},{"line_number":524,"context_line":"          - {{network.name_lower}}_interface_routes_set"},{"line_number":525,"context_line":"          - {get_param: {{network.name}}InterfaceRoutes}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfd5e7cf_ac656347","line":522,"range":{"start_line":522,"start_character":6,"end_line":522,"end_character":37},"in_reply_to":"dfd5e7cf_cc1c676c","updated":"2019-01-09 10:24:12.000000000","message":"Yes, it is. There is a utility script that can be used to merge required parameters to existing custom network config scripts. (see: tools/merge-new-params-nic-config-script.py)\n\n(We should have had a release-note on this ... we did for later changes that added properties here.)\n\nOne way to solve this would be to use a single parameter in NIC configs, then pass a json value to that parameter. Doing so would allow us to extend the parameters passed without forcing the user to update existing custom configs. But, doing so would also effectively disable the validations done in Heat. (Maby we could use some advanced parameter constraints in the nic config examples we ship to validate the single \"config\" json parameter?) Also, moving to ship a single \"config\" parameter here would break backward compatibility in itself.\n\nWe could also integrate the above mentioned mergre script, to automatically do that when creating the plan, before deploying the heat stack. But this would also mask user errors like typo\u0027s in custom nic configs.\n\n\nIMO the utility script developed to help the users merge in the required parameters is good enough. As long as we don\u0027t introduce changes like this to stable branches, requireing some updates to custom environment and template files on upgrade is ok.\n\n\nBut I\u0027m open to discuss options for the future, if we can find a good way to allow us to extend without breaking backward compatibility that would be good. Then we could also backport stuff like this.","commit_id":"d27ec26e56685cc05426d6c0835c3ea84402ee87"}]}