)]}'
{"docker/services/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"992848befa90f91e4b0233e2e11cf66830921bf9","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                ceph_ansible_command:"},{"line_number":435,"context_line":"                  list_join:"},{"line_number":436,"context_line":"                  - \u0027 \u0027"},{"line_number":437,"context_line":"                  - - ANSIBLE_ACTION_PLUGINS\u003d/usr/share/ceph-ansible/plugins/actions/"},{"line_number":438,"context_line":"                    - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"},{"line_number":439,"context_line":"                    - ANSIBLE_LOG_PATH\u003d\"{{playbook_dir}}/ceph-ansible/ceph_ansible_command.log\""},{"line_number":440,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_46f20ee5","line":437,"updated":"2018-07-18 16:02:08.000000000","message":"we should also add\n\n  ANSIBLE_CALLBACK_PLUGINS\u003d/usr/share/ceph-ansible/plugins/callback","commit_id":"369731094307f1c9f4ff3e95a2653ef5868464ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"992848befa90f91e4b0233e2e11cf66830921bf9","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"},{"line_number":439,"context_line":"                    - ANSIBLE_LOG_PATH\u003d\"{{playbook_dir}}/ceph-ansible/ceph_ansible_command.log\""},{"line_number":440,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"},{"line_number":441,"context_line":"                    - ANSIBLE_RETRY_FILES_ENABLED\u003dFalse"},{"line_number":442,"context_line":"                    - ANSIBLE_SSH_RETRIES\u003d3"},{"line_number":443,"context_line":"                    - ANSIBLE_HOST_KEY_CHECKING\u003dFalse"},{"line_number":444,"context_line":"                    - DEFAULT_FORKS\u003d25"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_66394aa0","line":441,"updated":"2018-07-18 16:02:08.000000000","message":"ceph-ansible defaults this to false already","commit_id":"369731094307f1c9f4ff3e95a2653ef5868464ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"992848befa90f91e4b0233e2e11cf66830921bf9","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                    - ANSIBLE_LOG_PATH\u003d\"{{playbook_dir}}/ceph-ansible/ceph_ansible_command.log\""},{"line_number":440,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"},{"line_number":441,"context_line":"                    - ANSIBLE_RETRY_FILES_ENABLED\u003dFalse"},{"line_number":442,"context_line":"                    - ANSIBLE_SSH_RETRIES\u003d3"},{"line_number":443,"context_line":"                    - ANSIBLE_HOST_KEY_CHECKING\u003dFalse"},{"line_number":444,"context_line":"                    - DEFAULT_FORKS\u003d25"},{"line_number":445,"context_line":"                    - ANSIBLE_CONFIG\u003d/usr/share/ceph-ansible/ansible.cfg"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_06b5f618","line":442,"updated":"2018-07-18 16:02:08.000000000","message":"ceph-ansible also defaults this to 5 already","commit_id":"369731094307f1c9f4ff3e95a2653ef5868464ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"992848befa90f91e4b0233e2e11cf66830921bf9","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"},{"line_number":441,"context_line":"                    - ANSIBLE_RETRY_FILES_ENABLED\u003dFalse"},{"line_number":442,"context_line":"                    - ANSIBLE_SSH_RETRIES\u003d3"},{"line_number":443,"context_line":"                    - ANSIBLE_HOST_KEY_CHECKING\u003dFalse"},{"line_number":444,"context_line":"                    - DEFAULT_FORKS\u003d25"},{"line_number":445,"context_line":"                    - ANSIBLE_CONFIG\u003d/usr/share/ceph-ansible/ansible.cfg"},{"line_number":446,"context_line":"                    - yaql:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_46bf6efb","line":443,"updated":"2018-07-18 16:02:08.000000000","message":"this is set in ceph-ansible already","commit_id":"369731094307f1c9f4ff3e95a2653ef5868464ba"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"992848befa90f91e4b0233e2e11cf66830921bf9","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                    - ANSIBLE_RETRY_FILES_ENABLED\u003dFalse"},{"line_number":442,"context_line":"                    - ANSIBLE_SSH_RETRIES\u003d3"},{"line_number":443,"context_line":"                    - ANSIBLE_HOST_KEY_CHECKING\u003dFalse"},{"line_number":444,"context_line":"                    - DEFAULT_FORKS\u003d25"},{"line_number":445,"context_line":"                    - ANSIBLE_CONFIG\u003d/usr/share/ceph-ansible/ansible.cfg"},{"line_number":446,"context_line":"                    - yaql:"},{"line_number":447,"context_line":"                        data: {get_param: CephAnsibleEnvironmentVariables}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_86c906ac","line":444,"updated":"2018-07-18 16:02:08.000000000","message":"unrelated, but we should also remove this and stick with the default (20) set in ceph-ansible","commit_id":"369731094307f1c9f4ff3e95a2653ef5868464ba"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"70d40437ddcd7f338c61c91c9084ef973ee2ffad","unresolved":false,"context_lines":[{"line_number":419,"context_line":"              shell:"},{"line_number":420,"context_line":"                list_join:"},{"line_number":421,"context_line":"                - \u0027 \u0027"},{"line_number":422,"context_line":"                - - ANSIBLE_LOG_PATH\u003d{{playbook_dir}}/ceph-ansible/nodes_uuid_command.log"},{"line_number":423,"context_line":"                  - ANSIBLE_CONFIG\u003d{{playbook_dir}}/ansible.cfg"},{"line_number":424,"context_line":"                  - ANSIBLE_LOCAL_TEMP\u003d{{playbook_dir}}"},{"line_number":425,"context_line":"                  - HOME\u003d{{playbook_dir}}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_00f879be","line":422,"updated":"2018-07-18 18:35:57.000000000","message":"stripped quotes","commit_id":"e183670f5c345e2d76f57ccb42fa6202129deada"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0a581239962dd1ae4750d5f2d30cc5cc9823409c","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                - - ANSIBLE_LOG_PATH\u003d{{playbook_dir}}/ceph-ansible/nodes_uuid_command.log"},{"line_number":423,"context_line":"                  - ANSIBLE_CONFIG\u003d{{playbook_dir}}/ansible.cfg"},{"line_number":424,"context_line":"                  - ANSIBLE_LOCAL_TEMP\u003d{{playbook_dir}}"},{"line_number":425,"context_line":"                  - HOME\u003d{{playbook_dir}}"},{"line_number":426,"context_line":"                  - ansible-playbook"},{"line_number":427,"context_line":"                  - \u0027{% if ansible_ssh_private_key_file is defined %}--private-key {{ansible_ssh_private_key_file}}{% endif %}\u0027"},{"line_number":428,"context_line":"                  - \u0027-i\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_c01b617d","line":425,"updated":"2018-07-18 19:06:09.000000000","message":"if the above two are necessary, we should probably add them to the ceph-ansible call as well","commit_id":"e183670f5c345e2d76f57ccb42fa6202129deada"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"70d40437ddcd7f338c61c91c9084ef973ee2ffad","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                    - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"},{"line_number":442,"context_line":"                    - ANSIBLE_LOG_PATH\u003d{{playbook_dir}}/ceph-ansible/ceph_ansible_command.log"},{"line_number":443,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"},{"line_number":444,"context_line":"                    - DEFAULT_FORKS\u003d25"},{"line_number":445,"context_line":"                    - ANSIBLE_CONFIG\u003d/usr/share/ceph-ansible/ansible.cfg"},{"line_number":446,"context_line":"                    - yaql:"},{"line_number":447,"context_line":"                        data: {get_param: CephAnsibleEnvironmentVariables}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_6007edc9","line":444,"updated":"2018-07-18 18:35:57.000000000","message":"I kept these at 25 based on the work we did in https://review.openstack.org/#/c/530752/","commit_id":"e183670f5c345e2d76f57ccb42fa6202129deada"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6bb815aeaec6cda84ac5317d00e4e1d451be00bf","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                    - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"},{"line_number":442,"context_line":"                    - ANSIBLE_LOG_PATH\u003d{{playbook_dir}}/ceph-ansible/ceph_ansible_command.log"},{"line_number":443,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"},{"line_number":444,"context_line":"                    - DEFAULT_FORKS\u003d25"},{"line_number":445,"context_line":"                    - ANSIBLE_CONFIG\u003d/usr/share/ceph-ansible/ansible.cfg"},{"line_number":446,"context_line":"                    - yaql:"},{"line_number":447,"context_line":"                        data: {get_param: CephAnsibleEnvironmentVariables}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_a02d05af","line":444,"in_reply_to":"5f7c97a3_6007edc9","updated":"2018-07-18 19:05:40.000000000","message":"I think it should also be called ANSIBLE_FORKS not DEFAULT_FORKS","commit_id":"e183670f5c345e2d76f57ccb42fa6202129deada"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"fa178aeb7eb422693da915b54de1fbfea9233796","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                    - ANSIBLE_LIBRARY\u003d/usr/share/ceph-ansible/library/"},{"line_number":445,"context_line":"                    - ANSIBLE_FORKS\u003d25"},{"line_number":446,"context_line":"                    - ANSIBLE_CONFIG\u003d/usr/share/ceph-ansible/ansible.cfg"},{"line_number":447,"context_line":"                    - ANSIBLE_LOCAL_TEMP\u003d\"{{playbook_dir}}/ceph-ansible\""},{"line_number":448,"context_line":"                    - ANSIBLE_REMOTE_TEMP\u003d/tmp/"},{"line_number":449,"context_line":"                    - HOME\u003d\"{{playbook_dir}}/ceph-ansible\""},{"line_number":450,"context_line":"                    - yaql:"},{"line_number":451,"context_line":"                        data: {get_param: CephAnsibleEnvironmentVariables}"},{"line_number":452,"context_line":"                        expression: $.data.items().select($[0] + \u0027\u003d\u0027 + $[1]).join(\u0027 \u0027)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_199f9451","line":449,"range":{"start_line":447,"start_character":0,"end_line":449,"end_character":58},"updated":"2018-07-18 21:31:21.000000000","message":"ceph-ansible failed with these three lines from PS5: http://ix.io/1hF4. \n\nWhen I removed them and used PS6 ceph-ansible succeeded: http://ix.io/1hFh\n\nSo, these lines were necessary to fix the UUID playbook but ceph-ansible is different.","commit_id":"bcb463b204354a9540319a28101c717956b00405"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f8634b89b9887d6477cabd77ca40012dc61edbee","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                  - ANSIBLE_CONFIG\u003d\"{{playbook_dir}}/ansible.cfg\""},{"line_number":424,"context_line":"                  - ANSIBLE_LOCAL_TEMP\u003d\"{{playbook_dir}}\""},{"line_number":425,"context_line":"                  - ANSIBLE_REMOTE_TEMP\u003d/tmp/"},{"line_number":426,"context_line":"                  - HOME\u003d\"{{playbook_dir}}\""},{"line_number":427,"context_line":"                  - ansible-playbook"},{"line_number":428,"context_line":"                  - \u0027{% if ansible_ssh_private_key_file is defined %}--private-key {{ansible_ssh_private_key_file}}{% endif %}\u0027"},{"line_number":429,"context_line":"                  - \u0027-i\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_82cfa052","line":426,"range":{"start_line":426,"start_character":20,"end_line":426,"end_character":24},"updated":"2018-07-19 07:57:41.000000000","message":"seems like you are also adding things that weren\u0027t previously being set here. I see you aresetting ansible.cfg for config as per the commit message, I guess setting the local temp makes sense (not sure why you need override remote tmp) but why do we need to override HOME\n\nIs FORKS ok now, per your comments ceph-ansible has 20 which is less than your current 25.","commit_id":"309782cf742d47594a49878566e1ee375071f004"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"66861df6825bad3e158028dfede69d94d7bc06bc","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                  - ANSIBLE_CONFIG\u003d\"{{playbook_dir}}/ansible.cfg\""},{"line_number":424,"context_line":"                  - ANSIBLE_LOCAL_TEMP\u003d\"{{playbook_dir}}\""},{"line_number":425,"context_line":"                  - ANSIBLE_REMOTE_TEMP\u003d/tmp/"},{"line_number":426,"context_line":"                  - HOME\u003d\"{{playbook_dir}}\""},{"line_number":427,"context_line":"                  - ansible-playbook"},{"line_number":428,"context_line":"                  - \u0027{% if ansible_ssh_private_key_file is defined %}--private-key {{ansible_ssh_private_key_file}}{% endif %}\u0027"},{"line_number":429,"context_line":"                  - \u0027-i\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_c21d9877","line":426,"range":{"start_line":426,"start_character":20,"end_line":426,"end_character":24},"in_reply_to":"5f7c97a3_82cfa052","updated":"2018-07-19 08:18:25.000000000","message":"we set $HOME to the same value to which it is set for the parent ansible run, the inner ansible run does not inherit it because it is not \"exported\"\n\nand yes we kept 25 on purpose, hence overridden it","commit_id":"309782cf742d47594a49878566e1ee375071f004"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f055634dfbe315bd78b2ad3bb7a9da209812a69c","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                  - ANSIBLE_CONFIG\u003d\"{{playbook_dir}}/ansible.cfg\""},{"line_number":424,"context_line":"                  - ANSIBLE_LOCAL_TEMP\u003d\"{{playbook_dir}}/.ansible/tmp\""},{"line_number":425,"context_line":"                  - ANSIBLE_REMOTE_TEMP\u003d/tmp/.ansible/tmp"},{"line_number":426,"context_line":"                  - ANSIBLE_REMOTE_USER\u003dtripleo-admin"},{"line_number":427,"context_line":"                  - HOME\u003d\"{{playbook_dir}}\""},{"line_number":428,"context_line":"                  - ansible-playbook"},{"line_number":429,"context_line":"                  - \u0027{% if ansible_ssh_private_key_file is defined %}--private-key {{ansible_ssh_private_key_file}}{% endif %}\u0027"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_0211505c","line":426,"updated":"2018-07-19 08:20:17.000000000","message":"this is in the global ansible.cfg and gets overridden on a per-host basis in the inventory anyway, removing","commit_id":"a22785c608a7e6fc102d8dc383fd61ab2d60818d"}]}