)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"dc79ce7a3314a6f212627cb909033110e104eac3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add reflection of RpcPort to health checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch passes RpcPort parameter value to container health check"},{"line_number":10,"context_line":"scripts, which are based on verifying if service is connected to RabbitMQ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If63f136b5173bb9a94572ea5062a188469c2c782"},{"line_number":13,"context_line":"Closes-Bug: #1782369"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_dba9b57c","line":10,"updated":"2018-08-29 09:53:51.000000000","message":"We\u0027re missing a few healthchecks:\n- barbican-keystone-listener, in docker/services/barbican-api.yaml\n- barbican-worker, in docker/services/barbican-api.yaml\n- ceilometer-agent-compute, healthcheck is implemented in tripleo-common but never called from tht\n- neutron-sriov-agent, healthcheck is implemented in tripleo-common but never called from tht\n\nIt would be nice to double check we\u0027re not having other containers where the healthcheck is implemented but never called from tht.\n\nAlso, rabbitmq port is not the only one that can be changed. We also need to pass the redis port to some healtchecks, and other service specific ports. Is there already a bug tracking this?","commit_id":"79db22385ae75e5364852fe113aab6c0e760bdf6"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"cfb0b017f2f6c101c2e6f652d602dfd21b5987d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add reflection of RpcPort to health checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch passes RpcPort parameter value to container health check"},{"line_number":10,"context_line":"scripts, which are based on verifying if service is connected to RabbitMQ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If63f136b5173bb9a94572ea5062a188469c2c782"},{"line_number":13,"context_line":"Closes-Bug: #1782369"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_0d75b432","line":10,"in_reply_to":"3f79a3b5_dba9b57c","updated":"2018-08-29 10:59:02.000000000","message":"\u003e We\u0027re missing a few healthchecks:\n \u003e - barbican-keystone-listener, in docker/services/barbican-api.yaml\n \u003e - barbican-worker, in docker/services/barbican-api.yaml\n\nDuring implementation of this patch I checked all containers using healthcheck_listen and healthcheck_port functions. I\u0027m not sure why I missed some, but will do that again and fix also every missing healthchecks.\n\n \u003e - ceilometer-agent-compute, healthcheck is implemented in\n \u003e tripleo-common but never called from tht\n\nhttps://review.openstack.org/#/c/552501/\n\n \u003e - neutron-sriov-agent, healthcheck is implemented in tripleo-common\n \u003e but never called from tht\n\nhttps://review.openstack.org/#/c/552501/\n\n \u003e \n \u003e It would be nice to double check we\u0027re not having other containers\n \u003e where the healthcheck is implemented but never called from tht.\n\nThere are health checks for several containers implemented by me, but half patches are merged, half are waiting to be merged. I\u0027m currently trying to finally close this task.\n\nhttps://review.openstack.org/#/q/owner:mmagr@redhat.com+status:open\n \n \u003e \n \u003e Also, rabbitmq port is not the only one that can be changed. We\n \u003e also need to pass the redis port to some healtchecks, and other\n \u003e service specific ports. \n\nRegarding Redis, we don\u0027t need to handle the port passing in this case, because it is hardcoded as you can see here:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/database/redis-base.yaml#L82\n\n \u003e Is there already a bug tracking this?\n\nI\u0027m not aware of any bug tracking what containers are missing health checks.","commit_id":"79db22385ae75e5364852fe113aab6c0e760bdf6"}]}