)]}'
{"environments/manila-cephfsnative-config.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"72b5f3fa2635e441fdd0489a4bd1626fb1f9c63f","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  ManilaCephFSBackendName: cephfs"},{"line_number":13,"context_line":"  ManilaCephFSDriverHandlesShareServers: false"},{"line_number":14,"context_line":"  ManilaCephFSCephFSAuthId: \u0027manila\u0027"},{"line_number":15,"context_line":"  ManilaCephFSCephFSEnableSnapshots: false"},{"line_number":16,"context_line":"  # manila cephfs driver supports either native cephfs backend - \u0027CEPHFS\u0027"},{"line_number":17,"context_line":"  # (users mount shares directly from ceph cluster), or nfs-ganesha backend -"},{"line_number":18,"context_line":"  # \u0027NFS\u0027 (users mount shares through nfs-ganesha server)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_e01a0716","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":42},"updated":"2018-07-19 13:10:26.000000000","message":"Looks like this fixes a latent bug in stable/queens, where the parameters were renamed in the templates but not updated in this env file.\n\nI\u0027m guessing this patch will need to be backported to stable/queens. Fixing the parameter names seems worthy of a LP bug, and that will make it easier to get the patch accepted on stable/queens.","commit_id":"2d3cd3f3e4f24a9bf9386666ea6b3244c7771a21"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"869caab4ad6cd802fa12c8d874e73d84719e0db8","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  ManilaCephFSBackendName: cephfs"},{"line_number":13,"context_line":"  ManilaCephFSDriverHandlesShareServers: false"},{"line_number":14,"context_line":"  ManilaCephFSCephFSAuthId: \u0027manila\u0027"},{"line_number":15,"context_line":"  ManilaCephFSCephFSEnableSnapshots: false"},{"line_number":16,"context_line":"  # manila cephfs driver supports either native cephfs backend - \u0027CEPHFS\u0027"},{"line_number":17,"context_line":"  # (users mount shares directly from ceph cluster), or nfs-ganesha backend -"},{"line_number":18,"context_line":"  # \u0027NFS\u0027 (users mount shares through nfs-ganesha server)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_cac4c110","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":42},"in_reply_to":"5f7c97a3_2a93f55a","updated":"2018-07-19 17:53:11.000000000","message":"Hmm, OK, I think I understand. Without this patch, the file would continue to think it was setting default values for 4 THT parameters that happen to no longer exist. But, the parameters have been replaced with 5 new ones, whose default values are equivalent. So no harm, no foul.","commit_id":"2d3cd3f3e4f24a9bf9386666ea6b3244c7771a21"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7be7fe8a3c51fdeecae5c15b1f3145498989200a","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  ManilaCephFSBackendName: cephfs"},{"line_number":13,"context_line":"  ManilaCephFSDriverHandlesShareServers: false"},{"line_number":14,"context_line":"  ManilaCephFSCephFSAuthId: \u0027manila\u0027"},{"line_number":15,"context_line":"  ManilaCephFSCephFSEnableSnapshots: false"},{"line_number":16,"context_line":"  # manila cephfs driver supports either native cephfs backend - \u0027CEPHFS\u0027"},{"line_number":17,"context_line":"  # (users mount shares directly from ceph cluster), or nfs-ganesha backend -"},{"line_number":18,"context_line":"  # \u0027NFS\u0027 (users mount shares through nfs-ganesha server)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_0a42b9ac","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":42},"in_reply_to":"5f7c97a3_2a93f55a","updated":"2018-07-19 17:49:43.000000000","message":"Oh, but all those other parameter names changed, d\u0027oh.","commit_id":"2d3cd3f3e4f24a9bf9386666ea6b3244c7771a21"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5c6551b4f9a7bc806c740f29076e9c1005b29202","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  ManilaCephFSBackendName: cephfs"},{"line_number":13,"context_line":"  ManilaCephFSDriverHandlesShareServers: false"},{"line_number":14,"context_line":"  ManilaCephFSCephFSAuthId: \u0027manila\u0027"},{"line_number":15,"context_line":"  ManilaCephFSCephFSEnableSnapshots: false"},{"line_number":16,"context_line":"  # manila cephfs driver supports either native cephfs backend - \u0027CEPHFS\u0027"},{"line_number":17,"context_line":"  # (users mount shares directly from ceph cluster), or nfs-ganesha backend -"},{"line_number":18,"context_line":"  # \u0027NFS\u0027 (users mount shares through nfs-ganesha server)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_9534aefb","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":42},"in_reply_to":"5f7c97a3_556a961a","updated":"2018-07-19 18:42:05.000000000","message":"I\u0027m not expressing myself well - one couldn\u0027t actually set any useful values with the old file even if the defaults would work.  It\u0027s legit to set these to non-default values - e.g. EnableSnapshots: true","commit_id":"2d3cd3f3e4f24a9bf9386666ea6b3244c7771a21"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0188600a8c0968471ec302bfe7771eea19eee9d5","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  ManilaCephFSBackendName: cephfs"},{"line_number":13,"context_line":"  ManilaCephFSDriverHandlesShareServers: false"},{"line_number":14,"context_line":"  ManilaCephFSCephFSAuthId: \u0027manila\u0027"},{"line_number":15,"context_line":"  ManilaCephFSCephFSEnableSnapshots: false"},{"line_number":16,"context_line":"  # manila cephfs driver supports either native cephfs backend - \u0027CEPHFS\u0027"},{"line_number":17,"context_line":"  # (users mount shares directly from ceph cluster), or nfs-ganesha backend -"},{"line_number":18,"context_line":"  # \u0027NFS\u0027 (users mount shares through nfs-ganesha server)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_556a961a","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":42},"in_reply_to":"5f7c97a3_cac4c110","updated":"2018-07-19 18:33:46.000000000","message":"But the old file wouldn\u0027t have worked and someone might have tried to use it, so I think you\u0027re right that there\u0027s a bug.  The non-dockerized-name is the expected name and it needs to have the new parameters.  If someone tried to use it, they\u0027d have trouble until we fix it up.","commit_id":"2d3cd3f3e4f24a9bf9386666ea6b3244c7771a21"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"451b083ec6f1c718ca6a941b9b7363e58ef06be6","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  ManilaCephFSBackendName: cephfs"},{"line_number":13,"context_line":"  ManilaCephFSDriverHandlesShareServers: false"},{"line_number":14,"context_line":"  ManilaCephFSCephFSAuthId: \u0027manila\u0027"},{"line_number":15,"context_line":"  ManilaCephFSCephFSEnableSnapshots: false"},{"line_number":16,"context_line":"  # manila cephfs driver supports either native cephfs backend - \u0027CEPHFS\u0027"},{"line_number":17,"context_line":"  # (users mount shares directly from ceph cluster), or nfs-ganesha backend -"},{"line_number":18,"context_line":"  # \u0027NFS\u0027 (users mount shares through nfs-ganesha server)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_2a93f55a","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":42},"in_reply_to":"5f7c97a3_e01a0716","updated":"2018-07-19 17:41:39.000000000","message":"It\u0027s not really a bug b/c we are backwards compatible here, setting ManilaCephFSCephFSProtocolHelperType to \u0027CEPHFS\u0027 by default.\n\nWe will want to backport this cleanup to stable/queens just to avoid customer confusion though.\n\nI\u0027ll update the commit msg \u0027splain a bit.","commit_id":"2d3cd3f3e4f24a9bf9386666ea6b3244c7771a21"}],"releasenotes/notes/rm-special-manila-docker-envs-5a376db667ddfd1c.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"76cb0791f92181dded0fa204785834af5dff338b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    manila containerization was experimental in Pike and we had both bare"},{"line_number":5,"context_line":"    metal and docker versions of some of the manila environment files.  Now"},{"line_number":6,"context_line":"    the docker environment files are fully supported so we keep them using the"},{"line_number":7,"context_line":"    standard manila environment file names, without any \u0027docker\u0027 in their name."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_f0acfdeb","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":52},"updated":"2018-07-20 11:39:16.000000000","message":"nit: what about Queens? was it experimental?","commit_id":"08e67b8ff02db3ccf82fd96a0c8ff2eb17a2988b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bbc92f4b59b493ed77e662b587947acaf388b91a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    manila containerization was experimental in Pike and we had both bare"},{"line_number":5,"context_line":"    metal and docker versions of some of the manila environment files.  Now"},{"line_number":6,"context_line":"    the docker environment files are fully supported so we keep them using the"},{"line_number":7,"context_line":"    standard manila environment file names, without any \u0027docker\u0027 in their name."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_703d4d8b","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":52},"in_reply_to":"5f7c97a3_f0acfdeb","updated":"2018-07-20 11:44:12.000000000","message":"No.  We want to backport this to stable/queens.","commit_id":"08e67b8ff02db3ccf82fd96a0c8ff2eb17a2988b"}]}