)]}'
{"docker/services/neutron-ovs-agent.yaml":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44825ab553d5b7fca5ba6a51d5b4a6898df8a34b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                service:"},{"line_number":206,"context_line":"                  name: neutron-cleanup-shutdown"},{"line_number":207,"context_line":"                  enabled: yes"},{"line_number":208,"context_line":"                  state: started"},{"line_number":209,"context_line":"              - name: Enabling the startup service"},{"line_number":210,"context_line":"                service:"},{"line_number":211,"context_line":"                  name: neutron-cleanup-startup"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_38edf324","line":208,"range":{"start_line":208,"start_character":18,"end_line":208,"end_character":32},"updated":"2018-08-09 16:34:29.000000000","message":"Won\u0027t this execute the service right away because it\u0027s a oneshot?","commit_id":"f844f729de594aa45e06cfc53565fa712b7adade"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a55d39e22d19a28aa96d21c5d09db054a0e4f503","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            - block:"},{"line_number":188,"context_line":"              - name: Copy in cleanup script"},{"line_number":189,"context_line":"                copy:"},{"line_number":190,"context_line":"                  content: {get_file: ./neutron/neutron-cleanup}"},{"line_number":191,"context_line":"                  dest: \u0027/usr/libexec/neutron-cleanup\u0027"},{"line_number":192,"context_line":"                  force: yes"},{"line_number":193,"context_line":"                  mode: \u00270755\u0027"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_90239a56","line":190,"range":{"start_line":190,"start_character":18,"end_line":190,"end_character":64},"updated":"2018-08-10 18:47:42.000000000","message":"Just out of curiosity, is this the same as:\n\n src: ./neutron/neutron-cleanup\n\nor does the get_file have some secrets in it? :)","commit_id":"120c07729c8f83d51d0cdbd75085db5bcdef3477"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"99450c1ce35e80008dcb20780af5525f59acc080","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            - block:"},{"line_number":188,"context_line":"              - name: Copy in cleanup script"},{"line_number":189,"context_line":"                copy:"},{"line_number":190,"context_line":"                  content: {get_file: ./neutron/neutron-cleanup}"},{"line_number":191,"context_line":"                  dest: \u0027/usr/libexec/neutron-cleanup\u0027"},{"line_number":192,"context_line":"                  force: yes"},{"line_number":193,"context_line":"                  mode: \u00270755\u0027"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_39d37cd7","line":190,"range":{"start_line":190,"start_character":18,"end_line":190,"end_character":64},"in_reply_to":"3f79a3b5_90239a56","updated":"2018-08-13 12:01:10.000000000","message":"The location of the file relative to ansible is up for grabs once this gets to the config-download part.  I\u0027m not aware of any other way to do this.","commit_id":"120c07729c8f83d51d0cdbd75085db5bcdef3477"}],"docker/services/neutron/neutron-cleanup":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44825ab553d5b7fca5ba6a51d5b4a6898df8a34b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Cleanup neutron namespaces and OVS bridges. To be called on startup and shutdown to "},{"line_number":3,"context_line":"# avoid difficult to debug issues with partially configured resources"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"NEUTRON_OVS_BRIDGES\u003d\"br-tun br-int\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"for ns in `ip netns | grep \u0027qrouter\\|qdhcp\\|qsnat\u0027`;"},{"line_number":8,"context_line":"do "}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_78e28b31","line":5,"range":{"start_line":5,"start_character":21,"end_line":5,"end_character":34},"updated":"2018-08-09 16:34:29.000000000","message":"Those are configurable names, we should pick them from the config file","commit_id":"f844f729de594aa45e06cfc53565fa712b7adade"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44825ab553d5b7fca5ba6a51d5b4a6898df8a34b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"NEUTRON_OVS_BRIDGES\u003d\"br-tun br-int\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"for ns in `ip netns | grep \u0027qrouter\\|qdhcp\\|qsnat\u0027`;"},{"line_number":8,"context_line":"do "},{"line_number":9,"context_line":"   ip netns del ${ns}"},{"line_number":10,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_58c0ef7b","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":49},"updated":"2018-08-09 16:34:29.000000000","message":"Missing fip namespace for dvr","commit_id":"f844f729de594aa45e06cfc53565fa712b7adade"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44825ab553d5b7fca5ba6a51d5b4a6898df8a34b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for br in ${NEUTRON_OVS_BRIDGES};"},{"line_number":13,"context_line":"do"},{"line_number":14,"context_line":"    ovs-vsctl --if-exists del-br ${br}"},{"line_number":15,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_78504bd5","line":15,"updated":"2018-08-09 16:34:29.000000000","message":"Maybe we should delete bridges before namespaces. If there is a device in namespace (router interface is in namespace) then you delete namespace with existing devices in it.","commit_id":"f844f729de594aa45e06cfc53565fa712b7adade"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"89cd7110f78da542bce2db9278b5589046ec348f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Cleanup neutron OVS bridges. To be called on startup and shutdown to "},{"line_number":3,"context_line":"# avoid difficult to debug issues with partially configured resources"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"NEUTRON_OVS_BRIDGES\u003d\"br-tun br-int\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f79a3b5_0ebf7cb0","line":2,"range":{"start_line":2,"start_character":70,"end_line":2,"end_character":71},"updated":"2018-08-10 12:44:53.000000000","message":"nit whitespace","commit_id":"00f7693e03f476631a9ec10f4e21ba5909f5571f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"89cd7110f78da542bce2db9278b5589046ec348f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"for br in ${NEUTRON_OVS_BRIDGES};"},{"line_number":8,"context_line":"do"},{"line_number":9,"context_line":"    ovs-vsctl --if-exists del-br ${br}"},{"line_number":10,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f79a3b5_8ea14c97","line":10,"updated":"2018-08-10 12:44:53.000000000","message":"You may need to test it for correction, bu handling trunk bridges would be thist:\n\nfor br in $(ovs-vsctl list-br | egrep \u0027tbr-[0-9a-f\\-]+\u0027); do\n   ovs-vsctl --if-exists del-br $br\ndone","commit_id":"00f7693e03f476631a9ec10f4e21ba5909f5571f"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"5d744d5c24621e8d698bdb68cbbe7176e0857d41","unresolved":false,"context_lines":[{"line_number":7,"context_line":"for br in ${NEUTRON_OVS_BRIDGES};"},{"line_number":8,"context_line":"do"},{"line_number":9,"context_line":"    ovs-vsctl --if-exists del-br ${br}"},{"line_number":10,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f79a3b5_2e57d828","line":10,"in_reply_to":"3f79a3b5_8ea14c97","updated":"2018-08-10 12:53:54.000000000","message":"ah cool.. will try it out","commit_id":"00f7693e03f476631a9ec10f4e21ba5909f5571f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a55d39e22d19a28aa96d21c5d09db054a0e4f503","unresolved":false,"context_lines":[{"line_number":8,"context_line":"then"},{"line_number":9,"context_line":"    INT_BRIDGE\u003d`crudini --get ${NEUTRON_OVS_CONF} ovs integration_bridge`"},{"line_number":10,"context_line":"    TUN_BRIDGE\u003d`crudini --get ${NEUTRON_OVS_CONF} ovs tunnel_bridge`"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for br in ${INT_BRIDGE:-\"br-int\"} ${TUN_BRIDGE:-\"br-tun\"};"},{"line_number":14,"context_line":"do"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3f79a3b5_5052e2df","line":11,"updated":"2018-08-10 18:47:42.000000000","message":"Nice :)","commit_id":"120c07729c8f83d51d0cdbd75085db5bcdef3477"}],"docker/services/neutron/neutron-cleanup-shutdown.service":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44825ab553d5b7fca5ba6a51d5b4a6898df8a34b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dNeutron cleanup on shutdown"},{"line_number":3,"context_line":"After\u003dopenvswitch.service network.target"},{"line_number":4,"context_line":"Before\u003dpaunch-container-shutdown.service"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3f79a3b5_f8121b09","line":1,"updated":"2018-08-09 16:34:29.000000000","message":"I wonder why do we need to execute this on shutdown. Isn\u0027t executing it during the start sufficient?","commit_id":"f844f729de594aa45e06cfc53565fa712b7adade"}],"docker/services/neutron/neutron-cleanup.service":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"89cd7110f78da542bce2db9278b5589046ec348f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Type\u003doneshot"},{"line_number":9,"context_line":"ExecStart\u003d/usr/libexec/neutron-cleanup"},{"line_number":10,"context_line":"ExecStop\u003d/bin/true"},{"line_number":11,"context_line":"RemainAfterExit\u003dyes"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3f79a3b5_6ed2b002","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":19},"updated":"2018-08-10 12:44:53.000000000","message":"I wonder if we need to keep that behaviour of \"remaining after exit\" I know it was somehow important for HA, but in our case?\n\nMay be it\u0027s important if we had the same ExecStop for shutdown?","commit_id":"00f7693e03f476631a9ec10f4e21ba5909f5571f"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"5d744d5c24621e8d698bdb68cbbe7176e0857d41","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Type\u003doneshot"},{"line_number":9,"context_line":"ExecStart\u003d/usr/libexec/neutron-cleanup"},{"line_number":10,"context_line":"ExecStop\u003d/bin/true"},{"line_number":11,"context_line":"RemainAfterExit\u003dyes"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"},{"line_number":14,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3f79a3b5_2e7ef8ae","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":19},"in_reply_to":"3f79a3b5_6ed2b002","updated":"2018-08-10 12:53:54.000000000","message":"Good point! Will check","commit_id":"00f7693e03f476631a9ec10f4e21ba5909f5571f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a55d39e22d19a28aa96d21c5d09db054a0e4f503","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Service]"},{"line_number":8,"context_line":"Type\u003doneshot"},{"line_number":9,"context_line":"ExecStart\u003d/usr/libexec/neutron-cleanup"},{"line_number":10,"context_line":"ExecStop\u003d/bin/true"},{"line_number":11,"context_line":"RemainAfterExit\u003dyes"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3f79a3b5_b0f7b6d3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":18},"updated":"2018-08-10 18:47:42.000000000","message":"Nit: Can we just omit this? It\u0027s not needed, isn\u0027t it?","commit_id":"120c07729c8f83d51d0cdbd75085db5bcdef3477"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"99450c1ce35e80008dcb20780af5525f59acc080","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Service]"},{"line_number":8,"context_line":"Type\u003doneshot"},{"line_number":9,"context_line":"ExecStart\u003d/usr/libexec/neutron-cleanup"},{"line_number":10,"context_line":"ExecStop\u003d/bin/true"},{"line_number":11,"context_line":"RemainAfterExit\u003dyes"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[Install]"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3f79a3b5_b970ec09","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":18},"in_reply_to":"3f79a3b5_b0f7b6d3","updated":"2018-08-13 12:01:10.000000000","message":"removing..","commit_id":"120c07729c8f83d51d0cdbd75085db5bcdef3477"}]}