)]}'
{"docker/services/octavia-api.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"93933c3310996f9ebe785735b3315bb37b8b2816","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  OctaviaFlavor:"},{"line_number":72,"context_line":"    type: ../../puppet/services/octavia-worker.yaml"},{"line_number":73,"context_line":"    properties:"},{"line_number":74,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":75,"context_line":"      ServiceData: {get_param: ServiceData}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_14ea050c","line":72,"range":{"start_line":72,"start_character":47,"end_line":72,"end_character":51},"updated":"2018-10-25 09:44:38.000000000","message":"This is creating another nested stack to set three hiera keys I think - are those still needed for the worker now this task moved?\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/octavia-worker.yaml#L118..L120\n\nNot blocking but I wonder if we could just move those hiera keys and parameters to puppet/services/octavia-api.yaml instead, e.g particularly if those are now redundant in the worker template?","commit_id":"7d533b77370311926e23b18ef6dbdbf2c3dcac01"}]}