)]}'
{"docker/services/nova-api.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"9406979c9475fb3aa10f31643f0129825df4c588","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                fi"},{"line_number":210,"context_line":"              params:"},{"line_number":211,"context_line":"                CELLDB:"},{"line_number":212,"context_line":"                  make_url:"},{"line_number":213,"context_line":"                    scheme: {get_param: [EndpointMap, MysqlInternal, protocol]}"},{"line_number":214,"context_line":"                    username: {username}"},{"line_number":215,"context_line":"                    password: {password}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_a2df6537","line":212,"range":{"start_line":212,"start_character":18,"end_line":212,"end_character":25},"updated":"2018-12-06 14:36:28.000000000","message":"make_url encodes the url and we get { } replaced with the encoded chars in the DB.","commit_id":"eed01762ca71b0ffa36a31f9fbbaa555cb0bd708"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ed6b5af754196ac833db4629681ecea5b22f0478","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                        - \u0027:\u0027"},{"line_number":523,"context_line":"                        - \u0027{password}\u0027"},{"line_number":524,"context_line":"                        - \u0027@\u0027"},{"line_number":525,"context_line":"                        - \u0027{hostname}\u0027"},{"line_number":526,"context_line":"                        - \u0027/\u0027"},{"line_number":527,"context_line":"                        - \u0027nova_cell0\u0027"},{"line_number":528,"context_line":"                        - \u0027?\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_40c9eaab","line":525,"updated":"2018-12-17 08:49:03.000000000","message":"I think we need to put these trough filter ipwrap to ensure ipv6 addresses are wrappend in brackets.\n\ni.e:\n\n\u0027{hostname | ipwrap}\u0027\n\nSee: https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters_ipaddr.html#wrapping-ipv6-addresses-in-brackets","commit_id":"760b85c51a512e0db93961be05f56e51c2efd028"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1398aa72a6bcd09581141654ab80acdce0c2b3d3","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                fi"},{"line_number":216,"context_line":"              params:"},{"line_number":217,"context_line":"                CELLDB:"},{"line_number":218,"context_line":"                  list_join:"},{"line_number":219,"context_line":"                  - \u0027\u0027"},{"line_number":220,"context_line":"                  - - \u0027{scheme}\u0027"},{"line_number":221,"context_line":"                    - \u0027://\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_9db0922a","line":218,"range":{"start_line":218,"start_character":18,"end_line":218,"end_character":27},"updated":"2018-12-19 10:09:50.000000000","message":"Nit, Probably better to use make_url[1]? (I should have tought about this in earlyer review passes, but I somehow tought this was ansible. Sorry.)\n\n[1] https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#make-url","commit_id":"753ff7ad469f3626c0564f9a5efc3776227f7020"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"11770dd0aafc02efe942045b154ea7a16171f129","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                fi"},{"line_number":216,"context_line":"              params:"},{"line_number":217,"context_line":"                CELLDB:"},{"line_number":218,"context_line":"                  list_join:"},{"line_number":219,"context_line":"                  - \u0027\u0027"},{"line_number":220,"context_line":"                  - - \u0027{scheme}\u0027"},{"line_number":221,"context_line":"                    - \u0027://\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_fda98697","line":218,"range":{"start_line":218,"start_character":18,"end_line":218,"end_character":27},"in_reply_to":"3f79a3b5_1d0802d5","updated":"2018-12-19 10:17:31.000000000","message":"well not escapes, it encodes { to %7B","commit_id":"753ff7ad469f3626c0564f9a5efc3776227f7020"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"95550d1427d6be15fad7bc5945b5cfa25da9eae3","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                fi"},{"line_number":216,"context_line":"              params:"},{"line_number":217,"context_line":"                CELLDB:"},{"line_number":218,"context_line":"                  list_join:"},{"line_number":219,"context_line":"                  - \u0027\u0027"},{"line_number":220,"context_line":"                  - - \u0027{scheme}\u0027"},{"line_number":221,"context_line":"                    - \u0027://\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_1d0802d5","line":218,"range":{"start_line":218,"start_character":18,"end_line":218,"end_character":27},"in_reply_to":"3f79a3b5_9db0922a","updated":"2018-12-19 10:14:33.000000000","message":"The initial patch used make_url, but make_url escapes { in the resulting url we write to the DB which breaks it. Therefore the change to list_join","commit_id":"753ff7ad469f3626c0564f9a5efc3776227f7020"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1b29bd2b66dedfff52d8568039fda96863ff746b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                fi"},{"line_number":216,"context_line":"              params:"},{"line_number":217,"context_line":"                CELLDB:"},{"line_number":218,"context_line":"                  list_join:"},{"line_number":219,"context_line":"                  - \u0027\u0027"},{"line_number":220,"context_line":"                  - - \u0027{scheme}\u0027"},{"line_number":221,"context_line":"                    - \u0027://\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_fd77463d","line":218,"range":{"start_line":218,"start_character":18,"end_line":218,"end_character":27},"in_reply_to":"3f79a3b5_fda98697","updated":"2018-12-19 10:21:38.000000000","message":"Oh, thanks. Then this lgtm.","commit_id":"753ff7ad469f3626c0564f9a5efc3776227f7020"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3fc8bf107302711652977cc68bdd0b2fc36adf39","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                str_replace:"},{"line_number":531,"context_line":"                  template: nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL0DB\u0027"},{"line_number":532,"context_line":"                  params:"},{"line_number":533,"context_line":"                    CELL0DB:"},{"line_number":534,"context_line":"                      list_join:"},{"line_number":535,"context_line":"                      - \u0027\u0027"},{"line_number":536,"context_line":"                      - - \u0027{scheme}\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f769fc5_cc0d653f","line":533,"updated":"2018-12-29 20:16:07.000000000","message":"Can we use make_url? https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#make-url","commit_id":"7288062676e9f1153c7982f708952a7f4ba59706"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ecd7d2537fc3f923340a7dbabc0e8cc42f8b5d8a","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                str_replace:"},{"line_number":531,"context_line":"                  template: nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL0DB\u0027"},{"line_number":532,"context_line":"                  params:"},{"line_number":533,"context_line":"                    CELL0DB:"},{"line_number":534,"context_line":"                      list_join:"},{"line_number":535,"context_line":"                      - \u0027\u0027"},{"line_number":536,"context_line":"                      - - \u0027{scheme}\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f769fc5_aa06b785","line":533,"in_reply_to":"1f769fc5_2f896b22","updated":"2019-01-02 14:16:16.000000000","message":"Oh right i was assuming we were actually building the url in heat, we\u0027re just building the template","commit_id":"7288062676e9f1153c7982f708952a7f4ba59706"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"b76906797973f8c9928586b0be6c14237064ba1f","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                str_replace:"},{"line_number":531,"context_line":"                  template: nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL0DB\u0027"},{"line_number":532,"context_line":"                  params:"},{"line_number":533,"context_line":"                    CELL0DB:"},{"line_number":534,"context_line":"                      list_join:"},{"line_number":535,"context_line":"                      - \u0027\u0027"},{"line_number":536,"context_line":"                      - - \u0027{scheme}\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f769fc5_2f896b22","line":533,"in_reply_to":"1f769fc5_cc0d653f","updated":"2018-12-29 23:04:28.000000000","message":"make_url encodes the brackets like { to %7B which we don\u0027t want. We need the URL including the brackets in the DB.","commit_id":"7288062676e9f1153c7982f708952a7f4ba59706"}],"puppet/services/nova-base.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"9406979c9475fb3aa10f31643f0129825df4c588","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                  host: {get_param: [EndpointMap, MysqlInternal, host]}"},{"line_number":271,"context_line":"                  path: /nova_cell0 # Not a typo"},{"line_number":272,"context_line":"                  query:"},{"line_number":273,"context_line":"                    bind_address: BIND_ADDRESS"},{"line_number":274,"context_line":"              params:"},{"line_number":275,"context_line":"                BIND_ADDRESS: \"%{hiera(\u0027tripleo::profile::base::database::mysql::client::mysql_client_bind_address\u0027)}\""},{"line_number":276,"context_line":"          nova::cell0_database_connection:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_62be2dd0","line":273,"range":{"start_line":273,"start_character":20,"end_line":273,"end_character":46},"updated":"2018-12-06 14:36:28.000000000","message":"with this connect string we fail to connect to the db and deploy fails. I think we can stay with the read_default_file and group.","commit_id":"eed01762ca71b0ffa36a31f9fbbaa555cb0bd708"}],"releasenotes/notes/nova_templated_cells_db_urls-2eb151090c49c51d.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c020a706d75ca0c281a07e37cd868706c4955743","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"    features or adding release theme details should have a prelude."},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Nova now allows use of templated urls in the database and mq"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_929be9c5","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":67},"updated":"2018-12-14 18:00:59.000000000","message":"Remove this line.","commit_id":"14ea7e97a07a3cd6f4b2613debb0e97f6fae89eb"}]}