)]}'
{"network/network.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6020c37a67ca1018c6d1cc24185773248165f05d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  OS::stack_id:"},{"line_number":187,"context_line":"    description: {{network.name_lower}} network"},{"line_number":188,"context_line":"    value: {get_resource: {{network.name}}Network}"},{"line_number":189,"context_line":"  network_cidrs:"},{"line_number":190,"context_line":"    description: List of {{network.name}} network\u0027s subnets in CIDR notation."},{"line_number":191,"context_line":"    value:"},{"line_number":192,"context_line":"      list_concat:"},{"line_number":193,"context_line":"      - - {get_attr: [{{network.name}}Subnet, cidr]}"},{"line_number":194,"context_line":"      -"},{"line_number":195,"context_line":"{%- for subnet in network.subnets|default({}) if network.subnets[subnet].enabled|default(true) %}"},{"line_number":196,"context_line":"        - {get_attr: [{{network.name}}Subnet_{{subnet}}, cidr]}"},{"line_number":197,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_6fd97125","line":197,"range":{"start_line":189,"start_character":0,"end_line":197,"end_character":13},"updated":"2018-11-20 03:01:35.000000000","message":"This should create a list.","commit_id":"215d0f7f035a56037cf300bb36062d12eb708018"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e055fad4a153dd9ec50f9ce437cea4dc8b68c38c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  OS::stack_id:"},{"line_number":187,"context_line":"    description: {{network.name_lower}} network"},{"line_number":188,"context_line":"    value: {get_resource: {{network.name}}Network}"},{"line_number":189,"context_line":"  network_cidrs:"},{"line_number":190,"context_line":"    description: List of {{network.name}} network\u0027s subnets in CIDR notation."},{"line_number":191,"context_line":"    value:"},{"line_number":192,"context_line":"      list_concat:"},{"line_number":193,"context_line":"      - - {get_attr: [{{network.name}}Subnet, cidr]}"},{"line_number":194,"context_line":"      -"},{"line_number":195,"context_line":"{%- for subnet in network.subnets|default({}) if network.subnets[subnet].enabled|default(true) %}"},{"line_number":196,"context_line":"        - {get_attr: [{{network.name}}Subnet_{{subnet}}, cidr]}"},{"line_number":197,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_afe789d7","line":197,"range":{"start_line":189,"start_character":0,"end_line":197,"end_character":13},"in_reply_to":"3f79a3b5_6fd97125","updated":"2018-11-20 03:10:01.000000000","message":"In the stack output network_cidrs is a list.\n\n(undercloud) [centos@undercloud overcloud]$ openstack stack show overcloud-Networks-nzqfik4rh3eq-InternalApiNetwork-tqyau7vwq7p7 -f yaml\nid: 64e1e991-35ef-47c8-987b-92276489653e\nstack_name: overcloud-Networks-nzqfik4rh3eq-InternalApiNetwork-tqyau7vwq7p7\ndescription: \u0027InternalApi network definition (automatically generated).\n\n  \u0027\ncreation_time: \u00272018-11-20T00:35:54Z\u0027\nupdated_time: \u00272018-11-20T02:13:27Z\u0027\nstack_status: UPDATE_COMPLETE\nstack_status_reason: Stack UPDATE completed successfully\nparameters:\n  InternalApiAllocationPools: \u0027[{\"start\": \"172.17.0.10\", \"end\": \"172.17.0.250\"}]\u0027\n  InternalApiAllocationPools_internal_api_leaf1: \u0027[{\"start\": \"172.17.1.10\", \"end\":\n    \"172.17.1.250\"}]\u0027\n  InternalApiAllocationPools_internal_api_leaf2: \u0027[{\"start\": \"172.17.2.10\", \"end\":\n    \"172.17.2.250\"}]\u0027\n  InternalApiInterfaceDefaultRoute: 172.17.0.254\n  InternalApiInterfaceDefaultRoute_internal_api_leaf1: 172.17.1.254\n  InternalApiInterfaceDefaultRoute_internal_api_leaf2: 172.17.2.254\n  InternalApiNetAdminStateUp: \u0027False\u0027\n  InternalApiNetCidr: 172.17.0.0/24\n  InternalApiNetEnableDHCP: \u0027False\u0027\n  InternalApiNetName: internal_api\n  InternalApiNetShared: \u0027False\u0027\n  InternalApiNetValueSpecs: \u0027{\"provider:physical_network\": \"internal_api\", \"provider:network_type\":\n    \"flat\"}\u0027\n  InternalApiNetworkVlanID: \u002710\u0027\n  InternalApiNetworkVlanID_internal_api_leaf1: \u002711\u0027\n  InternalApiNetworkVlanID_internal_api_leaf2: \u002712\u0027\n  InternalApiRoutes: \u0027[]\u0027\n  InternalApiRoutes_internal_api_leaf1: \u0027[]\u0027\n  InternalApiRoutes_internal_api_leaf2: \u0027[]\u0027\n  InternalApiSubnetCidr_internal_api_leaf1: 172.17.1.0/24\n  InternalApiSubnetCidr_internal_api_leaf2: 172.17.2.0/24\n  InternalApiSubnetName: internal_api_subnet\n  OS::project_id: f023bb4b894047f2ac1f20d77478785b\n  OS::stack_id: 64e1e991-35ef-47c8-987b-92276489653e\n  OS::stack_name: overcloud-Networks-nzqfik4rh3eq-InternalApiNetwork-tqyau7vwq7p7\noutputs:\n- description: List of InternalApi network\u0027s subnets in CIDR notation.\n  output_key: network_cidrs\n  output_value:\n  - 172.17.0.0/24\n  - 172.17.1.0/24\n  - 172.17.2.0/24\n- description: internal_api network\n  output_key: OS::stack_id\n  output_value: 45b8a46e-b102-4731-9a2e-3a499820b55c\nlinks:\n- href: https://192.168.24.2:13004/v1/f023bb4b894047f2ac1f20d77478785b/stacks/overcloud-Networks-nzqfik4rh3eq-InternalApiNetwork-tqyau7vwq7p7/64e1e991-35ef-47c8-987b-92276489653e\n  rel: self\nparent: 900b6aca-b6fc-4985-a0d8-5c2d9b02d226\ndisable_rollback: true\ndeletion_time: null\nstack_user_project_id: 6f90facb6d5e4953a43d41689f2ed9a1\ncapabilities: []\nnotification_topics: []\nstack_owner: null\ntimeout_mins: 240\ntags: null","commit_id":"215d0f7f035a56037cf300bb36062d12eb708018"}],"network/networks.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6020c37a67ca1018c6d1cc24185773248165f05d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      {%- set network_name \u003d network.compat_name|default(network.name) %}"},{"line_number":23,"context_line":"      {{network.name_lower}}:"},{"line_number":24,"context_line":"        yaql:"},{"line_number":25,"context_line":"          data: {get_attr: [{{network_name}}Network, network_cidrs]}"},{"line_number":26,"context_line":"          expression: str($.data).replace(\u0027null\u0027, \u0027disabled\u0027)"},{"line_number":27,"context_line":"      {%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_0fe0fdca","line":25,"range":{"start_line":25,"start_character":53,"end_line":25,"end_character":66},"updated":"2018-11-20 03:01:35.000000000","message":"{\"net_cidr_map\":\n  {\n    \"storage\": \"(u\u0027\u0027172.18.0.0/24\u0027\u0027, u\u0027\u0027172.18.2.0/24\u0027\u0027, u\u0027\u0027172.18.1.0/24\u0027\u0027)\",\n    \"ctlplane\": [\"192.168.24.0/24\", \"192.168.25.0/24\", \"192.168.26.0/24\"],\n    \"external\": \"(u\u0027\u002710.0.0.0/24\u0027\u0027,)\",\n    \"internal_api\": \"(u\u0027\u0027172.17.0.0/24\u0027\u0027, u\u0027\u0027172.17.1.0/24\u0027\u0027, u\u0027\u0027172.17.2.0/24\u0027\u0027)\",\n    \"storage_mgmt\": \"(u\u0027\u0027172.19.0.0/24\u0027\u0027, u\u0027\u0027172.19.2.0/24\u0027\u0027, u\u0027\u0027172.19.1.0/24\u0027\u0027)\",\n    \"tenant\": \"(u\u0027\u0027172.16.0.0/24\u0027\u0027, u\u0027\u0027172.16.1.0/24\u0027\u0027, u\u0027\u0027172.16.2.0/24\u0027\u0027)\"\n   }\n}\u0027\n\nNetworks is not a list here.\nBut the networks_cidrs should be a list: https://review.openstack.org/#/c/613459/7/network/network.j2","commit_id":"215d0f7f035a56037cf300bb36062d12eb708018"}],"overcloud.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"dc8b55d11b087ac20262f7aaa234d3c258c14730","unresolved":false,"context_lines":[{"line_number":355,"context_line":"          - ctlplane: {get_attr: [ControlVirtualIP, network, tags]}"},{"line_number":356,"context_line":"        - keys:"},{"line_number":357,"context_line":"            ctlplane: {get_param: NeutronControlPlaneID}"},{"line_number":358,"context_line":"          values:"},{"line_number":359,"context_line":"            disabled: {get_attr: [ControlVirtualIP, network, tags]}"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"  ServiceNetMap:"},{"line_number":362,"context_line":"    type: OS::TripleO::ServiceNetMap"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f769fc5_2fd159fc","line":359,"range":{"start_line":358,"start_character":10,"end_line":359,"end_character":67},"updated":"2019-01-02 13:07:21.000000000","message":"In a follow up, or if this needs a rebase we can remove this code. network/networks.j2.yaml no longer returns disabled.","commit_id":"e46c690157bc0fe3290014082ae52062e2f42b01"}]}