)]}'
{"puppet/services/tripleo-packages.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"5ddb0eb9aa9532dd843d807d2801501b7ed4d40e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"              ignore_errors: true"},{"line_number":110,"context_line":"            - name: Set fact for triggering OpenvSwitch layered product package handling"},{"line_number":111,"context_line":"              set_fact:"},{"line_number":112,"context_line":"                ovs_lp_packaging: \"{{ rhosp_package_result.rc }} \u003d\u003d 0\""},{"line_number":113,"context_line":"            - name: Capture the expected OpenvSwitch version."},{"line_number":114,"context_line":"              set_fact:"},{"line_number":115,"context_line":"                new_ovs_version: \"{{ rhosp_package_result.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_d272efaf","line":112,"updated":"2018-11-14 13:56:48.000000000","message":"From the bug report, it doesn\u0027t look like this is doing what I wanted: Did I introduce a typo here? should it be \n\n{{ rhosp_package_result.rc \u003d\u003d 0 }} \n\ninstead?","commit_id":"0ba0a0e92ca9f435d52cf11485db4f86e7de0904"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0ac300ab3835c095dc1f0c7b3b7cedaa6054ff25","unresolved":false,"context_lines":[{"line_number":109,"context_line":"              ignore_errors: true"},{"line_number":110,"context_line":"            - name: Set fact for triggering OpenvSwitch layered product package handling"},{"line_number":111,"context_line":"              set_fact:"},{"line_number":112,"context_line":"                ovs_lp_packaging: \"{{ rhosp_package_result.rc }} \u003d\u003d 0\""},{"line_number":113,"context_line":"            - name: Capture the expected OpenvSwitch version."},{"line_number":114,"context_line":"              set_fact:"},{"line_number":115,"context_line":"                new_ovs_version: \"{{ rhosp_package_result.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_8a143144","line":112,"in_reply_to":"3f79a3b5_d272efaf","updated":"2018-11-15 11:42:07.000000000","message":"right, see that one for instance https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/haproxy.yaml#L273\n\nI\u0027ll commit the fix and will be removing the depends-on as when I first added it it reseted the standalone-upgrade from the gate.  Not sure why zuul would do that, but I don\u0027t want to take any risk.\n\nI\u0027ll test it manually using reproducer.","commit_id":"0ba0a0e92ca9f435d52cf11485db4f86e7de0904"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"194332c312856af940f871ffd7bf9698eee746ca","unresolved":false,"context_lines":[{"line_number":109,"context_line":"              ignore_errors: true"},{"line_number":110,"context_line":"            - name: Set fact for triggering OpenvSwitch layered product package handling"},{"line_number":111,"context_line":"              set_fact:"},{"line_number":112,"context_line":"                ovs_lp_packaging: \"{{ rhosp_package_result.rc \u003d\u003d 0 }}\""},{"line_number":113,"context_line":"            - name: Capture the expected OpenvSwitch version."},{"line_number":114,"context_line":"              set_fact:"},{"line_number":115,"context_line":"                new_ovs_version: \"{{ rhosp_package_result.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_5f97a7eb","line":112,"updated":"2018-11-16 12:45:10.000000000","message":"Just to get better understanding myself, i tested on a minimal example. Indeed, the previous state will generate string value e.g. \"0 \u003d\u003d 0\", while this will generate a boolean. Looking at code below, boolean is what\u0027s expected.","commit_id":"49e9d44d004adc25b9623acd4339fb5455ab58ea"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"194332c312856af940f871ffd7bf9698eee746ca","unresolved":false,"context_lines":[{"line_number":149,"context_line":"              shell: |"},{"line_number":150,"context_line":"                rpm -e --noscripts --nopreun --nopostun --notriggers --nodeps $(rpm -qa \u0027openvswitch{{ package_suffix|default(\u0027\u0027) }}*\u0027 | grep -v \u0027selinux\u0027)"},{"line_number":151,"context_line":"              warn: false"},{"line_number":152,"context_line":"              when: new_ovs_version !\u003d current_ovs_version"},{"line_number":153,"context_line":"            - name: install/upgrade OpenvSwitch LP package"},{"line_number":154,"context_line":"              package:"},{"line_number":155,"context_line":"                name: rhosp-openvswitch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_1f812fa2","line":152,"updated":"2018-11-16 12:45:10.000000000","message":"Also tested this on a minimal example, only this option worked for me. +2","commit_id":"49e9d44d004adc25b9623acd4339fb5455ab58ea"}]}