)]}'
{"docker/services/neutron/neutron-cleanup":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ef6e858aa39a1266db0625ddde8804a840731a20","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    TUN_BRIDGE\u003d`crudini --get ${NEUTRON_OVS_CONF} ovs tunnel_bridge`"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"}; "},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    external_ids\u003d`ovs-vsctl --format list --columns\u003dexternal_ids list Interface $port`"},{"line_number":16,"context_line":"    if ! [[ \"$external_ids\" \u003d~ \"skip_cleanup\u003d\\\"true\\\"\" ]]; "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_01cc4294","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":59},"updated":"2018-11-20 19:02:24.000000000","message":"nit: trailing whitespace","commit_id":"4e0e98cd30aca610937c7bd6faf6ff303b5ea7ac"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ef6e858aa39a1266db0625ddde8804a840731a20","unresolved":false,"context_lines":[{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"}; "},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    external_ids\u003d`ovs-vsctl --format list --columns\u003dexternal_ids list Interface $port`"},{"line_number":16,"context_line":"    if ! [[ \"$external_ids\" \u003d~ \"skip_cleanup\u003d\\\"true\\\"\" ]]; "},{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"},{"line_number":19,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_e1d82652","line":16,"range":{"start_line":16,"start_character":58,"end_line":16,"end_character":59},"updated":"2018-11-20 19:02:24.000000000","message":"nit: trailing whitespace","commit_id":"4e0e98cd30aca610937c7bd6faf6ff303b5ea7ac"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"26de478411fb4d523a4f0ea9b02b79252d639be3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"};"},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    external_ids\u003d`ovs-vsctl --format list --columns\u003dexternal_ids list Interface $port`"},{"line_number":16,"context_line":"    if ! [[ \"$external_ids\" \u003d~ \"skip_cleanup\u003d\\\"true\\\"\" ]];"},{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_190116b5","line":15,"updated":"2018-11-20 21:29:00.000000000","message":"You could ask explicitly for the skip_cleanup value like:\n\n  skip_cleanup\u003d$(ovs-vsctl --if-exists get Interface $port external_ids:skip_cleanup)\n\nYou can then avoid doing a regex lookup and just check:\n\n  if ! [[ $skip_cleanup \u003d \"\\\"true\\\"\" ]]; then","commit_id":"c1a164f84450984bce6c2554a3cfb2592e84d1a5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"6d706dc2f2fa5b57e751007e701d2a12c4cf5175","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    TUN_BRIDGE\u003d`crudini --get ${NEUTRON_OVS_CONF} ovs tunnel_bridge`"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"};"},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    skip_cleanup\u003d`ovs-vsctl --format list --columns\u003dexternal_ids list Interface $port external_ids:skip_cleanup`"},{"line_number":16,"context_line":"    if ! [[ $skip_cleanup \u003d \"\\\"true\\\"\" ]];"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_a555f720","line":13,"range":{"start_line":13,"start_character":57,"end_line":13,"end_character":58},"updated":"2018-11-27 13:09:45.000000000","message":"Missing closing backquote","commit_id":"bdd463ce0e05ed5cbe09a596a819d9e4c8824147"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"6d706dc2f2fa5b57e751007e701d2a12c4cf5175","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"};"},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    skip_cleanup\u003d`ovs-vsctl --format list --columns\u003dexternal_ids list Interface $port external_ids:skip_cleanup`"},{"line_number":16,"context_line":"    if ! [[ $skip_cleanup \u003d \"\\\"true\\\"\" ]];"},{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_c50a7327","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":111},"updated":"2018-11-27 13:09:45.000000000","message":"This one does not seem to work:\novs-vsctl: no row \"external_ids:skip_cleanup\" in table Interface\n\nLars\u0027 suggestion does:\novs-vsctl --if-exists get Interface $port external_ids:skip_cleanup","commit_id":"bdd463ce0e05ed5cbe09a596a819d9e4c8824147"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6e9f92dc3a9bb573ce7a04e38c8126c2b512b48c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"};"},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    skip_cleanup\u003d`ovs-vsctl --format list --columns\u003dexternal_ids list Interface $port external_ids:skip_cleanup`"},{"line_number":16,"context_line":"    if ! [[ $skip_cleanup \u003d \"\\\"true\\\"\" ]];"},{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_a8dcee42","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":111},"in_reply_to":"3f79a3b5_c50a7327","updated":"2018-11-27 13:28:08.000000000","message":"Yeah, give a try to that, it may work, but also note that if it\u0027s empty, L16 may fail.\n\nOne small trick for that can be either making sure that skip_cleanup is set to false, or ... that you do \n\nif ! [[ \"x$skip_cleanup\" \u003d x\\\"true\\\" ]];","commit_id":"bdd463ce0e05ed5cbe09a596a819d9e4c8824147"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"124b744b7073b3aa9b5e0db71023d11f5ed64bad","unresolved":false,"context_lines":[{"line_number":13,"context_line":"for port in `ovs-vsctl list-ports ${INT_BRIDGE:-\"br-int\"}`;"},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    skip_cleanup\u003d`ovs-vsctl --if-exists get Interface $port external_ids:skip_cleanup`"},{"line_number":16,"context_line":"    if ! [[ $skip_cleanup \u003d \"\\\"true\\\"\" ]];"},{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"},{"line_number":19,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_88ca526c","line":16,"updated":"2018-11-27 13:28:50.000000000","message":"if $skip_cleanup is empty, it will fail\n\ntry to check if \n\"x$skip_cleanup\" \u003d\u003d x\\\"true\\\"","commit_id":"5190aa87d326aeaa30283459b2660407e42b1aac"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7a4f31ba6067fddc968ad440f68f80d664cdcaa3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"done"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ovs-vsctl --if-exists del-br ${TUN_BRIDGE:-\"br-tun\"}"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_5cff06fe","line":20,"updated":"2018-11-28 09:51:32.000000000","message":"Is it required to delete br-int bridge, when all the ports are deleted?","commit_id":"b19867931a76ff438734f9203de938e6f1145d2b"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3dd15096e9ef2b0c2aaf60df056a202d7e49497e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    then"},{"line_number":18,"context_line":"        ovs-vsctl del-port ${INT_BRIDGE:-\"br-int\"} $port"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"done"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ovs-vsctl --if-exists del-br ${TUN_BRIDGE:-\"br-tun\"}"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_762bfa99","line":20,"in_reply_to":"3f79a3b5_5cff06fe","updated":"2018-11-28 14:46:10.000000000","message":"No. This is actually what we are trying to avoid here to avoid disrupting Octavia\u0027s health manager ports.","commit_id":"b19867931a76ff438734f9203de938e6f1145d2b"}]}