)]}'
{"puppet/role.role.j2.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"16dca5032c21feeb6a871ea2da83f1f5da7b4381","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            - {get_param: [{{role.deprecated_param_ips}}, \u0027ctlplane\u0027, {get_param: NodeIndex}]}"},{"line_number":339,"context_line":"            - \"\""},{"line_number":340,"context_line":"{%- endif %}"},{"line_number":341,"context_line":"      - false  # NOTE(hjensas): Make sure \u0027or\u0027 get\u0027s 2 conditions or more"},{"line_number":342,"context_line":"{%- for network in networks %}"},{"line_number":343,"context_line":"  {{role.name}}_{{network.name}}_fixed_ip_set:"},{"line_number":344,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_f71e2473","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":13},"updated":"2018-11-28 16:25:43.000000000","message":"Doesn\u0027t this need to be in else or we\u0027ll get 3 parameters when role.deprecated_param_ips is set?","commit_id":"7a1cd822f648384b24a85b81128c841b59e8d6aa"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"c1d54a14f8d65d95c37a6776f0d36748e52fa324","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            - {get_param: [{{role.deprecated_param_ips}}, \u0027ctlplane\u0027, {get_param: NodeIndex}]}"},{"line_number":339,"context_line":"            - \"\""},{"line_number":340,"context_line":"{%- endif %}"},{"line_number":341,"context_line":"      - false  # NOTE(hjensas): Make sure \u0027or\u0027 get\u0027s 2 conditions or more"},{"line_number":342,"context_line":"{%- for network in networks %}"},{"line_number":343,"context_line":"  {{role.name}}_{{network.name}}_fixed_ip_set:"},{"line_number":344,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_ccb6fed5","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":13},"in_reply_to":"3f79a3b5_a9a29496","updated":"2018-11-28 17:28:43.000000000","message":"Ah right, sorry I should\u0027ve just checked the docs \u0026 I forgot it\u0027s doing \"any\" vs a strict \"or\"\n\n  https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#or","commit_id":"7a1cd822f648384b24a85b81128c841b59e8d6aa"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1b95e68569236b38b7c704ffe7909de7c081f491","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            - {get_param: [{{role.deprecated_param_ips}}, \u0027ctlplane\u0027, {get_param: NodeIndex}]}"},{"line_number":339,"context_line":"            - \"\""},{"line_number":340,"context_line":"{%- endif %}"},{"line_number":341,"context_line":"      - false  # NOTE(hjensas): Make sure \u0027or\u0027 get\u0027s 2 conditions or more"},{"line_number":342,"context_line":"{%- for network in networks %}"},{"line_number":343,"context_line":"  {{role.name}}_{{network.name}}_fixed_ip_set:"},{"line_number":344,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_a9a29496","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":13},"in_reply_to":"3f79a3b5_f71e2473","updated":"2018-11-28 16:48:51.000000000","message":"\u0027or\u0027 needs|takes 2 or more parameters. So 3 parameters is\u0027nt a problem. The condition will return true if any of the other two resolves to true.","commit_id":"7a1cd822f648384b24a85b81128c841b59e8d6aa"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"02d7e3c48b3e7fee35b1b581c9e3bd1c70797c0f","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"      IPPool:"},{"line_number":489,"context_line":"        map_merge:"},{"line_number":490,"context_line":"{%- if role.deprecated_param_ips is defined %}"},{"line_number":491,"context_line":"          - {get_param: {{role.deprecated_param_ips}}}"},{"line_number":492,"context_line":"{%- endif %}"},{"line_number":493,"context_line":"          - {get_param: {{role.name}}IPs}"},{"line_number":494,"context_line":"      NodeIndex: {get_param: NodeIndex}"},{"line_number":495,"context_line":"  {%- endfor %}"},{"line_number":496,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_1fd8ab7a","line":493,"range":{"start_line":490,"start_character":1,"end_line":493,"end_character":41},"updated":"2018-11-27 21:35:38.000000000","message":"Does this need to change too?","commit_id":"7a1cd822f648384b24a85b81128c841b59e8d6aa"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"af503369c66fd4113721798b1469bec0440e2a3a","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"      IPPool:"},{"line_number":489,"context_line":"        map_merge:"},{"line_number":490,"context_line":"{%- if role.deprecated_param_ips is defined %}"},{"line_number":491,"context_line":"          - {get_param: {{role.deprecated_param_ips}}}"},{"line_number":492,"context_line":"{%- endif %}"},{"line_number":493,"context_line":"          - {get_param: {{role.name}}IPs}"},{"line_number":494,"context_line":"      NodeIndex: {get_param: NodeIndex}"},{"line_number":495,"context_line":"  {%- endfor %}"},{"line_number":496,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_ab5cd67f","line":493,"range":{"start_line":490,"start_character":1,"end_line":493,"end_character":41},"in_reply_to":"3f79a3b5_1fd8ab7a","updated":"2018-11-28 08:02:32.000000000","message":"By merging the deprecated and the non deprecated parameter, this enable transparent use of either ComputeIPs or NovaComputeIPs etc. I.e this provides similar functionality already, so I don\u0027t think we should change it.","commit_id":"7a1cd822f648384b24a85b81128c841b59e8d6aa"}]}